X-Git-Url: https://git.carlh.net/gitweb/?p=dcpomatic.git;a=blobdiff_plain;f=test%2Fhints_test.cc;h=bc858192dc6f33876a82adc61603d81677727c5c;hp=2aec8169330f8a20f614b16dcd2c9085dbc38f74;hb=fb0e2ead59a442700c671270c7d57b5bffeaeab3;hpb=8fedaaa75c4586a4cc7ffb393bd71d1fdb091dc8 diff --git a/test/hints_test.cc b/test/hints_test.cc index 2aec81693..bc858192d 100644 --- a/test/hints_test.cc +++ b/test/hints_test.cc @@ -1,5 +1,5 @@ /* - Copyright (C) 2020 Carl Hetherington + Copyright (C) 2020-2022 Carl Hetherington This file is part of DCP-o-matic. @@ -19,6 +19,8 @@ */ +#include "lib/audio_content.h" +#include "lib/config.h" #include "lib/content.h" #include "lib/content_factory.h" #include "lib/cross.h" @@ -31,10 +33,11 @@ #include +using std::make_shared; +using std::shared_ptr; using std::string; using std::vector; using boost::optional; -using std::shared_ptr; vector current_hints; @@ -54,6 +57,8 @@ get_hints (shared_ptr film) { current_hints.clear (); Hints hints (film); + /* None of our tests need the audio analysis, and it is quite time-consuming */ + hints.disable_audio_analysis (); hints.Hint.connect (collect_hint); hints.start (); hints.join (); @@ -66,12 +71,13 @@ static void check (TextType type, string name, optional expected_hint = optional()) { - shared_ptr film = new_test_film2 (name); - shared_ptr content = content_factory("test/data/" + name + ".srt").front(); + auto film = new_test_film2 (name); + auto content = content_factory("test/data/" + name + ".srt").front(); content->text.front()->set_type (type); + content->text.front()->set_language (dcp::LanguageTag("en-US")); film->examine_and_add_content (content); BOOST_REQUIRE (!wait_for_jobs()); - vector hints = get_hints (film); + auto hints = get_hints (film); if (expected_hint) { BOOST_REQUIRE_EQUAL (hints.size(), 1U); @@ -147,7 +153,17 @@ BOOST_AUTO_TEST_CASE (hint_subtitle_too_long) check ( TextType::OPEN_SUBTITLE, "hint_subtitle_too_long", - string("At least one of your subtitle lines has more than 52 characters. It is advisable to make each line 52 characters at most in length.") + string("At least one of your subtitle lines has more than 52 characters. It is recommended to make each line 52 characters at most in length.") + ); +} + + +BOOST_AUTO_TEST_CASE (hint_subtitle_much_too_long) +{ + check ( + TextType::OPEN_SUBTITLE, + "hint_subtitle_much_too_long", + string("At least one of your subtitle lines has more than 79 characters. You should make each line 79 characters at most in length.") ); } @@ -156,17 +172,18 @@ BOOST_AUTO_TEST_CASE (hint_subtitle_mxf_too_big) { string const name = "hint_subtitle_mxf_too_big"; - shared_ptr film = new_test_film2 (name); - shared_ptr content = content_factory("test/data/" + name + ".srt").front(); + auto film = new_test_film2 (name); + auto content = content_factory("test/data/" + name + ".srt").front(); content->text.front()->set_type (TextType::OPEN_SUBTITLE); + content->text.front()->set_language (dcp::LanguageTag("en-US")); for (int i = 1; i < 512; ++i) { - shared_ptr font(new dcpomatic::Font(String::compose("font_%1", i))); + auto font = make_shared(String::compose("font_%1", i)); font->set_file ("test/data/LiberationSans-Regular.ttf"); content->text.front()->add_font(font); } film->examine_and_add_content (content); BOOST_REQUIRE (!wait_for_jobs()); - vector hints = get_hints (film); + auto hints = get_hints (film); BOOST_REQUIRE_EQUAL (hints.size(), 1U); BOOST_CHECK_EQUAL ( @@ -181,24 +198,25 @@ BOOST_AUTO_TEST_CASE (hint_closed_caption_xml_too_big) { string const name = "hint_closed_caption_xml_too_big"; - shared_ptr film = new_test_film2 (name); + auto film = new_test_film2 (name); - FILE* ccap = fopen_boost (String::compose("build/test/%1.srt", name), "w"); + dcp::File ccap(String::compose("build/test/%1.srt", name), "w"); BOOST_REQUIRE (ccap); for (int i = 0; i < 2048; ++i) { - fprintf(ccap, "%d\n", i + 1); + fprintf(ccap.get(), "%d\n", i + 1); int second = i * 2; int minute = second % 60; - fprintf(ccap, "00:%02d:%02d,000 --> 00:%02d:%02d,000\n", minute, second, minute, second + 1); - fprintf(ccap, "Here are some closed captions.\n\n"); + fprintf(ccap.get(), "00:%02d:%02d,000 --> 00:%02d:%02d,000\n", minute, second, minute, second + 1); + fprintf(ccap.get(), "Here are some closed captions.\n\n"); } - fclose (ccap); + ccap.close(); - shared_ptr content = content_factory("build/test/" + name + ".srt").front(); + auto content = content_factory("build/test/" + name + ".srt").front(); content->text.front()->set_type (TextType::CLOSED_CAPTION); + content->text.front()->set_language (dcp::LanguageTag("en-US")); film->examine_and_add_content (content); BOOST_REQUIRE (!wait_for_jobs()); - vector hints = get_hints (film); + auto hints = get_hints (film); BOOST_REQUIRE_EQUAL (hints.size(), 1U); BOOST_CHECK_EQUAL ( @@ -208,3 +226,53 @@ BOOST_AUTO_TEST_CASE (hint_closed_caption_xml_too_big) ); } + +BOOST_AUTO_TEST_CASE (hints_destroyed_while_running) +{ + auto film = new_test_film2 ("hints_destroyed_while_running"); + auto content = content_factory(TestPaths::private_data() / "boon_telly.mkv").front(); + film->examine_and_add_content (content); + BOOST_REQUIRE (!wait_for_jobs()); + + auto hints = make_shared(film); + hints->start (); + dcpomatic_sleep_seconds (1); + hints.reset (); + dcpomatic_sleep_seconds (1); +} + + +BOOST_AUTO_TEST_CASE (hints_audio_with_no_language) +{ + auto content = content_factory("test/data/sine_440.wav").front(); + auto film = new_test_film2 ("hints_audio_with_no_language", { content }); + content->audio->set_gain (-6); + + auto hints = get_hints (film); + BOOST_REQUIRE_EQUAL (hints.size(), 1U); + BOOST_CHECK_EQUAL ( + hints[0], + "Some of your content has audio but you have not set the audio language. It is advisable to set the audio language " + "in the \"DCP\" tab unless your audio has no spoken parts." + ); +} + + +BOOST_AUTO_TEST_CASE (hints_certificate_validity) +{ + ConfigRestorer cr; + + Config::instance()->set_signer_chain(make_shared(openssl_path(), 40 * 365)); + + auto film = new_test_film2 ("hints_certificate_validity"); + auto hints = get_hints (film); + BOOST_REQUIRE_EQUAL (hints.size(), 1U); + BOOST_CHECK_EQUAL ( + hints[0], + "The certificate chain that DCP-o-matic uses for signing DCPs and KDMs has a validity period " + "that is too long. This will cause problems playing back DCPs on some systems. " + "You are advised to re-create the signing certificate chain by clicking the " + "\"Re-make certificates and key...\" button in the Keys page of Preferences." + ); +} +