X-Git-Url: https://git.carlh.net/gitweb/?p=dcpomatic.git;a=blobdiff_plain;f=test%2Fhints_test.cc;h=ff989647359bfe8e6aaa9357e0b6757f42d90f31;hp=f929da9c46f993f64b1596c27ad1493a6de376cf;hb=6d686ea45f5cd01a0d11f92a903ac77779ad8562;hpb=03dac68294060d84f57cf255584c2a7ca0dccc07

diff --git a/test/hints_test.cc b/test/hints_test.cc
index f929da9c4..ff9896473 100644
--- a/test/hints_test.cc
+++ b/test/hints_test.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2020-2021 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2020-2022 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -19,6 +19,8 @@
 */
 
 
+#include "lib/audio_content.h"
+#include "lib/config.h"
 #include "lib/content.h"
 #include "lib/content_factory.h"
 #include "lib/cross.h"
@@ -55,10 +57,13 @@ get_hints (shared_ptr<Film> film)
 {
 	current_hints.clear ();
 	Hints hints (film);
+	/* None of our tests need the audio analysis, and it is quite time-consuming */
+	hints.disable_audio_analysis ();
 	hints.Hint.connect (collect_hint);
 	hints.start ();
 	hints.join ();
 	while (signal_manager->ui_idle()) {}
+	hints.rethrow();
 	return current_hints;
 }
 
@@ -168,17 +173,20 @@ BOOST_AUTO_TEST_CASE (hint_subtitle_mxf_too_big)
 {
 	string const name = "hint_subtitle_mxf_too_big";
 
+	dcp::File fake_font("build/test/hint_subtitle_mxf_too_big.ttf", "w");
+	for (int i = 0; i < 4096; ++i) {
+		std::vector<uint8_t> rubbish(65536);
+		fake_font.write(rubbish.data(), 1, rubbish.size());
+	}
+	fake_font.close();
+
 	auto film = new_test_film2 (name);
 	auto content = content_factory("test/data/" + name + ".srt").front();
 	content->text.front()->set_type (TextType::OPEN_SUBTITLE);
 	content->text.front()->set_language (dcp::LanguageTag("en-US"));
-	for (int i = 1; i < 512; ++i) {
-		auto font = make_shared<dcpomatic::Font>(String::compose("font_%1", i));
-		font->set_file ("test/data/LiberationSans-Regular.ttf");
-		content->text.front()->add_font(font);
-	}
 	film->examine_and_add_content (content);
 	BOOST_REQUIRE (!wait_for_jobs());
+	content->text.front()->get_font("")->set_file("build/test/hint_subtitle_mxf_too_big.ttf");
 	auto hints = get_hints (film);
 
 	BOOST_REQUIRE_EQUAL (hints.size(), 1U);
@@ -196,16 +204,16 @@ BOOST_AUTO_TEST_CASE (hint_closed_caption_xml_too_big)
 
 	auto film = new_test_film2 (name);
 
-	auto ccap = fopen_boost (String::compose("build/test/%1.srt", name), "w");
+	dcp::File ccap(String::compose("build/test/%1.srt", name), "w");
 	BOOST_REQUIRE (ccap);
 	for (int i = 0; i < 2048; ++i) {
-		fprintf(ccap, "%d\n", i + 1);
+		fprintf(ccap.get(), "%d\n", i + 1);
 		int second = i * 2;
 		int minute = second % 60;
-		fprintf(ccap, "00:%02d:%02d,000 --> 00:%02d:%02d,000\n", minute, second, minute, second + 1);
-		fprintf(ccap, "Here are some closed captions.\n\n");
+		fprintf(ccap.get(), "00:%02d:%02d,000 --> 00:%02d:%02d,000\n", minute, second, minute, second + 1);
+		fprintf(ccap.get(), "Here are some closed captions.\n\n");
 	}
-	fclose (ccap);
+	ccap.close();
 
 	auto content = content_factory("build/test/" + name + ".srt").front();
 	content->text.front()->set_type (TextType::CLOSED_CAPTION);
@@ -222,3 +230,53 @@ BOOST_AUTO_TEST_CASE (hint_closed_caption_xml_too_big)
 		);
 }
 
+
+BOOST_AUTO_TEST_CASE (hints_destroyed_while_running)
+{
+	auto film = new_test_film2 ("hints_destroyed_while_running");
+	auto content = content_factory(TestPaths::private_data() / "boon_telly.mkv").front();
+	film->examine_and_add_content (content);
+	BOOST_REQUIRE (!wait_for_jobs());
+
+	auto hints = make_shared<Hints>(film);
+	hints->start ();
+	dcpomatic_sleep_seconds (1);
+	hints.reset ();
+	dcpomatic_sleep_seconds (1);
+}
+
+
+BOOST_AUTO_TEST_CASE (hints_audio_with_no_language)
+{
+	auto content = content_factory("test/data/sine_440.wav").front();
+	auto film = new_test_film2 ("hints_audio_with_no_language", { content });
+	content->audio->set_gain (-6);
+
+	auto hints = get_hints (film);
+	BOOST_REQUIRE_EQUAL (hints.size(), 1U);
+	BOOST_CHECK_EQUAL (
+		hints[0],
+		"Some of your content has audio but you have not set the audio language.  It is advisable to set the audio language "
+		"in the \"DCP\" tab unless your audio has no spoken parts."
+		);
+}
+
+
+BOOST_AUTO_TEST_CASE (hints_certificate_validity)
+{
+	ConfigRestorer cr;
+
+	Config::instance()->set_signer_chain(make_shared<dcp::CertificateChain>(openssl_path(), 40 * 365));
+
+	auto film = new_test_film2 ("hints_certificate_validity");
+	auto hints = get_hints (film);
+	BOOST_REQUIRE_EQUAL (hints.size(), 1U);
+	BOOST_CHECK_EQUAL (
+		hints[0],
+		"The certificate chain that DCP-o-matic uses for signing DCPs and KDMs has a validity period "
+		"that is too long.  This will cause problems playing back DCPs on some systems. "
+		"You are advised to re-create the signing certificate chain by clicking the "
+		"\"Re-make certificates and key...\" button in the Keys page of Preferences."
+		);
+}
+