X-Git-Url: https://git.carlh.net/gitweb/?p=dcpomatic.git;a=blobdiff_plain;f=test%2Fsilence_padding_test.cc;h=e4c640792d675bda09cfe7fd1acbe1b4c91d997f;hp=d876a0228d7acafa9cd7ab0bb8319097c127869d;hb=6d686ea45f5cd01a0d11f92a903ac77779ad8562;hpb=73f52e94953848c696725defd3d7f5c4c30707e2 diff --git a/test/silence_padding_test.cc b/test/silence_padding_test.cc index d876a0228..e4c640792 100644 --- a/test/silence_padding_test.cc +++ b/test/silence_padding_test.cc @@ -1,59 +1,64 @@ /* - Copyright (C) 2013-2014 Carl Hetherington + Copyright (C) 2013-2021 Carl Hetherington - This program is free software; you can redistribute it and/or modify + This file is part of DCP-o-matic. + + DCP-o-matic is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version. - This program is distributed in the hope that it will be useful, + DCP-o-matic is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License - along with this program; if not, write to the Free Software - Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + along with DCP-o-matic. If not, see . */ + /** @file test/silence_padding_test.cc * @brief Test the padding (with silence) of a mono source to a 6-channel DCP. + * @ingroup feature */ -#include + +#include "lib/ffmpeg_content.h" +#include "lib/film.h" +#include "lib/dcp_content_type.h" +#include "lib/ratio.h" +#include "test.h" #include #include -#include +#include #include #include #include -#include "lib/sndfile_content.h" -#include "lib/film.h" -#include "lib/dcp_content_type.h" -#include "lib/ratio.h" -#include "test.h" +#include +#include + +using std::make_shared; using std::string; +using std::shared_ptr; using boost::lexical_cast; -using boost::shared_ptr; + static void test_silence_padding (int channels) { string const film_name = "silence_padding_test_" + lexical_cast (channels); - shared_ptr film = new_test_film (film_name); - film->set_dcp_content_type (DCPContentType::from_isdcf_name ("FTR")); - film->set_container (Ratio::from_id ("185")); - film->set_name (film_name); - - shared_ptr content (new SndfileContent (film, "test/data/staircase.wav")); - film->examine_and_add_content (content); - wait_for_jobs (); + auto film = new_test_film2 ( + film_name, + { + make_shared("test/data/flat_red.png"), + make_shared("test/data/staircase.wav") + }); film->set_audio_channels (channels); - film->make_dcp (); - wait_for_jobs (); + make_and_verify_dcp (film); boost::filesystem::path path = "build/test"; path /= film_name; @@ -61,67 +66,88 @@ test_silence_padding (int channels) dcp::DCP check (path.string ()); check.read (); - shared_ptr sound_asset = check.cpls().front()->reels().front()->main_sound (); + auto sound_asset = check.cpls()[0]->reels()[0]->main_sound(); BOOST_CHECK (sound_asset); - BOOST_CHECK_EQUAL (sound_asset->mxf()->channels (), channels); + BOOST_CHECK_EQUAL (sound_asset->asset()->channels (), channels); /* Sample index in the DCP */ int n = 0; /* DCP sound asset frame */ int frame = 0; - while (n < sound_asset->mxf()->intrinsic_duration()) { - shared_ptr sound_frame = sound_asset->mxf()->get_frame (frame++); + while (n < sound_asset->asset()->intrinsic_duration()) { + auto sound_frame = sound_asset->asset()->start_read()->get_frame(frame++); uint8_t const * d = sound_frame->data (); - - for (int i = 0; i < sound_frame->size(); i += (3 * sound_asset->mxf()->channels())) { - if (sound_asset->mxf()->channels() > 0) { + for (int i = 0; i < sound_frame->size(); i += (3 * sound_asset->asset()->channels())) { + + if (sound_asset->asset()->channels() > 0) { /* L should be silent */ - int const sample = d[i + 0] | (d[i + 1] << 8); + int const sample = d[i + 1] | (d[i + 2] << 8); BOOST_CHECK_EQUAL (sample, 0); } - if (sound_asset->mxf()->channels() > 1) { + if (sound_asset->asset()->channels() > 1) { /* R should be silent */ - int const sample = d[i + 2] | (d[i + 3] << 8); + int const sample = d[i + 4] | (d[i + 5] << 8); BOOST_CHECK_EQUAL (sample, 0); } - - if (sound_asset->mxf()->channels() > 2) { + + if (sound_asset->asset()->channels() > 2) { /* Mono input so it will appear on centre */ int const sample = d[i + 7] | (d[i + 8] << 8); BOOST_CHECK_EQUAL (sample, n); } - if (sound_asset->mxf()->channels() > 3) { + if (sound_asset->asset()->channels() > 3) { /* Lfe should be silent */ - int const sample = d[i + 9] | (d[i + 10] << 8); + int const sample = d[i + 10] | (d[i + 11] << 8); BOOST_CHECK_EQUAL (sample, 0); } - if (sound_asset->mxf()->channels() > 4) { + if (sound_asset->asset()->channels() > 4) { /* Ls should be silent */ - int const sample = d[i + 11] | (d[i + 12] << 8); + int const sample = d[i + 13] | (d[i + 14] << 8); BOOST_CHECK_EQUAL (sample, 0); } - if (sound_asset->mxf()->channels() > 5) { + if (sound_asset->asset()->channels() > 5) { /* Rs should be silent */ - int const sample = d[i + 13] | (d[i + 14] << 8); + int const sample = d[i + 16] | (d[i + 17] << 8); BOOST_CHECK_EQUAL (sample, 0); } ++n; } } - + } + BOOST_AUTO_TEST_CASE (silence_padding_test) { for (int i = 1; i < MAX_DCP_AUDIO_CHANNELS; ++i) { test_silence_padding (i); } } + + +/** Test a situation that used to crash because of a sub-sample rounding confusion + * caused by a trim. + */ + +BOOST_AUTO_TEST_CASE (silence_padding_test2) +{ + Cleanup cl; + + auto content = make_shared(TestPaths::private_data() / "cars.mov"); + auto film = new_test_film2 ("silence_padding_test2", { content }, &cl); + + film->set_video_frame_rate (24); + content->set_trim_start (dcpomatic::ContentTime(4003)); + + make_and_verify_dcp (film); + + cl.run (); +}