add_fonts_from_examiner() can be called multiple times with the same font

in the case of closed captions with multiple tracks.  Don't reuse the
same font objects in this case, otherwise we will start with something
like font, disambiguate it to 0_font, then disambiguate _that_ to
0_0_font.

diff --git a/src/lib/dcp_content.cc b/src/lib/dcp_content.cc
index cad775b24854b9c79aba7448570c11a70edd99ce..7d835e618f1ecdfe2185f57863fea40093d7144d 100644 (file)
--- a/src/lib/dcp_content.cc
+++ b/src/lib/dcp_content.cc
@@ -831,8 +831,9 @@ add_fonts_from_examiner(shared_ptr<TextContent> text, vector<vector<shared_ptr<F
                         * by prepending the reel number.  We do the same disambiguation when emitting the
                         * subtitles in the DCP decoder.
                         */
-                       font->set_id(id_for_font_in_reel(font->id(), reel_number));
-                       text->add_font(font);
+                       auto font_copy = make_shared<dcpomatic::Font>(*font);
+                       font_copy->set_id(id_for_font_in_reel(font->id(), reel_number));
+                       text->add_font(font_copy);
                }
                ++reel_number;
        }