From: Carl Hetherington <cth@carlh.net>
Date: Thu, 16 Mar 2023 00:48:44 +0000 (+0100)
Subject: Cleanup: move variable assignment that happens in every branch.
X-Git-Tag: v2.16.48~6
X-Git-Url: https://git.carlh.net/gitweb/?p=dcpomatic.git;a=commitdiff_plain;h=c7044a1b444c2e5e7659bf5d34ed5ac73f5a6271

Cleanup: move variable assignment that happens in every branch.
---

diff --git a/src/wx/text_panel.cc b/src/wx/text_panel.cc
index fa039dbde..2fdcbb51f 100644
--- a/src/wx/text_panel.cc
+++ b/src/wx/text_panel.cc
@@ -886,9 +886,10 @@ TextPanel::clear_outline_subtitles ()
 void
 TextPanel::analysis_finished ()
 {
+	_loading_analysis = false;
+
 	auto content = _analysis_content.lock ();
 	if (!content) {
-		_loading_analysis = false;
 		setup_sensitivity ();
 		return;
 	}
@@ -899,12 +900,10 @@ TextPanel::analysis_finished ()
 		*/
 		error_dialog (_parent->window(), _("Could not analyse subtitles."));
 		clear_outline_subtitles ();
-		_loading_analysis = false;
 		setup_sensitivity ();
 		return;
 	}
 
-	_loading_analysis = false;
 	try_to_load_analysis ();
 }