From: Carl Hetherington Date: Sat, 27 Jul 2013 20:44:29 +0000 (+0100) Subject: More attempts to fix audio / merging etc. X-Git-Tag: v2.0.48~1337^2~107 X-Git-Url: https://git.carlh.net/gitweb/?p=dcpomatic.git;a=commitdiff_plain;h=e899b255083acafeac601253a33e109b30285707 More attempts to fix audio / merging etc. --- diff --git a/src/lib/audio_merger.h b/src/lib/audio_merger.h index afb21871b..226601e0e 100644 --- a/src/lib/audio_merger.h +++ b/src/lib/audio_merger.h @@ -26,50 +26,51 @@ class AudioMerger public: AudioMerger (int channels, boost::function t_to_f, boost::function f_to_t) : _buffers (new AudioBuffers (channels, 0)) - , _next_out (0) + , _last_pull (0) , _t_to_f (t_to_f) , _f_to_t (f_to_t) {} + /** Pull audio up to a given time; after this call, no more data can be pushed + * before the specified time. + */ TimedAudioBuffers - push (boost::shared_ptr audio, T time) + pull (T time) { - assert (time >= _next_out); - TimedAudioBuffers out; - if (time > _next_out) { - /* We can return some audio from our buffer; this is how many frames - we are going to return. - */ - F const to_return = _t_to_f (time - _next_out); - out.audio.reset (new AudioBuffers (_buffers->channels(), to_return)); - /* And this is how many we will get from our buffer */ - F const to_return_from_buffers = min (to_return, _buffers->frames ()); - - /* Copy the data that we have to the back end of the return buffer */ - out.audio->copy_from (_buffers.get(), to_return_from_buffers, 0, to_return - to_return_from_buffers); - /* Silence any gap at the start */ - out.audio->make_silent (0, to_return - to_return_from_buffers); + F const to_return = _t_to_f (time - _last_pull); + out.audio.reset (new AudioBuffers (_buffers->channels(), to_return)); + /* And this is how many we will get from our buffer */ + F const to_return_from_buffers = min (to_return, _buffers->frames ()); + + /* Copy the data that we have to the back end of the return buffer */ + out.audio->copy_from (_buffers.get(), to_return_from_buffers, 0, to_return - to_return_from_buffers); + /* Silence any gap at the start */ + out.audio->make_silent (0, to_return - to_return_from_buffers); + + out.time = _last_pull; + _last_pull = time; + + /* And remove the data we're returning from our buffers */ + if (_buffers->frames() > to_return_from_buffers) { + _buffers->move (to_return_from_buffers, 0, _buffers->frames() - to_return_from_buffers); + } + _buffers->set_frames (_buffers->frames() - to_return_from_buffers); - out.time = _next_out; - _next_out += _f_to_t (to_return); + return out; + } - /* And remove the data we're returning from our buffers */ - if (_buffers->frames() > to_return_from_buffers) { - _buffers->move (to_return_from_buffers, 0, _buffers->frames() - to_return_from_buffers); - } - _buffers->set_frames (_buffers->frames() - to_return_from_buffers); - } + void + push (boost::shared_ptr audio, T time) + { + assert (time >= _last_pull); - /* Now accumulate the new audio into our buffers */ F frame = _t_to_f (time); - F after = max (_buffers->frames(), frame + audio->frames() - _t_to_f (_next_out)); + F after = max (_buffers->frames(), frame + audio->frames() - _t_to_f (_last_pull)); _buffers->ensure_size (after); - _buffers->accumulate_frames (audio.get(), 0, frame - _t_to_f (_next_out), audio->frames ()); + _buffers->accumulate_frames (audio.get(), 0, frame - _t_to_f (_last_pull), audio->frames ()); _buffers->set_frames (after); - - return out; } F min (F a, int b) @@ -97,12 +98,12 @@ public: return TimedAudioBuffers (); } - return TimedAudioBuffers (_buffers, _next_out); + return TimedAudioBuffers (_buffers, _last_pull); } private: boost::shared_ptr _buffers; - T _next_out; + T _last_pull; boost::function _t_to_f; boost::function _f_to_t; }; diff --git a/src/lib/player.cc b/src/lib/player.cc index e2f23e6e3..bf5bc6489 100644 --- a/src/lib/player.cc +++ b/src/lib/player.cc @@ -48,7 +48,7 @@ using boost::shared_ptr; using boost::weak_ptr; using boost::dynamic_pointer_cast; -#define DEBUG_PLAYER 1 +//#define DEBUG_PLAYER 1 class Piece { @@ -98,6 +98,7 @@ Player::Player (shared_ptr f, shared_ptr p) , _video_position (0) , _audio_position (0) , _audio_merger (f->audio_channels(), bind (&Film::time_to_audio_frames, f.get(), _1), bind (&Film::audio_frames_to_time, f.get(), _1)) + , _last_emit_was_black (false) { _playlist->Changed.connect (bind (&Player::playlist_changed, this)); _playlist->ContentChanged.connect (bind (&Player::content_changed, this, _1, _2, _3)); @@ -191,7 +192,7 @@ Player::pass () } else { #ifdef DEBUG_PLAYER cout << "Pass " << *earliest << "\n"; -#endif +#endif earliest->decoder->pass (); if (earliest->decoder->done()) { @@ -205,11 +206,25 @@ Player::pass () } } } - + + } + + Time done_up_to = TIME_MAX; + for (list >::iterator i = _pieces.begin(); i != _pieces.end(); ++i) { + if (dynamic_pointer_cast ((*i)->content)) { + done_up_to = min (done_up_to, (*i)->audio_position); + } + } + + TimedAudioBuffers