dcpomatic.git
11 months agoCleanup: use a namespace.
Carl Hetherington [Sat, 13 May 2023 20:07:47 +0000 (22:07 +0200)]
Cleanup: use a namespace.

11 months agoCleanup: remove unnecessary explicit.
Carl Hetherington [Sat, 13 May 2023 20:02:53 +0000 (22:02 +0200)]
Cleanup: remove unnecessary explicit.

11 months agoMissing relink of dcpomatic2_map.
Carl Hetherington [Sat, 13 May 2023 19:09:49 +0000 (21:09 +0200)]
Missing relink of dcpomatic2_map.

11 months agoFix missing signing of dcpomatic2_map.
Carl Hetherington [Sat, 13 May 2023 17:14:20 +0000 (19:14 +0200)]
Fix missing signing of dcpomatic2_map.

11 months agoSupporters update.
Carl Hetherington [Sat, 13 May 2023 15:36:16 +0000 (17:36 +0200)]
Supporters update.

11 months agoAdd dcpomatic2_map tool (#2445).
Carl Hetherington [Fri, 17 Feb 2023 23:15:30 +0000 (00:15 +0100)]
Add dcpomatic2_map tool (#2445).

11 months agoCleanup: using ordering.
Carl Hetherington [Fri, 14 Apr 2023 14:41:38 +0000 (16:41 +0200)]
Cleanup: using ordering.

11 months agoFix typos in errors.
Carl Hetherington [Tue, 11 Apr 2023 21:04:24 +0000 (23:04 +0200)]
Fix typos in errors.

11 months agoFix typo in variable name.
Carl Hetherington [Tue, 11 Apr 2023 21:04:07 +0000 (23:04 +0200)]
Fix typo in variable name.

11 months agoRemove unused define.
Carl Hetherington [Tue, 11 Apr 2023 21:03:40 +0000 (23:03 +0200)]
Remove unused define.

11 months agoFix some typos in comments.
Carl Hetherington [Tue, 11 Apr 2023 21:03:36 +0000 (23:03 +0200)]
Fix some typos in comments.

11 months agoAdd verify_dcp().
Carl Hetherington [Fri, 17 Feb 2023 23:15:10 +0000 (00:15 +0100)]
Add verify_dcp().

11 months agoOnly add fonts to assets when they are required.
Carl Hetherington [Fri, 12 May 2023 00:19:36 +0000 (02:19 +0200)]
Only add fonts to assets when they are required.

11 months agoCleanup: whitespace fix.
Carl Hetherington [Thu, 11 May 2023 22:46:28 +0000 (00:46 +0200)]
Cleanup: whitespace fix.

11 months agoHandle fonts for ccaps coming from DCP content (#2525).
Carl Hetherington [Thu, 11 May 2023 11:50:57 +0000 (13:50 +0200)]
Handle fonts for ccaps coming from DCP content (#2525).

Not dealing with them calls all sort of chaos as described in the
bug report.

11 months agoadd_fonts_from_examiner() can be called multiple times with the same font
Carl Hetherington [Thu, 11 May 2023 11:48:58 +0000 (13:48 +0200)]
add_fonts_from_examiner() can be called multiple times with the same font
in the case of closed captions with multiple tracks.  Don't reuse the
same font objects in this case, otherwise we will start with something
like font, disambiguate it to 0_font, then disambiguate _that_ to
0_0_font.

11 months agoFix _text_count for ccaps when there are multiple reels.
Carl Hetherington [Thu, 11 May 2023 11:47:35 +0000 (13:47 +0200)]
Fix _text_count for ccaps when there are multiple reels.

Previously we would get a _text_count of 1 for open subs, no matter
how many reels there were, but for ccaps the _text_count would
increase with the number of tracks _and_ the number of reels.

11 months agoFix comment.
Carl Hetherington [Thu, 11 May 2023 11:45:02 +0000 (13:45 +0200)]
Fix comment.

11 months agoAllow copy-construction of Font.
Carl Hetherington [Thu, 11 May 2023 11:44:57 +0000 (13:44 +0200)]
Allow copy-construction of Font.

11 months agoCleanup: include/using sorting.
Carl Hetherington [Thu, 11 May 2023 00:46:22 +0000 (02:46 +0200)]
Cleanup: include/using sorting.

11 months agoRemove incorrect silencing (#2526).
Carl Hetherington [Thu, 11 May 2023 01:24:57 +0000 (03:24 +0200)]
Remove incorrect silencing (#2526).

On switching to the new FFmpeg send/receive API in
e29ce33a36c2e20444d57196defc86d5072bce81
the channels variable in deinterleave_audio() was switched from
stream channels to frame channels.

I'm not sure if this is right, but it does mean that audio has
`channels` channels, so calling make_silent() up to the stream
channel count is clearly wrong if the stream has more channels
than the frame.

11 months agoFix uninitialised variable caught by the macOS compiler.
Carl Hetherington [Wed, 10 May 2023 14:36:44 +0000 (16:36 +0200)]
Fix uninitialised variable caught by the macOS compiler.

11 months agoAdd some assertions.
Carl Hetherington [Tue, 9 May 2023 18:22:07 +0000 (20:22 +0200)]
Add some assertions.

11 months agoDon't edit start trim unless it's necessary.
Carl Hetherington [Mon, 8 May 2023 23:41:31 +0000 (01:41 +0200)]
Don't edit start trim unless it's necessary.

11 months agoAllow signals to be blocked and resumed, and so make sure that a set
Carl Hetherington [Mon, 8 May 2023 23:33:45 +0000 (01:33 +0200)]
Allow signals to be blocked and resumed, and so make sure that a set
of content changes taken from an examiner are handled at the same
time.

Should fix DoM #2523.

11 months agoCleanup: more variable renames.
Carl Hetherington [Sat, 6 May 2023 22:01:38 +0000 (00:01 +0200)]
Cleanup: more variable renames.

11 months agoCleanup: rename variable.
Carl Hetherington [Sat, 6 May 2023 21:50:06 +0000 (23:50 +0200)]
Cleanup: rename variable.

11 months agoFix old C++ syntax.
Carl Hetherington [Mon, 8 May 2023 21:33:49 +0000 (23:33 +0200)]
Fix old C++ syntax.

11 months agoFix typo in comment.
Carl Hetherington [Mon, 8 May 2023 21:33:39 +0000 (23:33 +0200)]
Fix typo in comment.

11 months agoCope with WEBVTT files named with .srt extensions.
Carl Hetherington [Thu, 27 Apr 2023 22:13:20 +0000 (00:13 +0200)]
Cope with WEBVTT files named with .srt extensions.

11 months agoDon't use wx_ptr for the splash screen.
Carl Hetherington [Tue, 25 Apr 2023 09:03:54 +0000 (11:03 +0200)]
Don't use wx_ptr for the splash screen.

Using wx_ptr in the wxApp object seems bad because in ~App wxWidgets
deletes all top-level windows in `DeleteAllTLWs` so if ~wx_ptr then
tries to destroy them we get a use-after-free.

11 months agoCleanup: remove some unnecessary includes.
Carl Hetherington [Tue, 25 Apr 2023 09:03:42 +0000 (11:03 +0200)]
Cleanup: remove some unnecessary includes.

11 months agoFix length()/bytes() mismatch on XML string.
Carl Hetherington [Sun, 23 Apr 2023 20:45:35 +0000 (22:45 +0200)]
Fix length()/bytes() mismatch on XML string.

11 months agoAdd some missing replacements.
Carl Hetherington [Sat, 22 Apr 2023 19:20:16 +0000 (21:20 +0200)]
Add some missing replacements.

11 months agoAdd some more bandwidths to a test.
Carl Hetherington [Sat, 22 Apr 2023 19:20:12 +0000 (21:20 +0200)]
Add some more bandwidths to a test.

11 months agoAdd some missing Ubuntu 23.04 dependencies. v2.16.55
Carl Hetherington [Fri, 21 Apr 2023 22:53:44 +0000 (00:53 +0200)]
Add some missing Ubuntu 23.04 dependencies.

11 months agoSupporters update. v2.16.54
Carl Hetherington [Fri, 21 Apr 2023 08:51:52 +0000 (10:51 +0200)]
Supporters update.

11 months agoUpdate wscript (missed in last commit).
Carl Hetherington [Fri, 21 Apr 2023 08:51:31 +0000 (10:51 +0200)]
Update wscript (missed in last commit).

11 months agoBump libdcp to 1.8.67.
Carl Hetherington [Thu, 20 Apr 2023 10:14:12 +0000 (12:14 +0200)]
Bump libdcp to 1.8.67.

11 months agoFix lack of email sending if there are no cinema addresses (only extra ones) (#2514).
Carl Hetherington [Thu, 20 Apr 2023 19:49:57 +0000 (21:49 +0200)]
Fix lack of email sending if there are no cinema addresses (only extra ones) (#2514).

12 months agoIn 1c73379ed8483dcf71c5ccfc459c2c22516a9aef I changed
Carl Hetherington [Wed, 19 Apr 2023 21:57:03 +0000 (23:57 +0200)]
In 1c73379ed8483dcf71c5ccfc459c2c22516a9aef I changed
FontConfig::_available_fonts to use the font ID as a key, but that's
totally wrong because the same Font object with the same ID can have
its font filename/data changed, and in that case we don't want to
use the cached font.

Here we use the actual TTF/OTF font data as the key.  We could have
just hashed the data (whether it comes from a disk file or is held
in memory) but this is slower in the case where we have the filename,
as then the file must be loaded from disk for each comparison.

This fixes #2518.

12 months agoWrap path/data in a struct.
Carl Hetherington [Wed, 19 Apr 2023 21:53:58 +0000 (23:53 +0200)]
Wrap path/data in a struct.

12 months agoAdd a comment.
Carl Hetherington [Wed, 19 Apr 2023 21:53:14 +0000 (23:53 +0200)]
Add a comment.

12 months agoFix crash if saving files during save/cancel/close (#2517).
Carl Hetherington [Tue, 18 Apr 2023 19:04:27 +0000 (21:04 +0200)]
Fix crash if saving files during save/cancel/close (#2517).

12 months agoCleanup: longer variable name.
Carl Hetherington [Tue, 18 Apr 2023 10:53:16 +0000 (12:53 +0200)]
Cleanup: longer variable name.

12 months agoSlight improvement to error when failing to save a metadata file.
Carl Hetherington [Tue, 18 Apr 2023 09:28:19 +0000 (11:28 +0200)]
Slight improvement to error when failing to save a metadata file.

12 months agoUpdate dcpomatic-test-private for some v2.17.x changes that don't affect main.
Carl Hetherington [Fri, 14 Apr 2023 21:16:28 +0000 (23:16 +0200)]
Update dcpomatic-test-private for some v2.17.x changes that don't affect main.

12 months agoDefault to 14fL luminance in the GUI.
Carl Hetherington [Wed, 12 Apr 2023 10:00:47 +0000 (12:00 +0200)]
Default to 14fL luminance in the GUI.

12 months agoGive an error if a non-number is passed to dcpomatic2_create -s (#2488).
Carl Hetherington [Mon, 10 Apr 2023 22:54:13 +0000 (00:54 +0200)]
Give an error if a non-number is passed to dcpomatic2_create -s (#2488).

12 months agoSupporters update. v2.16.53
Carl Hetherington [Tue, 11 Apr 2023 08:01:57 +0000 (10:01 +0200)]
Supporters update.

12 months agoBump ffcmp to fix ffmpeg dependency.
Carl Hetherington [Mon, 10 Apr 2023 20:47:30 +0000 (22:47 +0200)]
Bump ffcmp to fix ffmpeg dependency.

12 months agoFix subtitle font handling with in-memory fonts from SMPTE (#2509). v2.16.52
Carl Hetherington [Fri, 7 Apr 2023 23:04:37 +0000 (01:04 +0200)]
Fix subtitle font handling with in-memory fonts from SMPTE (#2509).

Previously we would fail to make a font available if it came from
a SMPTE MXF.  In that case we have a memory buffer containing the
TTF/OTF file but no file; here we add a hack/workaround so that
in-memory font files can be used by FontConfig.

12 months agoFix ffmpeg revision that was set wrong in b6deee98.
Carl Hetherington [Sun, 9 Apr 2023 08:28:04 +0000 (10:28 +0200)]
Fix ffmpeg revision that was set wrong in b6deee98.

12 months agoFix ffmpeg git repo name.
Carl Hetherington [Sun, 9 Apr 2023 08:11:05 +0000 (10:11 +0200)]
Fix ffmpeg git repo name.

12 months agoSupport loading of certificate chains for trusted devices.
Carl Hetherington [Sat, 8 Apr 2023 22:19:34 +0000 (00:19 +0200)]
Support loading of certificate chains for trusted devices.

12 months agoImprove thumbprint dialog; disallow thumbprint editing and make OK only sensitive...
Carl Hetherington [Sat, 8 Apr 2023 20:36:41 +0000 (22:36 +0200)]
Improve thumbprint dialog; disallow thumbprint editing and make OK only sensitive when a certificate is there.

12 months agoBump ffmpeg for cherry-pick to fix #2508.
Carl Hetherington [Sat, 8 Apr 2023 19:27:11 +0000 (21:27 +0200)]
Bump ffmpeg for cherry-pick to fix #2508.

12 months agoWrite MainSoundConfiguration tags with hyphens for unused channels (#2501).
Carl Hetherington [Wed, 5 Apr 2023 20:05:12 +0000 (22:05 +0200)]
Write MainSoundConfiguration tags with hyphens for unused channels (#2501).

12 months agoDon't add fonts to SMPTE closed caption MXFs (#2505).
Carl Hetherington [Wed, 5 Apr 2023 20:25:03 +0000 (22:25 +0200)]
Don't add fonts to SMPTE closed caption MXFs (#2505).

12 months agoFix scrollbars when using zoom in the timeline.
Carl Hetherington [Wed, 5 Apr 2023 20:03:02 +0000 (22:03 +0200)]
Fix scrollbars when using zoom in the timeline.

12 months agoRemove incorrect GC translation.
Carl Hetherington [Wed, 5 Apr 2023 20:02:13 +0000 (22:02 +0200)]
Remove incorrect GC translation.

This appears not to be necessary, and if present it messes up the scrollbars
so that scrolling fully right shows a big empty space at the end of the
timeline items.

12 months agoMore zh_CN translation fixes from Danbo Song.
Carl Hetherington [Tue, 4 Apr 2023 22:02:34 +0000 (00:02 +0200)]
More zh_CN translation fixes from Danbo Song.

12 months agoUpdated nl_NL translation from Rob van Nieuwkerk.
Carl Hetherington [Sat, 1 Apr 2023 22:42:09 +0000 (00:42 +0200)]
Updated nl_NL translation from Rob van Nieuwkerk.

12 months agoSupporters update. v2.16.51
Carl Hetherington [Thu, 30 Mar 2023 07:50:14 +0000 (09:50 +0200)]
Supporters update.

12 months agoUse CURLOPT_NOSIGNAL to fix crashes on update check (#2495).
Carl Hetherington [Wed, 29 Mar 2023 23:25:25 +0000 (01:25 +0200)]
Use CURLOPT_NOSIGNAL to fix crashes on update check (#2495).

Without this, it's possible to come back from curl_easy_perform
in a different thread to the one that it was called from (in the case
of an error).

As I understand it, this happens because a signal handler is called
(from a different thread) and CURLOPT_NOSIGNAL stops this from
happening.

12 months agoAdd + and - as zoom shortcuts in the timeline.
Carl Hetherington [Wed, 29 Mar 2023 23:24:41 +0000 (01:24 +0200)]
Add + and - as zoom shortcuts in the timeline.

12 months agoAdd some more test cleanups.
Carl Hetherington [Wed, 29 Mar 2023 08:10:53 +0000 (10:10 +0200)]
Add some more test cleanups.

12 months agoAdd create support for some more audio channels.
Carl Hetherington [Sat, 25 Mar 2023 23:29:44 +0000 (00:29 +0100)]
Add create support for some more audio channels.

12 months agoWrite the correct MCA subdescriptors depending on active channels.
Carl Hetherington [Tue, 21 Mar 2023 00:11:01 +0000 (01:11 +0100)]
Write the correct MCA subdescriptors depending on active channels.

12 months agoFix dependence of test on a particular j2c path.
Carl Hetherington [Sun, 19 Mar 2023 17:58:28 +0000 (18:58 +0100)]
Fix dependence of test on a particular j2c path.

12 months agoStop running ./check_sums now we're using git annex.
Carl Hetherington [Sun, 19 Mar 2023 13:45:57 +0000 (14:45 +0100)]
Stop running ./check_sums now we're using git annex.

12 months agoAlways make 16-channel MXFs.
Carl Hetherington [Thu, 16 Mar 2023 22:03:08 +0000 (23:03 +0100)]
Always make 16-channel MXFs.

12 months agoCleanup: simplify test.
Carl Hetherington [Fri, 17 Mar 2023 20:33:52 +0000 (21:33 +0100)]
Cleanup: simplify test.

12 months agoMore zh_CN translation fixes from Danbo Song.
Carl Hetherington [Tue, 28 Mar 2023 23:59:33 +0000 (01:59 +0200)]
More zh_CN translation fixes from Danbo Song.

12 months agopot/merge.
Carl Hetherington [Tue, 28 Mar 2023 23:54:05 +0000 (01:54 +0200)]
pot/merge.

12 months agoJust call it the Combiner not the DCP Combiner.
Carl Hetherington [Tue, 28 Mar 2023 23:56:41 +0000 (01:56 +0200)]
Just call it the Combiner not the DCP Combiner.

12 months agoString fix.
Carl Hetherington [Tue, 28 Mar 2023 23:54:49 +0000 (01:54 +0200)]
String fix.

12 months agoAdd missing tools to the i18n list.
Carl Hetherington [Tue, 28 Mar 2023 23:53:58 +0000 (01:53 +0200)]
Add missing tools to the i18n list.

12 months agoSome zh_CN translation fixes from Danbo Song.
Carl Hetherington [Tue, 28 Mar 2023 23:50:36 +0000 (01:50 +0200)]
Some zh_CN translation fixes from Danbo Song.

12 months agopot/merge.
Carl Hetherington [Tue, 28 Mar 2023 23:43:56 +0000 (01:43 +0200)]
pot/merge.

12 months agoFix some translator comments.
Carl Hetherington [Tue, 28 Mar 2023 23:43:45 +0000 (01:43 +0200)]
Fix some translator comments.

12 months agoFix marker to use for gettext comments; they just need TRANSLATORS: in front of them...
Carl Hetherington [Tue, 28 Mar 2023 23:43:29 +0000 (01:43 +0200)]
Fix marker to use for gettext comments; they just need TRANSLATORS: in front of them now.

12 months agoFix strange behaviour of player export frame dialog (#2493). 2493-player-export-frame
Carl Hetherington [Mon, 27 Mar 2023 22:39:50 +0000 (00:39 +0200)]
Fix strange behaviour of player export frame dialog (#2493).

12 months agozh_CN translation fixes from Danbo Song.
Carl Hetherington [Mon, 27 Mar 2023 21:11:29 +0000 (23:11 +0200)]
zh_CN translation fixes from Danbo Song.

12 months agopot/merge.
Carl Hetherington [Mon, 27 Mar 2023 21:02:48 +0000 (23:02 +0200)]
pot/merge.

12 months agoFix markup in fr_FR translation causing missing text in disk writer (#2492). v2.16.50
Carl Hetherington [Sun, 26 Mar 2023 09:07:04 +0000 (11:07 +0200)]
Fix markup in fr_FR translation causing missing text in disk writer (#2492).

12 months agoSupporters update.
Carl Hetherington [Sat, 25 Mar 2023 20:29:28 +0000 (21:29 +0100)]
Supporters update.

12 months agoPrepare for Ubuntu 23.04.
Carl Hetherington [Fri, 24 Mar 2023 21:36:58 +0000 (22:36 +0100)]
Prepare for Ubuntu 23.04.

12 months agoCleanup: make things a little clearer. v2.16.49
Carl Hetherington [Wed, 22 Mar 2023 23:32:03 +0000 (00:32 +0100)]
Cleanup: make things a little clearer.

12 months agoFix crashes when using templates in some cases (#2491).
Carl Hetherington [Wed, 22 Mar 2023 23:29:40 +0000 (00:29 +0100)]
Fix crashes when using templates in some cases (#2491).

If a template had content with N audio channels there would be various
problems if content with <N channels was subsequently added.

12 months agoAdd AudioMapping::take_from().
Carl Hetherington [Wed, 22 Mar 2023 23:24:36 +0000 (00:24 +0100)]
Add AudioMapping::take_from().

12 months agoCleanup: don't need to store _{input,output}_channels.
Carl Hetherington [Wed, 22 Mar 2023 23:01:49 +0000 (00:01 +0100)]
Cleanup: don't need to store _{input,output}_channels.

12 months agoDon't crash immediately if there's no private data.
Carl Hetherington [Tue, 21 Mar 2023 11:24:20 +0000 (12:24 +0100)]
Don't crash immediately if there's no private data.

12 months agoBump private git sha. v2.16.48
Carl Hetherington [Tue, 21 Mar 2023 16:02:13 +0000 (17:02 +0100)]
Bump private git sha.

13 months agoAdd assert.
Carl Hetherington [Sun, 19 Mar 2023 13:52:24 +0000 (14:52 +0100)]
Add assert.

13 months agoBump private test git for use of git-annex.
Carl Hetherington [Sat, 18 Mar 2023 18:01:49 +0000 (19:01 +0100)]
Bump private test git for use of git-annex.

13 months agoAllow re-start of cancelled subtitle analysis jobs.
Carl Hetherington [Thu, 16 Mar 2023 01:03:21 +0000 (02:03 +0100)]
Allow re-start of cancelled subtitle analysis jobs.

13 months agoMake it quicker to cancel an analyse subtitle job (#2486).
Carl Hetherington [Thu, 16 Mar 2023 00:51:25 +0000 (01:51 +0100)]
Make it quicker to cancel an analyse subtitle job (#2486).

13 months agoDon't show an error when cancelling subtitle analysis.
Carl Hetherington [Thu, 16 Mar 2023 00:51:11 +0000 (01:51 +0100)]
Don't show an error when cancelling subtitle analysis.

13 months agoCleanup: move variable assignment that happens in every branch.
Carl Hetherington [Thu, 16 Mar 2023 00:48:44 +0000 (01:48 +0100)]
Cleanup: move variable assignment that happens in every branch.