From 5a649b6d803697388925d7cd64ec5f0da345f865 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Thu, 16 Apr 2020 23:33:50 +0200 Subject: [PATCH] Added some FIXMEs. --- src/lib/ffmpeg_decoder.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/lib/ffmpeg_decoder.cc b/src/lib/ffmpeg_decoder.cc index 350362478..cfaf0361b 100644 --- a/src/lib/ffmpeg_decoder.cc +++ b/src/lib/ffmpeg_decoder.cc @@ -210,6 +210,9 @@ FFmpegDecoder::deinterleave_audio (shared_ptr stream) const 0, stream->stream(_format_context)->codec->channels, _frame->nb_samples, audio_sample_format (stream), 1 ); + /* XXX: can't we just use _frame->nb_samples directly here? */ + /* XXX: can't we use swr_convert() to do the format conversion? */ + /* Deinterleave and convert to float */ /* total_samples and frames will be rounded down here, so if there are stray samples at the end -- 2.30.2