From d31bb9dd64630718fe7faa607e61be7ba88e9097 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Thu, 31 Jan 2019 01:34:56 +0000 Subject: [PATCH] Add some comments. --- src/lib/image.cc | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/lib/image.cc b/src/lib/image.cc index 41582f307..46c085ff2 100644 --- a/src/lib/image.cc +++ b/src/lib/image.cc @@ -185,6 +185,18 @@ Image::crop_scale_window ( SWS_CS_ITU709 }; + /* The 3rd parameter here is: + 0 -> source range MPEG (i.e. "video", 16-235) + 1 -> source range JPEG (i.e. "full", 0-255) + And the 5th: + 0 -> destination range MPEG (i.e. "video", 16-235) + 1 -> destination range JPEG (i.e. "full", 0-255) + + But remember: sws_setColorspaceDetails ignores + these parameters unless the image isYUV or isGray + (if it's neither, it uses video range for source + and destination). + */ sws_setColorspaceDetails ( scale_context, sws_getCoefficients (lut[yuv_to_rgb]), 0, @@ -271,6 +283,18 @@ Image::scale (dcp::Size out_size, dcp::YUVToRGB yuv_to_rgb, AVPixelFormat out_fo SWS_CS_ITU709 }; + /* The 3rd parameter here is: + 0 -> source range MPEG (i.e. "video", 16-235) + 1 -> source range JPEG (i.e. "full", 0-255) + And the 5th: + 0 -> destination range MPEG (i.e. "video", 16-235) + 1 -> destination range JPEG (i.e. "full", 0-255) + + But remember: sws_setColorspaceDetails ignores + these parameters unless the image isYUV or isGray + (if it's neither, it uses video range for source + and destination). + */ sws_setColorspaceDetails ( scale_context, sws_getCoefficients (lut[yuv_to_rgb]), 0, -- 2.30.2