From da39ed1516f2463f8a9bf4795a94f23d420c9ca3 Mon Sep 17 00:00:00 2001 From: Carl Hetherington Date: Wed, 30 Oct 2019 21:39:58 +0000 Subject: [PATCH] Fix dying butler on changing CPL from one without to one with subtitles (#1641). --- src/lib/dcp_decoder.cc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/lib/dcp_decoder.cc b/src/lib/dcp_decoder.cc index 8179ef009..340ef5d93 100644 --- a/src/lib/dcp_decoder.cc +++ b/src/lib/dcp_decoder.cc @@ -204,8 +204,14 @@ void DCPDecoder::pass_texts (ContentTime next, dcp::Size size) { list >::const_iterator decoder = text.begin (); + if (decoder == text.end()) { + /* It's possible that there is now a main subtitle but no TextDecoders, for example if + the CPL has just changed but the TextContent's texts have not been recreated yet. + */ + return; + } + if ((*_reel)->main_subtitle()) { - DCPOMATIC_ASSERT (decoder != text.end ()); pass_texts ( next, (*_reel)->main_subtitle()->asset(), @@ -216,8 +222,8 @@ DCPDecoder::pass_texts (ContentTime next, dcp::Size size) ); ++decoder; } + BOOST_FOREACH (shared_ptr i, (*_reel)->closed_captions()) { - DCPOMATIC_ASSERT (decoder != text.end ()); pass_texts ( next, i->asset(), _dcp_content->reference_text(TEXT_CLOSED_CAPTION), i->entry_point(), *decoder, size ); -- 2.30.2