When reading a DCP set up asset hashes from the CPL/PKL, not by digesting the actual...
authorCarl Hetherington <cth@carlh.net>
Mon, 26 Jun 2023 22:11:43 +0000 (00:11 +0200)
committerCarl Hetherington <cth@carlh.net>
Wed, 28 Jun 2023 23:25:40 +0000 (01:25 +0200)
commite702623781c8d5853b79a29ca8c5f495d0ade3d1
tree50240036d3cf18d87c9582d71e5fd3ee2d29e8e5
parentd305bb807a686fd7850257a724f46a77977fe491
When reading a DCP set up asset hashes from the CPL/PKL, not by digesting the actual asset.

Previously when reading a DCP we would recalculate asset hashes.  This meant that corrupted
DCPs could be loaded in and their hashes re-written (if nobody checked the new hashes against
the ones in the PKL/CPL).

It seems better to take the hashes from the metadata.  Then if the assets are corrupted
and the DCP is re-written the PKL/CPL hashes will be preserved, showing rather than hiding
the corruption.
src/dcp.cc
src/verify.cc
test/dcp_test.cc