summaryrefslogtreecommitdiff
path: root/src/AS_02.h
diff options
context:
space:
mode:
authorjhurst <jhurst@cinecert.com>2018-03-25 22:54:20 +0000
committerjhurst <>2018-03-25 22:54:20 +0000
commitffc88e36d1b15a863bad6577dee7d59254edfa22 (patch)
treef46ee12919d9eb6690815eb01f48e3fae73ddfbb /src/AS_02.h
parent40ecb821a29d1049e0a69149b20e552c7fbb0ae0 (diff)
o Fixed MinorVersion error (was "2", is now "3") when writing BodyPartition packs preceding partitions in AS-02 files.
o Fixed AS-DCP timed text writer, was creating DM Segment instead of SourceClip in the source package. o Changed SourcePackage timecode track start to 00:00:00:00 (was 01:00:00:00) o Fixed reference counting errors in asdcp.MXFWriter and asdcp.TimedTextWriter that were causing asdcp.MXFReader and asdcp.TimedTextReader (respectively) to remain allocated after all references had been deleted, thus leaking file handles and memory. o Fixed broken arg parser (missing format token in format string for "EssenceType" argument) in TimedTextWriter
Diffstat (limited to 'src/AS_02.h')
-rw-r--r--src/AS_02.h10
1 files changed, 7 insertions, 3 deletions
diff --git a/src/AS_02.h b/src/AS_02.h
index c768507..33163c3 100644
--- a/src/AS_02.h
+++ b/src/AS_02.h
@@ -367,12 +367,16 @@ namespace AS_02
// Opens an XML file for reading, parses data to provide a complete
// set of stream metadata for the MXFWriter below.
- Result_t OpenRead(const std::string& filename, const std::string& profile_name) const;
+ Result_t OpenRead(const std::string& filename) const;
// Parse an XML string
- Result_t OpenRead(const std::string& xml_doc, const std::string& filename,
- const std::string& profile_name) const;
+ Result_t OpenRead(const std::string& xml_doc, const std::string& filename) const;
+ // The "profile_name" parameter was removed from OpenRead() because it made the API
+ // awkward WRT lexical compatibility with TimedText_Parser. The value can still be
+ // modified by changing the descriptor's NamespaceName property after the call to
+ // FillTimedTextDescriptor() has set it.
+
// Fill a TimedTextDescriptor struct with the values from the file's contents.
// Returns RESULT_INIT if the file is not open.
Result_t FillTimedTextDescriptor(ASDCP::TimedText::TimedTextDescriptor&) const;