summaryrefslogtreecommitdiff
path: root/doc/design/decoder_structures.tex
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2017-02-21 23:30:35 +0000
committerCarl Hetherington <cth@carlh.net>2017-04-19 23:04:32 +0100
commit476ef8b0024a6f2e00095df780d0a191019aec95 (patch)
treeebfa0a6dec237c18131125d053e81aac868c5fbb /doc/design/decoder_structures.tex
parent0a33b35732450d91e39b725ace6cf3e51ab9bc3a (diff)
Move / update some design docs.
Diffstat (limited to 'doc/design/decoder_structures.tex')
-rw-r--r--doc/design/decoder_structures.tex36
1 files changed, 35 insertions, 1 deletions
diff --git a/doc/design/decoder_structures.tex b/doc/design/decoder_structures.tex
index 64a7da752..594c66450 100644
--- a/doc/design/decoder_structures.tex
+++ b/doc/design/decoder_structures.tex
@@ -162,7 +162,7 @@ Questions:
\begin{itemize}
\item Add signals to \texttt{Player}.
\begin{itemize}
- \item \texttt{signal<void (shared\_ptr<PlayerVideo>), DCPTime> Video;}
+ \item \texttt{signal<void (shared\_ptr<PlayerVideo>), DCPTime)> Video;}
\item \texttt{signal<void (shared\_ptr<AudioBuffers>, DCPTime)> Audio;}
\item \texttt{signal<void (PlayerSubtitles, DCPTimePeriod)> Subtitle;}
\end{itemize}
@@ -174,4 +174,38 @@ Questions:
\item Remove \texttt{get} methods from \texttt{Player}; replace with \texttt{pass()} and \texttt{seek()}.
\end{itemize}
+
+\section{Summary of work done in \texttt{back-to-pass}}
+
+The diff between \texttt{back-to-pass} and \texttt{master} as at 21/2/2017 can be summarised as:
+
+\begin{enumerate}
+\item Remove \texttt{AudioDecoderStream}; no more need to buffer, and resampling is done in \texttt{Player}.
+\item \texttt{AudioDecoder} is simple; basically counting frames.
+\item All subtitles-during stuff is gone; no need to know what happens in a particular period as we just wait and see.
+\item Pass reason stuff gone; not sure what it was for but seems to have been a contortion related to trying to find specific stuff.
+ \item \texttt{Player::pass} back, obviously.
+ \item \texttt{Player::get\_video}, \texttt{get\_audio} and
+ \texttt{get\_subtitle} more-or-less become \texttt{Player}'s
+ handlers for emissions from decoders; lots of buffering crap gone
+ in the process.
+ \item Add \texttt{Decoder::position} stuff so that we know what to \texttt{pass()} in \texttt{Player}.
+ \item Add \texttt{AudioMerger}; necessary as audio arrives at the
+ \texttt{Player} from different streams at different times. The
+ \texttt{AudioMerger} just accepts data, mixes and spits it out
+ again.
+\item Obvious consumer changes: what was a loop over the playlist
+ length and calls to \texttt{get()} is now calls to \texttt{pass()}.
+ \item Maybe-seek stuff gone.
+ \item Some small \texttt{const}-correctness bits.
+\end{enumerate}
+
+Obvious things to do:
+
+\begin{enumerate}
+\item Ensure AudioMerger is being tested.
+\item Ensure hardest-case in video / audio is being tested.
+\item Look at symmetry of video/audio paths / APIs.
+\end{enumerate}
+
\end{document}