diff options
| author | Carl Hetherington <cth@carlh.net> | 2023-07-31 00:51:11 +0200 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2023-07-31 00:51:13 +0200 |
| commit | ea57d67cb7c7cd500d34bf783ed23c3dbc66b59b (patch) | |
| tree | 7d7f9f0fe1e1f071140c1c2b10d4137a2b577933 /src/lib/hints.cc | |
| parent | 0ed5dfdeb21577f617184a5e6605cc8e9c60a892 (diff) | |
Only warn about a missing text language for subtitles (not closed captions).
I haven't properly checked that closed captions shouldn't have some
language metadata, but the existing GUI code explicitly disallows
setup of a closed caption language.
Diffstat (limited to 'src/lib/hints.cc')
| -rw-r--r-- | src/lib/hints.cc | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/src/lib/hints.cc b/src/lib/hints.cc index 6c574d991..d472dfc03 100644 --- a/src/lib/hints.cc +++ b/src/lib/hints.cc @@ -397,7 +397,7 @@ try auto const check_loudness_done = check_loudness (); check_ffec_and_ffmc_in_smpte_feature (); check_out_of_range_markers (); - check_text_languages (); + check_subtitle_languages(); check_audio_language (); if (check_loudness_done) { @@ -647,14 +647,14 @@ Hints::join () void -Hints::check_text_languages () +Hints::check_subtitle_languages() { for (auto i: film()->content()) { for (auto j: i->text) { - if (j->use() && !j->language()) { - hint (_("At least one piece of subtitle or closed caption content has no specified language. " - "It is advisable to set the language for each piece of subtitle or closed caption content " - "in the \"Content→Timed text\", \"Content→Open subtitles\" or \"Content→Closed captions\" tab.")); + if (j->use() && j->type() == TextType::OPEN_SUBTITLE && !j->language()) { + hint (_("At least one piece of subtitle content has no specified language. " + "It is advisable to set the language for each piece of subtitle content " + "in the \"Content→Timed text\" or \"Content→Open subtitles\" tab.")); return; } } |
