summaryrefslogtreecommitdiff
path: root/src/lib
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2025-12-31 22:52:12 +0100
committerCarl Hetherington <cth@carlh.net>2025-12-31 22:52:12 +0100
commitd99879343b9c77a008577eb9c4e3adaed26f6f8f (patch)
tree9eec2507def3c498dc4308dfe85e45819ee0d591 /src/lib
parenta97aca6d9eb0abd8b1acdfad188ae2e0a43765e2 (diff)
Use encoder frames encoded counts for transcode progress (#2864).
This seems to make more sense than using whatever the player has produced, which may not be what you want to know about in cases like a DCP containing no video and only subs.
Diffstat (limited to 'src/lib')
-rw-r--r--src/lib/dcp_film_encoder.cc10
1 files changed, 8 insertions, 2 deletions
diff --git a/src/lib/dcp_film_encoder.cc b/src/lib/dcp_film_encoder.cc
index c66858bac..a818c9b4c 100644
--- a/src/lib/dcp_film_encoder.cc
+++ b/src/lib/dcp_film_encoder.cc
@@ -125,12 +125,14 @@ DCPFilmEncoder::go()
_writer->write(_player.get_subtitle_fonts());
}
+ auto const length = _film->length().frames_round(_film->video_frame_rate());
+
int passes = 0;
while (!_player.pass()) {
if ((++passes % 8) == 0) {
auto job = _job.lock();
DCPOMATIC_ASSERT(job);
- job->set_progress(_player.progress());
+ job->set_progress(static_cast<float>(frames_done()) / length);
}
}
@@ -201,5 +203,9 @@ DCPFilmEncoder::current_rate() const
Frame
DCPFilmEncoder::frames_done() const
{
- return _player.frames_done();
+ if (!_encoder) {
+ return 0;
+ }
+
+ return _encoder->video_frames_encoded();
}