diff options
| author | Carl Hetherington <cth@carlh.net> | 2025-02-25 01:53:48 +0100 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2025-02-25 13:04:08 +0100 |
| commit | 6d3086dd78a35bdc179a6579e23f8b5816347dbf (patch) | |
| tree | a47facfec259302afd6e0e690b748ad9f655548e /src/wx/audio_panel.h | |
| parent | 91c171b65e7329b90ac77442fd35b165bde70b26 (diff) | |
Fix misunderstanding of wxDialog lifetime handling.
Broken by d0308d53dd9f4d036d8c5fe8023920fcdfd43f39
wxDialog can be stack allocated if opened with ShowModal(), but not with
Show(). Go back to wx_ptr for those that are opened with Show().
Diffstat (limited to 'src/wx/audio_panel.h')
| -rw-r--r-- | src/wx/audio_panel.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/wx/audio_panel.h b/src/wx/audio_panel.h index 56552992d..813246652 100644 --- a/src/wx/audio_panel.h +++ b/src/wx/audio_panel.h @@ -19,13 +19,14 @@ */ -#include "audio_dialog.h" #include "content_sub_panel.h" #include "content_widget.h" #include "timecode.h" +#include "wx_ptr.h" #include "lib/audio_mapping.h" +class AudioDialog; class AudioMappingView; class CheckBox; class LanguageTagWidget; @@ -76,7 +77,7 @@ private: CheckBox* _use_same_fades_as_video; AudioMappingView* _mapping; wxStaticText* _description; - boost::optional<AudioDialog> _audio_dialog; + wx_ptr<AudioDialog> _audio_dialog; boost::signals2::scoped_connection _mapping_connection; boost::signals2::scoped_connection _active_jobs_connection; |