summaryrefslogtreecommitdiff
path: root/src/wx/content_menu.cc
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2025-02-25 01:53:48 +0100
committerCarl Hetherington <cth@carlh.net>2025-02-25 01:54:22 +0100
commit9f150f04c8fce17dbcbe11278dd78c6e35809aa2 (patch)
treedc4c36254282b9152b9ff04dc09f07dc1e6ba0f1 /src/wx/content_menu.cc
parent674b74173d2d0ec8e178fa0938a4c48c2863c38b (diff)
Fix misunderstanding of wxDialog lifetime handling.2978-wxptr-crash
Broken by d0308d53dd9f4d036d8c5fe8023920fcdfd43f39 wxDialog can be stack allocated if opened with ShowModal(), but not with Show(). Go back to wx_ptr for those that are opened with Show().
Diffstat (limited to 'src/wx/content_menu.cc')
-rw-r--r--src/wx/content_menu.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/wx/content_menu.cc b/src/wx/content_menu.cc
index 1106a10fc..e2dfdaf97 100644
--- a/src/wx/content_menu.cc
+++ b/src/wx/content_menu.cc
@@ -570,7 +570,7 @@ ContentMenu::auto_crop ()
auto const crop = guess_crop_for_content ();
update_viewer (crop);
- _auto_crop_dialog.emplace(_parent, crop);
+ _auto_crop_dialog.reset(_parent, crop);
_auto_crop_dialog->Show ();
/* Update the dialog and view when the crop threshold changes */