diff options
| author | Carl Hetherington <cth@carlh.net> | 2024-01-03 23:32:22 +0100 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2024-01-03 23:32:38 +0100 |
| commit | 647136fda2e33b5493b0d0b89a5ad4976623952e (patch) | |
| tree | 25cc0889a8bb7aa22f83c588a7cbfbbb793f4587 /src | |
| parent | 145fac712fe6dbdd57063f2ba423d586e16b2462 (diff) | |
Bump libdcp for better diagnostics of bad/large J2K frames (#2680).2698-verify
Diffstat (limited to 'src')
| -rw-r--r-- | src/wx/verify_dcp_dialog.cc | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/src/wx/verify_dcp_dialog.cc b/src/wx/verify_dcp_dialog.cc index 9b7afdd7b..fe177dd67 100644 --- a/src/wx/verify_dcp_dialog.cc +++ b/src/wx/verify_dcp_dialog.cc @@ -100,6 +100,9 @@ VerifyDCPDialog::VerifyDCPDialog (wxWindow* parent, shared_ptr<VerifyDCPJob> job if (note.note()) { message.Replace("%n", std_to_wx(note.note().get())); } + if (note.frame()) { + message.Replace("%frame", std_to_wx(dcp::raw_convert<string>(note.frame().get()))); + } if (note.file()) { message.Replace("%f", std_to_wx(note.file()->filename().string())); } @@ -121,6 +124,10 @@ VerifyDCPDialog::VerifyDCPDialog (wxWindow* parent, shared_ptr<VerifyDCPJob> job if (note.other_id()) { message.Replace("%other_id", std_to_wx(note.other_id().get())); } + if (note.frame() && note.frame_rate()) { + auto frame_rate = note.frame_rate().get(); + message.Replace("%timecode", std_to_wx(dcp::Time(note.frame().get(), frame_rate, frame_rate).as_string(dcp::Standard::SMPTE))); + } add_bullet (note.type(), message); }; @@ -178,10 +185,10 @@ VerifyDCPDialog::VerifyDCPDialog (wxWindow* parent, shared_ptr<VerifyDCPJob> job add(i, _("The asset %n has a duration of less than 1 second, which is invalid.")); break; case dcp::VerificationNote::Code::INVALID_PICTURE_FRAME_SIZE_IN_BYTES: - add(i, _("At least one frame of the video asset %f is over the limit of 250Mbit/s.")); + add(i, _("Frame %timecode (timecode %timecode) in asset %f is over the limit of 250Mbit/s.")); break; case dcp::VerificationNote::Code::NEARLY_INVALID_PICTURE_FRAME_SIZE_IN_BYTES: - add(i, _("At least one frame of the video asset %f is close to the limit of 250MBit/s.")); + add(i, _("Frame %frame (timecode %timecode) in asset %f is close to the limit of 250Mbit/s.")); break; case dcp::VerificationNote::Code::EXTERNAL_ASSET: add(i, _("This DCP refers to at the asset %n in another DCP (and perhaps others), so it is a \"version file\" (VF)")); |