summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2024-05-09 22:13:15 +0200
committerCarl Hetherington <cth@carlh.net>2024-05-29 10:35:55 +0200
commit2d82f86d2f99b812edd5d64d13f3dd5a4950719e (patch)
tree58214917cec0f6f829f85f4919d5f2c532b93d64 /src
parent98a0aa443e10d1db466c575fd854bef841988534 (diff)
Remove default video bit rate settings.
Diffstat (limited to 'src')
-rw-r--r--src/lib/config.cc4
-rw-r--r--src/lib/config.h4
-rw-r--r--src/wx/full_config_dialog.cc39
3 files changed, 0 insertions, 47 deletions
diff --git a/src/lib/config.cc b/src/lib/config.cc
index 5401839e3..a446b37ca 100644
--- a/src/lib/config.cc
+++ b/src/lib/config.cc
@@ -787,10 +787,6 @@ Config::write_config () const
/* [XML] DefaultStillLength Default length (in seconds) for still images in new films. */
cxml::add_text_child(root, "DefaultStillLength", raw_convert<string>(_default_still_length));
- /* [XML] DefaultJ2KVideoBitRate Default bitrate (in bits per second) for JPEG2000 data in new films. */
- cxml::add_text_child(root, "DefaultJ2KVideoBitRate", raw_convert<string>(_default_video_bit_rate[VideoEncoding::JPEG2000]));
- /* [XML] DefaultMPEG2VideoBitRate Default bitrate (in bits per second) for MPEG2 data in new films. */
- cxml::add_text_child(root, "DefaultMPEG2VideoBitRate", raw_convert<string>(_default_video_bit_rate[VideoEncoding::MPEG2]));
/* [XML] DefaultAudioDelay Default delay to apply to audio (positive moves audio later) in milliseconds. */
cxml::add_text_child(root, "DefaultAudioDelay", raw_convert<string>(_default_audio_delay));
/* [XML] DefaultInterop 1 to default new films to Interop, 0 for SMPTE. */
diff --git a/src/lib/config.h b/src/lib/config.h
index aaeada4e6..4fccf2d5c 100644
--- a/src/lib/config.h
+++ b/src/lib/config.h
@@ -794,10 +794,6 @@ public:
maybe_set (_dcp_j2k_comment, c);
}
- void set_default_video_bit_rate(VideoEncoding encoding, int64_t b) {
- maybe_set(_default_video_bit_rate[encoding], b);
- }
-
void set_default_audio_delay (int d) {
maybe_set (_default_audio_delay, d);
}
diff --git a/src/wx/full_config_dialog.cc b/src/wx/full_config_dialog.cc
index 67813ba0b..856f70113 100644
--- a/src/wx/full_config_dialog.cc
+++ b/src/wx/full_config_dialog.cc
@@ -311,24 +311,6 @@ private:
table->Add (_directory, 1, wxEXPAND);
{
- add_label_to_sizer(table, _panel, _("Default JPEG2000 bit rate"), true, 0, wxLEFT | wxRIGHT | wxALIGN_CENTRE_VERTICAL);
- auto s = new wxBoxSizer (wxHORIZONTAL);
- _j2k_video_bit_rate = new wxSpinCtrl(_panel);
- s->Add(_j2k_video_bit_rate);
- add_label_to_sizer (s, _panel, _("Mbit/s"), false, 0, wxLEFT | wxRIGHT | wxALIGN_CENTRE_VERTICAL);
- table->Add (s, 1);
- }
-
- {
- add_label_to_sizer(table, _panel, _("Default MPEG2 bit rate"), true, 0, wxLEFT | wxRIGHT | wxALIGN_CENTRE_VERTICAL);
- auto s = new wxBoxSizer (wxHORIZONTAL);
- _mpeg2_video_bit_rate = new wxSpinCtrl(_panel);
- s->Add(_mpeg2_video_bit_rate);
- add_label_to_sizer (s, _panel, _("Mbit/s"), false, 0, wxLEFT | wxRIGHT | wxALIGN_CENTRE_VERTICAL);
- table->Add (s, 1);
- }
-
- {
add_label_to_sizer (table, _panel, _("Default audio delay"), true, 0, wxLEFT | wxRIGHT | wxALIGN_CENTRE_VERTICAL);
auto s = new wxBoxSizer (wxHORIZONTAL);
_audio_delay = new wxSpinCtrl (_panel);
@@ -401,11 +383,6 @@ private:
_use_isdcf_name_by_default->bind(&DefaultsPage::use_isdcf_name_by_default_changed, this);
- _j2k_video_bit_rate->SetRange(50, 250);
- _j2k_video_bit_rate->Bind(wxEVT_SPINCTRL, boost::bind(&DefaultsPage::j2k_video_bit_rate_changed, this));
- _mpeg2_video_bit_rate->SetRange(1, 50);
- _mpeg2_video_bit_rate->Bind(wxEVT_SPINCTRL, boost::bind(&DefaultsPage::mpeg2_video_bit_rate_changed, this));
-
_audio_delay->SetRange (-1000, 1000);
_audio_delay->Bind (wxEVT_SPINCTRL, boost::bind (&DefaultsPage::audio_delay_changed, this));
@@ -436,10 +413,6 @@ private:
_kdm_directory->SetPath (std_to_wx (config->default_kdm_directory_or (wx_to_std (wxStandardPaths::Get().GetDocumentsDir())).string ()));
_kdm_type->set (config->default_kdm_type());
checked_set (_use_isdcf_name_by_default, config->use_isdcf_name_by_default());
- checked_set(_j2k_video_bit_rate, config->default_video_bit_rate(VideoEncoding::JPEG2000) / 1000000);
- _j2k_video_bit_rate->SetRange(50, config->maximum_video_bit_rate(VideoEncoding::JPEG2000) / 1000000);
- checked_set(_mpeg2_video_bit_rate, config->default_video_bit_rate(VideoEncoding::MPEG2) / 1000000);
- _mpeg2_video_bit_rate->SetRange(1, config->maximum_video_bit_rate(VideoEncoding::MPEG2) / 1000000);
checked_set (_audio_delay, config->default_audio_delay ());
checked_set (_standard, config->default_interop() ? 1 : 0);
auto dal = config->default_audio_language();
@@ -513,16 +486,6 @@ private:
config->set_default_kdm_duration (RoughDuration(duration, unit));
}
- void j2k_video_bit_rate_changed()
- {
- Config::instance()->set_default_video_bit_rate(VideoEncoding::JPEG2000, _j2k_video_bit_rate->GetValue() * 1000000);
- }
-
- void mpeg2_video_bit_rate_changed()
- {
- Config::instance()->set_default_video_bit_rate(VideoEncoding::MPEG2, _mpeg2_video_bit_rate->GetValue() * 1000000);
- }
-
void audio_delay_changed ()
{
Config::instance()->set_default_audio_delay (_audio_delay->GetValue());
@@ -609,8 +572,6 @@ private:
}
}
- wxSpinCtrl* _j2k_video_bit_rate;
- wxSpinCtrl* _mpeg2_video_bit_rate;
wxSpinCtrl* _audio_delay;
wxSpinCtrl* _still_length;
#ifdef DCPOMATIC_USE_OWN_PICKER