summaryrefslogtreecommitdiff
path: root/test/audio_analysis_test.cc
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2023-11-08 00:18:22 +0100
committerCarl Hetherington <cth@carlh.net>2023-11-20 07:34:23 +0100
commit4ae0193c125cc70176eb1660919d507fbf5378e4 (patch)
tree710e43057b4d5110c90807b4498d59b0bf2d6bea /test/audio_analysis_test.cc
parent16557827b252bd653b15eead479ec5699eda7360 (diff)
Don't feed channels to leqm that we don't have a correction factor for (#2647).
Diffstat (limited to 'test/audio_analysis_test.cc')
-rw-r--r--test/audio_analysis_test.cc24
1 files changed, 24 insertions, 0 deletions
diff --git a/test/audio_analysis_test.cc b/test/audio_analysis_test.cc
index 39abe7e48..9ad37ec2e 100644
--- a/test/audio_analysis_test.cc
+++ b/test/audio_analysis_test.cc
@@ -31,6 +31,7 @@
#include "lib/audio_analysis.h"
#include "lib/audio_content.h"
#include "lib/content_factory.h"
+#include "lib/dcp_content.h"
#include "lib/dcp_content_type.h"
#include "lib/ffmpeg_content.h"
#include "lib/ffmpeg_content.h"
@@ -211,6 +212,29 @@ BOOST_AUTO_TEST_CASE (analyse_audio_leqm_test)
}
+BOOST_AUTO_TEST_CASE(analyse_audio_leqm_same_with_empty_channels)
+{
+ auto dcp = make_shared<DCPContent>(TestPaths::private_data() / "JourneyToJah_TLR-1_F_EN-DE-FR_CH_51_2K_LOK_20140225_DGL_SMPTE_OV");
+ auto film = new_test_film2("analyse_audio_leqm_test2", { dcp });
+ film->set_audio_channels(8);
+
+ auto analyse = [film, dcp](int channels) {
+ film->set_audio_channels(channels);
+ auto playlist = make_shared<Playlist>();
+ playlist->add(film, dcp);
+ boost::signals2::connection c;
+ JobManager::instance()->analyse_audio(film, playlist, false, c, [](Job::Result) {});
+ BOOST_CHECK(!wait_for_jobs());
+ AudioAnalysis analysis(film->audio_analysis_path(playlist));
+ return analysis.leqm().get_value_or(0);
+ };
+
+ BOOST_CHECK_CLOSE(analyse( 6), 84.51411, 0.001);
+ BOOST_CHECK_CLOSE(analyse( 8), 84.51411, 0.001);
+ BOOST_CHECK_CLOSE(analyse(16), 84.51411, 0.001);
+}
+
+
/** Bug #2364; a file with a lot of silent video at the end (about 50s worth)
* crashed the audio analysis with an OOM on Windows.
*/