diff options
| author | Carl Hetherington <cth@carlh.net> | 2020-11-27 23:30:13 +0100 |
|---|---|---|
| committer | Carl Hetherington <cth@carlh.net> | 2020-11-28 20:58:56 +0100 |
| commit | cf26869c2789b7ecf91e486fc3c7bf271276a592 (patch) | |
| tree | 5f945ce6382e06344a26d4b7e5ab31ffca0186f1 /test | |
| parent | 9121eb64810e39ba356d4a1b723a720adc82c096 (diff) | |
Fix over-read behaviour of FileGroup to be the same on all platforms.
Instead of relying on the operating system's behaviour when seeking
off the end of a file, keep our own _position. This normalises
the behaviour between POSIX and Windows.
Diffstat (limited to 'test')
| -rw-r--r-- | test/file_group_test.cc | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/test/file_group_test.cc b/test/file_group_test.cc index 05127828c..1d42741b6 100644 --- a/test/file_group_test.cc +++ b/test/file_group_test.cc @@ -88,10 +88,15 @@ BOOST_AUTO_TEST_CASE (file_group_test) BOOST_CHECK_EQUAL (memcmp (data + pos, test, 128), 0); pos += 128; - /* Read overlapping B/C/D and over-reading */ + /* Read overlapping B/C/D and over-reading by a lot */ BOOST_CHECK_EQUAL (fg.read (test, total_length * 3), total_length - pos); BOOST_CHECK_EQUAL (memcmp (data + pos, test, total_length - pos), 0); + /* Over-read by a little */ + BOOST_CHECK_EQUAL (fg.seek (0, SEEK_SET), 0); + BOOST_CHECK_EQUAL (fg.read (test, total_length), total_length); + BOOST_CHECK_EQUAL (fg.read (test, 1), 0); + /* Seeking off the end of the file should not give an error */ BOOST_CHECK_EQUAL (fg.seek (total_length * 2, SEEK_SET), total_length * 2); /* and attempting to read should return nothing */ |