summaryrefslogtreecommitdiff
path: root/src/lib
diff options
context:
space:
mode:
Diffstat (limited to 'src/lib')
-rw-r--r--src/lib/trimmer.cc23
-rw-r--r--src/lib/trimmer.h1
2 files changed, 12 insertions, 12 deletions
diff --git a/src/lib/trimmer.cc b/src/lib/trimmer.cc
index b7afc9299..1ec9e2a5b 100644
--- a/src/lib/trimmer.cc
+++ b/src/lib/trimmer.cc
@@ -18,6 +18,7 @@
*/
#include <boost/shared_ptr.hpp>
+#include <stdint.h>
#include "trimmer.h"
using std::cout;
@@ -55,18 +56,22 @@ Trimmer::Trimmer (
_audio_end = video_frames_to_audio_frames (_video_end, audio_sample_rate, frames_per_second);
}
- /* XXX: this is a hack; this flag means that no trim is happening at the end of the film, and I'm
- using that to prevent audio trim being rounded to video trim, which breaks the current set
- of regression tests. This could be removed if a) the regression tests are regenerated and b)
- I can work out what DCP length should be.
+ /* XXX: this is a hack; if there is no trim at the end, set
+ the audio end point to infinity so that
+ shorter-video-than-audio does not trim audio (which breaks
+ the current set of regression tests). This could be
+ removed if a) the regression tests are regenerated and b) I
+ can work out what DCP length should be.
*/
- _no_trim = (_video_start == 0) && (_video_end == (video_length - video_trim_end));
+ if (video_trim_end == 0) {
+ _audio_end = INT64_MAX;
+ }
}
void
Trimmer::process_video (shared_ptr<const Image> image, bool same, shared_ptr<Subtitle> sub)
{
- if (_no_trim || (_video_in >= _video_start && _video_in <= _video_end)) {
+ if (_video_in >= _video_start && _video_in < _video_end) {
Video (image, same, sub);
}
@@ -76,13 +81,9 @@ Trimmer::process_video (shared_ptr<const Image> image, bool same, shared_ptr<Sub
void
Trimmer::process_audio (shared_ptr<const AudioBuffers> audio)
{
- if (_no_trim) {
- Audio (audio);
- return;
- }
-
int64_t offset = _audio_start - _audio_in;
if (offset > audio->frames()) {
+ /* we haven't reached the start of the untrimmed section yet */
_audio_in += audio->frames ();
return;
}
diff --git a/src/lib/trimmer.h b/src/lib/trimmer.h
index 98a118fb2..45b3f149a 100644
--- a/src/lib/trimmer.h
+++ b/src/lib/trimmer.h
@@ -36,5 +36,4 @@ private:
int64_t _audio_start;
int64_t _audio_end;
int64_t _audio_in;
- bool _no_trim;
};