1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
|
/*
Copyright (C) 2016-2022 Carl Hetherington <cth@carlh.net>
This file is part of DCP-o-matic.
DCP-o-matic is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
DCP-o-matic is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with DCP-o-matic. If not, see <http://www.gnu.org/licenses/>.
*/
#include "audio_analysis.h"
#include "audio_content.h"
#include "audio_processor.h"
#include "compose.hpp"
#include "config.h"
#include "constants.h"
#include "content.h"
#include "cross.h"
#include "dcp_content_type.h"
#include "film.h"
#include "font.h"
#include "hints.h"
#include "maths_util.h"
#include "player.h"
#include "ratio.h"
#include "text_content.h"
#include "variant.h"
#include "video_content.h"
#include "writer.h"
#include <dcp/cpl.h>
#include <dcp/filesystem.h>
#include <dcp/raw_convert.h>
#include <dcp/reel.h>
#include <dcp/reel_text_asset.h>
#include <boost/algorithm/string.hpp>
#include <iostream>
#include "i18n.h"
using std::cout;
using std::make_shared;
using std::max;
using std::shared_ptr;
using std::string;
using std::weak_ptr;
using boost::optional;
using namespace dcpomatic;
#if BOOST_VERSION >= 106100
using namespace boost::placeholders;
#endif
/* When checking to see if things are too big, we'll say they are if they
* are more than the target size minus this "slack."
*/
#define SIZE_SLACK 4096
/* When writing hints:
* - put quotation marks around the name of a GUI tab that you are referring to (e.g. "DCP" or "DCP→Video" tab)
*/
Hints::Hints (weak_ptr<const Film> weak_film)
: WeakConstFilm (weak_film)
, _writer(new Writer(weak_film, weak_ptr<Job>(), film()->dir("hints") / dcpomatic::get_process_id(), true))
, _analyser (film(), film()->playlist(), true, [](float) {})
, _stop (false)
{
}
void
Hints::start ()
{
_thread = boost::thread(boost::bind(&Hints::thread, this));
}
Hints::~Hints ()
{
boost::this_thread::disable_interruption dis;
try {
_stop = true;
_thread.interrupt ();
_thread.join ();
} catch (...) {}
}
void
Hints::check_few_audio_channels ()
{
if (film()->audio_channels() < 6) {
hint(
variant::insert_dcpomatic(
_("Your DCP has fewer than 6 audio channels. This may cause problems on some projectors. "
"You may want to set the DCP to have 6 channels. It does not matter if your content has "
"fewer channels, as %1 will fill the extras with silence.")
)
);
}
}
void
Hints::check_upmixers ()
{
auto ap = film()->audio_processor();
if (ap && (ap->id() == "stereo-5.1-upmix-a" || ap->id() == "stereo-5.1-upmix-b")) {
hint(variant::insert_dcpomatic(
_("You are using %1's stereo-to-5.1 upmixer. This is experimental and "
"may result in poor-quality audio. If you continue, you should listen to the "
"resulting DCP in a cinema to make sure that it sounds good.")
)
);
}
}
void
Hints::check_incorrect_container ()
{
int narrower_than_scope = 0;
int scope = 0;
for (auto i: film()->content()) {
if (i->video && i->video->size()) {
auto const r = Ratio::nearest_from_ratio(i->video->scaled_size(film()->frame_size())->ratio());
if (r && r->id() == "239") {
++scope;
} else if (r && r->id() != "239" && r->id() != "235" && r->id() != "190") {
++narrower_than_scope;
}
}
}
string const film_container = film()->container()->id();
if (scope && !narrower_than_scope && film_container == "185") {
hint (_("All of your content is in Scope (2.39:1) but your DCP's container is Flat (1.85:1). This will letter-box your content inside a Flat (1.85:1) frame. You may prefer to set your DCP's container to Scope (2.39:1) in the \"DCP\" tab."));
}
if (!scope && narrower_than_scope && film_container == "239") {
hint (_("All of your content narrower than 1.90:1 but your DCP's container is Scope (2.39:1). This will pillar-box your content. You may prefer to set your DCP's container to have the same ratio as your content."));
}
}
void
Hints::check_unusual_container ()
{
auto const film_container = film()->container()->id();
if (film()->video_encoding() != VideoEncoding::MPEG2 && film_container != "185" && film_container != "239") {
hint (_("Your DCP uses an unusual container ratio. This may cause problems on some projectors. If possible, use Flat or Scope for the DCP container ratio."));
}
}
void
Hints::check_high_video_bit_rate()
{
if (film()->video_encoding() == VideoEncoding::JPEG2000 && film()->video_bit_rate(VideoEncoding::JPEG2000) >= 245000000) {
hint (_("A few projectors have problems playing back very high bit-rate DCPs. It is a good idea to drop the video bit rate down to about 200Mbit/s; this is unlikely to have any visible effect on the image."));
}
}
void
Hints::check_frame_rate ()
{
auto f = film ();
switch (f->video_frame_rate()) {
case 24:
/* Fine */
break;
case 25:
{
/* You might want to go to 24 */
string base = String::compose(_("You are set up for a DCP at a frame rate of %1 fps. This frame rate is not supported by all projectors. You may want to consider changing your frame rate to %2 fps."), 25, 24);
if (f->interop()) {
base += " ";
base += _("If you do use 25fps you should change your DCP standard to SMPTE.");
}
hint (base);
break;
}
case 30:
/* 30fps: we can't really offer any decent solutions */
hint (_("You are set up for a DCP frame rate of 30fps, which is not supported by all projectors. Be aware that you may have compatibility problems."));
break;
case 48:
case 50:
case 60:
/* You almost certainly want to go to half frame rate */
hint (String::compose(_("You are set up for a DCP at a frame rate of %1 fps. This frame rate is not supported by all projectors. It is advisable to change the DCP frame rate to %2 fps."), f->video_frame_rate(), f->video_frame_rate() / 2));
break;
}
}
void
Hints::check_4k_3d ()
{
auto f = film();
if (f->resolution() == Resolution::FOUR_K && f->three_d()) {
hint (_("4K 3D is only supported by a very limited number of projectors. Unless you know that you will play this DCP back on a capable projector, it is advisable to set the DCP to be 2K in the \"DCP→Video\" tab."));
}
}
void
Hints::check_speed_up ()
{
optional<double> lowest_speed_up;
optional<double> highest_speed_up;
for (auto i: film()->content()) {
double spu = film()->active_frame_rate_change(i->position()).speed_up;
if (!lowest_speed_up || spu < *lowest_speed_up) {
lowest_speed_up = spu;
}
if (!highest_speed_up || spu > *highest_speed_up) {
highest_speed_up = spu;
}
}
double worst_speed_up = 1;
if (highest_speed_up) {
worst_speed_up = *highest_speed_up;
}
if (lowest_speed_up) {
worst_speed_up = max (worst_speed_up, 1 / *lowest_speed_up);
}
if (worst_speed_up > 25.5/24.0) {
hint (_("There is a large difference between the frame rate of your DCP and that of some of your content. This will cause your audio to play back at a much lower or higher pitch than it should. It is advisable to set your DCP frame rate to one closer to your content, provided that your target projection systems support your chosen DCP rate."));
}
}
void
Hints::check_interop ()
{
if (film()->interop()) {
hint (_("In general it is now advisable to make SMPTE DCPs unless you have a particular reason to use Interop. It is advisable to set your DCP to use the SMPTE standard in the \"DCP\" tab."));
}
}
void
Hints::check_video_encoding()
{
if (film()->video_encoding() == VideoEncoding::MPEG2) {
hint(_("The vast majority of cinemas in Europe, Australasia and North America expect DCPs encoded with JPEG2000 rather than MPEG2. Make sure that your cinema really wants an old-style MPEG2 DCP."));
}
}
void
Hints::check_big_font_files ()
{
bool big_font_files = false;
if (film()->interop ()) {
for (auto i: film()->content()) {
for (auto j: i->text) {
for (auto k: j->fonts()) {
auto const p = k->file ();
if (p && dcp::filesystem::file_size(p.get()) >= (MAX_FONT_FILE_SIZE - SIZE_SLACK)) {
big_font_files = true;
}
}
}
}
}
if (big_font_files) {
hint (_("You have specified a font file which is larger than 640kB. This is very likely to cause problems on playback."));
}
}
void
Hints::check_vob ()
{
int vob = 0;
for (auto i: film()->content()) {
if (boost::algorithm::starts_with(i->path(0).filename().string(), "VTS_")) {
++vob;
}
}
if (vob > 1) {
hint (String::compose (_("You have %1 files that look like they are VOB files from DVD. You should join them to ensure smooth joins between the files."), vob));
}
}
void
Hints::check_3d_in_2d ()
{
int three_d = 0;
for (auto i: film()->content()) {
if (i->video && i->video->frame_type() != VideoFrameType::TWO_D) {
++three_d;
}
}
if (three_d > 0 && !film()->three_d()) {
hint (_("You are using 3D content but your DCP is set to 2D. Set the DCP to 3D if you want to play it back on a 3D system (e.g. Real-D, MasterImage etc.)"));
}
}
/** @return true if the loudness could be checked, false if it could not because no analysis was available */
bool
Hints::check_loudness ()
{
auto path = film()->audio_analysis_path(film()->playlist());
if (!dcp::filesystem::exists(path)) {
return false;
}
try {
auto an = make_shared<AudioAnalysis>(path);
string ch;
auto sample_peak = an->sample_peak ();
auto true_peak = an->true_peak ();
for (size_t i = 0; i < sample_peak.size(); ++i) {
float const peak = max (sample_peak[i].peak, true_peak.empty() ? 0 : true_peak[i]);
float const peak_dB = linear_to_db(peak) + an->gain_correction(film()->playlist());
if (peak_dB > -3) {
ch += dcp::raw_convert<string>(short_audio_channel_name(i)) + ", ";
}
}
ch = ch.substr (0, ch.length() - 2);
if (!ch.empty()) {
hint(String::compose(
_("Your audio level is very high (on %1). You should reduce the gain of your audio content."),
ch
)
);
}
} catch (OldFormatError& e) {
/* The audio analysis is too old to load in */
return false;
}
return true;
}
static
bool
subtitle_mxf_too_big(shared_ptr<dcp::TextAsset> asset)
{
return asset && asset->file() && dcp::filesystem::file_size(*asset->file()) >= (MAX_TEXT_MXF_SIZE - SIZE_SLACK);
}
void
Hints::check_out_of_range_markers ()
{
auto const length = film()->length();
for (auto const& i: film()->markers()) {
if (i.second >= length) {
hint (_("At least one marker comes after the end of the project and will be ignored."));
}
}
}
void
Hints::scan_content(shared_ptr<const Film> film)
{
auto const check_loudness_done = check_loudness();
auto content = film->playlist()->content();
auto iter = std::find_if(content.begin(), content.end(), [](shared_ptr<const Content> content) {
auto text_iter = std::find_if(content->text.begin(), content->text.end(), [](shared_ptr<const TextContent> text) {
return text->use();
});
return text_iter != content->text.end();
});
auto const have_text = iter != content.end();
if (check_loudness_done && !have_text) {
/* We don't need to check loudness, and we don't have any active text to check,
* so a scan of the content is pointless.
*/
return;
}
if (check_loudness_done && have_text) {
emit(boost::bind(boost::ref(Progress), _("Examining subtitles and closed captions")));
} else if (!check_loudness_done && !have_text) {
emit(boost::bind(boost::ref(Progress), _("Examining audio")));
} else {
emit(boost::bind(boost::ref(Progress), _("Examining audio, subtitles and closed captions")));
}
auto player = make_shared<Player>(film, Image::Alignment::COMPACT);
player->set_ignore_video();
if (check_loudness_done || _disable_audio_analysis) {
/* We don't need to analyse audio because we already loaded a suitable analysis */
player->set_ignore_audio();
} else {
/* Send auto to the analyser to check loudness */
player->Audio.connect(boost::bind(&Hints::audio, this, _1, _2));
}
player->Text.connect(boost::bind(&Hints::text, this, _1, _2, _3, _4));
struct timeval last_pulse;
gettimeofday(&last_pulse, 0);
_writer->write(player->get_subtitle_fonts());
while (!player->pass()) {
struct timeval now;
gettimeofday(&now, 0);
if ((seconds(now) - seconds(last_pulse)) > 1) {
if (_stop) {
return;
}
emit(boost::bind(boost::ref(Pulse)));
last_pulse = now;
}
}
if (!check_loudness_done) {
_analyser.finish();
_analyser.get().write(film->audio_analysis_path(film->playlist()));
check_loudness();
}
}
void
Hints::thread ()
try
{
start_of_thread ("Hints");
auto film = _film.lock ();
if (!film) {
return;
}
auto content = film->content ();
check_certificates ();
check_interop ();
check_video_encoding();
check_big_font_files ();
check_few_audio_channels ();
check_upmixers ();
check_incorrect_container ();
check_unusual_container ();
check_high_video_bit_rate();
check_frame_rate ();
check_4k_3d ();
check_speed_up ();
check_vob ();
check_3d_in_2d ();
check_ffec_and_ffmc_in_smpte_feature ();
check_out_of_range_markers ();
check_subtitle_languages();
check_audio_language ();
check_8_or_16_audio_channels();
scan_content(film);
if (_long_subtitle && !_very_long_subtitle) {
hint (_("At least one of your subtitle lines has more than 52 characters. It is recommended to make each line 52 characters at most in length."));
} else if (_very_long_subtitle) {
hint (_("At least one of your subtitle lines has more than 79 characters. You should make each line 79 characters at most in length."));
}
bool ccap_xml_too_big = false;
bool ccap_mxf_too_big = false;
bool subs_mxf_too_big = false;
auto dcp_dir = film->dir("hints") / dcpomatic::get_process_id();
dcp::filesystem::remove_all(dcp_dir);
_writer->finish();
dcp::DCP dcp (dcp_dir);
dcp.read ();
DCPOMATIC_ASSERT (dcp.cpls().size() == 1);
for (auto reel: dcp.cpls()[0]->reels()) {
for (auto ccap: reel->closed_captions()) {
if (ccap->asset() && ccap->asset()->xml_as_string().length() > static_cast<size_t>(MAX_CLOSED_CAPTION_XML_SIZE - SIZE_SLACK) && !ccap_xml_too_big) {
hint (_(
"At least one of your closed caption files' XML part is larger than " MAX_CLOSED_CAPTION_XML_SIZE_TEXT
". You should divide the DCP into shorter reels."
));
ccap_xml_too_big = true;
}
if (subtitle_mxf_too_big(ccap->asset()) && !ccap_mxf_too_big) {
hint (_(
"At least one of your closed caption files is larger than " MAX_TEXT_MXF_SIZE_TEXT
" in total. You should divide the DCP into shorter reels."
));
ccap_mxf_too_big = true;
}
}
if (reel->main_subtitle() && subtitle_mxf_too_big(reel->main_subtitle()->asset()) && !subs_mxf_too_big) {
hint (_(
"At least one of your subtitle files is larger than " MAX_TEXT_MXF_SIZE_TEXT " in total. "
"You should divide the DCP into shorter reels."
));
subs_mxf_too_big = true;
}
}
dcp::filesystem::remove_all(dcp_dir);
emit(boost::bind(boost::ref(Finished)));
}
catch (boost::thread_interrupted)
{
/* The Hints object is being destroyed before it has finished, so just give up */
}
catch (...)
{
store_current ();
}
void
Hints::hint (string h)
{
emit(boost::bind(boost::ref(Hint), h));
}
void
Hints::audio (shared_ptr<AudioBuffers> audio, DCPTime time)
{
_analyser.analyse (audio, time);
}
void
Hints::text (PlayerText text, TextType type, optional<DCPTextTrack> track, DCPTimePeriod period)
{
_writer->write (text, type, track, period);
switch (type) {
case TextType::CLOSED_CAPTION:
closed_caption (text, period);
break;
case TextType::OPEN_SUBTITLE:
open_subtitle (text, period);
break;
default:
break;
}
}
void
Hints::closed_caption (PlayerText text, DCPTimePeriod period)
{
int lines = text.string.size();
for (auto i: text.string) {
if (utf8_strlen(i.text()) > MAX_CLOSED_CAPTION_LENGTH) {
++lines;
if (!_long_ccap) {
_long_ccap = true;
hint (
String::compose(
"At least one of your closed caption lines has more than %1 characters. "
"It is advisable to make each line %1 characters at most in length.",
MAX_CLOSED_CAPTION_LENGTH,
MAX_CLOSED_CAPTION_LENGTH)
);
}
}
}
if (!_too_many_ccap_lines && lines > MAX_CLOSED_CAPTION_LINES) {
hint (String::compose(_("Some of your closed captions span more than %1 lines, so they will be truncated."), MAX_CLOSED_CAPTION_LINES));
_too_many_ccap_lines = true;
}
/* XXX: maybe overlapping closed captions (i.e. different languages) are OK with Interop? */
if (film()->interop() && !_overlap_ccap && _last_ccap && _last_ccap->overlap(period)) {
_overlap_ccap = true;
hint (_("You have overlapping closed captions, which are not allowed in Interop DCPs. Change your DCP standard to SMPTE."));
}
_last_ccap = period;
}
void
Hints::open_subtitle (PlayerText text, DCPTimePeriod period)
{
if (period.from < DCPTime::from_seconds(4) && !_early_subtitle) {
_early_subtitle = true;
hint (_("It is advisable to put your first subtitle at least 4 seconds after the start of the DCP to make sure it is seen."));
}
int const vfr = film()->video_frame_rate ();
if (period.duration().frames_round(vfr) < 15 && !_short_subtitle) {
_short_subtitle = true;
hint (_("At least one of your subtitles lasts less than 15 frames. It is advisable to make each subtitle at least 15 frames long."));
}
if (_last_subtitle && DCPTime(period.from - _last_subtitle->to).frames_round(vfr) < 2 && !_subtitles_too_close) {
_subtitles_too_close = true;
hint (_("At least one of your subtitles starts less than 2 frames after the previous one. It is advisable to make the gap between subtitles at least 2 frames."));
}
struct VPos
{
public:
dcp::VAlign align;
float position;
bool operator<(VPos const& other) const {
if (static_cast<int>(align) != static_cast<int>(other.align)) {
return static_cast<int>(align) < static_cast<int>(other.align);
}
return position < other.position;
}
};
/* This is rather an approximate way to count distinct lines, but I guess it will do;
* to make it better we need to take into account font metrics, and the SMPTE alignment
* debacle, and so on.
*/
std::set<VPos> lines;
for (auto const& line: text.string) {
lines.insert({ line.v_align(), line.v_position() });
}
if (lines.size() > 3 && !_too_many_subtitle_lines) {
_too_many_subtitle_lines = true;
hint (_("At least one of your subtitles has more than 3 lines. It is advisable to use no more than 3 lines."));
}
size_t longest_line = 0;
for (auto const& i: text.string) {
longest_line = max (longest_line, i.text().length());
}
if (longest_line > 52) {
_long_subtitle = true;
}
if (longest_line > 79) {
_very_long_subtitle = true;
}
_last_subtitle = period;
}
void
Hints::check_ffec_and_ffmc_in_smpte_feature ()
{
auto f = film();
if (!f->interop() && f->dcp_content_type()->libdcp_kind() == dcp::ContentKind::FEATURE && (!f->marker(dcp::Marker::FFEC) || !f->marker(dcp::Marker::FFMC))) {
hint (_("SMPTE DCPs with the type FTR (feature) should have markers for the first frame of end credits (FFEC) and the first frame of moving credits (FFMC). You should add these markers using the 'Markers' button in the \"DCP\" tab."));
}
}
void
Hints::join ()
{
_thread.join ();
}
void
Hints::check_subtitle_languages()
{
for (auto i: film()->content()) {
for (auto j: i->text) {
if (j->use() && j->type() == TextType::OPEN_SUBTITLE && !j->language()) {
hint (_("At least one piece of subtitle content has no specified language. "
"It is advisable to set the language for each piece of subtitle content "
"in the \"Content→Timed text\" or \"Content→Open subtitles\" tab."));
return;
}
}
}
}
void
Hints::check_audio_language ()
{
auto content = film()->content();
auto mapped_audio =
std::find_if(content.begin(), content.end(), [](shared_ptr<const Content> c) {
return c->has_mapped_audio();
});
if (mapped_audio != content.end() && !film()->audio_language()) {
hint (_("Some of your content has audio but you have not set the audio language. It is advisable to set the audio language "
"in the \"DCP\" tab unless your audio has no spoken parts."));
}
}
void
Hints::check_certificates ()
{
auto bad = Config::instance()->check_certificates();
if (!bad) {
return;
}
switch (*bad) {
case Config::BAD_SIGNER_UTF8_STRINGS:
hint(variant::insert_dcpomatic(
_("The certificate chain that %1 uses for signing DCPs and KDMs contains a small error "
"which will prevent DCPs from being validated correctly on some systems. It is advisable to "
"re-create the signing certificate chain by clicking the \"Re-make certificates and key...\" "
"button in the Keys page of Preferences.")
));
break;
case Config::BAD_SIGNER_VALIDITY_TOO_LONG:
hint(variant::insert_dcpomatic(
_("The certificate chain that %1 uses for signing DCPs and KDMs has a validity period "
"that is too long. This will cause problems playing back DCPs on some systems. "
"It is advisable to re-create the signing certificate chain by clicking the "
"\"Re-make certificates and key...\" button in the Keys page of Preferences.")
));
break;
default:
/* Some bad situations can't happen here as DCP-o-matic would have refused to start until they are fixed */
break;
}
}
void
Hints::check_8_or_16_audio_channels()
{
auto const channels = film()->audio_channels();
if (film()->video_encoding() != VideoEncoding::MPEG2 && channels != 8 && channels != 16) {
hint(String::compose(_("Your DCP has %1 audio channels, rather than 8 or 16. This may cause some distributors to raise QC errors when they check your DCP. To avoid this, set the DCP audio channels to 8 or 16."), channels));
}
}
|