summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2026-03-29 23:22:53 +0200
committerCarl Hetherington <cth@carlh.net>2026-04-01 23:43:00 +0200
commitced73c6557bd6ff56ef0317491653fbd33858cbb (patch)
tree9364dea28b45e0c97516bd9027e1ff884695fc51
parent60827711476f31920a1c8d7045907512abe2085d (diff)
UNSIGNED_PKL_WITH_ENCRYPTED_CONTENT: note -> pkl_id.
-rw-r--r--src/verify.cc4
-rw-r--r--src/verify.h2
-rw-r--r--test/verify_test.cc2
3 files changed, 4 insertions, 4 deletions
diff --git a/src/verify.cc b/src/verify.cc
index 95a63df5..e3113280 100644
--- a/src/verify.cc
+++ b/src/verify.cc
@@ -1812,7 +1812,7 @@ verify_pkl(Context& context, shared_ptr<const PKL> pkl)
cxml::Document doc("PackingList");
doc.read_file(dcp::filesystem::fix_long_path(pkl->file().get()));
if (!doc.optional_node_child("Signature")) {
- context.add_note(VerificationNote::Code::UNSIGNED_PKL_WITH_ENCRYPTED_CONTENT, pkl->id(), pkl->file().get());
+ context.add_note(VerificationNote(VerificationNote::Code::UNSIGNED_PKL_WITH_ENCRYPTED_CONTENT, pkl->file().get()).set_pkl_id(pkl->id()));
}
}
@@ -2106,7 +2106,7 @@ dcp::note_to_string(VerificationNote note, function<string (string)> process_str
case VerificationNote::Code::UNSIGNED_CPL_WITH_ENCRYPTED_CONTENT:
return compose("The CPL %1, which has encrypted content, is not signed.", note.cpl_id().get());
case VerificationNote::Code::UNSIGNED_PKL_WITH_ENCRYPTED_CONTENT:
- return compose("The PKL %1, which has encrypted content, is not signed.", note.note().get());
+ return compose("The PKL %1, which has encrypted content, is not signed.", *note.pkl_id());
case VerificationNote::Code::MISMATCHED_PKL_ANNOTATION_TEXT_WITH_CPL:
return compose("The PKL %1 has only one CPL but its <AnnotationText> does not match the CPL's <ContentTitleText>.", note.note().get());
case VerificationNote::Code::MATCHING_PKL_ANNOTATION_TEXT_WITH_CPL:
diff --git a/src/verify.h b/src/verify.h
index f901feb0..793adf7f 100644
--- a/src/verify.h
+++ b/src/verify.h
@@ -382,7 +382,7 @@ public:
*/
UNSIGNED_CPL_WITH_ENCRYPTED_CONTENT,
/** A PKL containing encrypted content is not signed [Bv2.1_8.7]
- * note contains the PKL ID
+ * pkl_id contains the PKL ID
* file contains the PKL filename
*/
UNSIGNED_PKL_WITH_ENCRYPTED_CONTENT,
diff --git a/test/verify_test.cc b/test/verify_test.cc
index bdb8041c..defd06e2 100644
--- a/test/verify_test.cc
+++ b/test/verify_test.cc
@@ -4691,7 +4691,7 @@ BOOST_AUTO_TEST_CASE (verify_unsigned_pkl_with_encrypted_content)
VN(VC::MISSING_FFOC).set_cpl_id(cpl->id()),
VN(VC::MISSING_LFOC).set_cpl_id(cpl->id()),
VN(VC::MISSING_CPL_METADATA, canonical(cpl_path)).set_cpl_id(cpl->id()),
- VN(VC::UNSIGNED_PKL_WITH_ENCRYPTED_CONTENT, encryption_test_pkl_id(), canonical(pkl))
+ VN(VC::UNSIGNED_PKL_WITH_ENCRYPTED_CONTENT, canonical(pkl)).set_pkl_id(encryption_test_pkl_id()),
});
}