summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2026-03-29 17:18:08 +0200
committerCarl Hetherington <cth@carlh.net>2026-04-01 23:43:00 +0200
commit2835cd88ff5ddd9dc5ad4bf7e5eaefe7cc4b6a99 (patch)
tree14c6fe38aa00f90bf85ac484499cd76be95d12be /src
parent81215b312016ef1e947e92675bea176be05f168d (diff)
{MISSING,INCORRECT}_{SUBTITLE,CLOSED_CAPTION}_ENTRY_POINT: note -> asset_id.
Diffstat (limited to 'src')
-rw-r--r--src/verify.cc16
-rw-r--r--src/verify.h8
2 files changed, 12 insertions, 12 deletions
diff --git a/src/verify.cc b/src/verify.cc
index d4cd4b3f..2d3031d5 100644
--- a/src/verify.cc
+++ b/src/verify.cc
@@ -669,9 +669,9 @@ verify_main_subtitle_reel(Context& context, shared_ptr<const ReelTextAsset> reel
}
if (!reel_asset->entry_point()) {
- context.add_note(VerificationNote::Code::MISSING_SUBTITLE_ENTRY_POINT, reel_asset->id());
+ context.add_note(VerificationNote(VerificationNote::Code::MISSING_SUBTITLE_ENTRY_POINT).set_asset_id(reel_asset->id()));
} else if (reel_asset->entry_point().get()) {
- context.add_note(VerificationNote::Code::INCORRECT_SUBTITLE_ENTRY_POINT, reel_asset->id());
+ context.add_note(VerificationNote(VerificationNote::Code::INCORRECT_SUBTITLE_ENTRY_POINT).set_asset_id(reel_asset->id()));
}
}
@@ -685,9 +685,9 @@ verify_closed_caption_reel(Context& context, shared_ptr<const ReelTextAsset> ree
}
if (!reel_asset->entry_point()) {
- context.add_note(VerificationNote::Code::MISSING_CLOSED_CAPTION_ENTRY_POINT, reel_asset->id());
+ context.add_note(VerificationNote(VerificationNote::Code::MISSING_CLOSED_CAPTION_ENTRY_POINT).set_asset_id(reel_asset->id()));
} else if (reel_asset->entry_point().get()) {
- context.add_note(VerificationNote::Code::INCORRECT_CLOSED_CAPTION_ENTRY_POINT, reel_asset->id());
+ context.add_note(VerificationNote(VerificationNote::Code::INCORRECT_CLOSED_CAPTION_ENTRY_POINT).set_asset_id(reel_asset->id()));
}
}
@@ -2074,13 +2074,13 @@ dcp::note_to_string(VerificationNote note, function<string (string)> process_str
case VerificationNote::Code::MISMATCHED_CLOSED_CAPTION_ASSET_COUNTS:
return process_string("At least one reel has closed captions, but reels have different numbers of closed caption assets.");
case VerificationNote::Code::MISSING_SUBTITLE_ENTRY_POINT:
- return compose("The subtitle asset %1 has no <EntryPoint> tag.", note.note().get());
+ return compose("The subtitle asset %1 has no <EntryPoint> tag.", *note.asset_id());
case VerificationNote::Code::INCORRECT_SUBTITLE_ENTRY_POINT:
- return compose("The subtitle asset %1 has an <EntryPoint> other than 0.", note.note().get());
+ return compose("The subtitle asset %1 has an <EntryPoint> other than 0.", *note.asset_id());
case VerificationNote::Code::MISSING_CLOSED_CAPTION_ENTRY_POINT:
- return compose("The closed caption asset %1 has no <EntryPoint> tag.", note.note().get());
+ return compose("The closed caption asset %1 has no <EntryPoint> tag.", *note.asset_id());
case VerificationNote::Code::INCORRECT_CLOSED_CAPTION_ENTRY_POINT:
- return compose("The closed caption asset %1 has an <EntryPoint> other than 0.", note.note().get());
+ return compose("The closed caption asset %1 has an <EntryPoint> other than 0.", *note.asset_id());
case VerificationNote::Code::MISSING_HASH:
return compose("The asset %1 has no <Hash> tag in the CPL.", note.note().get());
case VerificationNote::Code::MISSING_FFEC_IN_FEATURE:
diff --git a/src/verify.h b/src/verify.h
index 334cea5c..ba726349 100644
--- a/src/verify.h
+++ b/src/verify.h
@@ -320,19 +320,19 @@ public:
/** If one reel has at least one _ClosedCaption_, all reels must have the same number of _ClosedCaptions_ */
MISMATCHED_CLOSED_CAPTION_ASSET_COUNTS,
/** MainSubtitle in reels must have _<EntryPoint>_ [Bv2.1_8.3.2]
- * note contains the asset ID
+ * asset_id contains the asset ID
*/
MISSING_SUBTITLE_ENTRY_POINT,
/** MainSubtitle _<EntryPoint>_ must be zero [Bv2.1_8.3.2]
- * note contains the asset ID
+ * asset_id contains the asset ID
*/
INCORRECT_SUBTITLE_ENTRY_POINT,
/** Closed caption in reels must have _<EntryPoint>_ [Bv2.1_8.3.2]
- * note contains the asset ID
+ * asset_id contains the asset ID
*/
MISSING_CLOSED_CAPTION_ENTRY_POINT,
/** Closed caption _MainSubtitle_ _<EntryPoint>_ must be zero [Bv2.1_8.3.2]
- * note contains the asset ID
+ * asset_id contains the asset ID
*/
INCORRECT_CLOSED_CAPTION_ENTRY_POINT,
/** _<Hash>_ must be present for assets in CPLs