summaryrefslogtreecommitdiff
path: root/src/stl_binary_reader.cc
diff options
context:
space:
mode:
authorCarl Hetherington <cth@carlh.net>2020-04-01 13:23:32 +0000
committerCarl Hetherington <cth@carlh.net>2020-04-01 15:28:38 +0200
commit877f212035be55e8103a0dcaf572d93337122712 (patch)
treeea6acf4c167b87f2dfc0ef0ac656f52d7a845886 /src/stl_binary_reader.cc
parentae38783104589bea24836ee9455378b1f2244796 (diff)
Remove confusing use of repeated loop counters.
Diffstat (limited to 'src/stl_binary_reader.cc')
-rw-r--r--src/stl_binary_reader.cc12
1 files changed, 6 insertions, 6 deletions
diff --git a/src/stl_binary_reader.cc b/src/stl_binary_reader.cc
index e8e8832..467830c 100644
--- a/src/stl_binary_reader.cc
+++ b/src/stl_binary_reader.cc
@@ -207,14 +207,14 @@ void STLBinaryReader::read (shared_ptr<InputReader> reader)
bool italic = false;
bool underline = false;
- for (size_t i = 0; i < lines.size(); ++i) {
+ for (size_t j = 0; j < lines.size(); ++j) {
RawSubtitle sub;
sub.from = reader->get_timecode(5, frame_rate);
sub.to = reader->get_timecode(9, frame_rate);
- /* XXX: only the verticial position of the first TTI block should be used (says the spec),
+ /* XXX: only the vertical position of the first TTI block should be used (says the spec),
so using reader->get_int(13, 1) here is wrong if i > 0
*/
- sub.vertical_position.line = reader->get_int(13, 1) + i;
+ sub.vertical_position.line = reader->get_int(13, 1) + j;
sub.vertical_position.lines = maximum_rows;
sub.vertical_position.reference = TOP_OF_SCREEN;
sub.italic = italic;
@@ -237,9 +237,9 @@ void STLBinaryReader::read (shared_ptr<InputReader> reader)
/* Loop over characters */
string text;
- for (size_t j = 0; j < lines[i].size(); ++j) {
+ for (size_t k = 0; k < lines[j].size(); ++k) {
- unsigned char const c = static_cast<unsigned char> (lines[i][j]);
+ unsigned char const c = static_cast<unsigned char> (lines[j][k]);
if (c == 0x8f) {
/* Unused space i.e. end of line */
@@ -267,7 +267,7 @@ void STLBinaryReader::read (shared_ptr<InputReader> reader)
underline = false;
break;
default:
- text += lines[i][j];
+ text += lines[j][k];
break;
}