diff options
| author | Max Moroz <dor3s1@gmail.com> | 2020-01-13 09:07:54 -0800 |
|---|---|---|
| committer | Even Rouault <even.rouault@spatialys.com> | 2020-01-13 18:07:54 +0100 |
| commit | b63a433ba168bad5fa10e83de04d6305e6a222e2 (patch) | |
| tree | 92643ba25dd5f32412c011770c727a4aeeab57ca /tests | |
| parent | 46c1eff9e98bbcf794d042f7b2e3d45556e805ce (diff) | |
tests/fuzzers: link fuzz binaries using $LIB_FUZZING_ENGINE. (#1230)
This was changed some time ago (https://google.github.io/oss-fuzz/getting-started/new-project-guide/) but the build didn't fail as there is a fallback mechanism. The main advantage of the new approach is that for libFuzzer this produces more performant binaries (as `$LIB_FUZZING_ENGINE` expands into `-fsanitize=fuzzer`, which links libFuzzer from the compiler-rt, allowing better optimization tricks).
I'm also experimenting with dataflow (https://github.com/google/oss-fuzz/issues/1632) on your project, and the dataflow config doesn't have a fallback (as it's a new configuration), therefore I'm proposing a change to migrate from `-lFuzzingEngine` to `$LIB_FUZZING_ENGINE`.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/fuzzers/GNUmakefile | 3 | ||||
| -rwxr-xr-x | tests/fuzzers/build_google_oss_fuzzers.sh | 2 |
2 files changed, 3 insertions, 2 deletions
diff --git a/tests/fuzzers/GNUmakefile b/tests/fuzzers/GNUmakefile index 0384d1a9..39e1cd40 100644 --- a/tests/fuzzers/GNUmakefile +++ b/tests/fuzzers/GNUmakefile @@ -8,5 +8,6 @@ fuzzingengine.o: fuzzingengine.c dummyfuzzers: fuzzingengine.o $(AR) r libFuzzingEngine.a fuzzingengine.o - CXX="${CXX}" CXXFLAGS="-L. ${CXXFLAGS}" SRC=/tmp OUT=/tmp ./build_google_oss_fuzzers.sh + LIB_FUZZING_ENGINE="-lFuzzingEngine" CXX="${CXX}" CXXFLAGS="-L. ${CXXFLAGS}" \ + SRC=/tmp OUT=/tmp ./build_google_oss_fuzzers.sh OUT=/tmp ./build_seed_corpus.sh diff --git a/tests/fuzzers/build_google_oss_fuzzers.sh b/tests/fuzzers/build_google_oss_fuzzers.sh index 88bda556..d99f639f 100755 --- a/tests/fuzzers/build_google_oss_fuzzers.sh +++ b/tests/fuzzers/build_google_oss_fuzzers.sh @@ -28,7 +28,7 @@ build_fuzzer() echo "Building fuzzer $fuzzerName" $CXX $CXXFLAGS -std=c++11 -I$SRC_DIR/src/lib/openjp2 -I$SRC_DIR/build/src/lib/openjp2 \ $sourceFilename $* -o $OUT/$fuzzerName \ - -lFuzzingEngine $SRC_DIR/build/bin/libopenjp2.a -lm -lpthread + $LIB_FUZZING_ENGINE $SRC_DIR/build/bin/libopenjp2.a -lm -lpthread } fuzzerFiles=$(dirname $0)/*.cpp |