Carl Hetherington [Thu, 21 Apr 2022 21:19:27 +0000 (23:19 +0200)]
Revert "Adjust handling of -Wsuggest-override"
This reverts commit
e7e4af869f7144fa9a265ccf1e15c7b2f182ac2c.
I misunderstood what was going on, and we were just missing some
DCPOMATIC_{DIS,EN}ABLE_WARNINGS calls.
Carl Hetherington [Thu, 21 Apr 2022 19:35:10 +0000 (21:35 +0200)]
Disable warnings around all wx includes.
Carl Hetherington [Thu, 21 Apr 2022 19:34:50 +0000 (21:34 +0200)]
Tidying.
Carl Hetherington [Thu, 21 Apr 2022 12:22:08 +0000 (14:22 +0200)]
Adjust handling of -Wsuggest-override
It seems that on older GCCs (e.g. the one from Ubuntu 18.04) the
pragma to temporarily turn off this warning does not work, so here
we only use it on newer GCCs where we can turn it off for libraries
that trigger the warning (mostly asdcplib, but also wxWidgets).
Carl Hetherington [Thu, 21 Apr 2022 09:38:15 +0000 (11:38 +0200)]
Revert "Try to fix some warnings when libdcp include asdcplib."
This reverts commit
0582196d78d27c349e5be8f87186499acb4b322f.
Carl Hetherington [Wed, 20 Apr 2022 22:25:29 +0000 (00:25 +0200)]
Try to fix some warnings when libdcp include asdcplib.
Carl Hetherington [Sun, 17 Apr 2022 20:25:50 +0000 (22:25 +0200)]
Lookup the correct DCNC code to use for languages rather than just
using the language's subtag (#2235).
Carl Hetherington [Tue, 19 Apr 2022 12:03:20 +0000 (14:03 +0200)]
Use std::vector in AudioBuffers (#2236).
Carl Hetherington [Tue, 19 Apr 2022 11:09:49 +0000 (13:09 +0200)]
Cleanup: improve some variable names.
Carl Hetherington [Tue, 19 Apr 2022 10:56:10 +0000 (12:56 +0200)]
Add ScopeGuard.
Carl Hetherington [Mon, 18 Apr 2022 20:40:22 +0000 (22:40 +0200)]
Add button to use same fades for audio as video (#2230).
Carl Hetherington [Mon, 18 Apr 2022 19:05:41 +0000 (21:05 +0200)]
Tidying.
Carl Hetherington [Sat, 16 Apr 2022 21:57:19 +0000 (23:57 +0200)]
Replace encrypted content with black if we have no key (#2234).
Carl Hetherington [Sat, 16 Apr 2022 21:56:06 +0000 (23:56 +0200)]
C++11 tidying.
Carl Hetherington [Mon, 3 Jan 2022 00:11:16 +0000 (00:11 +0000)]
Fix creation of dcpdig files in projects that make VFs (#2109).
Previously we would always get keys from the project which was
wrong with assets that already have their own key.
Carl Hetherington [Wed, 3 Nov 2021 17:19:58 +0000 (18:19 +0100)]
Support DCP digest files (#2109).
Carl Hetherington [Wed, 20 Apr 2022 19:17:54 +0000 (21:17 +0200)]
Remove DCP class and replace its functionality with a plain method in libdcp.
Carl Hetherington [Wed, 20 Apr 2022 19:17:14 +0000 (21:17 +0200)]
Tidying.
Carl Hetherington [Tue, 28 Dec 2021 23:54:19 +0000 (00:54 +0100)]
Clean up a hack by adding DCPTranscodeJob.
Carl Hetherington [Sat, 18 Dec 2021 13:23:50 +0000 (14:23 +0100)]
Move make_dcp() out of Film (#2132).
Carl Hetherington [Sun, 17 Apr 2022 20:07:25 +0000 (22:07 +0200)]
Add more missing override labels.
Carl Hetherington [Sun, 17 Apr 2022 19:52:04 +0000 (21:52 +0200)]
Bump libsub for override warning fix.
Carl Hetherington [Sun, 17 Apr 2022 19:09:15 +0000 (21:09 +0200)]
Add deps for Ubuntu 22.04.
Carl Hetherington [Sun, 17 Apr 2022 18:53:40 +0000 (20:53 +0200)]
Missing override label.
Carl Hetherington [Sun, 17 Apr 2022 17:08:07 +0000 (19:08 +0200)]
Remove some commented-out code.
Carl Hetherington [Sat, 9 Apr 2022 11:58:49 +0000 (13:58 +0200)]
C++11 tidying.
Carl Hetherington [Sat, 9 Apr 2022 11:58:41 +0000 (13:58 +0200)]
Warn about missing override labels.
Carl Hetherington [Sat, 9 Apr 2022 11:58:27 +0000 (13:58 +0200)]
Add some missing override labels.
Carl Hetherington [Fri, 8 Apr 2022 23:24:48 +0000 (01:24 +0200)]
Fix some comment typos.
Carl Hetherington [Fri, 8 Apr 2022 17:58:50 +0000 (19:58 +0200)]
Update supporters list.
Carl Hetherington [Fri, 8 Apr 2022 15:04:39 +0000 (17:04 +0200)]
More missing override labels.
Carl Hetherington [Fri, 8 Apr 2022 12:29:01 +0000 (14:29 +0200)]
More missing override labels.
Carl Hetherington [Fri, 8 Apr 2022 12:08:27 +0000 (14:08 +0200)]
Another missing override label.
Carl Hetherington [Thu, 7 Apr 2022 23:03:50 +0000 (01:03 +0200)]
Add some missing override labels.
Carl Hetherington [Thu, 7 Apr 2022 22:43:28 +0000 (00:43 +0200)]
Guess video range better when importing 2.14.x projects (#2227).
Carl Hetherington [Thu, 7 Apr 2022 21:51:19 +0000 (23:51 +0200)]
Cleanup: tidying.
Carl Hetherington [Thu, 7 Apr 2022 21:50:41 +0000 (23:50 +0200)]
Remove erroneous comment.
Carl Hetherington [Sun, 3 Apr 2022 22:42:57 +0000 (00:42 +0200)]
Cleanup: remove unused parameter to PlayerVideo::force.
Carl Hetherington [Sun, 3 Apr 2022 22:24:26 +0000 (00:24 +0200)]
Cleanup: use a vector instead of a raw array.
Carl Hetherington [Tue, 5 Apr 2022 17:07:26 +0000 (19:07 +0200)]
Another missing #include.
Carl Hetherington [Tue, 5 Apr 2022 09:37:20 +0000 (11:37 +0200)]
Missing #include.
Carl Hetherington [Sun, 23 Jan 2022 21:21:29 +0000 (22:21 +0100)]
Add fade in/out option to the content audio tab (#1026).
Carl Hetherington [Mon, 24 Jan 2022 21:30:52 +0000 (22:30 +0100)]
Cleanup: move some methods from util to memory_util.
Carl Hetherington [Mon, 4 Apr 2022 20:37:31 +0000 (22:37 +0200)]
Cleanup: move some methods from util to maths_util.
Carl Hetherington [Mon, 24 Jan 2022 21:30:20 +0000 (22:30 +0100)]
Cleanup: move stride_round_up into the only place it is used.
Carl Hetherington [Sat, 2 Apr 2022 22:04:31 +0000 (00:04 +0200)]
C++11 and whitespace cleanups.
Carl Hetherington [Fri, 1 Apr 2022 22:03:12 +0000 (00:03 +0200)]
Add button to send test emails in the mail server prefs (#2216).
Carl Hetherington [Wed, 30 Mar 2022 20:59:05 +0000 (22:59 +0200)]
Fix writing of planar audio to export buffers in some cases (#2223).
Previously we did not take into account alignment padding that can
exist with FLTP samples; each channel's block of samples can have
a gap between. This doesn't happen with the normal 1024 sample blocks;
only when flushing at the end, when we write shorter blocks.
Not doing this right meant that we were passing uninitialised memory
to aacenc which sometimes responded by returning an EINVAL due to one
of its internal calculations returning a NaN.
Carl Hetherington [Wed, 30 Mar 2022 17:56:19 +0000 (19:56 +0200)]
Tweak --export-filename help.
Carl Hetherington [Sun, 27 Mar 2022 21:39:21 +0000 (23:39 +0200)]
Remove strange proportion values when adding content buttons.
These seemed to cause the buttons to appear in strange places in some
cases.
Carl Hetherington [Fri, 25 Mar 2022 18:28:40 +0000 (19:28 +0100)]
Supporters update.
Carl Hetherington [Thu, 24 Mar 2022 12:34:08 +0000 (13:34 +0100)]
Bump libdcp for fix to remove erroneous <EntryPoint> and <Duration> markers from <MainMarkers> (#2215).
Carl Hetherington [Wed, 23 Mar 2022 23:01:33 +0000 (00:01 +0100)]
Don't throw an exception part-way through resolving assets (#2221).
This was applied to libdcp master in
81c6fcba2. It seems wrong
to give up in the middle of resolving things, as it might not
work if things happen to be in the wrong order.
Carl Hetherington [Mon, 21 Mar 2022 07:05:33 +0000 (08:05 +0100)]
Fix build error on mac.
Carl Hetherington [Sun, 20 Mar 2022 23:54:18 +0000 (00:54 +0100)]
Add check/uncheck all buttons to screens panel.
Carl Hetherington [Sun, 20 Mar 2022 22:53:09 +0000 (23:53 +0100)]
Update test reference for config change.
Carl Hetherington [Sun, 20 Mar 2022 20:47:09 +0000 (21:47 +0100)]
Remove unnecessary heading in email address list in cinema dialogue.
Carl Hetherington [Tue, 15 Mar 2022 14:37:23 +0000 (15:37 +0100)]
Bump libdcp for fix to subtitle formatting (#2205).
Carl Hetherington [Sat, 19 Mar 2022 21:34:00 +0000 (22:34 +0100)]
Add config option for default KDM type.
Carl Hetherington [Sat, 19 Mar 2022 19:30:20 +0000 (20:30 +0100)]
Make a small class to choose KDM types.
Carl Hetherington [Sat, 19 Mar 2022 19:08:06 +0000 (20:08 +0100)]
Remove KDM type that was added for testing.
Carl Hetherington [Sat, 19 Mar 2022 18:43:31 +0000 (19:43 +0100)]
Add $CINEMA_SHORT_NAME variable in KDM emails.
Carl Hetherington [Sat, 19 Mar 2022 18:34:22 +0000 (19:34 +0100)]
Cleanup: remove some duplicated code.
Carl Hetherington [Sat, 19 Mar 2022 18:23:07 +0000 (19:23 +0100)]
We can (and should) get the screens straight from _checked_screens now.
Carl Hetherington [Sat, 19 Mar 2022 18:21:19 +0000 (19:21 +0100)]
Now we don't need _cinemas and _screens any more.
Carl Hetherington [Sat, 19 Mar 2022 18:11:35 +0000 (19:11 +0100)]
Fix _selected_* to only store pointers to things.
The wxWidgets item IDs can easily become outdated (when a search
is done).
Carl Hetherington [Fri, 18 Mar 2022 22:52:58 +0000 (23:52 +0100)]
Speed things up by sorting before adding cinemas.
Carl Hetherington [Fri, 18 Mar 2022 21:50:12 +0000 (22:50 +0100)]
Preserve checked status during search (#2212).
Carl Hetherington [Fri, 18 Mar 2022 21:49:29 +0000 (22:49 +0100)]
Add an initialisation in the class.
Carl Hetherington [Fri, 18 Mar 2022 00:10:24 +0000 (01:10 +0100)]
Also keep maps the other way around.
Carl Hetherington [Thu, 17 Mar 2022 23:57:42 +0000 (00:57 +0100)]
Keep maps of wxTreeListItem to Cinema/Screen.
Carl Hetherington [Thu, 17 Mar 2022 20:45:46 +0000 (21:45 +0100)]
Fix writing KDMs with long filenames.
Carl Hetherington [Wed, 16 Mar 2022 21:10:55 +0000 (22:10 +0100)]
Use the ICU library to sort cinemas rather than strcoll() (part of #2208).
strcoll() just doesn't really seem to work at all on Windows.
Carl Hetherington [Fri, 11 Mar 2022 22:35:43 +0000 (23:35 +0100)]
Encode UTF-8 subjects and attachment names properly (#2207).
Carl Hetherington [Fri, 11 Mar 2022 22:35:08 +0000 (23:35 +0100)]
Slightly improve behaviour under low memory conditions.
Carl Hetherington [Fri, 11 Mar 2022 22:34:00 +0000 (23:34 +0100)]
Use a vector<pair<...>> to store screens and cinemas instead of a map.
In this way, ordering will be preserved (part of #2208).
Carl Hetherington [Sun, 13 Mar 2022 20:10:36 +0000 (21:10 +0100)]
Replace class shim with a custom comparator.
Carl Hetherington [Sun, 13 Mar 2022 20:04:02 +0000 (21:04 +0100)]
Fix weird placement of SetSortColumn() call causing strange assertion failure in wxWidgets.
Carl Hetherington [Fri, 11 Mar 2022 21:41:36 +0000 (22:41 +0100)]
Cleanup: use some better variable names.
Carl Hetherington [Thu, 10 Mar 2022 22:00:43 +0000 (23:00 +0100)]
Make the value used for 'f' in KDM names consistent (#1657).
Before it was mostly the film name, but this is confusing when a
single film contains multiple CPLs.
Carl Hetherington [Sat, 5 Mar 2022 10:15:59 +0000 (11:15 +0100)]
Cleanup: tidying.
Carl Hetherington [Mon, 14 Mar 2022 21:16:52 +0000 (22:16 +0100)]
Fix tests for newly-saved write to/email checkboxes.
Carl Hetherington [Mon, 14 Mar 2022 19:29:44 +0000 (20:29 +0100)]
Fix incorrectly-timed emission of silence padding causing buffer fill (#2217).
On initialisation or after seek we insert silence corresponding to
a positive delay in an audio stream. Previously this inserted silence
was done at time 0, so that after a seek to time T the silent frames
would come out of the audio merger at time 0 and then the player would
fill the space up to time T with silence. If T was far enough along
this would fill the audio buffers without there being any video.
Carl Hetherington [Mon, 14 Mar 2022 19:24:13 +0000 (20:24 +0100)]
C++11 tidying.
Carl Hetherington [Mon, 14 Mar 2022 19:23:47 +0000 (20:23 +0100)]
Cleanup: tidy some comments.
Carl Hetherington [Sun, 13 Mar 2022 23:09:09 +0000 (00:09 +0100)]
Remember the state of the write to/email checkboxes in the KDM creator across runs (#2213).
Carl Hetherington [Sun, 13 Mar 2022 22:53:13 +0000 (23:53 +0100)]
C++11 tidying.
Carl Hetherington [Sun, 13 Mar 2022 22:52:49 +0000 (23:52 +0100)]
Tidying.
Carl Hetherington [Sun, 13 Mar 2022 14:49:06 +0000 (15:49 +0100)]
Fix sensitivity of custom scaled edit button.
Carl Hetherington [Fri, 11 Mar 2022 20:00:32 +0000 (21:00 +0100)]
Allow editing of a screen's cinema / adding a new screen when
a screen is selected (#2210).
Carl Hetherington [Thu, 10 Mar 2022 07:04:48 +0000 (08:04 +0100)]
Fix build with the macOS 10.8 version of wxWidgets.
Carl Hetherington [Wed, 2 Mar 2022 21:10:41 +0000 (22:10 +0100)]
Fix incorrect quoting in helper script.
Carl Hetherington [Tue, 1 Mar 2022 21:41:56 +0000 (22:41 +0100)]
Improve ratings dialog to allow only valid values (#2199).
Carl Hetherington [Tue, 1 Mar 2022 23:09:58 +0000 (00:09 +0100)]
Allow passing flags into TableDialog::add for labels.
Carl Hetherington [Tue, 1 Mar 2022 21:40:57 +0000 (22:40 +0100)]
Add search_ctrl_height()
Carl Hetherington [Tue, 1 Mar 2022 21:40:47 +0000 (22:40 +0100)]
C++11 cleanup.
Carl Hetherington [Sun, 27 Feb 2022 22:45:46 +0000 (23:45 +0100)]
Don't write a <ContentVersion> tag with an empty <LabelText> (#2191).
I can't see the problem with this, but apparently Dolby
CineInspect complains about it.
We could fix this in libdcp but I think that would make more sense
if this were related to a definite standard violation, instead of
just some tinkering to hide a possibly-incorrect warning.
Carl Hetherington [Thu, 17 Feb 2022 20:46:41 +0000 (21:46 +0100)]
Use some decimal places when reporting transcode speed in the log.
Carl Hetherington [Sun, 13 Feb 2022 19:15:58 +0000 (20:15 +0100)]
Mark full debian package as replacing the CLI one (#2179).
Carl Hetherington [Fri, 28 Jan 2022 19:37:02 +0000 (20:37 +0100)]
Bail out early when there's a reason why the KDM is invalid.