Paul Davis [Fri, 26 Sep 2014 19:38:48 +0000 (15:38 -0400)]
next (final?) part of handling missing MIDI files.
If an external-to-session file is missing, consider it a fatal error in session
loading.
If an internal-to-session file is missing, just create a new MIDI source with
the same path and ID, and use that instead.
Paul Davis [Wed, 24 Sep 2014 23:03:59 +0000 (19:03 -0400)]
next (final?) part of handling missing MIDI files.
If an external-to-session file is missing, consider it a fatal error in session loading.
If an internal-to-session file is missing, just create a new MIDI source with the same path and ID, and use that instead.
Paul Davis [Mon, 15 Sep 2014 23:53:10 +0000 (19:53 -0400)]
fix API errors after cherry-picking empty MIDI file fixes from cairocanvas
Paul Davis [Mon, 15 Sep 2014 18:09:01 +0000 (14:09 -0400)]
if a (file) source really cannot be found, differentiate between audio & MIDI.
For now, recovering from missing MIDI is a no-can-do situation (because MIDI is inherently data-editable).
Paul Davis [Mon, 15 Sep 2014 16:38:54 +0000 (12:38 -0400)]
fix up condition where a MIDI filesource is marked empty, not found, and its _path member is not set correctly
Paul Davis [Mon, 15 Sep 2014 16:38:16 +0000 (12:38 -0400)]
FileSource should not generate its own error message when a file is missing
Conflicts:
libs/ardour/file_source.cc
Paul Davis [Thu, 28 Aug 2014 18:01:52 +0000 (14:01 -0400)]
tentative fix for losing (empty) MIDI files. Incomplete because testing shows issues with some workflows
Robin Gareus [Sat, 16 Aug 2014 11:30:00 +0000 (13:30 +0200)]
prepare for upcoming Jadeo.app -> Xjadeo.app rename on OSX.
also add Windows code while we're at it
and fallback to xjadeo on GNU/Linux.
Robin Gareus [Sat, 16 Aug 2014 11:18:44 +0000 (13:18 +0200)]
amend list of known video file extensions.
David Robillard [Mon, 14 Jul 2014 05:27:21 +0000 (01:27 -0400)]
Don't show all controllers for generic MIDI devices.
This takes a VERY long time to do, so is probably a problem for defined devices
with a ton of channels and devices, too. Not sure what the smart thing to do
here is, though adding lanes really shouldn't be this slow in the first place.
David Robillard [Mon, 14 Jul 2014 05:26:21 +0000 (01:26 -0400)]
Add midnam files for Korg Volca series.
David Robillard [Mon, 14 Jul 2014 04:43:36 +0000 (00:43 -0400)]
Show all named controllers for "Show All Automation" on MIDI tracks.
David Robillard [Mon, 14 Jul 2014 04:03:04 +0000 (00:03 -0400)]
Show 1-based channel numbers in MIDI controller automation menu.
This matches the numbers shown elsewhere, previously if you had a track set to
e.g. channel 10, the controller menu items had "[9]" suffixes.
David Robillard [Mon, 14 Jul 2014 03:36:45 +0000 (23:36 -0400)]
Support midnam files with a channel (not patch) NoteNameList.
Paul Davis [Tue, 10 Jun 2014 14:07:04 +0000 (10:07 -0400)]
fix crash recovery: add new constructors to SndFileSource, AudioFileSource, add a new SourceFactory method and finally tweak
AudioDiskstream::use_pending_capture_data() to create both the required whole-file and the in-playlist regions
Paul Davis [Mon, 2 Jun 2014 15:20:37 +0000 (11:20 -0400)]
substantive changes to the logic and safety for naming of (audio/MIDI) sources, especially when created via import
Paul Davis [Thu, 29 May 2014 20:28:57 +0000 (16:28 -0400)]
back port
6576105 from cairocanvas as fix for data loss/file deletion
Paul Davis [Thu, 22 May 2014 18:11:02 +0000 (14:11 -0400)]
fix binding name for set-tempo-from-region
Paul Davis [Wed, 14 May 2014 13:04:24 +0000 (09:04 -0400)]
Merge branch 'minsec-ruler-display' of https://github.com/djpohly/ardour
Devin J. Pohly [Wed, 14 May 2014 12:36:03 +0000 (08:36 -0400)]
fix major/minor ticks on min:sec ruler
All ticks from 0:00.000 to 0:00.999... were major, and everything after
was minor, instead of the correct distribution.
Devin J. Pohly [Wed, 14 May 2014 05:40:30 +0000 (01:40 -0400)]
fix rounding error in the min:sec ruler
When zoomed in to the millisecond level, the framerate was being divided
by 1000 as an integer to generate a ruler tick interval, which doesn't
work so well at things like 44100 or 88200. Instead, just count this
value in milliseconds, dividing by 1000 when we are done.
This was purely a display issue - the grid was in the correct place.
Devin J. Pohly [Wed, 14 May 2014 06:59:25 +0000 (02:59 -0400)]
don't use llrint on already-integral variables
This could trick people into thinking that there is a floating-point
type hiding behind the typedef instead of an integer.
Devin J. Pohly [Wed, 14 May 2014 06:47:32 +0000 (02:47 -0400)]
fix accumulated rounding error in BBT grid
Though current_frame is an integral type (framepos_t), it was being
added to as if it were floating-point, leading to an ever-increasing
rounding error when creating the grid for bars/beats/ticks.
Damien Zammit [Mon, 28 Apr 2014 20:44:40 +0000 (06:44 +1000)]
Fixed problem where importing invalid midi files caused crash.
Paul Davis [Mon, 28 Apr 2014 14:37:17 +0000 (10:37 -0400)]
add new SMFSource constructor to be used for existing-external files. Fixes #5919. Needs merging with CC
Paul Davis [Mon, 14 Apr 2014 18:14:30 +0000 (14:14 -0400)]
fix minor problem with recent cherry-picking from cairocanvas
Paul Davis [Mon, 14 Apr 2014 07:03:35 +0000 (03:03 -0400)]
merge
5764970709f15e85ec30c9cea89c318eb8114c58 from cairocanvas as final(?) change related to data loss
Paul Davis [Sun, 13 Apr 2014 15:35:49 +0000 (11:35 -0400)]
check whether a source with the same path exists in session list not just on disk.
This is intended to catch a potential wierd condition where a source exists as a stub, but has not yet been written to disk,
and then a new source is created with the same path. Currently it is not understood how/when this might happen
Paul Davis [Sun, 13 Apr 2014 15:12:22 +0000 (11:12 -0400)]
further code simplification and rationalization related to MIDI source/file renaming
Paul Davis [Sun, 13 Apr 2014 14:29:07 +0000 (10:29 -0400)]
dramatic change in logic and naming for operations related to adding a MIDI region on demand and cloning/unlinking
Existing code would cause data loss due to creation of two Source objects referring the same path, one with removable flags and one without. Careful code review suggested a variety of thinkos, function naming problems and other confusion that caused this. I have tried ot extensively comment what is going on with these operations, because it is one key area in which MIDI differs from audio: with audio, capture is the only way to add a new audio region, but for MIDI there are GUI input events that can add a new region.
Paul Davis [Thu, 10 Apr 2014 12:58:04 +0000 (08:58 -0400)]
redesign technique for naming/creating regions for MIDI clone (or other non-capture driven MIDI region creation operations).
See comments in Session::new_midi_source_name() for details.
Paul Davis [Fri, 4 Apr 2014 19:26:44 +0000 (15:26 -0400)]
after cloning a MIDI region, mark the source file as non-removable. Fixes reports about missing MIDI files on the forums and IRC
Paul Davis [Fri, 4 Apr 2014 19:26:44 +0000 (15:26 -0400)]
after cloning a MIDI region, mark the source file as non-removable. Fixes reports about missing MIDI files on the forums and IRC
Paul Davis [Mon, 14 Apr 2014 16:53:30 +0000 (12:53 -0400)]
backport
1d85ab27a7e and
ba128eea from cairocanvas branch to remove GIO (possible hotfix release)
Robin Gareus [Mon, 14 Apr 2014 10:26:10 +0000 (12:26 +0200)]
-d (disable plugin) option takes no arguments
Robin Gareus [Fri, 11 Apr 2014 15:01:26 +0000 (17:01 +0200)]
add manual reference to missing video-tools warnings
Sakari Bergen [Mon, 7 Apr 2014 18:36:58 +0000 (21:36 +0300)]
export ARDOUR_TEST_PATH for artest
We should probably remove the old test running stuff from libs/ardour.
Does someone still need it?
Sakari Bergen [Mon, 7 Apr 2014 18:27:56 +0000 (21:27 +0300)]
Fix buffer size mismatch in evoral tests
Robin Gareus [Wed, 2 Apr 2014 16:48:28 +0000 (18:48 +0200)]
fix typo
Robin Gareus [Sun, 23 Mar 2014 17:59:24 +0000 (18:59 +0100)]
midi-controller, support log parameters - fixes #5890
Adrian Knoth [Fri, 21 Mar 2014 13:00:00 +0000 (14:00 +0100)]
Keybindings for maximising the mixer window
Adrian Knoth [Fri, 21 Mar 2014 12:45:00 +0000 (13:45 +0100)]
Add option to display the mixer in fullscreen
This is useful for dual-head setups.
Robin Gareus [Wed, 19 Mar 2014 22:46:01 +0000 (23:46 +0100)]
videotimeline: fix black-frame generation (sample aspect ratio) on export
Robin Gareus [Wed, 19 Mar 2014 17:12:16 +0000 (18:12 +0100)]
tweak A/V import logic
Robin Gareus [Wed, 19 Mar 2014 16:34:45 +0000 (17:34 +0100)]
clarify A/V import options
Paul Davis [Fri, 28 Feb 2014 01:37:17 +0000 (20:37 -0500)]
(backport from cairocanvas branch) do not crash when considering a directory called midi (with any case) as an apparent MIDI file
Paul Davis [Fri, 21 Feb 2014 20:30:33 +0000 (15:30 -0500)]
reverse default behaviour for adding control points to automation with mouse clicks. unmodified click adds new control point without guard points; ctrl-click adds new point with a guard point (old behaviour)
Paul Davis [Thu, 20 Feb 2014 19:07:42 +0000 (14:07 -0500)]
add the with-guard-point distinction to region gain lines (imported from cairocanvas)
Robin Gareus [Wed, 19 Feb 2014 23:53:23 +0000 (00:53 +0100)]
the forgotten second (amend to prev commit)
Robin Gareus [Wed, 19 Feb 2014 23:48:14 +0000 (00:48 +0100)]
fix prev_snap_choice() key="3" binding
Paul Davis [Wed, 19 Feb 2014 18:22:41 +0000 (13:22 -0500)]
click (no drag) on automation line now adds a new control point on the line (not fully checked for precision)
Paul Davis [Wed, 19 Feb 2014 18:16:02 +0000 (13:16 -0500)]
Revert "add a hack to deal with device discovery race, in which the devices were not actually known to be ready before the last update_surfaces() call (which is where binding between strips and routes occurs) ; add support for Mackie Control touch on/off messages"
This reverts commit
06a25ffd5695697db9869a19e46c2f93c6c17458.
Paul Davis [Wed, 19 Feb 2014 18:15:33 +0000 (13:15 -0500)]
add a hack to deal with device discovery race, in which the devices were not actually known to be ready before the last update_surfaces() call (which is where binding between strips and routes occurs) ; add support for Mackie Control touch on/off messages
Paul Davis [Wed, 19 Feb 2014 17:54:00 +0000 (12:54 -0500)]
ctrl-click when adding automation points no longer adds guard points
Paul Davis [Wed, 19 Feb 2014 17:53:31 +0000 (12:53 -0500)]
use new ControlList::add() argument
Paul Davis [Wed, 19 Feb 2014 17:53:19 +0000 (12:53 -0500)]
do not needlessly keep starting touch/automation watch passes just because a command to start or stop touch was received
Paul Davis [Wed, 19 Feb 2014 17:52:14 +0000 (12:52 -0500)]
add option to skip guard points when adding new control points to a ControlList; add more debugging statements
Paul Davis [Wed, 19 Feb 2014 17:51:32 +0000 (12:51 -0500)]
clear up some stupid thinking in Amp regarding the way the underlying AutomationControl/Controllable gets set when Amp::set_gain() is called
Paul Davis [Wed, 19 Feb 2014 17:50:28 +0000 (12:50 -0500)]
add a hack to deal with device discovery race, in which the devices were not actually known to be ready before the last update_surfaces() call (which is where binding between strips and routes occurs) ; add support for Mackie Control touch on/off messages
Robin Gareus [Wed, 19 Feb 2014 17:32:00 +0000 (18:32 +0100)]
fix meter(s) when mixer-strip is switched to AuxSend
Robin Gareus [Sat, 15 Feb 2014 22:12:43 +0000 (23:12 +0100)]
clarify fader labels
Robin Gareus [Tue, 11 Feb 2014 04:52:39 +0000 (05:52 +0100)]
list action-names as part of --bindings
Robin Gareus [Tue, 11 Feb 2014 04:52:07 +0000 (05:52 +0100)]
fix crash at exit with '-b', '--bindings' option
Paul Davis [Sat, 8 Feb 2014 16:17:50 +0000 (11:17 -0500)]
add kxstudio linux vst dirs to LXVST default search path
Paul Davis [Sat, 8 Feb 2014 16:16:17 +0000 (11:16 -0500)]
fix missing colon in extension of LXVST search path
Paul Davis [Fri, 7 Feb 2014 22:38:42 +0000 (17:38 -0500)]
when cleaning up sources, do not remove "stub" sources from the source list, even though they do not exist on disk yet; remove some debug output
Paul Davis [Fri, 7 Feb 2014 22:30:34 +0000 (17:30 -0500)]
add FileSource::is_stub() declaration
Paul Davis [Fri, 7 Feb 2014 22:16:13 +0000 (17:16 -0500)]
Fix egregious logic bug in FileSource::removable() and introduce FileSource::is_stub() to hide logic for deciding if a source (file) is a stub
Paul Davis [Fri, 7 Feb 2014 20:25:18 +0000 (15:25 -0500)]
make backtrace symbols work again inside gtk2_ardour (-rdynamic is a link-time flag, not compile-time
Paul Davis [Fri, 7 Feb 2014 18:38:15 +0000 (13:38 -0500)]
fix utter confusion about session _path in new sessions.
Yikes!
Robin Gareus [Fri, 7 Feb 2014 18:30:43 +0000 (19:30 +0100)]
don't add a [shared] panner for the sends to monitoing section
fixes issue with 'stuck' mono panners (when using a stereo
monitoring section and auto-connect): the send to monitor
section is added after the main panner. At this point the
channel-count is different, but the send shared panner() with
the main route.
Here: mono-panner on track, stereo-panner; and they shared control
settings. since stereo-panner's width is 1, the position cannot be
changed.
Robin Gareus [Fri, 7 Feb 2014 18:21:30 +0000 (19:21 +0100)]
fix stereo-panner GUI edge case (panshel changes, send|listen)
Robin Gareus [Fri, 7 Feb 2014 17:05:47 +0000 (18:05 +0100)]
panner UI: check URI and #of channels on re-configuration
Robin Gareus [Fri, 7 Feb 2014 16:55:46 +0000 (17:55 +0100)]
update available panners when panshell changes
Fixes issue when adding splitting plugin
Robin Gareus [Wed, 5 Feb 2014 17:49:32 +0000 (18:49 +0100)]
add debug-message to track down missing Sources
Robin Gareus [Mon, 3 Feb 2014 19:25:05 +0000 (20:25 +0100)]
fix typo ndef, NDEBUG
Robin Gareus [Mon, 3 Feb 2014 18:12:29 +0000 (19:12 +0100)]
VBAP nomenclature s/Direction/Azimuth/
Robin Gareus [Mon, 3 Feb 2014 15:54:07 +0000 (16:54 +0100)]
don't display debug message in no-debug builds
Robin Gareus [Mon, 3 Feb 2014 15:52:36 +0000 (16:52 +0100)]
update audio-buffer assert, take offset into account
Robin Gareus [Mon, 3 Feb 2014 15:59:51 +0000 (16:59 +0100)]
remove cruft - unused _size in audio-buffers
Robin Gareus [Mon, 3 Feb 2014 15:51:08 +0000 (16:51 +0100)]
fix stem-export buffer-size check
Robin Gareus [Mon, 3 Feb 2014 14:09:17 +0000 (15:09 +0100)]
fix processor_lock
Only WriterLock requires to hold process_lock() as well
otherwise Route::process_output_buffers() may deadlock
Robin Gareus [Sat, 1 Feb 2014 22:06:24 +0000 (23:06 +0100)]
forward port lv2_evbuf update (from jalv)
Paul Davis [Thu, 30 Jan 2014 16:18:58 +0000 (11:18 -0500)]
even though man alloca says to include <alloca.h>, it apparently isn't necessary and no such header exists in the msvc world
Paul Davis [Wed, 29 Jan 2014 20:50:17 +0000 (15:50 -0500)]
move check for n_speakers so that we avoid needless work
Robin Gareus [Wed, 29 Jan 2014 20:45:13 +0000 (21:45 +0100)]
fix vbap-speaker calculations to work with alloca()
Robin Gareus [Tue, 28 Jan 2014 12:50:41 +0000 (13:50 +0100)]
fix thinko. custom panner URL is remembered for later when port-count/panner changes
Paul Davis [Tue, 28 Jan 2014 01:37:17 +0000 (20:37 -0500)]
fix up the abomination caused by moving from variable length (multidimensional) arrays to alloca'ed arrays, specifically access to arr[a][b].
This needs checking by an actual VBAP+multispeaker user.
Paul Davis [Tue, 28 Jan 2014 01:36:09 +0000 (20:36 -0500)]
prevent a strange crash while iterating over tracks (now, and maybe in the future)
Paul Davis [Mon, 27 Jan 2014 19:55:58 +0000 (14:55 -0500)]
add new folders to linux vst search path to help out AVLinux and some other specialized distros
Paul Davis [Mon, 27 Jan 2014 18:53:15 +0000 (13:53 -0500)]
replace standards-wobbling variable-length-arrays with alloca()
Paul Davis [Mon, 27 Jan 2014 18:52:48 +0000 (13:52 -0500)]
comment unused function argument
Robin Gareus [Sun, 26 Jan 2014 18:11:54 +0000 (19:11 +0100)]
fix #5840 ; redefinition of typedef 'VstTimeInfo'
Robin Gareus [Sun, 26 Jan 2014 00:21:28 +0000 (01:21 +0100)]
fix routing display for mono synths and midi-tracks w/o synth
Robin Gareus [Sat, 25 Jan 2014 23:46:39 +0000 (00:46 +0100)]
fix crash when removing synth from midi-track
(and there are bypassed audio-plugins after said synth)
Robin Gareus [Thu, 23 Jan 2014 14:32:26 +0000 (15:32 +0100)]
change VBAP visual parameter name again :)
Robin Gareus [Thu, 23 Jan 2014 13:57:19 +0000 (14:57 +0100)]
VBAP change visual parameter name. Diffusion -> Spread
Robin Gareus [Thu, 23 Jan 2014 12:14:25 +0000 (13:14 +0100)]
LV2 plugin save/delete -- fixes 5835
Robin Gareus [Wed, 22 Jan 2014 23:22:02 +0000 (00:22 +0100)]
midi-audition: make "no synth" selection work.
Robin Gareus [Wed, 22 Jan 2014 22:59:24 +0000 (23:59 +0100)]
configurable midi audition synth