Hopefully fix crash when the same frame is encoded twice.
authorCarl Hetherington <cth@carlh.net>
Mon, 24 Oct 2022 18:37:02 +0000 (20:37 +0200)
committerCarl Hetherington <cth@carlh.net>
Tue, 25 Oct 2022 14:08:34 +0000 (16:08 +0200)
commite55b2b3a7eb05b3cc69411b133aeec9772420c83
tree633c6295351e6feed73b98add6d24be3f17d49d0
parent811cd49873641f612a1df12b5b9d7d26bc289759
Hopefully fix crash when the same frame is encoded twice.

Previously if some frame X was passed to the encoder twice
I think this would happen:

X1 written; X stored to _pending_images
X2 written; _pending_images remains the same
X1 encode finishes; X is discarded from _pending_images
Data for X2 is read by the encoder but was just freed

I think this might have resulted in intermittent crashes, which were
fairly common in the 2.17.x branch with the test
ffmpeg_encoder_prores_regression_1

But I didn't conclusively prove it.
src/lib/ffmpeg_file_encoder.cc
src/lib/ffmpeg_file_encoder.h