Carl Hetherington [Sun, 19 Nov 2023 23:25:27 +0000 (00:25 +0100)]
Verify encrypted DCPs (more) correctly (#2659).
Carl Hetherington [Sun, 19 Nov 2023 23:20:44 +0000 (00:20 +0100)]
Cleanup: use stack-allocated FileDialog and accept multiple KDMs.
Carl Hetherington [Sun, 19 Nov 2023 23:14:32 +0000 (00:14 +0100)]
Cleanup: use ScopeGuard.
Carl Hetherington [Mon, 20 Nov 2023 14:37:23 +0000 (15:37 +0100)]
Fix build.
Carl Hetherington [Wed, 15 Nov 2023 16:02:16 +0000 (17:02 +0100)]
Fix audio analysis attempts with source files that have more channels than the film.
Carl Hetherington [Tue, 7 Nov 2023 23:59:42 +0000 (00:59 +0100)]
Cleanup: handle Filter objects by value rather than by reference.
Carl Hetherington [Tue, 7 Nov 2023 23:24:20 +0000 (00:24 +0100)]
Cleanup: remove an unnecessary shared_ptr.
Carl Hetherington [Tue, 7 Nov 2023 23:24:11 +0000 (00:24 +0100)]
Add header guards.
Carl Hetherington [Tue, 7 Nov 2023 23:18:22 +0000 (00:18 +0100)]
Don't feed channels to leqm that we don't have a correction factor for (#2647).
Carl Hetherington [Sun, 19 Nov 2023 20:34:56 +0000 (21:34 +0100)]
Add a dialog to show which screens have potentially-problematic
certificate validity periods when making KDMs (#2645).
Carl Hetherington [Sun, 19 Nov 2023 20:34:27 +0000 (21:34 +0100)]
Fix "create KDM" button sensitivity with invalid KDM time range.
Carl Hetherington [Sun, 19 Nov 2023 20:33:11 +0000 (21:33 +0100)]
Cleanup: header ordering.
Carl Hetherington [Sun, 12 Nov 2023 21:09:48 +0000 (22:09 +0100)]
Improve progress reporting of digest calculations (might help with #2643).
Carl Hetherington [Sun, 19 Nov 2023 21:40:40 +0000 (22:40 +0100)]
Supporters update.
Carl Hetherington [Sun, 19 Nov 2023 20:07:25 +0000 (21:07 +0100)]
Fix out-of-bounds read in OSX disk checking (#2658).
Carl Hetherington [Fri, 10 Nov 2023 22:51:46 +0000 (23:51 +0100)]
Always add a font with an empty ID (#2649).
It's not just subtitle files with no <LoadFont> that can have
subtitles without a specified font. In particular, DoM makes a
single space subtitle with no font spec when it creates filler
subtitles in multi-reel DCPs.
Carl Hetherington [Wed, 15 Nov 2023 22:07:42 +0000 (23:07 +0100)]
Pass through <Ruby> tags in subtitles (#2635) (GH#23).
Carl Hetherington [Thu, 16 Nov 2023 14:14:16 +0000 (15:14 +0100)]
Fix crash with subtitles for which we have no codec.
Carl Hetherington [Sun, 12 Nov 2023 23:30:48 +0000 (00:30 +0100)]
Copy Interop PNG subtitle files correctly (#2640).
Carl Hetherington [Wed, 15 Nov 2023 00:48:29 +0000 (01:48 +0100)]
Extract copy().
Carl Hetherington [Sat, 11 Nov 2023 00:59:22 +0000 (01:59 +0100)]
Replace deprecated zip_add() with zip_file_add().
Carl Hetherington [Sat, 11 Nov 2023 00:31:58 +0000 (01:31 +0100)]
Replace deprecated leaf() with filename().
Carl Hetherington [Sat, 11 Nov 2023 22:45:37 +0000 (23:45 +0100)]
Move a IMB location to try_imb() and add a new IMS pattern (#2644).
Carl Hetherington [Sat, 11 Nov 2023 21:55:27 +0000 (22:55 +0100)]
Store last path for adding KDMs (#2348).
Carl Hetherington [Sat, 11 Nov 2023 21:54:51 +0000 (22:54 +0100)]
Add FileDialog::path().
Carl Hetherington [Sat, 11 Nov 2023 21:19:37 +0000 (22:19 +0100)]
Cleanup: stack-allocated dialogs.
Carl Hetherington [Sat, 11 Nov 2023 20:07:54 +0000 (21:07 +0100)]
Use DirDialog and fix initial path (#2348).
Carl Hetherington [Sat, 11 Nov 2023 20:03:39 +0000 (21:03 +0100)]
Move add_files_override_path to film_util
Carl Hetherington [Sat, 11 Nov 2023 20:03:16 +0000 (21:03 +0100)]
Add comment.
Carl Hetherington [Sat, 11 Nov 2023 19:37:42 +0000 (20:37 +0100)]
Cleanup: stack-allocated dialogs.
Carl Hetherington [Sat, 11 Nov 2023 19:37:35 +0000 (20:37 +0100)]
Cleanup: auto.
Carl Hetherington [Sat, 28 Oct 2023 21:16:41 +0000 (23:16 +0200)]
Add check before dereferencing pointer.
Carl Hetherington [Sat, 28 Oct 2023 21:16:32 +0000 (23:16 +0200)]
Fix uninitialised variable.
Carl Hetherington [Sat, 28 Oct 2023 21:04:36 +0000 (23:04 +0200)]
Add some std::move.
Carl Hetherington [Sat, 28 Oct 2023 21:04:26 +0000 (23:04 +0200)]
Add some const& to uses of auto.
Carl Hetherington [Sat, 28 Oct 2023 21:04:15 +0000 (23:04 +0200)]
Fix some possible overflows.
Carl Hetherington [Sat, 28 Oct 2023 21:04:04 +0000 (23:04 +0200)]
Fix a bizarre thinko / typo of "false" for false.
Carl Hetherington [Sat, 28 Oct 2023 21:03:38 +0000 (23:03 +0200)]
Make sure a dynamic_pointer_cast worked.
Carl Hetherington [Sat, 28 Oct 2023 21:03:24 +0000 (23:03 +0200)]
Check some unsanitized network inputs before allocating memory using them.
Carl Hetherington [Sat, 28 Oct 2023 21:02:54 +0000 (23:02 +0200)]
Fix theoretical int overflow.
Carl Hetherington [Sat, 28 Oct 2023 21:02:40 +0000 (23:02 +0200)]
Add some missing locks.
Carl Hetherington [Sat, 28 Oct 2023 21:02:17 +0000 (23:02 +0200)]
Cleanup: whitespace.
Carl Hetherington [Sat, 28 Oct 2023 21:02:09 +0000 (23:02 +0200)]
Fix thinko when trying to keep channel counts even.
Carl Hetherington [Sat, 28 Oct 2023 20:31:38 +0000 (22:31 +0200)]
Fix possible deference of invalid iterator (if _reel == _reels.end()).
Carl Hetherington [Sat, 28 Oct 2023 20:28:14 +0000 (22:28 +0200)]
Fix possible dereference of invalid iterator (if have_pushed is empty).
Carl Hetherington [Sat, 28 Oct 2023 19:48:26 +0000 (21:48 +0200)]
Tolerate DCPs with no video and/or audio.
Carl Hetherington [Fri, 27 Oct 2023 23:51:51 +0000 (01:51 +0200)]
Use updated libdcp, including an optimisation for rgb-onto-xyz12.
Carl Hetherington [Wed, 18 Oct 2023 22:10:58 +0000 (00:10 +0200)]
Fix transcode job fps logging.
Broken in
d3455851f60ee6bc35ea4f314c62a7da51ce0d81
Carl Hetherington [Tue, 17 Oct 2023 22:44:30 +0000 (00:44 +0200)]
Add button to show only checked screens in the KDM creator (#2624).
Carl Hetherington [Tue, 17 Oct 2023 23:03:55 +0000 (01:03 +0200)]
Fix crash when removing multiple cinemas caused by _selected_cinemas being changed as we read it (#2632).
Carl Hetherington [Mon, 16 Oct 2023 21:31:46 +0000 (23:31 +0200)]
Make sure 2-channel MXFs don't get extra channel descriptors (#2631).
With all the EasyDCP tests done in bug #2487 we didn't look at stereo
MXFs as it appeared fairly early on that EasyDCP would reject them all.
In #2631 it's pointed out that it seems to make no sense to have descriptors
for channels which aren't there. I've still got no docs for any of this,
but let's try fixing that.
Carl Hetherington [Mon, 16 Oct 2023 21:28:26 +0000 (23:28 +0200)]
Change how channels are specified for these tests.
We now have a number of channels for the MXF, and the active
channels that we map in the DCP.
Carl Hetherington [Mon, 16 Oct 2023 18:19:53 +0000 (20:19 +0200)]
Replace a slightly tortured lambda with a loop.
Carl Hetherington [Mon, 16 Oct 2023 09:30:27 +0000 (11:30 +0200)]
Remove unused code.
Carl Hetherington [Sun, 15 Oct 2023 22:40:28 +0000 (00:40 +0200)]
This test suddenly just started failing with
opj_int_fix_mul: Assertion `(temp >> 13) <= (OPJ_INT64)0x7FFFFFFF' failed.
which is odd - why now?
Anywhere here we limit the OpenJPEG image values to what I think is
the "legal" range.
Carl Hetherington [Sun, 15 Oct 2023 15:34:33 +0000 (17:34 +0200)]
Supporters update.
Carl Hetherington [Sun, 15 Oct 2023 07:16:49 +0000 (09:16 +0200)]
Supporters update.
Carl Hetherington [Sat, 14 Oct 2023 19:48:25 +0000 (21:48 +0200)]
Fix DCP content font ID allocation to cope with DCPs that have multiple fonts
with the same name in the same reel (#2600).
Previously we had this id_for_font_in_reel() which would give an ID
of N_font-ID. This means we got duplicate font IDs.
Here we replace that method with FontAllocator, which gives an ID of
N_font-ID for the first font and M_font-ID, where M is a number higher than
the highest reel index. The idea is to support the required new IDs
without breaking exisiting projects.
There is some documentation of how it works in doc/design/fonts
Carl Hetherington [Sat, 14 Oct 2023 19:43:52 +0000 (21:43 +0200)]
Cleanup: assert.
Carl Hetherington [Sat, 14 Oct 2023 19:41:15 +0000 (21:41 +0200)]
Cleanup: rename sc -> subtitle_asset
Carl Hetherington [Sat, 14 Oct 2023 19:40:32 +0000 (21:40 +0200)]
Cleanup: assert result of get_font().
Carl Hetherington [Thu, 12 Oct 2023 08:50:24 +0000 (10:50 +0200)]
Bump libdcp for channel ID fix (#2629).
Carl Hetherington [Tue, 10 Oct 2023 18:35:16 +0000 (20:35 +0200)]
Another compilation error fix for old toolchains.
Carl Hetherington [Tue, 10 Oct 2023 18:35:06 +0000 (20:35 +0200)]
Cleanup: remove unnecessary namespace.
Carl Hetherington [Tue, 10 Oct 2023 17:32:37 +0000 (19:32 +0200)]
Apply another fix for a weird compilation error on old compilers.
Carl Hetherington [Tue, 10 Oct 2023 10:12:54 +0000 (12:12 +0200)]
Bump libdcp for fixes to build on Ubuntu 16.04 etc.
Carl Hetherington [Mon, 9 Oct 2023 23:05:27 +0000 (01:05 +0200)]
Add new "copy markers from this DCP" option (#2628).
Also stop the "copy settings" options from doing this, as Carsten points
out that it could be confusing and potentially very bad if you copy
markers from an OV to an edited VF which then bring house lights up at
the wrong time or whatever.
Carl Hetherington [Mon, 9 Oct 2023 22:58:39 +0000 (00:58 +0200)]
Rename copy_dcp_details_to_film -> copy_dcp_settings_to_film.
Carl Hetherington [Mon, 9 Oct 2023 21:52:16 +0000 (23:52 +0200)]
Supporters update.
Carl Hetherington [Fri, 6 Oct 2023 00:37:16 +0000 (02:37 +0200)]
Use dcp::filesystem to wrap filesystem calls and fix_long_path
anything that is passed to read_file() from libcxml.
This should fix #2623 and other similar problems.
Carl Hetherington [Wed, 4 Oct 2023 22:20:27 +0000 (00:20 +0200)]
Bump libdcp for new filesystem wrappers.
Carl Hetherington [Sun, 8 Oct 2023 21:04:59 +0000 (23:04 +0200)]
Bump leqm-nrt to build with -O2 for a large speed-up (#2616).
Carl Hetherington [Wed, 4 Oct 2023 23:17:16 +0000 (01:17 +0200)]
Fix flickering timeline drags on Windows (#2625).
Carl Hetherington [Mon, 2 Oct 2023 21:41:06 +0000 (23:41 +0200)]
You are advised -> It is advisable (#2189).
Carl Hetherington [Sat, 30 Sep 2023 20:58:45 +0000 (22:58 +0200)]
Cleanup: use a lambda.
Carl Hetherington [Sat, 30 Sep 2023 10:35:26 +0000 (12:35 +0200)]
Fix test/data branching SNAFU.
Carl Hetherington [Sat, 30 Sep 2023 10:32:42 +0000 (12:32 +0200)]
Allow DCP content type from template to work.
Carl Hetherington [Sat, 30 Sep 2023 10:28:05 +0000 (12:28 +0200)]
Allow SMPTE/interop setting from template to work.
Carl Hetherington [Sat, 30 Sep 2023 10:09:00 +0000 (12:09 +0200)]
Add --no-encrypt with the same idea as the previous commit.
Carl Hetherington [Sat, 30 Sep 2023 09:58:29 +0000 (11:58 +0200)]
Add --twod option to create CLI and stop 2D from being forced over
a template if --threed is not specified (#2620/GH#22).
Carl Hetherington [Sat, 30 Sep 2023 09:42:26 +0000 (11:42 +0200)]
Cleanup: add some _ prefixes.
Carl Hetherington [Sat, 30 Sep 2023 09:37:34 +0000 (11:37 +0200)]
Cleanup: make some variables private.
Carl Hetherington [Sat, 30 Sep 2023 09:29:42 +0000 (11:29 +0200)]
Cleanup: extract some stuff to a method in CreateCLI.
Carl Hetherington [Sat, 30 Sep 2023 08:43:15 +0000 (10:43 +0200)]
Apply video range from template (#2611).
Carl Hetherington [Thu, 28 Sep 2023 20:18:34 +0000 (22:18 +0200)]
Support alpha blending 64-bit RGB onto things.
Carl Hetherington [Wed, 27 Sep 2023 22:00:15 +0000 (00:00 +0200)]
Rename alpha_blend_test_one -> alpha_blend_test_bgra_onto.
Carl Hetherington [Sun, 24 Sep 2023 22:38:10 +0000 (00:38 +0200)]
Cleanup: extract some parts of alpha_blend().
Carl Hetherington [Tue, 26 Sep 2023 22:16:38 +0000 (00:16 +0200)]
Fix errors with WAVs containing markers (#2617).
I'm not 100% sure about this but they seem to end up giving audio
packets with no channels and no frames. Here we handle such packets
better.
Carl Hetherington [Thu, 28 Sep 2023 19:02:44 +0000 (21:02 +0200)]
Install for all users on Windows (#2202).
Carl Hetherington [Sun, 24 Sep 2023 21:30:19 +0000 (23:30 +0200)]
Add some new pixfmts.
Carl Hetherington [Thu, 21 Sep 2023 21:58:49 +0000 (23:58 +0200)]
Clean up and add Ubuntu 23.10
Carl Hetherington [Wed, 20 Sep 2023 23:10:14 +0000 (01:10 +0200)]
Supporters update.
Carl Hetherington [Wed, 20 Sep 2023 21:59:20 +0000 (23:59 +0200)]
Fix example names in prefs (#2612).
Carl Hetherington [Wed, 20 Sep 2023 20:57:03 +0000 (22:57 +0200)]
Better error message.
Carl Hetherington [Fri, 15 Sep 2023 08:53:33 +0000 (10:53 +0200)]
Updated zh_CN translation from poppinzhang.
Carl Hetherington [Thu, 14 Sep 2023 21:12:19 +0000 (23:12 +0200)]
Updated sl_SI translation from Martin Srebotnjak.
Carl Hetherington [Thu, 14 Sep 2023 08:57:18 +0000 (10:57 +0200)]
Supporters update.
Carl Hetherington [Wed, 13 Sep 2023 21:27:39 +0000 (23:27 +0200)]
Supporters update.
Carl Hetherington [Wed, 13 Sep 2023 20:29:04 +0000 (22:29 +0200)]
Bump libdcp for fix to GH #20, a spurious rejection of a KDM.
Carl Hetherington [Tue, 12 Sep 2023 21:14:42 +0000 (23:14 +0200)]
Update ISDCF name when DCP track changes.