2 Copyright (C) 2022 Carl Hetherington <cth@carlh.net>
4 This file is part of DCP-o-matic.
6 DCP-o-matic is free software; you can redistribute it and/or modify
7 it under the terms of the GNU General Public License as published by
8 the Free Software Foundation; either version 2 of the License, or
9 (at your option) any later version.
11 DCP-o-matic is distributed in the hope that it will be useful,
12 but WITHOUT ANY WARRANTY; without even the implied warranty of
13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 GNU General Public License for more details.
16 You should have received a copy of the GNU General Public License
17 along with DCP-o-matic. If not, see <http://www.gnu.org/licenses/>.
22 #include "lib/content_factory.h"
23 #include "lib/dcp_content.h"
26 #include "lib/text_content.h"
31 #include <dcp/reel_subtitle_asset.h>
32 #include <dcp/smpte_subtitle_asset.h>
34 #include <boost/test/unit_test.hpp>
37 using std::make_shared;
40 BOOST_AUTO_TEST_CASE(full_dcp_subtitle_font_id_test)
42 auto dcp = make_shared<DCPContent>(TestPaths::private_data() / "JourneyToJah_TLR-1_F_EN-DE-FR_CH_51_2K_LOK_20140225_DGL_SMPTE_OV");
43 auto film = new_test_film2("full_dcp_subtitle_font_id_test", { dcp });
45 auto content = film->content();
46 BOOST_REQUIRE_EQUAL(content.size(), 1U);
47 auto text = content[0]->only_text();
50 /* There's the font from the DCP and also a dummy one with an empty ID */
51 BOOST_REQUIRE_EQUAL(text->fonts().size(), 2U);
52 auto font = text->fonts().front();
53 BOOST_CHECK_EQUAL(font->id(), "0_theFontId");
54 BOOST_REQUIRE(font->data());
55 BOOST_CHECK_EQUAL(font->data()->size(), 367112);
59 BOOST_AUTO_TEST_CASE(dcp_subtitle_font_id_test)
61 auto subs = content_factory(TestPaths::private_data() / "JourneyToJah_TLR-1_F_EN-DE-FR_CH_51_2K_LOK_20140225_DGL_SMPTE_OV" / "8b48f6ae-c74b-4b80-b994-a8236bbbad74_sub.mxf");
62 auto film = new_test_film2("dcp_subtitle_font_id_test", subs);
64 auto content = film->content();
65 BOOST_REQUIRE_EQUAL(content.size(), 1U);
66 auto text = content[0]->only_text();
69 /* There's the font from the DCP and also a dummy one with an empty ID */
70 BOOST_REQUIRE_EQUAL(text->fonts().size(), 2U);
71 auto font = text->fonts().front();
72 BOOST_CHECK_EQUAL(font->id(), "theFontId");
73 BOOST_REQUIRE(font->data());
74 BOOST_CHECK_EQUAL(font->data()->size(), 367112);
78 BOOST_AUTO_TEST_CASE(make_dcp_with_subs_from_interop_dcp)
80 auto dcp = make_shared<DCPContent>("test/data/Iopsubs_FTR-1_F_XX-XX_MOS_2K_20220710_IOP_OV");
81 auto film = new_test_film2("make_dcp_with_subs_from_interop_dcp", { dcp });
82 dcp->text.front()->set_use(true);
86 dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
87 dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME
93 BOOST_AUTO_TEST_CASE(make_dcp_with_subs_from_smpte_dcp)
97 auto dcp = make_shared<DCPContent>(TestPaths::private_data() / "JourneyToJah_TLR-1_F_EN-DE-FR_CH_51_2K_LOK_20140225_DGL_SMPTE_OV");
98 auto film = new_test_film2("make_dcp_with_subs_from_smpte_dcp", { dcp }, &cl);
99 dcp->text.front()->set_use(true);
100 make_and_verify_dcp(film);
106 BOOST_AUTO_TEST_CASE(make_dcp_with_subs_from_mkv)
108 auto subs = content_factory(TestPaths::private_data() / "clapperboard_with_subs.mkv");
109 auto film = new_test_film2("make_dcp_with_subs_from_mkv", subs);
110 subs[0]->text.front()->set_use(true);
111 subs[0]->text.front()->set_language(dcp::LanguageTag("en-US"));
112 make_and_verify_dcp(film, { dcp::VerificationNote::Code::INVALID_PICTURE_FRAME_RATE_FOR_2K });
116 BOOST_AUTO_TEST_CASE(make_dcp_with_subs_without_font_tag)
118 auto subs = content_factory("test/data/no_font.xml");
119 auto film = new_test_film2("make_dcp_with_subs_without_font_tag", { subs });
120 subs[0]->text.front()->set_use(true);
124 dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
125 dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME,
126 dcp::VerificationNote::Code::MISSING_CPL_METADATA
129 auto check_file = subtitle_file(film);
130 dcp::SMPTESubtitleAsset check_asset(check_file);
131 BOOST_CHECK_EQUAL(check_asset.load_font_nodes().size(), 1U);
132 auto check_font_data = check_asset.font_data();
133 BOOST_CHECK_EQUAL(check_font_data.size(), 1U);
134 BOOST_CHECK(check_font_data.begin()->second == dcp::ArrayData(default_font_file()));
138 BOOST_AUTO_TEST_CASE(make_dcp_with_subs_in_dcp_without_font_tag)
140 /* Make a DCP with some subs in */
141 auto source_subs = content_factory("test/data/short.srt");
142 auto source = new_test_film2("make_dcp_with_subs_in_dcp_without_font_tag_source", { source_subs });
143 source->set_interop(true);
147 dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
148 dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME,
149 dcp::VerificationNote::Code::MISSING_CPL_METADATA,
150 dcp::VerificationNote::Code::INVALID_STANDARD
153 /* Find the ID of the subs */
154 dcp::DCP source_dcp(source->dir(source->dcp_name()));
156 BOOST_REQUIRE(!source_dcp.cpls().empty());
157 BOOST_REQUIRE(!source_dcp.cpls()[0]->reels().empty());
158 BOOST_REQUIRE(source_dcp.cpls()[0]->reels()[0]->main_subtitle());
159 auto const id = source_dcp.cpls()[0]->reels()[0]->main_subtitle()->asset()->id();
161 /* Graft in some bad subs with no <Font> tag */
162 auto source_subtitle_file = subtitle_file(source);
163 #if BOOST_VERSION >= 107400
164 boost::filesystem::copy_file("test/data/no_font.xml", source_subtitle_file, boost::filesystem::copy_options::overwrite_existing);
166 boost::filesystem::copy_file("test/data/no_font.xml", source_subtitle_file, boost::filesystem::copy_option::overwrite_if_exists);
169 /* Fix the <Id> tag */
171 Editor editor(source_subtitle_file);
172 editor.replace("4dd8ee05-5986-4c67-a6f8-bbeac62e21db", id);
175 /* Now make a project which imports that DCP and makes another DCP from it */
176 auto dcp_content = make_shared<DCPContent>(source->dir(source->dcp_name()));
177 auto film = new_test_film2("make_dcp_with_subs_without_font_tag", { dcp_content });
178 BOOST_REQUIRE(!dcp_content->text.empty());
179 dcp_content->text.front()->set_use(true);
183 dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
184 dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME,
185 dcp::VerificationNote::Code::MISSING_CPL_METADATA
188 auto check_file = subtitle_file(film);
189 dcp::SMPTESubtitleAsset check_asset(check_file);
190 BOOST_CHECK_EQUAL(check_asset.load_font_nodes().size(), 1U);
191 auto check_font_data = check_asset.font_data();
192 BOOST_CHECK_EQUAL(check_font_data.size(), 1U);
193 BOOST_CHECK(check_font_data.begin()->second == dcp::ArrayData(default_font_file()));
197 BOOST_AUTO_TEST_CASE(filler_subtitle_reels_have_load_font_tags)
199 auto const name = boost::unit_test::framework::current_test_case().full_name();
201 auto subs = content_factory("test/data/short.srt")[0];
202 auto video1 = content_factory("test/data/flat_red.png")[0];
203 auto video2 = content_factory("test/data/flat_red.png")[0];
205 auto film = new_test_film2(name, { video1, video2, subs });
206 film->set_reel_type(ReelType::BY_VIDEO_CONTENT);
211 dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
212 dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME,
213 dcp::VerificationNote::Code::INVALID_SUBTITLE_SPACING,
214 dcp::VerificationNote::Code::MISSING_CPL_METADATA
219 BOOST_AUTO_TEST_CASE(subtitle_with_no_font_test)
221 auto const name_base = boost::unit_test::framework::current_test_case().full_name();
223 auto video1 = content_factory("test/data/flat_red.png")[0];
224 auto video2 = content_factory("test/data/flat_red.png")[0];
225 auto subs = content_factory("test/data/short.srt")[0];
227 auto bad_film = new_test_film2(name_base + "_bad", { video1, video2, subs });
228 bad_film->set_reel_type(ReelType::BY_VIDEO_CONTENT);
229 video2->set_position(bad_film, video1->end(bad_film));
230 subs->set_position(bad_film, video1->end(bad_film));
231 subs->text[0]->add_font(make_shared<dcpomatic::Font>("foo", "test/data/LiberationSans-Regular.ttf"));
236 dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
237 dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME
240 /* When this test was written, this DCP would have one reel whose subtitles had <LoadFont>s
241 * but the subtitles specified no particular font. This triggers bug #2649, which this test
242 * is intended to trigger. First, make sure that the DCP has the required characteristics,
243 * to guard against a case where for some reason the DCP here is different enough that it
244 * doesn't trigger the bug.
246 dcp::DCP check(bad_film->dir(bad_film->dcp_name()));
248 BOOST_REQUIRE_EQUAL(check.cpls().size(), 1U);
249 auto cpl = check.cpls()[0];
250 BOOST_REQUIRE_EQUAL(cpl->reels().size(), 2U);
251 auto check_subs_reel = cpl->reels()[0]->main_subtitle();
252 BOOST_REQUIRE(check_subs_reel);
253 auto check_subs = check_subs_reel->asset();
254 BOOST_REQUIRE(check_subs);
256 BOOST_CHECK_EQUAL(check_subs->font_data().size(), 1U);
257 BOOST_REQUIRE_EQUAL(check_subs->subtitles().size(), 1U);
258 BOOST_CHECK(!std::dynamic_pointer_cast<const dcp::SubtitleString>(check_subs->subtitles()[0])->font().has_value());
260 auto check_film = new_test_film2(name_base + "_check", { make_shared<DCPContent>(bad_film->dir(bad_film->dcp_name())) });
261 make_and_verify_dcp(check_film);