Log on av_read_frame error (rather than aborting) and log on unused data in a packet.
[dcpomatic.git] / src / lib / ffmpeg_decoder.cc
index 8feb366239cbb0b19e04a63552aff60ec989af50..09f699543c790c6755b59cb6d54530833c793039 100644 (file)
@@ -27,6 +27,7 @@
 #include <iomanip>
 #include <iostream>
 #include <stdint.h>
+#include <boost/lexical_cast.hpp>
 extern "C" {
 #include <tiffio.h>
 #include <libavcodec/avcodec.h>
@@ -40,19 +41,22 @@ extern "C" {
 #include "transcoder.h"
 #include "job.h"
 #include "filter.h"
-#include "film_state.h"
 #include "options.h"
 #include "exceptions.h"
 #include "image.h"
 #include "util.h"
 #include "log.h"
 #include "ffmpeg_decoder.h"
+#include "subtitle.h"
 
-using namespace std;
-using namespace boost;
+using std::cout;
+using std::string;
+using std::vector;
+using std::stringstream;
+using boost::shared_ptr;
 
-FFmpegDecoder::FFmpegDecoder (boost::shared_ptr<const FilmState> s, boost::shared_ptr<const Options> o, Job* j, Log* l, bool minimal, bool ignore_length)
-       : Decoder (s, o, j, l, minimal, ignore_length)
+FFmpegDecoder::FFmpegDecoder (shared_ptr<Film> f, shared_ptr<const Options> o, Job* j, bool minimal, bool ignore_length)
+       : Decoder (f, o, j, minimal, ignore_length)
        , _format_context (0)
        , _video_stream (-1)
        , _audio_stream (-1)
@@ -64,7 +68,6 @@ FFmpegDecoder::FFmpegDecoder (boost::shared_ptr<const FilmState> s, boost::share
        , _audio_codec (0)
        , _subtitle_codec_context (0)
        , _subtitle_codec (0)
-       , _have_subtitle (false)
 {
        setup_general ();
        setup_video ();
@@ -82,15 +85,12 @@ FFmpegDecoder::~FFmpegDecoder ()
                avcodec_close (_video_codec_context);
        }
 
-       if (_have_subtitle) {
-               avsubtitle_free (&_subtitle);
-       }
-
        if (_subtitle_codec_context) {
                avcodec_close (_subtitle_codec_context);
        }
-       
+
        av_free (_frame);
+       
        avformat_close_input (&_format_context);
 }      
 
@@ -101,24 +101,43 @@ FFmpegDecoder::setup_general ()
        
        av_register_all ();
 
-       if ((r = avformat_open_input (&_format_context, _fs->content_path().c_str(), 0, 0)) != 0) {
-               throw OpenFileError (_fs->content_path ());
+       if ((r = avformat_open_input (&_format_context, _film->content_path().c_str(), 0, 0)) != 0) {
+               throw OpenFileError (_film->content_path ());
        }
 
        if (avformat_find_stream_info (_format_context, 0) < 0) {
                throw DecodeError ("could not find stream information");
        }
 
+       /* Find video, audio and subtitle streams and choose the first of each */
+
        for (uint32_t i = 0; i < _format_context->nb_streams; ++i) {
-               if (_format_context->streams[i]->codec->codec_type == AVMEDIA_TYPE_VIDEO) {
+               AVStream* s = _format_context->streams[i];
+               if (s->codec->codec_type == AVMEDIA_TYPE_VIDEO) {
                        _video_stream = i;
-               } else if (_format_context->streams[i]->codec->codec_type == AVMEDIA_TYPE_AUDIO) {
-                       _audio_stream = i;
-               } else if (_format_context->streams[i]->codec->codec_type == AVMEDIA_TYPE_SUBTITLE) {
-                       _subtitle_stream = i;
+               } else if (s->codec->codec_type == AVMEDIA_TYPE_AUDIO) {
+                       if (_audio_stream == -1) {
+                               _audio_stream = i;
+                       }
+                       _audio_streams.push_back (AudioStream (stream_name (s), i, s->codec->channels));
+               } else if (s->codec->codec_type == AVMEDIA_TYPE_SUBTITLE) {
+                       if (_subtitle_stream == -1) {
+                               _subtitle_stream = i;
+                       }
+                       _subtitle_streams.push_back (SubtitleStream (stream_name (s), i));
                }
        }
 
+       /* Now override audio and subtitle streams with those from the Film, if it has any */
+
+       if (_film->audio_stream_index() != -1) {
+               _audio_stream = _film->audio_stream().id();
+       }
+
+       if (_film->subtitle_stream_index() != -1) {
+               _subtitle_stream = _film->subtitle_stream().id ();
+       }
+
        if (_video_stream < 0) {
                throw DecodeError ("could not find video stream");
        }
@@ -138,8 +157,15 @@ FFmpegDecoder::setup_video ()
        if (_video_codec == 0) {
                throw DecodeError ("could not find video decoder");
        }
+
+       /* I think this prevents problems with green hash on decodes and
+          "changing frame properties on the fly is not supported by all filters"
+          messages with some content.  Although I'm not sure; needs checking.
+       */
+       AVDictionary* opts = 0;
+       av_dict_set (&opts, "threads", "1", 0);
        
-       if (avcodec_open2 (_video_codec_context, _video_codec, 0) < 0) {
+       if (avcodec_open2 (_video_codec_context, _video_codec, &opts) < 0) {
                throw DecodeError ("could not open video decoder");
        }
 }
@@ -195,9 +221,13 @@ bool
 FFmpegDecoder::do_pass ()
 {
        int r = av_read_frame (_format_context, &_packet);
+       
        if (r < 0) {
                if (r != AVERROR_EOF) {
-                       throw DecodeError ("error on av_read_frame");
+                       /* Maybe we should fail here, but for now we'll just finish off instead */
+                       char buf[256];
+                       av_strerror (r, buf, sizeof(buf));
+                       _film->log()->log (String::compose ("error on av_read_frame (%1) (%2)", buf, r));
                }
                
                /* Get any remaining frames */
@@ -205,13 +235,12 @@ FFmpegDecoder::do_pass ()
                _packet.data = 0;
                _packet.size = 0;
 
-               int frame_finished;
+               /* XXX: should we reset _packet.data and size after each *_decode_* call? */
 
-               if (_opt->decode_video) {
-                       while (avcodec_decode_video2 (_video_codec_context, _frame, &frame_finished, &_packet) >= 0 && frame_finished) {
+               int frame_finished;
 
-                               process_video (_frame);
-                       }
+               while (avcodec_decode_video2 (_video_codec_context, _frame, &frame_finished, &_packet) >= 0 && frame_finished) {
+                       process_video (_frame);
                }
 
                if (_audio_stream >= 0 && _opt->decode_audio) {
@@ -219,8 +248,8 @@ FFmpegDecoder::do_pass ()
                                int const data_size = av_samples_get_buffer_size (
                                        0, _audio_codec_context->channels, _frame->nb_samples, audio_sample_format (), 1
                                        );
-                               
-                               assert (_audio_codec_context->channels == _fs->audio_channels);
+
+                               assert (_audio_codec_context->channels == _film->audio_channels());
                                process_audio (_frame->data[0], data_size);
                        }
                }
@@ -228,115 +257,125 @@ FFmpegDecoder::do_pass ()
                return true;
        }
 
-       if (_packet.stream_index == _video_stream && _opt->decode_video) {
+       avcodec_get_frame_defaults (_frame);
+       
+       if (_packet.stream_index == _video_stream) {
 
                int frame_finished;
-               if (avcodec_decode_video2 (_video_codec_context, _frame, &frame_finished, &_packet) >= 0 && frame_finished) {
-                       
-                       cout << "decoded some video.\n";
-                       if (_have_subtitle) {
-                               cout << "have a subtitle; " << _subtitle.num_rects << "\n";
-                               for (unsigned int i = 0; i < _subtitle.num_rects; ++i) {
-                                       AVSubtitleRect* rect = _subtitle.rects[i];
-                                       if (rect->type != SUBTITLE_BITMAP) {
-                                               cout << "not a bitmap\n";
-                                               throw DecodeError ("non-bitmap subtitles not yet supported");
-                                       }
+               int const r = avcodec_decode_video2 (_video_codec_context, _frame, &frame_finished, &_packet);
+               if (r >= 0 && frame_finished) {
 
-                                       /* XXX: all this assumes YUV420 in _frame */
-                                       
-                                       assert (rect->nb_colors == 4);
-                                       assert (rect->pict.data[0]);
+                       if (r != _packet.size) {
+                               _film->log()->log (String::compose ("Used only %1 bytes of %2 in packet", r, _packet.size));
+                       }
 
-                                       /* Start of the first line in the target frame */
-                                       uint8_t* frame_y_p = _frame->data[0] + rect->y * _frame->linesize[0];
-                                       uint8_t* frame_u_p = _frame->data[1] + (rect->y / 2) * _frame->linesize[1];
-                                       uint8_t* frame_v_p = _frame->data[2] + (rect->y / 2) * _frame->linesize[2];
-                                       
-                                       /* Start of the first line in the subtitle */
-                                       uint8_t* sub_p = rect->pict.data[0];
+                       /* Where we are in the output, in seconds */
+                       double const out_pts_seconds = video_frame_index() / frames_per_second();
 
-                                       cout << "frame ls 0 is " << _frame->linesize[0] << "\n";
-                                       cout << "frame ls 1 is " << _frame->linesize[1] << "\n";
-                                       cout << "frame ls 2 is " << _frame->linesize[2] << "\n";
+                       /* Where we are in the source, in seconds */
+                       double const source_pts_seconds = av_q2d (_format_context->streams[_packet.stream_index]->time_base)
+                               * av_frame_get_best_effort_timestamp(_frame);
 
-                                       uint32_t* palette = (uint32_t *) rect->pict.data[1];
-                                       
-                                       for (int sub_y = 0; sub_y < rect->h; ++sub_y) {
-                                               uint8_t* sub_line_p = sub_p;
-                                               uint8_t* frame_line_y_p = frame_y_p + rect->x;
-                                               uint8_t* frame_line_u_p = frame_u_p + (rect->x / 2);
-                                               uint8_t* frame_line_v_p = frame_v_p + (rect->x / 2);
-
-                                               uint8_t current_u = 0;
-                                               uint8_t current_v = 0;
-                                               int subsample_step = 0;
-                                               
-                                               for (int sub_x = 0; sub_x < rect->w; ++sub_x) {
-
-                                                       uint32_t const val = palette[*sub_line_p++];
-                                                       
-                                                       int const     red =  (val &       0xff);
-                                                       int const   green =  (val &     0xff00) >> 8;
-                                                       int const    blue =  (val &   0xff0000) >> 16;
-                                                       float const alpha = ((val & 0xff000000) >> 24) / 255.0;
-
-                                                       int const cy = *frame_line_y_p;
-
-                                                       *frame_line_y_p++ = int (cy * (1 - alpha)) + int (RGB_TO_Y_CCIR (red, green, blue) * alpha);
-                                                       
-                                                       current_u |= ((RGB_TO_U_CCIR (red, green, blue, 0) & 0xf0) >> 4) << (4 * subsample_step);
-                                                       current_v |= ((RGB_TO_V_CCIR (red, green, blue, 0) & 0xf0) >> 4) << (4 * subsample_step);
-
-                                                       if (subsample_step == 1 && (sub_y % 2) == 0) {
-                                                               int const cu = *frame_line_u_p;
-                                                               int const cv = *frame_line_v_p;
-                                                               *frame_line_u_p++ = int (cu * (1 - alpha)) + int (current_u * alpha);
-                                                               *frame_line_v_p++ = int (cv * (1 - alpha)) + int (current_v * alpha);
-                                                               current_u = current_v = 0;
-                                                       }
-
-                                                       subsample_step = (subsample_step + 1) % 2;
-                                               }
-
-                                               sub_p += rect->pict.linesize[0];
-                                               frame_y_p += _frame->linesize[0];
-                                               if ((sub_y % 2) == 0) {
-                                                       frame_u_p += _frame->linesize[1];
-                                                       frame_v_p += _frame->linesize[2];
-                                               }
-                                       }
+                       if (!_first_video) {
+                               _first_video = source_pts_seconds;
+                       }
+
+                       /* Difference between where we are and where we should be */
+                       double const delta = source_pts_seconds - _first_video.get() - out_pts_seconds;
+                       double const one_frame = 1 / frames_per_second();
+
+                       /* Insert frames if required to get out_pts_seconds up to pts_seconds */
+                       if (delta > one_frame) {
+                               int const extra = rint (delta / one_frame);
+                               for (int i = 0; i < extra; ++i) {
+                                       repeat_last_video ();
+                                       _film->log()->log (
+                                               String::compose (
+                                                       "Extra frame inserted at %1s; DCP frame %2, source PTS %3",
+                                                       out_pts_seconds, video_frame_index(), source_pts_seconds
+                                                       )
+                                               );
                                }
                        }
-                       
-                       process_video (_frame);
+
+                       if (delta > -one_frame) {
+                               /* Process this frame */
+                               process_video (_frame);
+                       } else {
+                               /* Otherwise we are omitting a frame to keep things right */
+                               _film->log()->log (String::compose ("Frame removed at %1s", out_pts_seconds));
+                       }
                }
 
        } else if (_audio_stream >= 0 && _packet.stream_index == _audio_stream && _opt->decode_audio) {
-               
-               avcodec_get_frame_defaults (_frame);
-               
+
                int frame_finished;
                if (avcodec_decode_audio4 (_audio_codec_context, _frame, &frame_finished, &_packet) >= 0 && frame_finished) {
-                       int const data_size = av_samples_get_buffer_size (
-                               0, _audio_codec_context->channels, _frame->nb_samples, audio_sample_format (), 1
-                               );
 
-                       assert (_audio_codec_context->channels == _fs->audio_channels);
-                       process_audio (_frame->data[0], data_size);
-               }
+                       /* Where we are in the source, in seconds */
+                       double const source_pts_seconds = av_q2d (_format_context->streams[_packet.stream_index]->time_base)
+                               * av_frame_get_best_effort_timestamp(_frame);
+
+                       /* We only decode audio if we've had our first video packet through, and if it
+                          was before this packet.  Until then audio is thrown away.
+                       */
+                               
+                       if (_first_video && _first_video.get() <= source_pts_seconds) {
 
-       } else if (_subtitle_stream >= 0 && _packet.stream_index == _subtitle_stream) {
+                               if (!_first_audio) {
+                                       _first_audio = source_pts_seconds;
+                                       
+                                       /* This is our first audio frame, and if we've arrived here we must have had our
+                                          first video frame.  Push some silence to make up any gap between our first
+                                          video frame and our first audio.
+                                       */
+                       
+                                       /* frames of silence that we must push */
+                                       int const s = rint ((_first_audio.get() - _first_video.get()) * audio_sample_rate ());
+                                       
+                                       _film->log()->log (
+                                               String::compose (
+                                                       "First video at %1, first audio at %2, pushing %3 frames of silence for %4 channels (%5 bytes per sample)",
+                                                       _first_video.get(), _first_audio.get(), s, audio_channels(), bytes_per_audio_sample()
+                                                       )
+                                               );
+                                       
+                                       if (s) {
+                                               /* hence bytes */
+                                               int const b = s * audio_channels() * bytes_per_audio_sample();
+                                               
+                                               /* XXX: this assumes that it won't be too much, and there are shaky assumptions
+                                                  that all sound representations are silent with memset()ed zero data.
+                                               */
+                                               uint8_t silence[b];
+                                               memset (silence, 0, b);
+                                               process_audio (silence, b);
+                                       }
+                               }
 
-               if (_have_subtitle) {
-                       avsubtitle_free (&_subtitle);
-                       _have_subtitle = false;
+                               int const data_size = av_samples_get_buffer_size (
+                                       0, _audio_codec_context->channels, _frame->nb_samples, audio_sample_format (), 1
+                                       );
+                               
+                               assert (_audio_codec_context->channels == _film->audio_channels());
+                               process_audio (_frame->data[0], data_size);
+                       }
                }
+                       
+       } else if (_subtitle_stream >= 0 && _packet.stream_index == _subtitle_stream && _opt->decode_subtitles && _first_video) {
 
                int got_subtitle;
-               if (avcodec_decode_subtitle2 (_subtitle_codec_context, &_subtitle, &got_subtitle, &_packet) && got_subtitle) {
-                       cout << "got a subtitle.\n";
-                       _have_subtitle = true;
+               AVSubtitle sub;
+               if (avcodec_decode_subtitle2 (_subtitle_codec_context, &sub, &got_subtitle, &_packet) && got_subtitle) {
+                       /* Sometimes we get an empty AVSubtitle, which is used by some codecs to
+                          indicate that the previous subtitle should stop.
+                       */
+                       if (sub.num_rects > 0) {
+                               process_subtitle (shared_ptr<TimedSubtitle> (new TimedSubtitle (sub, _first_video.get())));
+                       } else {
+                               process_subtitle (shared_ptr<TimedSubtitle> ());
+                       }
+                       avsubtitle_free (&sub);
                }
        }
        
@@ -344,16 +383,16 @@ FFmpegDecoder::do_pass ()
        return false;
 }
 
-int
-FFmpegDecoder::length_in_frames () const
-{
-       return (_format_context->duration / AV_TIME_BASE) * frames_per_second ();
-}
-
 float
 FFmpegDecoder::frames_per_second () const
 {
-       return av_q2d (_format_context->streams[_video_stream]->avg_frame_rate);
+       AVStream* s = _format_context->streams[_video_stream];
+
+       if (s->avg_frame_rate.num && s->avg_frame_rate.den) {
+               return av_q2d (s->avg_frame_rate);
+       }
+
+       return av_q2d (s->r_frame_rate);
 }
 
 int
@@ -432,3 +471,46 @@ FFmpegDecoder::sample_aspect_ratio_denominator () const
        return _video_codec_context->sample_aspect_ratio.den;
 }
 
+bool
+FFmpegDecoder::has_subtitles () const
+{
+       return (_subtitle_stream != -1);
+}
+
+vector<AudioStream>
+FFmpegDecoder::audio_streams () const
+{
+       return _audio_streams;
+}
+
+vector<SubtitleStream>
+FFmpegDecoder::subtitle_streams () const
+{
+       return _subtitle_streams;
+}
+
+string
+FFmpegDecoder::stream_name (AVStream* s) const
+{
+       stringstream n;
+       
+       AVDictionaryEntry const * lang = av_dict_get (s->metadata, "language", 0, 0);
+       if (lang) {
+               n << lang->value;
+       }
+       
+       AVDictionaryEntry const * title = av_dict_get (s->metadata, "title", 0, 0);
+       if (title) {
+               if (!n.str().empty()) {
+                       n << " ";
+               }
+               n << title->value;
+       }
+
+       if (n.str().empty()) {
+               n << "unknown";
+       }
+
+       return n.str ();
+}
+