Remove believed-unnecessary film state mutexes.
[dcpomatic.git] / src / lib / ffmpeg_decoder.cc
index 201fac8aa5a74dabd82ee4e3b577de4b9e239cd1..ede724b5f26e9d03fdb85223a8a05985c89ceeb8 100644 (file)
@@ -42,6 +42,7 @@ extern "C" {
 #include "ffmpeg_decoder.h"
 #include "filter_graph.h"
 #include "audio_buffers.h"
+#include "ffmpeg_content.h"
 
 #include "i18n.h"
 
@@ -59,7 +60,7 @@ using libdcp::Size;
 
 FFmpegDecoder::FFmpegDecoder (shared_ptr<const Film> f, shared_ptr<const FFmpegContent> c, bool video, bool audio)
        : Decoder (f)
-       , VideoDecoder (f)
+       , VideoDecoder (f, c)
        , AudioDecoder (f)
        , SubtitleDecoder (f)
        , FFmpeg (c)
@@ -120,7 +121,30 @@ FFmpegDecoder::~FFmpegDecoder ()
        if (_subtitle_codec_context) {
                avcodec_close (_subtitle_codec_context);
        }
-}      
+}
+
+void
+FFmpegDecoder::flush ()
+{
+       /* Get any remaining frames */
+       
+       _packet.data = 0;
+       _packet.size = 0;
+       
+       /* XXX: should we reset _packet.data and size after each *_decode_* call? */
+       
+       if (_decode_video) {
+               while (decode_video_packet ()) {}
+       }
+       
+       if (_ffmpeg_content->audio_stream() && _decode_audio) {
+               decode_audio_packet ();
+       }
+
+       /* Stop us being asked for any more data */
+       _video_position = _ffmpeg_content->video_length ();
+       _audio_position = _ffmpeg_content->audio_length ();
+}
 
 void
 FFmpegDecoder::pass ()
@@ -137,34 +161,20 @@ FFmpegDecoder::pass ()
                        film->log()->log (String::compose (N_("error on av_read_frame (%1) (%2)"), buf, r));
                }
 
-               /* Get any remaining frames */
-               
-               _packet.data = 0;
-               _packet.size = 0;
-               
-               /* XXX: should we reset _packet.data and size after each *_decode_* call? */
-               
-               if (_decode_video) {
-                       while (decode_video_packet ()) {}
-               }
-
-               if (_ffmpeg_content->audio_stream() && _decode_audio) {
-                       decode_audio_packet ();
-               }
-
-               /* Stop us being asked for any more data */
-               _video_position = _ffmpeg_content->video_length ();
-               _audio_position = _ffmpeg_content->audio_length ();
+               flush ();
                return;
        }
 
        avcodec_get_frame_defaults (_frame);
 
+       shared_ptr<const Film> film = _film.lock ();
+       assert (film);
+       
        if (_packet.stream_index == _video_stream && _decode_video) {
                decode_video_packet ();
        } else if (_ffmpeg_content->audio_stream() && _packet.stream_index == _ffmpeg_content->audio_stream()->id && _decode_audio) {
                decode_audio_packet ();
-       } else if (_ffmpeg_content->subtitle_stream() && _packet.stream_index == _ffmpeg_content->subtitle_stream()->id) {
+       } else if (_ffmpeg_content->subtitle_stream() && _packet.stream_index == _ffmpeg_content->subtitle_stream()->id && film->with_subtitles ()) {
                decode_subtitle_packet ();
        }
 
@@ -293,6 +303,7 @@ FFmpegDecoder::seek (VideoContent::Frame frame, bool accurate)
           will hopefully then step through to where we want to be.
        */
        int initial = frame;
+
        if (accurate) {
                initial -= 5;
        }
@@ -303,8 +314,6 @@ FFmpegDecoder::seek (VideoContent::Frame frame, bool accurate)
 
        /* Initial seek time in the stream's timebase */
        int64_t const initial_vt = ((initial / _ffmpeg_content->video_frame_rate()) - _video_pts_offset) / time_base;
-       /* Wanted final seek time in the stream's timebase */
-       int64_t const final_vt = ((frame / _ffmpeg_content->video_frame_rate()) - _video_pts_offset) / time_base;
 
        av_seek_frame (_format_context, _video_stream, initial_vt, AVSEEK_FLAG_BACKWARD);
 
@@ -314,38 +323,39 @@ FFmpegDecoder::seek (VideoContent::Frame frame, bool accurate)
        }
 
        _just_sought = true;
-
-       if (frame == 0) {
-               /* We're already there; from here on we can only seek non-zero amounts */
+       _video_position = frame;
+       
+       if (frame == 0 || !accurate) {
+               /* We're already there, or we're as close as we need to be */
                return;
        }
 
-       if (accurate) {
-               while (1) {
-                       int r = av_read_frame (_format_context, &_packet);
-                       if (r < 0) {
-                               return;
-                       }
-                       
-                       avcodec_get_frame_defaults (_frame);
-                       
-                       if (_packet.stream_index == _video_stream) {
-                               int finished = 0;
-                               int const r = avcodec_decode_video2 (video_codec_context(), _frame, &finished, &_packet);
-                               if (r >= 0 && finished) {
-                                       int64_t const bet = av_frame_get_best_effort_timestamp (_frame);
-                                       if (bet >= final_vt) {
-                                               _video_position = rint (
-                                                       (bet * time_base + _video_pts_offset) * _ffmpeg_content->video_frame_rate()
-                                                       );
-                                               av_free_packet (&_packet);
-                                               break;
-                                       }
-                               }
+       while (1) {
+               int r = av_read_frame (_format_context, &_packet);
+               if (r < 0) {
+                       return;
+               }
+
+               if (_packet.stream_index != _video_stream) {
+                       continue;
+               }
+               
+               avcodec_get_frame_defaults (_frame);
+               
+               int finished = 0;
+               r = avcodec_decode_video2 (video_codec_context(), _frame, &finished, &_packet);
+               if (r >= 0 && finished) {
+                       _video_position = rint (
+                               (av_frame_get_best_effort_timestamp (_frame) * time_base + _video_pts_offset) * _ffmpeg_content->video_frame_rate()
+                               );
+
+                       if (_video_position >= (frame - 1)) {
+                               av_free_packet (&_packet);
+                               break;
                        }
-                       
-                       av_free_packet (&_packet);
                }
+               
+               av_free_packet (&_packet);
        }
 }
 
@@ -357,37 +367,48 @@ FFmpegDecoder::decode_audio_packet ()
        */
        
        AVPacket copy_packet = _packet;
-
+       
        while (copy_packet.size > 0) {
 
                int frame_finished;
                int const decode_result = avcodec_decode_audio4 (audio_codec_context(), _frame, &frame_finished, &copy_packet);
-               if (decode_result >= 0) {
-                       if (frame_finished) {
-
-                               if (_audio_position == 0) {
-                                       /* Where we are in the source, in seconds */
-                                       double const pts = av_q2d (_format_context->streams[copy_packet.stream_index]->time_base)
-                                               * av_frame_get_best_effort_timestamp(_frame) + _audio_pts_offset;
-
-                                       if (pts > 0) {
-                                               /* Emit some silence */
-                                               shared_ptr<AudioBuffers> silence (
-                                                       new AudioBuffers (
-                                                               _ffmpeg_content->audio_channels(),
-                                                               pts * _ffmpeg_content->content_audio_frame_rate()
-                                                               )
-                                                       );
-                                               
-                                               silence->make_silent ();
-                                               audio (silence, _audio_position);
-                                       }
-                               }
+               if (decode_result < 0) {
+                       shared_ptr<const Film> film = _film.lock ();
+                       assert (film);
+                       film->log()->log (String::compose ("avcodec_decode_audio4 failed (%1)", decode_result));
+                       return;
+               }
+
+               if (frame_finished) {
+                       
+                       if (_audio_position == 0) {
+                               /* Where we are in the source, in seconds */
+                               double const pts = av_q2d (_format_context->streams[copy_packet.stream_index]->time_base)
+                                       * av_frame_get_best_effort_timestamp(_frame) + _audio_pts_offset;
+                               
+                               if (pts > 0) {
+                                       /* Emit some silence */
+                                       shared_ptr<AudioBuffers> silence (
+                                               new AudioBuffers (
+                                                       _ffmpeg_content->audio_channels(),
+                                                       pts * _ffmpeg_content->content_audio_frame_rate()
+                                                       )
+                                               );
                                        
-                               copy_packet.data += decode_result;
-                               copy_packet.size -= decode_result;
+                                       silence->make_silent ();
+                                       audio (silence, _audio_position);
+                               }
                        }
+                       
+                       int const data_size = av_samples_get_buffer_size (
+                               0, audio_codec_context()->channels, _frame->nb_samples, audio_sample_format (), 1
+                               );
+                       
+                       audio (deinterleave_audio (_frame->data, data_size), _audio_position);
                }
+                       
+               copy_packet.data += decode_result;
+               copy_packet.size -= decode_result;
        }
 }
 
@@ -451,6 +472,8 @@ FFmpegDecoder::decode_video_packet ()
                                /* This PTS is more than one frame forward in time of where we think we should be; emit
                                   a black frame.
                                */
+
+                               /* XXX: I think this should be a copy of the last frame... */
                                boost::shared_ptr<Image> black (
                                        new Image (
                                                static_cast<AVPixelFormat> (_frame->format),