/*
- Copyright (C) 2014-2015 Carl Hetherington <cth@carlh.net>
+ Copyright (C) 2014-2021 Carl Hetherington <cth@carlh.net>
This file is part of DCP-o-matic.
*/
+
#include "update_checker.h"
#include "version.h"
#include "util.h"
#include <string>
#include <iostream>
+
#define BUFFER_SIZE 1024
+
using std::cout;
using std::min;
using std::string;
using boost::ends_with;
using dcp::raw_convert;
+
/** Singleton instance */
-UpdateChecker* UpdateChecker::_instance = 0;
+UpdateChecker* UpdateChecker::_instance = nullptr;
+
static size_t
write_callback_wrapper (void* data, size_t size, size_t nmemb, void* user)
return reinterpret_cast<UpdateChecker*>(user)->write_callback (data, size, nmemb);
}
+
/** Construct an UpdateChecker. This sets things up and starts a thread to
* do the work.
*/
UpdateChecker::UpdateChecker ()
- : _buffer (new char[BUFFER_SIZE])
- , _offset (0)
- , _curl (0)
- , _state (NOT_RUN)
- , _emits (0)
- , _thread (0)
- , _to_do (0)
- , _terminate (false)
+ : _buffer (BUFFER_SIZE)
+ , _state (State::NOT_RUN)
{
_curl = curl_easy_init ();
- curl_easy_setopt (_curl, CURLOPT_URL, "http://dcpomatic.com/update");
+ curl_easy_setopt (_curl, CURLOPT_URL, "https://dcpomatic.com/update");
curl_easy_setopt (_curl, CURLOPT_WRITEFUNCTION, write_callback_wrapper);
curl_easy_setopt (_curl, CURLOPT_WRITEDATA, this);
curl_easy_setopt (_curl, CURLOPT_TIMEOUT, 20);
+ curl_easy_setopt (_curl, CURLOPT_NOSIGNAL, 1L);
string const agent = "dcpomatic/" + string (dcpomatic_version);
curl_easy_setopt (_curl, CURLOPT_USERAGENT, agent.c_str ());
}
+
void
UpdateChecker::start ()
{
- _thread = new boost::thread (boost::bind (&UpdateChecker::thread, this));
+ _thread = boost::thread (boost::bind (&UpdateChecker::thread, this));
#ifdef DCPOMATIC_LINUX
- pthread_setname_np (_thread->native_handle(), "update-checker");
+ pthread_setname_np (_thread.native_handle(), "update-checker");
#endif
}
+
UpdateChecker::~UpdateChecker ()
{
+ boost::this_thread::disable_interruption dis;
+
{
boost::mutex::scoped_lock lm (_process_mutex);
_terminate = true;
}
_condition.notify_all ();
- if (_thread) {
- /* Ideally this would be a DCPOMATIC_ASSERT(_thread->joinable()) but we
- can't throw exceptions from a destructor.
- */
- if (_thread->joinable ()) {
- _thread->join ();
- }
- }
- delete _thread;
+ try {
+ _thread.join ();
+ } catch (...) {}
curl_easy_cleanup (_curl);
- delete[] _buffer;
}
+
/** Start running the update check */
void
UpdateChecker::run ()
_condition.notify_one ();
}
+
void
UpdateChecker::thread ()
{
int r = curl_easy_perform (_curl);
if (r != CURLE_OK) {
- set_state (FAILED);
- return;
+ set_state (State::FAILED);
+ continue;
}
/* Parse the reply */
_buffer[_offset] = '\0';
- string s (_buffer);
+ string s (_buffer.data());
cxml::Document doc ("Update");
doc.read_string (s);
}
if (_stable || _test) {
- set_state (YES);
+ set_state (State::YES);
} else {
- set_state (NO);
+ set_state (State::NO);
}
} catch (...) {
- set_state (FAILED);
+ set_state (State::FAILED);
}
}
}
+
size_t
UpdateChecker::write_callback (void* data, size_t size, size_t nmemb)
{
size_t const t = min (size * nmemb, size_t (BUFFER_SIZE - _offset - 1));
- memcpy (_buffer + _offset, data, t);
+ memcpy (_buffer.data() + _offset, data, t);
_offset += t;
return t;
}
+
void
UpdateChecker::set_state (State s)
{
{
boost::mutex::scoped_lock lm (_data_mutex);
_state = s;
- _emits++;
}
- emit (boost::bind (boost::ref (StateChanged)));
+ emit (boost::bind(boost::ref(StateChanged)));
}
+
UpdateChecker *
UpdateChecker::instance ()
{
return _instance;
}
+
bool
UpdateChecker::version_less_than (string const & a, string const & b)
{
DCPOMATIC_ASSERT (ap.size() == 3 && bp.size() == 3);
if (ap[0] != bp[0]) {
- return raw_convert<int> (ap[0]) < raw_convert<int> (bp[0]);
+ return raw_convert<int>(ap[0]) < raw_convert<int>(bp[0]);
}
if (ap[1] != bp[1]) {
- return raw_convert<int> (ap[1]) < raw_convert<int> (bp[1]);
+ return raw_convert<int>(ap[1]) < raw_convert<int>(bp[1]);
}
float am;
if (ends_with (ap[2], "devel")) {
- am = raw_convert<int> (ap[2].substr (0, ap[2].length() - 5)) + 0.5;
+ am = raw_convert<int>(ap[2].substr(0, ap[2].length() - 5)) + 0.5;
} else {
- am = raw_convert<int> (ap[2]);
+ am = raw_convert<int>(ap[2]);
}
float bm;
if (ends_with (bp[2], "devel")) {
- bm = raw_convert<int> (bp[2].substr (0, bp[2].length() - 5)) + 0.5;
+ bm = raw_convert<int>(bp[2].substr(0, bp[2].length() - 5)) + 0.5;
} else {
- bm = raw_convert<int> (bp[2]);
+ bm = raw_convert<int>(bp[2]);
}
return am < bm;