Fix some coverity-reported stuff.
[dcpomatic.git] / src / wx / timeline.cc
index e3eca8a1d4f31efab0aac1af38a89b5100ad5156..4e306c4998a526081e4629f79c03ba5d4fcaa63d 100644 (file)
@@ -25,7 +25,6 @@
 #include "film_editor.h"
 #include "timeline.h"
 #include "wx_util.h"
-#include "repeat_dialog.h"
 
 using std::list;
 using std::cout;
@@ -34,7 +33,9 @@ using boost::shared_ptr;
 using boost::weak_ptr;
 using boost::dynamic_pointer_cast;
 using boost::bind;
+using boost::optional;
 
+/** Parent class for components of the timeline (e.g. a piece of content or an axis) */
 class View : public boost::noncopyable
 {
 public:
@@ -43,6 +44,8 @@ public:
        {
 
        }
+
+       virtual ~View () {}
                
        void paint (wxGraphicsContext* g)
        {
@@ -72,29 +75,32 @@ private:
        dcpomatic::Rect<int> _last_paint_bbox;
 };
 
+
+/** Parent class for views of pieces of content */
 class ContentView : public View
 {
 public:
-       ContentView (Timeline& tl, shared_ptr<Content> c, int t)
+       ContentView (Timeline& tl, shared_ptr<Content> c)
                : View (tl)
                , _content (c)
-               , _track (t)
+               , _track (0)
                , _selected (false)
        {
-               _content_connection = c->Changed.connect (bind (&ContentView::content_changed, this, _2));
+               _content_connection = c->Changed.connect (bind (&ContentView::content_changed, this, _2, _3));
        }
 
        dcpomatic::Rect<int> bbox () const
        {
                shared_ptr<const Film> film = _timeline.film ();
-               if (!film) {
+               shared_ptr<const Content> content = _content.lock ();
+               if (!film || !content) {
                        return dcpomatic::Rect<int> ();
                }
                
                return dcpomatic::Rect<int> (
-                       time_x (_content->start ()) - 8,
+                       time_x (content->position ()) - 8,
                        y_pos (_track) - 8,
-                       _content->length () * _timeline.pixels_per_time_unit() + 16,
+                       content->length_after_trim () * _timeline.pixels_per_time_unit() + 16,
                        _timeline.track_height() + 16
                        );
        }
@@ -109,7 +115,7 @@ public:
        }
 
        shared_ptr<Content> content () const {
-               return _content;
+               return _content.lock ();
        }
 
        void set_track (int t) {
@@ -128,12 +134,13 @@ private:
        void do_paint (wxGraphicsContext* gc)
        {
                shared_ptr<const Film> film = _timeline.film ();
-               if (!film) {
+               shared_ptr<const Content> cont = content ();
+               if (!film || !cont) {
                        return;
                }
 
-               Time const start = _content->start ();
-               Time const len = _content->length ();
+               Time const position = cont->position ();
+               Time const len = cont->length_after_trim ();
 
                wxColour selected (colour().Red() / 2, colour().Green() / 2, colour().Blue() / 2);
 
@@ -147,23 +154,23 @@ private:
                }
 
                wxGraphicsPath path = gc->CreatePath ();
-               path.MoveToPoint    (time_x (start),       y_pos (_track) + 4);
-               path.AddLineToPoint (time_x (start + len), y_pos (_track) + 4);
-               path.AddLineToPoint (time_x (start + len), y_pos (_track + 1) - 4);
-               path.AddLineToPoint (time_x (start),       y_pos (_track + 1) - 4);
-               path.AddLineToPoint (time_x (start),       y_pos (_track) + 4);
+               path.MoveToPoint    (time_x (position),       y_pos (_track) + 4);
+               path.AddLineToPoint (time_x (position + len), y_pos (_track) + 4);
+               path.AddLineToPoint (time_x (position + len), y_pos (_track + 1) - 4);
+               path.AddLineToPoint (time_x (position),       y_pos (_track + 1) - 4);
+               path.AddLineToPoint (time_x (position),       y_pos (_track) + 4);
                gc->StrokePath (path);
                gc->FillPath (path);
 
-               wxString name = wxString::Format (wxT ("%s [%s]"), std_to_wx (_content->file().filename().string()).data(), type().data());
+               wxString name = wxString::Format (wxT ("%s [%s]"), std_to_wx (cont->path_summary()).data(), type().data());
                wxDouble name_width;
                wxDouble name_height;
                wxDouble name_descent;
                wxDouble name_leading;
                gc->GetTextExtent (name, &name_width, &name_height, &name_descent, &name_leading);
                
-               gc->Clip (wxRegion (time_x (start), y_pos (_track), len * _timeline.pixels_per_time_unit(), _timeline.track_height()));
-               gc->DrawText (name, time_x (start) + 12, y_pos (_track + 1) - name_height - 4);
+               gc->Clip (wxRegion (time_x (position), y_pos (_track), len * _timeline.pixels_per_time_unit(), _timeline.track_height()));
+               gc->DrawText (name, time_x (position) + 12, y_pos (_track + 1) - name_height - 4);
                gc->ResetClip ();
        }
 
@@ -172,18 +179,21 @@ private:
                return _timeline.tracks_position().y + t * _timeline.track_height();
        }
 
-       void content_changed (int p)
+       void content_changed (int p, bool frequent)
        {
-               if (p == ContentProperty::START || p == ContentProperty::LENGTH) {
+               ensure_ui_thread ();
+               
+               if (p == ContentProperty::POSITION || p == ContentProperty::LENGTH) {
                        force_redraw ();
                }
+
+               if (!frequent) {
+                       _timeline.setup_pixels_per_time_unit ();
+                       _timeline.Refresh ();
+               }
        }
 
-       /* This must be a shared_ptr, not a weak_ptr, as in the looped case this
-          will be the only remaining pointer to the looped content that we get
-          from the playlist.
-       */
-       boost::shared_ptr<Content> _content;
+       boost::weak_ptr<Content> _content;
        int _track;
        bool _selected;
 
@@ -193,8 +203,8 @@ private:
 class AudioContentView : public ContentView
 {
 public:
-       AudioContentView (Timeline& tl, shared_ptr<Content> c, int t)
-               : ContentView (tl, c, t)
+       AudioContentView (Timeline& tl, shared_ptr<Content> c)
+               : ContentView (tl, c)
        {}
        
 private:
@@ -212,8 +222,8 @@ private:
 class VideoContentView : public ContentView
 {
 public:
-       VideoContentView (Timeline& tl, shared_ptr<Content> c, int t)
-               : ContentView (tl, c, t)
+       VideoContentView (Timeline& tl, shared_ptr<Content> c)
+               : ContentView (tl, c)
        {}
 
 private:       
@@ -315,9 +325,6 @@ private:
        int _y;
 };
 
-enum {
-       ID_repeat
-};
 
 Timeline::Timeline (wxWindow* parent, FilmEditor* ed, shared_ptr<Film> film)
        : wxPanel (parent, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxFULL_REPAINT_ON_RESIZE)
@@ -327,21 +334,21 @@ Timeline::Timeline (wxWindow* parent, FilmEditor* ed, shared_ptr<Film> film)
        , _tracks (0)
        , _pixels_per_time_unit (0)
        , _left_down (false)
-       , _down_view_start (0)
+       , _down_view_position (0)
        , _first_move (false)
-       , _menu (0)
+       , _menu (this)
+       , _snap (true)
 {
 #ifndef __WXOSX__
        SetDoubleBuffered (true);
 #endif 
 
-       Connect (wxID_ANY, wxEVT_PAINT, wxPaintEventHandler (Timeline::paint), 0, this);
-       Connect (wxID_ANY, wxEVT_LEFT_DOWN, wxMouseEventHandler (Timeline::left_down), 0, this);
-       Connect (wxID_ANY, wxEVT_LEFT_UP, wxMouseEventHandler (Timeline::left_up), 0, this);
-       Connect (wxID_ANY, wxEVT_RIGHT_DOWN, wxMouseEventHandler (Timeline::right_down), 0, this);
-       Connect (wxID_ANY, wxEVT_MOTION, wxMouseEventHandler (Timeline::mouse_moved), 0, this);
-       Connect (wxID_ANY, wxEVT_SIZE, wxSizeEventHandler (Timeline::resized), 0, this);
-       Connect (ID_repeat, wxEVT_COMMAND_MENU_SELECTED, wxCommandEventHandler (Timeline::repeat), 0, this);
+       Bind (wxEVT_PAINT,      boost::bind (&Timeline::paint,       this));
+       Bind (wxEVT_LEFT_DOWN,  boost::bind (&Timeline::left_down,   this, _1));
+       Bind (wxEVT_LEFT_UP,    boost::bind (&Timeline::left_up,     this, _1));
+       Bind (wxEVT_RIGHT_DOWN, boost::bind (&Timeline::right_down,  this, _1));
+       Bind (wxEVT_MOTION,     boost::bind (&Timeline::mouse_moved, this, _1));
+       Bind (wxEVT_SIZE,       boost::bind (&Timeline::resized,     this));
 
        playlist_changed ();
 
@@ -351,7 +358,7 @@ Timeline::Timeline (wxWindow* parent, FilmEditor* ed, shared_ptr<Film> film)
 }
 
 void
-Timeline::paint (wxPaintEvent &)
+Timeline::paint ()
 {
        wxPaintDC dc (this);
 
@@ -362,7 +369,7 @@ Timeline::paint (wxPaintEvent &)
 
        gc->SetFont (gc->CreateFont (*wxNORMAL_FONT));
 
-       for (list<shared_ptr<View> >::iterator i = _views.begin(); i != _views.end(); ++i) {
+       for (ViewList::iterator i = _views.begin(); i != _views.end(); ++i) {
                (*i)->paint (gc);
        }
 
@@ -372,6 +379,8 @@ Timeline::paint (wxPaintEvent &)
 void
 Timeline::playlist_changed ()
 {
+       ensure_ui_thread ();
+       
        shared_ptr<const Film> fl = _film.lock ();
        if (!fl) {
                return;
@@ -380,14 +389,14 @@ Timeline::playlist_changed ()
        _views.clear ();
        _views.push_back (_time_axis_view);
 
-       Playlist::ContentList content = fl->playlist()->content ();
+       ContentList content = fl->playlist()->content ();
 
-       for (Playlist::ContentList::iterator i = content.begin(); i != content.end(); ++i) {
+       for (ContentList::iterator i = content.begin(); i != content.end(); ++i) {
                if (dynamic_pointer_cast<VideoContent> (*i)) {
-                       _views.push_back (shared_ptr<View> (new VideoContentView (*this, *i, 0)));
+                       _views.push_back (shared_ptr<View> (new VideoContentView (*this, *i)));
                }
                if (dynamic_pointer_cast<AudioContent> (*i)) {
-                       _views.push_back (shared_ptr<View> (new AudioContentView (*this, *i, 0)));
+                       _views.push_back (shared_ptr<View> (new AudioContentView (*this, *i)));
                }
        }
 
@@ -399,7 +408,7 @@ Timeline::playlist_changed ()
 void
 Timeline::assign_tracks ()
 {
-       for (list<shared_ptr<View> >::iterator i = _views.begin(); i != _views.end(); ++i) {
+       for (ViewList::iterator i = _views.begin(); i != _views.end(); ++i) {
                shared_ptr<ContentView> cv = dynamic_pointer_cast<ContentView> (*i);
                if (cv) {
                        cv->set_track (0);
@@ -407,17 +416,17 @@ Timeline::assign_tracks ()
                }
        }
 
-       for (list<shared_ptr<View> >::iterator i = _views.begin(); i != _views.end(); ++i) {
+       for (ViewList::iterator i = _views.begin(); i != _views.end(); ++i) {
                shared_ptr<AudioContentView> acv = dynamic_pointer_cast<AudioContentView> (*i);
                if (!acv) {
                        continue;
                }
        
                shared_ptr<Content> acv_content = acv->content();
-               
+
                int t = 1;
                while (1) {
-                       list<shared_ptr<View> >::iterator j = _views.begin();
+                       ViewList::iterator j = _views.begin();
                        while (j != _views.end()) {
                                shared_ptr<AudioContentView> test = dynamic_pointer_cast<AudioContentView> (*j);
                                if (!test) {
@@ -428,8 +437,11 @@ Timeline::assign_tracks ()
                                shared_ptr<Content> test_content = test->content();
                                        
                                if (test && test->track() == t) {
-                                       if ((acv_content->start() < test_content->start() && test_content->start() < acv_content->end()) ||
-                                           (acv_content->start() < test_content->end()   && test_content->end()   < acv_content->end())) {
+                                       bool const no_overlap =
+                                               (acv_content->position() < test_content->position() && acv_content->end() < test_content->position()) ||
+                                               (acv_content->position() > test_content->end()      && acv_content->end() > test_content->end());
+                                       
+                                       if (!no_overlap) {
                                                /* we have an overlap on track `t' */
                                                ++t;
                                                break;
@@ -462,7 +474,7 @@ void
 Timeline::setup_pixels_per_time_unit ()
 {
        shared_ptr<const Film> film = _film.lock ();
-       if (!film) {
+       if (!film || film->length() == 0) {
                return;
        }
 
@@ -472,7 +484,7 @@ Timeline::setup_pixels_per_time_unit ()
 shared_ptr<View>
 Timeline::event_to_view (wxMouseEvent& ev)
 {
-       list<shared_ptr<View> >::iterator i = _views.begin();
+       ViewList::iterator i = _views.begin();
        Position<int> const p (ev.GetX(), ev.GetY());
        while (i != _views.end() && !(*i)->bbox().contains (p)) {
                ++i;
@@ -489,25 +501,32 @@ void
 Timeline::left_down (wxMouseEvent& ev)
 {
        shared_ptr<View> view = event_to_view (ev);
+       shared_ptr<ContentView> content_view = dynamic_pointer_cast<ContentView> (view);
 
        _down_view.reset ();
 
-       if (view) {
-               shared_ptr<ContentView> cv = dynamic_pointer_cast<ContentView> (view);
-               if (cv) {
-                       _down_view = cv;
-                       _down_view_start = cv->content()->start ();
-               }
+       if (content_view) {
+               _down_view = content_view;
+               _down_view_position = content_view->content()->position ();
        }
 
-       for (list<shared_ptr<View> >::iterator i = _views.begin(); i != _views.end(); ++i) {
+       for (ViewList::iterator i = _views.begin(); i != _views.end(); ++i) {
                shared_ptr<ContentView> cv = dynamic_pointer_cast<ContentView> (*i);
-               if (cv) {
+               if (!cv) {
+                       continue;
+               }
+               
+               if (!ev.ShiftDown ()) {
                        cv->set_selected (view == *i);
-                       if (view == *i) {
-                               _film_editor->set_selection (cv->content ());
-                       }
                }
+               
+               if (view == *i) {
+                       _film_editor->set_selection (cv->content ());
+               }
+       }
+
+       if (content_view && ev.ShiftDown ()) {
+               content_view->set_selected (!content_view->selected ());
        }
 
        _left_down = true;
@@ -528,7 +547,7 @@ Timeline::left_up (wxMouseEvent& ev)
                _down_view->content()->set_change_signals_frequent (false);
        }
 
-       set_start_from_event (ev);
+       set_position_from_event (ev);
 }
 
 void
@@ -538,7 +557,7 @@ Timeline::mouse_moved (wxMouseEvent& ev)
                return;
        }
 
-       set_start_from_event (ev);
+       set_position_from_event (ev);
 }
 
 void
@@ -555,20 +574,18 @@ Timeline::right_down (wxMouseEvent& ev)
                cv->set_selected (true);
        }
 
-       if (!_menu) {
-               _menu = new wxMenu;
-               _menu->Append (ID_repeat, _("Repeat..."));
-       }
-
-       PopupMenu (_menu, ev.GetPosition ());
+       _menu.popup (_film, selected_content (), ev.GetPosition ());
 }
 
 void
-Timeline::set_start_from_event (wxMouseEvent& ev)
+Timeline::set_position_from_event (wxMouseEvent& ev)
 {
        wxPoint const p = ev.GetPosition();
 
        if (!_first_move) {
+               /* We haven't moved yet; in that case, we must move the mouse some reasonable distance
+                  before the drag is considered to have started.
+               */
                int const dist = sqrt (pow (p.x - _down_point.x, 2) + pow (p.y - _down_point.y, 2));
                if (dist < 8) {
                        return;
@@ -576,14 +593,63 @@ Timeline::set_start_from_event (wxMouseEvent& ev)
                _first_move = true;
        }
 
-       Time const time_diff = (p.x - _down_point.x) / _pixels_per_time_unit;
-       if (_down_view) {
-               _down_view->content()->set_start (max (static_cast<Time> (0), _down_view_start + time_diff));
-
-               shared_ptr<Film> film = _film.lock ();
-               assert (film);
-               film->set_sequence_video (false);
+       if (!_down_view) {
+               return;
        }
+       
+       Time new_position = _down_view_position + (p.x - _down_point.x) / _pixels_per_time_unit;
+       
+       if (_snap) {
+               
+               bool first = true;
+               Time nearest_distance = TIME_MAX;
+               Time nearest_new_position = TIME_MAX;
+               
+               /* Find the nearest content edge; this is inefficient */
+               for (ViewList::iterator i = _views.begin(); i != _views.end(); ++i) {
+                       shared_ptr<ContentView> cv = dynamic_pointer_cast<ContentView> (*i);
+                       if (!cv || cv == _down_view) {
+                               continue;
+                       }
+                       
+                       {
+                               /* Snap starts to ends */
+                               Time const d = abs (cv->content()->end() - new_position);
+                               if (first || d < nearest_distance) {
+                                       nearest_distance = d;
+                                       nearest_new_position = cv->content()->end();
+                               }
+                       }
+                       
+                       {
+                               /* Snap ends to starts */
+                               Time const d = abs (cv->content()->position() - (new_position + _down_view->content()->length_after_trim()));
+                               if (d < nearest_distance) {
+                                       nearest_distance = d;
+                                       nearest_new_position = cv->content()->position() - _down_view->content()->length_after_trim ();
+                               }
+                       }
+                       
+                       first = false;
+               }
+               
+               if (!first) {
+                       /* Snap if it's close; `close' means within a proportion of the time on the timeline */
+                       if (nearest_distance < (width() / pixels_per_time_unit()) / 32) {
+                               new_position = nearest_new_position;
+                       }
+               }
+       }
+       
+       if (new_position < 0) {
+               new_position = 0;
+       }
+       
+       _down_view->content()->set_position (new_position);
+       
+       shared_ptr<Film> film = _film.lock ();
+       assert (film);
+       film->set_sequence_video (false);
 }
 
 void
@@ -599,7 +665,7 @@ Timeline::film () const
 }
 
 void
-Timeline::resized (wxSizeEvent &)
+Timeline::resized ()
 {
        setup_pixels_per_time_unit ();
 }
@@ -607,7 +673,7 @@ Timeline::resized (wxSizeEvent &)
 void
 Timeline::clear_selection ()
 {
-       for (list<shared_ptr<View> >::iterator i = _views.begin(); i != _views.end(); ++i) {
+       for (ViewList::iterator i = _views.begin(); i != _views.end(); ++i) {
                shared_ptr<ContentView> cv = dynamic_pointer_cast<ContentView> (*i);
                if (cv) {
                        cv->set_selected (false);
@@ -615,36 +681,30 @@ Timeline::clear_selection ()
        }
 }
 
-void
-Timeline::repeat (wxCommandEvent &)
+Timeline::ContentViewList
+Timeline::selected_views () const
 {
-       shared_ptr<ContentView> sel = selected ();
-       if (!sel) {
-               return;
-       }
-               
-       RepeatDialog d (this);
-       d.ShowModal ();
-
-       shared_ptr<const Film> film = _film.lock ();
-       if (!film) {
-               return;
+       ContentViewList sel;
+       
+       for (ViewList::const_iterator i = _views.begin(); i != _views.end(); ++i) {
+               shared_ptr<ContentView> cv = dynamic_pointer_cast<ContentView> (*i);
+               if (cv && cv->selected()) {
+                       sel.push_back (cv);
+               }
        }
 
-       film->playlist()->repeat (sel->content (), d.number ());
-       d.Destroy ();
+       return sel;
 }
 
-shared_ptr<ContentView>
-Timeline::selected () const
+ContentList
+Timeline::selected_content () const
 {
-       for (list<shared_ptr<View> >::const_iterator i = _views.begin(); i != _views.end(); ++i) {
-               shared_ptr<ContentView> cv = dynamic_pointer_cast<ContentView> (*i);
-               if (cv && cv->selected()) {
-                       return cv;
-               }
+       ContentList sel;
+       ContentViewList views = selected_views ();
+       
+       for (ContentViewList::const_iterator i = views.begin(); i != views.end(); ++i) {
+               sel.push_back ((*i)->content ());
        }
 
-       return shared_ptr<ContentView> ();
+       return sel;
 }
-