/*
- Copyright (C) 2015-2019 Carl Hetherington <cth@carlh.net>
+ Copyright (C) 2015-2020 Carl Hetherington <cth@carlh.net>
This file is part of DCP-o-matic.
using std::list;
using std::cout;
+using std::vector;
+using std::string;
using boost::shared_ptr;
+using boost::function;
using namespace dcpomatic;
/** Test Film::reels() */
}
film->set_reel_type (REELTYPE_BY_VIDEO_CONTENT);
+ BOOST_CHECK_EQUAL (film->reels().size(), 3);
BOOST_REQUIRE (!wait_for_jobs());
film->make_dcp ();
film->examine_and_add_content (B);
BOOST_REQUIRE (!wait_for_jobs ());
film->set_video_frame_rate (24);
- A->video->set_length (3 * 24);
+ A->video->set_length (2 * 24);
film->set_reel_type (REELTYPE_BY_VIDEO_CONTENT);
BOOST_REQUIRE_EQUAL (film->reels().size(), 2);
- BOOST_CHECK (film->reels().front() == DCPTimePeriod(DCPTime(0), DCPTime::from_frames(3 * 24, 24)));
- BOOST_CHECK (film->reels().back() == DCPTimePeriod(DCPTime::from_frames(3 * 24, 24), DCPTime::from_frames(3 * 24 + 1, 24)));
+ BOOST_CHECK (film->reels().front() == DCPTimePeriod(DCPTime(0), DCPTime::from_frames(2 * 24, 24)));
+ BOOST_CHECK (film->reels().back() == DCPTimePeriod(DCPTime::from_frames(2 * 24, 24), DCPTime::from_frames(3 * 24 + 1, 24)));
film->make_dcp ();
BOOST_REQUIRE (!wait_for_jobs ());
BOOST_CHECK_EQUAL (r.back().from.get(), DCPTime::from_seconds(1).get());
BOOST_CHECK_EQUAL (r.back().to.get(), DCPTime::from_seconds(1 + 10).get());
}
+
+/** For VFs to work right we have to make separate reels for empty bits between
+ * video content.
+ */
+BOOST_AUTO_TEST_CASE (reels_test12)
+{
+ shared_ptr<Film> film = new_test_film2 ("reels_test12");
+ film->set_video_frame_rate (24);
+ film->set_reel_type (REELTYPE_BY_VIDEO_CONTENT);
+ film->set_sequence (false);
+
+ shared_ptr<FFmpegContent> A(new FFmpegContent("test/data/flat_red.png"));
+ film->examine_and_add_content (A);
+ BOOST_REQUIRE (!wait_for_jobs());
+ A->video->set_length (240);
+ A->set_video_frame_rate (24);
+ A->set_position (film, DCPTime::from_seconds(1));
+
+ shared_ptr<FFmpegContent> B(new FFmpegContent("test/data/flat_red.png"));
+ film->examine_and_add_content (B);
+ BOOST_REQUIRE (!wait_for_jobs());
+ B->video->set_length (120);
+ B->set_video_frame_rate (24);
+ B->set_position (film, DCPTime::from_seconds(14));
+
+ list<DCPTimePeriod> r = film->reels ();
+ BOOST_REQUIRE_EQUAL (r.size(), 4);
+ list<DCPTimePeriod>::const_iterator i = r.begin ();
+
+ BOOST_CHECK_EQUAL (i->from.get(), 0);
+ BOOST_CHECK_EQUAL (i->to.get(), DCPTime::from_seconds(1).get());
+ ++i;
+ BOOST_CHECK_EQUAL (i->from.get(), DCPTime::from_seconds(1).get());
+ BOOST_CHECK_EQUAL (i->to.get(), DCPTime::from_seconds(11).get());
+ ++i;
+ BOOST_CHECK_EQUAL (i->from.get(), DCPTime::from_seconds(11).get());
+ BOOST_CHECK_EQUAL (i->to.get(), DCPTime::from_seconds(14).get());
+ ++i;
+ BOOST_CHECK_EQUAL (i->from.get(), DCPTime::from_seconds(14).get());
+ BOOST_CHECK_EQUAL (i->to.get(), DCPTime::from_seconds(19).get());
+}
+
+static void
+no_op ()
+{
+
+}
+
+static void
+dump_notes (list<dcp::VerificationNote> const & notes)
+{
+ BOOST_FOREACH (dcp::VerificationNote i, notes) {
+ std::cout << dcp::note_to_string(i) << "\n";
+ }
+}
+
+
+/** Using less than 1 second's worth of content should not result in a reel
+ * of less than 1 second's duration.
+ */
+BOOST_AUTO_TEST_CASE (reels_should_not_be_short1)
+{
+ shared_ptr<Film> film = new_test_film2 ("reels_should_not_be_short1");
+ film->set_video_frame_rate (24);
+
+ shared_ptr<FFmpegContent> A(new FFmpegContent("test/data/flat_red.png"));
+ film->examine_and_add_content (A);
+ BOOST_REQUIRE (!wait_for_jobs());
+ A->video->set_length (23);
+
+ shared_ptr<FFmpegContent> B(new FFmpegContent("test/data/flat_red.png"));
+ film->examine_and_add_content (B);
+ BOOST_REQUIRE (!wait_for_jobs());
+ B->video->set_length (23);
+ B->set_position (film, DCPTime::from_frames(23, 24));
+
+ film->make_dcp ();
+ BOOST_REQUIRE (!wait_for_jobs());
+
+ vector<boost::filesystem::path> dirs;
+ dirs.push_back (film->dir(film->dcp_name(false)));
+ list<dcp::VerificationNote> const notes = dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd);
+ dump_notes (notes);
+ BOOST_REQUIRE (notes.empty());
+}
+
+/** Leaving less than 1 second's gap between two pieces of content with
+ * REELTYPE_BY_VIDEO_CONTENT should not make a <1s reel.
+ */
+BOOST_AUTO_TEST_CASE (reels_should_not_be_short2)
+{
+ shared_ptr<Film> film = new_test_film2 ("reels_should_not_be_short2");
+ film->set_video_frame_rate (24);
+ film->set_reel_type (REELTYPE_BY_VIDEO_CONTENT);
+
+ shared_ptr<FFmpegContent> A(new FFmpegContent("test/data/flat_red.png"));
+ film->examine_and_add_content (A);
+ BOOST_REQUIRE (!wait_for_jobs());
+ A->video->set_length (240);
+
+ shared_ptr<FFmpegContent> B(new FFmpegContent("test/data/flat_red.png"));
+ film->examine_and_add_content (B);
+ BOOST_REQUIRE (!wait_for_jobs());
+ B->video->set_length (240);
+ B->set_position (film, DCPTime::from_seconds(10.2));
+
+ film->make_dcp ();
+ BOOST_REQUIRE (!wait_for_jobs());
+
+ vector<boost::filesystem::path> dirs;
+ dirs.push_back (film->dir(film->dcp_name(false)));
+ list<dcp::VerificationNote> const notes = dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd);
+ dump_notes (notes);
+ BOOST_REQUIRE (notes.empty());
+}
+
+/** Setting REELTYPE_BY_LENGTH and using a small length value should not make
+ * <1s reels.
+ */
+BOOST_AUTO_TEST_CASE (reels_should_not_be_short3)
+{
+ shared_ptr<Film> film = new_test_film2 ("reels_should_not_be_short3");
+ film->set_video_frame_rate (24);
+ film->set_reel_type (REELTYPE_BY_LENGTH);
+ film->set_reel_length (1024 * 1024 * 10);
+
+ shared_ptr<FFmpegContent> A(new FFmpegContent("test/data/flat_red.png"));
+ film->examine_and_add_content (A);
+ BOOST_REQUIRE (!wait_for_jobs());
+ A->video->set_length (240);
+
+ film->make_dcp ();
+ BOOST_REQUIRE (!wait_for_jobs());
+
+ vector<boost::filesystem::path> dirs;
+ list<dcp::VerificationNote> const notes = dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd);
+ dump_notes (notes);
+ BOOST_REQUIRE (notes.empty());
+}
+
+/** Having one piece of content less than 1s long in REELTYPE_BY_VIDEO_CONTENT
+ * should not make a reel less than 1s long.
+ */
+BOOST_AUTO_TEST_CASE (reels_should_not_be_short4)
+{
+ shared_ptr<Film> film = new_test_film2 ("reels_should_not_be_short4");
+ film->set_video_frame_rate (24);
+ film->set_reel_type (REELTYPE_BY_VIDEO_CONTENT);
+
+ shared_ptr<FFmpegContent> A(new FFmpegContent("test/data/flat_red.png"));
+ film->examine_and_add_content (A);
+ BOOST_REQUIRE (!wait_for_jobs());
+ A->video->set_length (240);
+
+ shared_ptr<FFmpegContent> B(new FFmpegContent("test/data/flat_red.png"));
+ film->examine_and_add_content (B);
+ BOOST_REQUIRE (!wait_for_jobs());
+ B->video->set_length (23);
+ B->set_position (film, DCPTime::from_frames(240, 24));
+
+ film->make_dcp ();
+ BOOST_REQUIRE (!wait_for_jobs());
+
+ vector<boost::filesystem::path> dirs;
+ dirs.push_back (film->dir(film->dcp_name(false)));
+ list<dcp::VerificationNote> const notes = dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd);
+ dump_notes (notes);
+ BOOST_REQUIRE (notes.empty());
+}
+