Move luminance to Interop/SMPTE metadata and remove the ISDCF metadata dialogue.
[dcpomatic.git] / src / lib / film.cc
index aa5dfdea909ee6d952f3989856c5698f8405042e..a9ac82b5a227224a1a01ea97c074f4028ac94a67 100644 (file)
@@ -64,7 +64,7 @@
 #include <dcp/local_time.h>
 #include <dcp/decrypted_kdm.h>
 #include <dcp/raw_convert.h>
-#include <dcp/reel_mxf.h>
+#include <dcp/reel_file_asset.h>
 #include <dcp/reel_asset.h>
 #include <libxml++/libxml++.h>
 #include <boost/filesystem.hpp>
@@ -151,18 +151,17 @@ Film::Film (optional<boost::filesystem::path> dir)
        , _use_isdcf_name (true)
        , _dcp_content_type (Config::instance()->default_dcp_content_type ())
        , _container (Config::instance()->default_container ())
-       , _resolution (RESOLUTION_2K)
+       , _resolution (Resolution::TWO_K)
        , _encrypted (false)
        , _context_id (dcp::make_uuid ())
        , _j2k_bandwidth (Config::instance()->default_j2k_bandwidth ())
-       , _isdcf_metadata (Config::instance()->default_isdcf_metadata ())
        , _video_frame_rate (24)
        , _audio_channels (Config::instance()->default_dcp_audio_channels ())
        , _three_d (false)
        , _sequence (true)
        , _interop (Config::instance()->default_interop ())
        , _audio_processor (0)
-       , _reel_type (REELTYPE_SINGLE)
+       , _reel_type (ReelType::SINGLE)
        , _reel_length (2000000000)
        , _reencode_j2k (false)
        , _user_explicit_video_frame_rate (false)
@@ -170,7 +169,6 @@ Film::Film (optional<boost::filesystem::path> dir)
        , _user_explicit_resolution (false)
        , _name_language (dcp::LanguageTag("en-US"))
        , _audio_language (dcp::LanguageTag("en-US"))
-       , _release_territory (dcp::LanguageTag::RegionSubtag("US"))
        , _version_number (1)
        , _status (dcp::Status::FINAL)
        , _luminance (dcp::Luminance(4.5, dcp::Luminance::Unit::FOOT_LAMBERT))
@@ -447,7 +445,6 @@ Film::metadata (bool with_content_paths) const
 
        root->add_child("Resolution")->add_child_text (resolution_to_string (_resolution));
        root->add_child("J2KBandwidth")->add_child_text (raw_convert<string> (_j2k_bandwidth));
-       _isdcf_metadata.as_xml (root->add_child ("ISDCFMetadata"));
        root->add_child("VideoFrameRate")->add_child_text (raw_convert<string> (_video_frame_rate));
        root->add_child("ISDCFDate")->add_child_text (boost::gregorian::to_iso_string (_isdcf_date));
        root->add_child("AudioChannels")->add_child_text (raw_convert<string> (_audio_channels));
@@ -477,19 +474,33 @@ Film::metadata (bool with_content_paths) const
        }
        root->add_child("NameLanguage")->add_child_text(_name_language.to_string());
        root->add_child("AudioLanguage")->add_child_text(_audio_language.to_string());
-       root->add_child("ReleaseTerritory")->add_child_text(_release_territory.subtag());
+       if (_release_territory) {
+               root->add_child("ReleaseTerritory")->add_child_text(_release_territory->subtag());
+       }
        root->add_child("VersionNumber")->add_child_text(raw_convert<string>(_version_number));
        root->add_child("Status")->add_child_text(dcp::status_to_string(_status));
-       root->add_child("Chain")->add_child_text(_chain);
-       root->add_child("Distributor")->add_child_text(_distributor);
-       root->add_child("Facility")->add_child_text(_facility);
-       root->add_child("LuminanceValue")->add_child_text(raw_convert<string>(_luminance.value()));
-       root->add_child("LuminanceUnit")->add_child_text(dcp::Luminance::unit_to_string(_luminance.unit()));
+       if (_chain) {
+               root->add_child("Chain")->add_child_text(*_chain);
+       }
+       if (_distributor) {
+               root->add_child("Distributor")->add_child_text(*_distributor);
+       }
+       if (_facility) {
+               root->add_child("Facility")->add_child_text(*_facility);
+       }
+       if (_studio) {
+               root->add_child("Studio")->add_child_text(*_studio);
+       }
+       root->add_child("TempVersion")->add_child_text(_temp_version ? "1" : "0");
+       root->add_child("PreRelease")->add_child_text(_pre_release ? "1" : "0");
+       root->add_child("RedBand")->add_child_text(_red_band ? "1" : "0");
+       root->add_child("TwoDVersionOfThreeD")->add_child_text(_two_d_version_of_three_d ? "1" : "0");
+       if (_luminance) {
+               root->add_child("LuminanceValue")->add_child_text(raw_convert<string>(_luminance->value()));
+               root->add_child("LuminanceUnit")->add_child_text(dcp::Luminance::unit_to_string(_luminance->unit()));
+       }
        root->add_child("UserExplicitContainer")->add_child_text(_user_explicit_container ? "1" : "0");
        root->add_child("UserExplicitResolution")->add_child_text(_user_explicit_resolution ? "1" : "0");
-       for (auto i: _subtitle_languages) {
-               root->add_child("SubtitleLanguage")->add_child_text(i.to_string());
-       }
        _playlist->as_xml (root->add_child ("Playlist"), with_content_paths);
 
        return doc;
@@ -559,11 +570,9 @@ Film::read_metadata (optional<boost::filesystem::path> path)
        _name = f.string_child ("Name");
        if (_state_version >= 9) {
                _use_isdcf_name = f.bool_child ("UseISDCFName");
-               _isdcf_metadata = ISDCFMetadata (f.node_child ("ISDCFMetadata"));
                _isdcf_date = boost::gregorian::from_undelimited_string (f.string_child ("ISDCFDate"));
        } else {
                _use_isdcf_name = f.bool_child ("UseDCIName");
-               _isdcf_metadata = ISDCFMetadata (f.node_child ("DCIMetadata"));
                _isdcf_date = boost::gregorian::from_undelimited_string (f.string_child ("DCIDate"));
        }
 
@@ -620,7 +629,7 @@ Film::read_metadata (optional<boost::filesystem::path> path)
                }
        }
 
-       _reel_type = static_cast<ReelType> (f.optional_number_child<int>("ReelType").get_value_or (static_cast<int>(REELTYPE_SINGLE)));
+       _reel_type = static_cast<ReelType> (f.optional_number_child<int>("ReelType").get_value_or (static_cast<int>(ReelType::SINGLE)));
        _reel_length = f.optional_number_child<int64_t>("ReelLength").get_value_or (2000000000);
        _reencode_j2k = f.optional_bool_child("ReencodeJ2K").get_value_or(false);
        _user_explicit_video_frame_rate = f.optional_bool_child("UserExplicitVideoFrameRate").get_value_or(false);
@@ -657,24 +666,25 @@ Film::read_metadata (optional<boost::filesystem::path> path)
                _status = dcp::string_to_status (*status);
        }
 
-       _chain = f.optional_string_child("Chain").get_value_or("");
-       _distributor = f.optional_string_child("Distributor").get_value_or("");
-       _facility = f.optional_string_child("Facility").get_value_or("");
+       _chain = f.optional_string_child("Chain");
+       _distributor = f.optional_string_child("Distributor");
+       _facility = f.optional_string_child("Facility");
+       _studio = f.optional_string_child("Studio");
+       _temp_version = f.optional_bool_child("TempVersion").get_value_or(false);
+       _pre_release = f.optional_bool_child("PreRelease").get_value_or(false);
+       _red_band = f.optional_bool_child("RedBand").get_value_or(false);
+       _two_d_version_of_three_d = f.optional_bool_child("TwoDVersionOfThreeD").get_value_or(false);
 
-       auto value = f.optional_number_child<float>("LuminanceValue").get_value_or(4.5);
+       auto value = f.optional_number_child<float>("LuminanceValue");
        auto unit = f.optional_string_child("LuminanceUnit");
-       if (unit) {
-               _luminance = dcp::Luminance (value, dcp::Luminance::string_to_unit(*unit));
+       if (value && unit) {
+               _luminance = dcp::Luminance (*value, dcp::Luminance::string_to_unit(*unit));
        }
 
        /* Disable guessing for files made in previous DCP-o-matic versions */
        _user_explicit_container = f.optional_bool_child("UserExplicitContainer").get_value_or(true);
        _user_explicit_resolution = f.optional_bool_child("UserExplicitResolution").get_value_or(true);
 
-       for (auto i: f.node_children("SubtitleLanguage")) {
-               _subtitle_languages.push_back (dcp::LanguageTag(i->content()));
-       }
-
        list<string> notes;
        _playlist->set_from_xml (shared_from_this(), f.node_child ("Playlist"), _state_version, notes);
 
@@ -683,41 +693,6 @@ Film::read_metadata (optional<boost::filesystem::path> path)
                set_backtrace_file (file ("backtrace.txt"));
        }
 
-       /* Around 2.15.108 we removed subtitle language state from the text content and the ISDCF
-        * metadata and put it into the Film instead.  If we've loaded an old Film let's try and fish
-        * out the settings from where they were so that they don't get lost.
-        */
-
-       optional<dcp::LanguageTag> found_language;
-
-       for (auto i: f.node_child("Playlist")->node_children("Content")) {
-               auto text = i->optional_node_child("Text");
-               if (text && text->optional_string_child("Language") && !found_language) {
-                       try {
-                               found_language = dcp::LanguageTag(text->string_child("Language"));
-                       } catch (...) {}
-               }
-       }
-
-       if (_state_version >= 9) {
-               auto isdcf_language = f.node_child("ISDCFMetadata")->optional_string_child("SubtitleLanguage");
-               if (isdcf_language && !found_language) {
-                       try {
-                               found_language = dcp::LanguageTag(*isdcf_language);
-                       } catch (...) {
-                               try {
-                                       found_language = dcp::LanguageTag(boost::algorithm::to_lower_copy(*isdcf_language));
-                               } catch (...) {
-
-                               }
-                       }
-               }
-       }
-
-       if (found_language) {
-               _subtitle_languages.push_back (*found_language);
-       }
-
        _dirty = false;
        return notes;
 }
@@ -784,6 +759,50 @@ Film::mapped_audio_channels () const
        return mapped;
 }
 
+
+vector<dcp::LanguageTag>
+Film::audio_languages () const
+{
+       vector<dcp::LanguageTag> result;
+       for (auto i: content()) {
+               if (i->audio && !i->audio->mapping().mapped_output_channels().empty() && i->audio->language()) {
+                       result.push_back (i->audio->language().get());
+               }
+       }
+
+       std::sort (result.begin(), result.end());
+       auto last = std::unique (result.begin(), result.end());
+       result.erase (last, result.end());
+       return result;
+}
+
+
+pair<optional<dcp::LanguageTag>, vector<dcp::LanguageTag>>
+Film::subtitle_languages () const
+{
+       pair<optional<dcp::LanguageTag>, vector<dcp::LanguageTag>> result;
+       for (auto i: content()) {
+               for (auto j: i->text) {
+                       if (j->use() && j->type() == TextType::OPEN_SUBTITLE && j->language()) {
+                               if (j->language_is_additional()) {
+                                       result.second.push_back (j->language().get());
+                               } else {
+                                       result.first = j->language().get();
+                               }
+                       }
+               }
+               if (i->video && i->video->burnt_subtitle_language()) {
+                       result.first = i->video->burnt_subtitle_language();
+               }
+       }
+
+       std::sort (result.second.begin(), result.second.end());
+       auto last = std::unique (result.second.begin(), result.second.end());
+       result.second.erase (last, result.second.end());
+       return result;
+}
+
+
 /** @return a ISDCF-compliant name for a DCP of this film */
 string
 Film::isdcf_name (bool if_created_now) const
@@ -835,37 +854,49 @@ Film::isdcf_name (bool if_created_now) const
 
        if (dcp_content_type()) {
                d += "_" + dcp_content_type()->isdcf_name();
-               d += "-" + raw_convert<string>(isdcf_metadata().content_version);
+               string version = "1";
+               if (_interop) {
+                       if (!_content_versions.empty()) {
+                               auto cv = _content_versions[0];
+                               if (!cv.empty() && std::all_of(cv.begin(), cv.end(), isdigit)) {
+                                       version = cv;
+                               }
+                       }
+               } else {
+                       version = dcp::raw_convert<string>(_version_number);
+               }
+               d += "-" + version;
        }
 
-       auto const dm = isdcf_metadata ();
-
-       if (dm.temp_version) {
+       if (_temp_version) {
                d += "-Temp";
        }
 
-       if (dm.pre_release) {
+       if (_pre_release) {
                d += "-Pre";
        }
 
-       if (dm.red_band) {
+       if (_red_band) {
                d += "-RedBand";
        }
 
-       if (!dm.chain.empty ()) {
-               d += "-" + dm.chain;
+       if (_chain && !_chain->empty()) {
+               d += "-" + *_chain;
        }
 
        if (three_d ()) {
                d += "-3D";
        }
 
-       if (dm.two_d_version_of_three_d) {
+       if (_two_d_version_of_three_d) {
                d += "-2D";
        }
 
-       if (!dm.mastered_luminance.empty ()) {
-               d += "-" + dm.mastered_luminance;
+       if (_luminance) {
+               auto fl = _luminance->value_in_foot_lamberts();
+               char buffer[64];
+               snprintf (buffer, sizeof(buffer), "%.1f", fl);
+               d += String::compose("-%1fl", buffer);
        }
 
        if (video_frame_rate() != 24) {
@@ -895,49 +926,52 @@ Film::isdcf_name (bool if_created_now) const
                }
        }
 
-       if (!dm.audio_language.empty ()) {
-               d += "_" + dm.audio_language;
+       auto audio_langs = audio_languages();
+       auto audio_language = (audio_langs.empty() || !audio_langs.front().language()) ? "XX" : audio_langs.front().language()->subtag();
 
-               /* I'm not clear on the precise details of the convention for CCAP labelling;
-                  for now I'm just appending -CCAP if we have any closed captions.
-               */
+       d += "_" + to_upper (audio_language);
 
-               auto burnt_in = true;
-               auto ccap = false;
-               for (auto i: content()) {
-                       for (auto j: i->text) {
-                               if (j->type() == TEXT_OPEN_SUBTITLE && j->use() && !j->burn()) {
-                                       burnt_in = false;
-                               } else if (j->type() == TEXT_CLOSED_CAPTION && j->use()) {
-                                       ccap = true;
-                               }
-                       }
-               }
+       /* I'm not clear on the precise details of the convention for CCAP labelling;
+          for now I'm just appending -CCAP if we have any closed captions.
+       */
 
-               if (!_subtitle_languages.empty()) {
-                       auto lang = _subtitle_languages.front().language().get_value_or("en").subtag();
-                       if (burnt_in) {
-                               transform (lang.begin(), lang.end(), lang.begin(), ::tolower);
-                       } else {
-                               transform (lang.begin(), lang.end(), lang.begin(), ::toupper);
+       auto burnt_in = true;
+       auto ccap = false;
+       for (auto i: content()) {
+               for (auto j: i->text) {
+                       if (j->type() == TextType::OPEN_SUBTITLE && j->use() && !j->burn()) {
+                               burnt_in = false;
+                       } else if (j->type() == TextType::CLOSED_CAPTION && j->use()) {
+                               ccap = true;
                        }
+               }
+       }
 
-                       d += "-" + lang;
-                       if (ccap) {
-                               d += "-CCAP";
-                       }
+       auto sub_langs = subtitle_languages();
+       if (sub_langs.first && sub_langs.first->language()) {
+               auto lang = sub_langs.first->language()->subtag();
+               if (burnt_in) {
+                       transform (lang.begin(), lang.end(), lang.begin(), ::tolower);
                } else {
-                       /* No subtitles */
-                       d += "-XX";
+                       lang = to_upper (lang);
                }
+
+               d += "-" + lang;
+               if (ccap) {
+                       d += "-CCAP";
+               }
+       } else {
+               /* No subtitles */
+               d += "-XX";
        }
 
-       if (!dm.territory.empty ()) {
-               d += "_" + dm.territory;
-               if (dm.rating.empty ()) {
+       if (_release_territory) {
+               auto territory = _release_territory->subtag();
+               d += "_" + to_upper (territory);
+               if (_ratings.empty ()) {
                        d += "-NR";
                } else {
-                       d += "-" + dm.rating;
+                       d += "-" + _ratings[0].label;
                }
        }
 
@@ -961,8 +995,8 @@ Film::isdcf_name (bool if_created_now) const
 
        d += "_" + resolution_to_string (_resolution);
 
-       if (!dm.studio.empty ()) {
-               d += "_" + dm.studio;
+       if (_studio && _studio->length() >= 2) {
+               d += "_" + to_upper (_studio->substr(0, 4));
        }
 
        if (if_created_now) {
@@ -971,8 +1005,8 @@ Film::isdcf_name (bool if_created_now) const
                d += "_" + boost::gregorian::to_iso_string (_isdcf_date);
        }
 
-       if (!dm.facility.empty ()) {
-               d += "_" + dm.facility;
+       if (_facility && _facility->length() >= 3) {
+               d += "_" + to_upper(_facility->substr(0, 3));
        }
 
        if (_interop) {
@@ -993,7 +1027,7 @@ Film::isdcf_name (bool if_created_now) const
                }
 
                bool any_text = false;
-               for (int i = 0; i < TEXT_COUNT; ++i) {
+               for (int i = 0; i < static_cast<int>(TextType::COUNT); ++i) {
                        if (dc->reference_text(static_cast<TextType>(i))) {
                                any_text = true;
                        }
@@ -1034,21 +1068,21 @@ Film::set_directory (boost::filesystem::path d)
 void
 Film::set_name (string n)
 {
-       ChangeSignaller<Film> ch (this, NAME);
+       FilmChangeSignaller ch (this, Property::NAME);
        _name = n;
 }
 
 void
 Film::set_use_isdcf_name (bool u)
 {
-       ChangeSignaller<Film> ch (this, USE_ISDCF_NAME);
+       FilmChangeSignaller ch (this, Property::USE_ISDCF_NAME);
        _use_isdcf_name = u;
 }
 
 void
 Film::set_dcp_content_type (DCPContentType const * t)
 {
-       ChangeSignaller<Film> ch (this, DCP_CONTENT_TYPE);
+       FilmChangeSignaller ch (this, Property::DCP_CONTENT_TYPE);
        _dcp_content_type = t;
 }
 
@@ -1060,7 +1094,7 @@ Film::set_dcp_content_type (DCPContentType const * t)
 void
 Film::set_container (Ratio const * c, bool explicit_user)
 {
-       ChangeSignaller<Film> ch (this, CONTAINER);
+       FilmChangeSignaller ch (this, Property::CONTAINER);
        _container = c;
 
        if (explicit_user) {
@@ -1076,7 +1110,7 @@ Film::set_container (Ratio const * c, bool explicit_user)
 void
 Film::set_resolution (Resolution r, bool explicit_user)
 {
-       ChangeSignaller<Film> ch (this, RESOLUTION);
+       FilmChangeSignaller ch (this, Property::RESOLUTION);
        _resolution = r;
 
        if (explicit_user) {
@@ -1088,17 +1122,10 @@ Film::set_resolution (Resolution r, bool explicit_user)
 void
 Film::set_j2k_bandwidth (int b)
 {
-       ChangeSignaller<Film> ch (this, J2K_BANDWIDTH);
+       FilmChangeSignaller ch (this, Property::J2K_BANDWIDTH);
        _j2k_bandwidth = b;
 }
 
-void
-Film::set_isdcf_metadata (ISDCFMetadata m)
-{
-       ChangeSignaller<Film> ch (this, ISDCF_METADATA);
-       _isdcf_metadata = m;
-}
-
 /** @param f New frame rate.
  *  @param user_explicit true if this comes from a direct user instruction, false if it is from
  *  DCP-o-matic being helpful.
@@ -1106,7 +1133,7 @@ Film::set_isdcf_metadata (ISDCFMetadata m)
 void
 Film::set_video_frame_rate (int f, bool user_explicit)
 {
-       ChangeSignaller<Film> ch (this, VIDEO_FRAME_RATE);
+       FilmChangeSignaller ch (this, Property::VIDEO_FRAME_RATE);
        _video_frame_rate = f;
        if (user_explicit) {
                _user_explicit_video_frame_rate = true;
@@ -1116,41 +1143,40 @@ Film::set_video_frame_rate (int f, bool user_explicit)
 void
 Film::set_audio_channels (int c)
 {
-       ChangeSignaller<Film> ch (this, AUDIO_CHANNELS);
+       FilmChangeSignaller ch (this, Property::AUDIO_CHANNELS);
        _audio_channels = c;
 }
 
 void
 Film::set_three_d (bool t)
 {
-       ChangeSignaller<Film> ch (this, THREE_D);
+       FilmChangeSignaller ch (this, Property::THREE_D);
        _three_d = t;
 
-       if (_three_d && _isdcf_metadata.two_d_version_of_three_d) {
-               ChangeSignaller<Film> ch (this, ISDCF_METADATA);
-               _isdcf_metadata.two_d_version_of_three_d = false;
+       if (_three_d && _two_d_version_of_three_d) {
+               set_two_d_version_of_three_d (false);
        }
 }
 
 void
 Film::set_interop (bool i)
 {
-       ChangeSignaller<Film> ch (this, INTEROP);
+       FilmChangeSignaller ch (this, Property::INTEROP);
        _interop = i;
 }
 
 void
 Film::set_audio_processor (AudioProcessor const * processor)
 {
-       ChangeSignaller<Film> ch1 (this, AUDIO_PROCESSOR);
-       ChangeSignaller<Film> ch2 (this, AUDIO_CHANNELS);
+       FilmChangeSignaller ch1 (this, Property::AUDIO_PROCESSOR);
+       FilmChangeSignaller ch2 (this, Property::AUDIO_CHANNELS);
        _audio_processor = processor;
 }
 
 void
 Film::set_reel_type (ReelType t)
 {
-       ChangeSignaller<Film> ch (this, REEL_TYPE);
+       FilmChangeSignaller ch (this, Property::REEL_TYPE);
        _reel_type = t;
 }
 
@@ -1158,14 +1184,14 @@ Film::set_reel_type (ReelType t)
 void
 Film::set_reel_length (int64_t r)
 {
-       ChangeSignaller<Film> ch (this, REEL_LENGTH);
+       FilmChangeSignaller ch (this, Property::REEL_LENGTH);
        _reel_length = r;
 }
 
 void
 Film::set_reencode_j2k (bool r)
 {
-       ChangeSignaller<Film> ch (this, REENCODE_J2K);
+       FilmChangeSignaller ch (this, Property::REENCODE_J2K);
        _reencode_j2k = r;
 }
 
@@ -1178,10 +1204,10 @@ Film::signal_change (ChangeType type, int p)
 void
 Film::signal_change (ChangeType type, Property p)
 {
-       if (type == CHANGE_TYPE_DONE) {
+       if (type == ChangeType::DONE) {
                _dirty = true;
 
-               if (p == Film::CONTENT) {
+               if (p == Property::CONTENT) {
                        if (!_user_explicit_video_frame_rate) {
                                set_video_frame_rate (best_video_frame_rate());
                        }
@@ -1189,7 +1215,7 @@ Film::signal_change (ChangeType type, Property p)
 
                emit (boost::bind (boost::ref (Change), type, p));
 
-               if (p == Film::VIDEO_FRAME_RATE || p == Film::SEQUENCE) {
+               if (p == Property::VIDEO_FRAME_RATE || p == Property::SEQUENCE) {
                        /* We want to call Playlist::maybe_sequence but this must happen after the
                           main signal emission (since the butler will see that emission and un-suspend itself).
                        */
@@ -1217,9 +1243,9 @@ Film::j2c_path (int reel, Frame frame, Eyes eyes, bool tmp) const
        snprintf(buffer, sizeof(buffer), "%08d_%08" PRId64, reel, frame);
        string s (buffer);
 
-       if (eyes == EYES_LEFT) {
+       if (eyes == Eyes::LEFT) {
                s += ".L";
-       } else if (eyes == EYES_RIGHT) {
+       } else if (eyes == Eyes::RIGHT) {
                s += ".R";
        }
 
@@ -1275,7 +1301,7 @@ Film::cpls () const
 void
 Film::set_encrypted (bool e)
 {
-       ChangeSignaller<Film> ch (this, ENCRYPTED);
+       FilmChangeSignaller ch (this, Property::ENCRYPTED);
        _encrypted = e;
 }
 
@@ -1387,9 +1413,9 @@ Film::maybe_set_container_and_resolution ()
 
                if (!_user_explicit_resolution) {
                        if (video->size_after_crop().width > 2048 || video->size_after_crop().height > 1080) {
-                               set_resolution (RESOLUTION_4K, false);
+                               set_resolution (Resolution::FOUR_K, false);
                        } else {
-                               set_resolution (RESOLUTION_2K, false);
+                               set_resolution (Resolution::TWO_K, false);
                        }
                }
        }
@@ -1444,12 +1470,12 @@ void
 Film::playlist_content_change (ChangeType type, weak_ptr<Content> c, int p, bool frequent)
 {
        if (p == ContentProperty::VIDEO_FRAME_RATE) {
-               signal_change (type, Film::CONTENT);
+               signal_change (type, Property::CONTENT);
        } else if (p == AudioContentProperty::STREAMS) {
-               signal_change (type, Film::NAME);
+               signal_change (type, Property::NAME);
        }
 
-       if (type == CHANGE_TYPE_DONE) {
+       if (type == ChangeType::DONE) {
                emit (boost::bind (boost::ref (ContentChange), type, c, p, frequent));
                if (!frequent) {
                        check_settings_consistency ();
@@ -1470,10 +1496,10 @@ Film::playlist_length_change ()
 void
 Film::playlist_change (ChangeType type)
 {
-       signal_change (type, CONTENT);
-       signal_change (type, NAME);
+       signal_change (type, Property::CONTENT);
+       signal_change (type, Property::NAME);
 
-       if (type == CHANGE_TYPE_DONE) {
+       if (type == ChangeType::DONE) {
                check_settings_consistency ();
        }
 
@@ -1517,12 +1543,12 @@ Film::check_settings_consistency ()
                        d->set_reference_audio(false);
                        change_made = true;
                }
-               if (d->reference_text(TEXT_OPEN_SUBTITLE) && !d->can_reference_text(shared_from_this(), TEXT_OPEN_SUBTITLE, why_not)) {
-                       d->set_reference_text(TEXT_OPEN_SUBTITLE, false);
+               if (d->reference_text(TextType::OPEN_SUBTITLE) && !d->can_reference_text(shared_from_this(), TextType::OPEN_SUBTITLE, why_not)) {
+                       d->set_reference_text(TextType::OPEN_SUBTITLE, false);
                        change_made = true;
                }
-               if (d->reference_text(TEXT_CLOSED_CAPTION) && !d->can_reference_text(shared_from_this(), TEXT_CLOSED_CAPTION, why_not)) {
-                       d->set_reference_text(TEXT_CLOSED_CAPTION, false);
+               if (d->reference_text(TextType::CLOSED_CAPTION) && !d->can_reference_text(shared_from_this(), TextType::CLOSED_CAPTION, why_not)) {
+                       d->set_reference_text(TextType::CLOSED_CAPTION, false);
                        change_made = true;
                }
        }
@@ -1536,7 +1562,7 @@ void
 Film::playlist_order_changed ()
 {
        /* XXX: missing PENDING */
-       signal_change (CHANGE_TYPE_DONE, CONTENT_ORDER);
+       signal_change (ChangeType::DONE, Property::CONTENT_ORDER);
 }
 
 int
@@ -1555,7 +1581,7 @@ Film::set_sequence (bool s)
                return;
        }
 
-       ChangeSignaller<Film> cc (this, SEQUENCE);
+       FilmChangeSignaller cc (this, Property::SEQUENCE);
        _sequence = s;
        _playlist->set_sequence (s);
 }
@@ -1565,9 +1591,9 @@ dcp::Size
 Film::full_frame () const
 {
        switch (_resolution) {
-       case RESOLUTION_2K:
+       case Resolution::TWO_K:
                return dcp::Size (2048, 1080);
-       case RESOLUTION_4K:
+       case Resolution::FOUR_K:
                return dcp::Size (4096, 2160);
        }
 
@@ -1645,9 +1671,9 @@ Film::make_kdm (
                }
        }
 
-       map<shared_ptr<const dcp::ReelMXF>, dcp::Key> keys;
+       map<shared_ptr<const dcp::ReelFileAsset>, dcp::Key> keys;
 
-       for (auto i: cpl->reel_mxfs()) {
+       for (auto i: cpl->reel_file_assets()) {
                if (!i->key_id()) {
                        continue;
                }
@@ -1767,10 +1793,10 @@ Film::reels () const
        auto const len = length();
 
        switch (reel_type ()) {
-       case REELTYPE_SINGLE:
+       case ReelType::SINGLE:
                p.push_back (DCPTimePeriod (DCPTime (), len));
                break;
-       case REELTYPE_BY_VIDEO_CONTENT:
+       case ReelType::BY_VIDEO_CONTENT:
        {
                /* Collect all reel boundaries */
                list<DCPTime> split_points;
@@ -1800,9 +1826,13 @@ Film::reels () const
                                last = t;
                        }
                }
+
+               if (!p.empty()) {
+                       p.back().to = split_points.back();
+               }
                break;
        }
-       case REELTYPE_BY_LENGTH:
+       case ReelType::BY_LENGTH:
        {
                DCPTime current;
                /* Integer-divide reel length by the size of one frame to give the number of frames per reel,
@@ -1849,7 +1879,6 @@ Film::use_template (string name)
        _audio_processor = _template_film->_audio_processor;
        _reel_type = _template_film->_reel_type;
        _reel_length = _template_film->_reel_length;
-       _isdcf_metadata = _template_film->_isdcf_metadata;
 }
 
 pair<double, double>
@@ -1912,7 +1941,7 @@ Film::closed_caption_tracks () const
                for (auto j: i->text) {
                        /* XXX: Empty DCPTextTrack ends up being a magic value here - the "unknown" or "not specified" track */
                        auto dtt = j->dcp_track().get_value_or(DCPTextTrack());
-                       if (j->type() == TEXT_CLOSED_CAPTION && find(tt.begin(), tt.end(), dtt) == tt.end()) {
+                       if (j->type() == TextType::CLOSED_CAPTION && find(tt.begin(), tt.end(), dtt) == tt.end()) {
                                tt.push_back (dtt);
                        }
                }
@@ -1924,14 +1953,15 @@ Film::closed_caption_tracks () const
 void
 Film::set_marker (dcp::Marker type, DCPTime time)
 {
-       ChangeSignaller<Film> ch (this, MARKERS);
+       FilmChangeSignaller ch (this, Property::MARKERS);
        _markers[type] = time;
 }
 
+
 void
 Film::unset_marker (dcp::Marker type)
 {
-       ChangeSignaller<Film> ch (this, MARKERS);
+       FilmChangeSignaller ch (this, Property::MARKERS);
        _markers.erase (type);
 }
 
@@ -1939,7 +1969,7 @@ Film::unset_marker (dcp::Marker type)
 void
 Film::clear_markers ()
 {
-       ChangeSignaller<Film> ch (this, MARKERS);
+       FilmChangeSignaller ch (this, Property::MARKERS);
        _markers.clear ();
 }
 
@@ -1947,14 +1977,14 @@ Film::clear_markers ()
 void
 Film::set_ratings (vector<dcp::Rating> r)
 {
-       ChangeSignaller<Film> ch (this, RATINGS);
+       FilmChangeSignaller ch (this, Property::RATINGS);
        _ratings = r;
 }
 
 void
 Film::set_content_versions (vector<string> v)
 {
-       ChangeSignaller<Film> ch (this, CONTENT_VERSIONS);
+       FilmChangeSignaller ch (this, Property::CONTENT_VERSIONS);
        _content_versions = v;
 }
 
@@ -1962,7 +1992,7 @@ Film::set_content_versions (vector<string> v)
 void
 Film::set_name_language (dcp::LanguageTag lang)
 {
-       ChangeSignaller<Film> ch (this, NAME_LANGUAGE);
+       FilmChangeSignaller ch (this, Property::NAME_LANGUAGE);
        _name_language = lang;
 }
 
@@ -1970,15 +2000,15 @@ Film::set_name_language (dcp::LanguageTag lang)
 void
 Film::set_audio_language (dcp::LanguageTag lang)
 {
-       ChangeSignaller<Film> ch (this, AUDIO_LANGUAGE);
+       FilmChangeSignaller ch (this, Property::AUDIO_LANGUAGE);
        _audio_language = lang;
 }
 
 
 void
-Film::set_release_territory (dcp::LanguageTag::RegionSubtag region)
+Film::set_release_territory (optional<dcp::LanguageTag::RegionSubtag> region)
 {
-       ChangeSignaller<Film> ch (this, RELEASE_TERRITORY);
+       FilmChangeSignaller ch (this, Property::RELEASE_TERRITORY);
        _release_territory = region;
 }
 
@@ -1986,7 +2016,7 @@ Film::set_release_territory (dcp::LanguageTag::RegionSubtag region)
 void
 Film::set_status (dcp::Status s)
 {
-       ChangeSignaller<Film> ch (this, STATUS);
+       FilmChangeSignaller ch (this, Property::STATUS);
        _status = s;
 }
 
@@ -1994,63 +2024,48 @@ Film::set_status (dcp::Status s)
 void
 Film::set_version_number (int v)
 {
-       ChangeSignaller<Film> ch (this, VERSION_NUMBER);
+       FilmChangeSignaller ch (this, Property::VERSION_NUMBER);
        _version_number = v;
 }
 
 
 void
-Film::set_chain (string c)
+Film::set_chain (optional<string> c)
 {
-       ChangeSignaller<Film> ch (this, CHAIN);
+       FilmChangeSignaller ch (this, Property::CHAIN);
        _chain = c;
 }
 
 
 void
-Film::set_distributor (string d)
+Film::set_distributor (optional<string> d)
 {
-       ChangeSignaller<Film> ch (this, DISTRIBUTOR);
+       FilmChangeSignaller ch (this, Property::DISTRIBUTOR);
        _distributor = d;
 }
 
 
 void
-Film::set_luminance (dcp::Luminance l)
+Film::set_luminance (optional<dcp::Luminance> l)
 {
-       ChangeSignaller<Film> ch (this, LUMINANCE);
+       FilmChangeSignaller ch (this, Property::LUMINANCE);
        _luminance = l;
 }
 
 
 void
-Film::set_subtitle_language (dcp::LanguageTag language)
-{
-       set_subtitle_languages ({language});
-}
-
-
-void
-Film::unset_subtitle_language ()
-{
-       ChangeSignaller<Film> ch (this, SUBTITLE_LANGUAGES);
-       _subtitle_languages.clear();
-}
-
-
-void
-Film::set_subtitle_languages (vector<dcp::LanguageTag> languages)
+Film::set_facility (optional<string> f)
 {
-       ChangeSignaller<Film> ch (this, SUBTITLE_LANGUAGES);
-       _subtitle_languages = languages;
+       FilmChangeSignaller ch (this, Property::FACILITY);
+       _facility = f;
 }
 
 
 void
-Film::set_facility (string f)
+Film::set_studio (optional<string> s)
 {
-       ChangeSignaller<Film> ch (this, FACILITY);
-       _facility = f;
+       FilmChangeSignaller ch (this, Property::STUDIO);
+       _studio = s;
 }
 
 
@@ -2104,10 +2119,43 @@ void
 Film::add_ffoc_lfoc (Markers& markers) const
 {
        if (markers.find(dcp::Marker::FFOC) == markers.end()) {
-               markers[dcp::Marker::FFOC] = dcpomatic::DCPTime(0);
+               markers[dcp::Marker::FFOC] = dcpomatic::DCPTime::from_frames(1, video_frame_rate());
        }
 
        if (markers.find(dcp::Marker::LFOC) == markers.end()) {
                markers[dcp::Marker::LFOC] = length() - DCPTime::from_frames(1, video_frame_rate());
        }
 }
+
+
+void
+Film::set_temp_version (bool t)
+{
+       FilmChangeSignaller ch (this, Property::TEMP_VERSION);
+       _temp_version = t;
+}
+
+
+void
+Film::set_pre_release (bool p)
+{
+       FilmChangeSignaller ch (this, Property::PRE_RELEASE);
+       _pre_release = p;
+}
+
+
+void
+Film::set_red_band (bool r)
+{
+       FilmChangeSignaller ch (this, Property::RED_BAND);
+       _red_band = r;
+}
+
+
+void
+Film::set_two_d_version_of_three_d (bool t)
+{
+       FilmChangeSignaller ch (this, Property::TWO_D_VERSION_OF_THREE_D);
+       _two_d_version_of_three_d = t;
+}
+