Allow copy-construction of Font.

[dcpomatic.git] / src / lib / font.cc

diff --git a/src/lib/font.cc b/src/lib/font.cc
index 333539aa4b7cbc6441dbc2e5c75dae4d0f7752a3..955a2ad1ca2821b94ad43df82829d12ba2449b5d 100644 (file)
--- a/src/lib/font.cc
+++ b/src/lib/font.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2014-2015 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2014-2021 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -18,46 +18,94 @@
 
 */
 
-#include "font.h"
+
 #include "dcpomatic_assert.h"
+#include "font.h"
+#include <dcp/warnings.h>
+LIBDCP_DISABLE_WARNINGS
 #include <libxml++/libxml++.h>
-#include <boost/foreach.hpp>
+LIBDCP_ENABLE_WARNINGS
+
 
 using std::string;
+using boost::optional;
+using namespace dcpomatic;
+
 
 Font::Font (cxml::NodePtr node)
-       : _id (node->string_child ("Id"))
+       : _id (node->string_child("Id"))
 {
-       BOOST_FOREACH (cxml::NodePtr i, node->node_children("File")) {
-               string variant = i->optional_string_attribute("Variant").get_value_or ("Normal");
+       for (auto i: node->node_children("File")) {
+               string variant = i->optional_string_attribute("Variant").get_value_or("Normal");
                if (variant == "Normal") {
-                       _file = i->content();
+                       _content.file = i->content();
                }
        }
 }
 
+
+Font::Font(Font const& other)
+       : _id(other._id)
+       , _content(other._content)
+{
+
+}
+
+
+Font& Font::operator=(Font const& other)
+{
+       if (&other != this) {
+               _id = other._id;
+               _content = other._content;
+       }
+       return *this;
+}
+
+
 void
 Font::as_xml (xmlpp::Node* node)
 {
-       node->add_child("Id")->add_child_text (_id);
-       if (_file) {
-               node->add_child("File")->add_child_text(_file->string());
+       node->add_child("Id")->add_child_text(_id);
+       if (_content.file) {
+               node->add_child("File")->add_child_text(_content.file->string());
        }
 }
 
 
 bool
-operator== (Font const & a, Font const & b)
+dcpomatic::operator== (Font const & a, Font const & b)
 {
        if (a.id() != b.id()) {
                return false;
        }
 
+       /* XXX: it's dubious that this ignores _data, though I think it's OK for the cases
+        * where operator== is used.  Perhaps we should remove operator== and have a more
+        * specific comparator.
+        */
+
        return a.file() == b.file();
 }
 
+
 bool
-operator!= (Font const & a, Font const & b)
+dcpomatic::operator!= (Font const & a, Font const & b)
 {
        return !(a == b);
 }
+
+
+optional<dcp::ArrayData>
+Font::data () const
+{
+       if (_content.data) {
+               return _content.data;
+       }
+
+       if (_content.file) {
+               return dcp::ArrayData(*_content.file);
+       }
+
+       return {};
+}
+