Use wx_ptr for the splash screen.
[dcpomatic.git] / src / tools / dcpomatic_player.cc
index 23aabadd83317c55ccdd41d73a3b3dd2417dec47..1808e86fe4d3da7fb450b12c2a7ec0a74166627c 100644 (file)
 
 */
 
-#include "wx/wx_signal_manager.h"
-#include "wx/wx_util.h"
 #include "wx/about_dialog.h"
-#include "wx/report_problem_dialog.h"
 #include "wx/film_viewer.h"
-#include "wx/player_information.h"
-#include "wx/update_dialog.h"
+#include "wx/nag_dialog.h"
 #include "wx/player_config_dialog.h"
-#include "wx/verify_dcp_dialog.h"
-#include "wx/standard_controls.h"
+#include "wx/player_information.h"
+#include "wx/player_stress_tester.h"
 #include "wx/playlist_controls.h"
-#include "wx/timer_display.h"
+#include "wx/report_problem_dialog.h"
+#include "wx/standard_controls.h"
 #include "wx/system_information_dialog.h"
-#include "wx/player_stress_tester.h"
+#include "wx/timer_display.h"
+#include "wx/update_dialog.h"
+#include "wx/verify_dcp_dialog.h"
 #include "wx/verify_dcp_progress_dialog.h"
-#include "wx/nag_dialog.h"
-#include "lib/cross.h"
-#include "lib/config.h"
-#include "lib/util.h"
-#include "lib/internet.h"
-#include "lib/update_checker.h"
+#include "wx/wx_ptr.h"
+#include "wx/wx_signal_manager.h"
+#include "wx/wx_util.h"
 #include "lib/compose.hpp"
+#include "lib/config.h"
+#include "lib/constants.h"
+#include "lib/cross.h"
 #include "lib/dcp_content.h"
-#include "lib/job_manager.h"
-#include "lib/job.h"
-#include "lib/film.h"
-#include "lib/null_log.h"
-#include "lib/video_content.h"
-#include "lib/text_content.h"
-#include "lib/ratio.h"
-#include "lib/verify_dcp_job.h"
 #include "lib/dcp_examiner.h"
-#include "lib/examine_content_job.h"
-#include "lib/server.h"
+#include "lib/dcpomatic_log.h"
 #include "lib/dcpomatic_socket.h"
-#include "lib/scoped_temporary.h"
+#include "lib/examine_content_job.h"
 #include "lib/ffmpeg_content.h"
-#include "lib/dcpomatic_log.h"
 #include "lib/file_log.h"
+#include "lib/film.h"
+#include "lib/image.h"
+#include "lib/image_jpeg.h"
+#include "lib/image_png.h"
+#include "lib/internet.h"
+#include "lib/job.h"
+#include "lib/job_manager.h"
+#include "lib/null_log.h"
+#include "lib/player.h"
+#include "lib/player_video.h"
+#include "lib/ratio.h"
+#include "lib/scope_guard.h"
+#include "lib/scoped_temporary.h"
+#include "lib/server.h"
+#include "lib/text_content.h"
+#include "lib/update_checker.h"
+#include "lib/verify_dcp_job.h"
+#include "lib/video_content.h"
 #include <dcp/cpl.h>
 #include <dcp/dcp.h>
-#include <dcp/raw_convert.h>
 #include <dcp/exceptions.h>
-#include <wx/wx.h>
-#include <wx/stdpaths.h>
-#include <wx/splash.h>
+#include <dcp/raw_convert.h>
+#include <dcp/search.h>
+#include <dcp/warnings.h>
+LIBDCP_DISABLE_WARNINGS
 #include <wx/cmdline.h>
+#include <wx/display.h>
+#include <wx/dnd.h>
 #include <wx/preferences.h>
 #include <wx/progdlg.h>
-#include <wx/display.h>
+#include <wx/splash.h>
+#include <wx/stdpaths.h>
+#include <wx/wx.h>
+LIBDCP_ENABLE_WARNINGS
 #ifdef __WXGTK__
 #include <X11/Xlib.h>
 #endif
-#include <boost/bind/bind.hpp>
 #include <boost/algorithm/string.hpp>
+#include <boost/bind/bind.hpp>
 #include <iostream>
 
 #ifdef check
 #undef check
 #endif
 
+
 #define MAX_CPLS 32
 
+
 using std::cout;
 using std::dynamic_pointer_cast;
 using std::exception;
@@ -90,20 +104,22 @@ using std::shared_ptr;
 using std::string;
 using std::vector;
 using std::weak_ptr;
-using boost::scoped_array;
+using boost::bind;
 using boost::optional;
+using boost::scoped_array;
 using boost::thread;
-using boost::bind;
 #if BOOST_VERSION >= 106100
 using namespace boost::placeholders;
 #endif
 using dcp::raw_convert;
 using namespace dcpomatic;
 
+
 enum {
        ID_file_open = 1,
        ID_file_add_ov,
        ID_file_add_kdm,
+       ID_file_save_frame,
        ID_file_history,
        /* Allow spare IDs after _history for the recent files list */
        ID_file_close = 100,
@@ -135,12 +151,56 @@ enum {
        ID_go_to_end
 };
 
+
 class DOMFrame : public wxFrame
 {
 public:
+
+       class DCPDropTarget : public wxFileDropTarget
+       {
+       public:
+               DCPDropTarget(DOMFrame* owner)
+                       : _frame(owner)
+               {}
+
+               bool OnDropFiles(wxCoord, wxCoord, wxArrayString const& filenames) override
+               {
+                       if (filenames.GetCount() == 1) {
+                               /* Try to load a directory */
+                               auto path = boost::filesystem::path(wx_to_std(filenames[0]));
+                               if (boost::filesystem::is_directory(path)) {
+                                       _frame->load_dcp(wx_to_std(filenames[0]));
+                                       return true;
+                               }
+                       }
+
+                       if (filenames.GetCount() >= 1) {
+                               /* Try to load the parent if we drop some files, one if which is an asset map */
+                               for (size_t i = 0; i < filenames.GetCount(); ++i) {
+                                       auto path = boost::filesystem::path(wx_to_std(filenames[i]));
+                                       if (path.filename() == "ASSETMAP" || path.filename() == "ASSETMAP.xml") {
+                                               _frame->load_dcp(path.parent_path());
+                                               return true;
+                                       }
+                               }
+                       }
+
+                       return false;
+               }
+
+       private:
+               DOMFrame* _frame;
+       };
+
+
        DOMFrame ()
                : wxFrame (nullptr, -1, _("DCP-o-matic Player"))
                , _mode (Config::instance()->player_mode())
+               /* Use a panel as the only child of the Frame so that we avoid
+                  the dark-grey background on Windows.
+               */
+               , _overall_panel(new wxPanel(this, wxID_ANY))
+               , _viewer(_overall_panel)
                , _main_sizer (new wxBoxSizer(wxVERTICAL))
        {
                dcpomatic_log = make_shared<NullLog>();
@@ -165,6 +225,7 @@ public:
                Bind (wxEVT_MENU, boost::bind (&DOMFrame::file_open, this), ID_file_open);
                Bind (wxEVT_MENU, boost::bind (&DOMFrame::file_add_ov, this), ID_file_add_ov);
                Bind (wxEVT_MENU, boost::bind (&DOMFrame::file_add_kdm, this), ID_file_add_kdm);
+               Bind (wxEVT_MENU, boost::bind (&DOMFrame::file_save_frame, this), ID_file_save_frame);
                Bind (wxEVT_MENU, boost::bind (&DOMFrame::file_history, this, _1), ID_file_history, ID_file_history + HISTORY_SIZE);
                Bind (wxEVT_MENU, boost::bind (&DOMFrame::file_close, this), ID_file_close);
                Bind (wxEVT_MENU, boost::bind (&DOMFrame::file_exit, this), wxID_EXIT);
@@ -183,12 +244,6 @@ public:
                Bind (wxEVT_MENU, boost::bind (&DOMFrame::tools_timing, this), ID_tools_timing);
                Bind (wxEVT_MENU, boost::bind (&DOMFrame::tools_system_information, this), ID_tools_system_information);
 
-               /* Use a panel as the only child of the Frame so that we avoid
-                  the dark-grey background on Windows.
-               */
-               _overall_panel = new wxPanel (this, wxID_ANY);
-
-               _viewer = make_shared<FilmViewer>(_overall_panel);
                if (Config::instance()->player_mode() == Config::PLAYER_MODE_DUAL) {
                        auto pc = new PlaylistControls (_overall_panel, _viewer);
                        _controls = pc;
@@ -196,11 +251,10 @@ public:
                } else {
                        _controls = new StandardControls (_overall_panel, _viewer, false);
                }
-               _viewer->set_dcp_decode_reduction (Config::instance()->decode_reduction ());
-               _viewer->PlaybackPermitted.connect (bind(&DOMFrame::playback_permitted, this));
-               _viewer->Started.connect (bind(&DOMFrame::playback_started, this, _1));
-               _viewer->Stopped.connect (bind(&DOMFrame::playback_stopped, this, _1));
-               _viewer->TooManyDropped.connect (bind(&DOMFrame::too_many_frames_dropped, this));
+               _viewer.set_dcp_decode_reduction(Config::instance()->decode_reduction());
+               _viewer.set_optimise_for_j2k(true);
+               _viewer.PlaybackPermitted.connect(bind(&DOMFrame::playback_permitted, this));
+               _viewer.TooManyDropped.connect(bind(&DOMFrame::too_many_frames_dropped, this));
                _info = new PlayerInformation (_overall_panel, _viewer);
                setup_main_sizer (Config::instance()->player_mode());
 #ifdef __WXOSX__
@@ -211,7 +265,7 @@ public:
 
                _stress.setup (this, _controls);
 
-               wxAcceleratorEntry* accel = new wxAcceleratorEntry[accelerators];
+               std::vector<wxAcceleratorEntry> accel(accelerators);
                accel[0].Set(wxACCEL_NORMAL,                WXK_SPACE, ID_start_stop);
                accel[1].Set(wxACCEL_NORMAL,                WXK_LEFT,  ID_go_back_frame);
                accel[2].Set(wxACCEL_NORMAL,                WXK_RIGHT, ID_go_forward_frame);
@@ -226,9 +280,8 @@ public:
 #ifdef __WXOSX__
                accel[11].Set(wxACCEL_CTRL, static_cast<int>('W'), ID_file_close);
 #endif
-               wxAcceleratorTable accel_table (accelerators, accel);
+               wxAcceleratorTable accel_table (accelerators, accel.data());
                SetAcceleratorTable (accel_table);
-               delete[] accel;
 
                Bind (wxEVT_MENU, boost::bind(&DOMFrame::start_stop_pressed, this), ID_start_stop);
                Bind (wxEVT_MENU, boost::bind(&DOMFrame::go_back_frame, this),      ID_go_back_frame);
@@ -248,6 +301,8 @@ public:
                setup_screen ();
 
                _stress.LoadDCP.connect (boost::bind(&DOMFrame::load_dcp, this, _1));
+
+               SetDropTarget(new DCPDropTarget(this));
        }
 
        ~DOMFrame ()
@@ -255,16 +310,16 @@ public:
                /* It's important that this is stopped before our frame starts destroying its children,
                 * otherwise UI elements that it depends on will disappear from under it.
                 */
-               _viewer.reset ();
+               _viewer.stop();
        }
 
        void setup_main_sizer (Config::PlayerMode mode)
        {
-               _main_sizer->Detach (_viewer->panel());
+               _main_sizer->Detach(_viewer.panel());
                _main_sizer->Detach (_controls);
                _main_sizer->Detach (_info);
                if (mode != Config::PLAYER_MODE_DUAL) {
-                       _main_sizer->Add (_viewer->panel(), 1, wxEXPAND);
+                       _main_sizer->Add(_viewer.panel(), 1, wxEXPAND);
                }
                _main_sizer->Add (_controls, mode == Config::PLAYER_MODE_DUAL ? 1 : 0, wxEXPAND | wxALL, 6);
                _main_sizer->Add (_info, 0, wxEXPAND | wxALL, 6);
@@ -293,56 +348,11 @@ public:
                return ok;
        }
 
-       void playback_started (DCPTime time)
-       {
-               /* XXX: this only logs the first piece of content; probably should be each piece? */
-               if (_film->content().empty()) {
-                       return;
-               }
-
-               auto dcp = dynamic_pointer_cast<DCPContent>(_film->content().front());
-               if (dcp) {
-                       DCPExaminer ex (dcp, true);
-                       shared_ptr<dcp::CPL> playing_cpl;
-                       for (auto i: ex.cpls()) {
-                               if (!dcp->cpl() || i->id() == *dcp->cpl()) {
-                                       playing_cpl = i;
-                               }
-                       }
-                       DCPOMATIC_ASSERT (playing_cpl);
-
-                       _controls->log (
-                               wxString::Format(
-                                       "playback-started %s %s %s",
-                                       time.timecode(_film->video_frame_rate()).c_str(),
-                                       dcp->directories().front().string().c_str(),
-                                       playing_cpl->annotation_text().get_value_or("").c_str()
-                                       )
-                               );
-               }
-
-               auto ffmpeg = dynamic_pointer_cast<FFmpegContent>(_film->content().front());
-               if (ffmpeg) {
-                       _controls->log (
-                               wxString::Format(
-                                       "playback-started %s %s",
-                                       time.timecode(_film->video_frame_rate()).c_str(),
-                                       ffmpeg->path(0).string().c_str()
-                                       )
-                               );
-               }
-       }
-
-       void playback_stopped (DCPTime time)
-       {
-               _controls->log (wxString::Format("playback-stopped %s", time.timecode(_film->video_frame_rate()).c_str()));
-       }
-
 
        void too_many_frames_dropped ()
        {
                if (!Config::instance()->nagged(Config::NAG_TOO_MANY_DROPPED_FRAMES)) {
-                       _viewer->stop ();
+                       _viewer.stop();
                }
 
                NagDialog::maybe_nag (
@@ -359,7 +369,7 @@ public:
 
        void set_decode_reduction (optional<int> reduction)
        {
-               _viewer->set_dcp_decode_reduction (reduction);
+               _viewer.set_dcp_decode_reduction(reduction);
                _info->triggered_update ();
                Config::instance()->set_decode_reduction (reduction);
        }
@@ -371,7 +381,6 @@ public:
                reset_film ();
                try {
                        _stress.set_suspended (true);
-                       // here
                        auto dcp = make_shared<DCPContent>(dir);
                        auto job = make_shared<ExamineContentJob>(_film, dcp);
                        _examine_job_connection = job->Finished.connect(bind(&DOMFrame::add_dcp_to_film, this, weak_ptr<Job>(job), weak_ptr<Content>(dcp)));
@@ -381,13 +390,16 @@ public:
                                return;
                        }
                        Config::instance()->add_to_player_history (dir);
+                       if (dcp->video_frame_rate()) {
+                               _film->set_video_frame_rate(dcp->video_frame_rate().get(), true);
+                       }
                } catch (ProjectFolderError &) {
                        error_dialog (
                                this,
                                wxString::Format(_("Could not load a DCP from %s"), std_to_wx(dir.string())),
                                _(
                                        "This looks like a DCP-o-matic project folder, which cannot be loaded into the player.  "
-                                       "Choose the DCP directory inside the DCP-o-matic project folder if that's what you want to play."
+                                       "Choose the DCP folder inside the DCP-o-matic project folder if that's what you want to play."
                                 )
                                );
                } catch (dcp::ReadError& e) {
@@ -426,7 +438,7 @@ public:
                _film = film;
                _film->set_tolerant (true);
                _film->set_audio_channels (MAX_DCP_AUDIO_CHANNELS);
-               _viewer->set_film (_film);
+               _viewer.set_film(_film);
                _controls->set_film (_film);
                _film->Change.connect (bind(&DOMFrame::film_changed, this, _1, _2));
                _info->triggered_update ();
@@ -438,8 +450,8 @@ public:
                        return;
                }
 
-               if (_viewer->playing ()) {
-                       _viewer->stop ();
+               if (_viewer.playing()) {
+                       _viewer.stop();
                }
 
                /* Start off as Flat */
@@ -466,7 +478,7 @@ public:
                        }
                }
 
-               _viewer->seek (DCPTime(), true);
+               _viewer.seek(DCPTime(), true);
                _info->triggered_update ();
 
                set_menu_sensitivity ();
@@ -480,9 +492,8 @@ public:
                        /* Offer a CPL menu */
                        auto first = dynamic_pointer_cast<DCPContent>(_film->content().front());
                        if (first) {
-                               DCPExaminer ex (first, true);
                                int id = ID_view_cpl;
-                               for (auto i: ex.cpls()) {
+                               for (auto i: dcp::find_and_resolve_cpls(first->directories(), true)) {
                                        auto j = _cpl_menu->AppendRadioItem(
                                                id,
                                                wxString::Format("%s (%s)", std_to_wx(i->annotation_text().get_value_or("")).data(), std_to_wx(i->id()).data())
@@ -535,6 +546,8 @@ private:
                _file_menu->Append (ID_file_open, _("&Open...\tCtrl-O"));
                _file_add_ov = _file_menu->Append (ID_file_add_ov, _("&Add OV..."));
                _file_add_kdm = _file_menu->Append (ID_file_add_kdm, _("Add &KDM..."));
+               _file_menu->AppendSeparator ();
+               _file_save_frame = _file_menu->Append (ID_file_save_frame, _("&Save frame to file...\tCtrl-S"));
 
                _history_position = _file_menu->GetMenuItems().GetCount();
 
@@ -605,7 +618,7 @@ private:
                        d = std_to_wx (Config::instance()->last_player_load_directory()->string());
                }
 
-               auto c = new wxDirDialog (this, _("Select DCP to open"), d, wxDEFAULT_DIALOG_STYLE | wxDD_DIR_MUST_EXIST);
+               auto c = make_wx<wxDirDialog>(this, _("Select DCP to open"), d, wxDEFAULT_DIALOG_STYLE | wxDD_DIR_MUST_EXIST);
 
                int r;
                while (true) {
@@ -622,16 +635,19 @@ private:
                        load_dcp (dcp);
                        Config::instance()->set_last_player_load_directory (dcp.parent_path());
                }
-
-               c->Destroy ();
        }
 
        void file_add_ov ()
        {
-               auto c = new wxDirDialog (
+               auto initial_dir = wxStandardPaths::Get().GetDocumentsDir();
+               if (Config::instance()->last_player_load_directory()) {
+                       initial_dir = std_to_wx(Config::instance()->last_player_load_directory()->string());
+               }
+
+               auto c = make_wx<wxDirDialog>(
                        this,
                        _("Select DCP to open as OV"),
-                       wxStandardPaths::Get().GetDocumentsDir(),
+                       initial_dir,
                        wxDEFAULT_DIALOG_STYLE | wxDD_DIR_MUST_EXIST
                        );
 
@@ -666,13 +682,12 @@ private:
                        }
                }
 
-               c->Destroy ();
                _info->triggered_update ();
        }
 
        void file_add_kdm ()
        {
-               auto d = new wxFileDialog (this, _("Select KDM"));
+               auto d = make_wx<wxFileDialog>(this, _("Select KDM"));
 
                if (d->ShowModal() == wxID_OK) {
                        DCPOMATIC_ASSERT (_film);
@@ -680,22 +695,56 @@ private:
                        DCPOMATIC_ASSERT (dcp);
                        try {
                                if (dcp) {
-                                       _viewer->set_coalesce_player_changes (true);
+                                       _viewer.set_coalesce_player_changes(true);
                                        dcp->add_kdm (dcp::EncryptedKDM(dcp::file_to_string(wx_to_std(d->GetPath()), MAX_KDM_SIZE)));
                                        examine_content();
-                                       _viewer->set_coalesce_player_changes (false);
+                                       _viewer.set_coalesce_player_changes(false);
                                }
                        } catch (exception& e) {
                                error_dialog (this, wxString::Format (_("Could not load KDM.")), std_to_wx(e.what()));
-                               d->Destroy ();
                                return;
                        }
                }
 
-               d->Destroy ();
                _info->triggered_update ();
        }
 
+       void file_save_frame ()
+       {
+               wxFileDialog dialog (this, _("Save frame to file"), "", "", "PNG files (*.png)|*.png|JPEG files (*.jpg,*.jpeg)|*.jpg,*.jpeg", wxFD_SAVE | wxFD_OVERWRITE_PROMPT);
+               if (dialog.ShowModal() == wxID_CANCEL) {
+                       return;
+               }
+
+               auto path = boost::filesystem::path (wx_to_std(dialog.GetPath()));
+
+               auto player = make_shared<Player>(_film, Image::Alignment::PADDED);
+               player->seek(_viewer.position(), true);
+
+               bool done = false;
+               player->Video.connect ([path, &done, this](shared_ptr<PlayerVideo> video, DCPTime) {
+                       auto ext = boost::algorithm::to_lower_copy(path.extension().string());
+                       if (ext == ".png") {
+                               auto image = video->image(boost::bind(PlayerVideo::force, AV_PIX_FMT_RGBA), VideoRange::FULL, false);
+                               image_as_png(image).write(path);
+                       } else if (ext == ".jpg" || ext == ".jpeg") {
+                               auto image = video->image(boost::bind(PlayerVideo::force, AV_PIX_FMT_RGB24), VideoRange::FULL, false);
+                               image_as_jpeg(image, 80).write(path);
+                       } else {
+                               error_dialog (this, _(wxString::Format("Unrecognised file extension %s (use .jpg, .jpeg or .png)", std_to_wx(ext))));
+                       }
+                       done = true;
+               });
+
+               int tries_left = 50;
+               while (!done && tries_left >= 0) {
+                       player->pass();
+                       --tries_left;
+               }
+
+               DCPOMATIC_ASSERT (tries_left >= 0);
+       }
+
        void file_history (wxCommandEvent& event)
        {
                auto history = Config::instance()->player_history ();
@@ -737,21 +786,20 @@ private:
        {
                auto dcp = std::dynamic_pointer_cast<DCPContent>(_film->content().front());
                DCPOMATIC_ASSERT (dcp);
-               DCPExaminer ex (dcp, true);
+               auto cpls = dcp::find_and_resolve_cpls (dcp->directories(), true);
                int id = ev.GetId() - ID_view_cpl;
                DCPOMATIC_ASSERT (id >= 0);
-               DCPOMATIC_ASSERT (id < int(ex.cpls().size()));
-               auto cpls = ex.cpls();
+               DCPOMATIC_ASSERT (id < int(cpls.size()));
                auto i = cpls.begin();
                while (id > 0) {
                        ++i;
                        --id;
                }
 
-               _viewer->set_coalesce_player_changes (true);
+               _viewer.set_coalesce_player_changes(true);
                dcp->set_cpl ((*i)->id());
                examine_content ();
-               _viewer->set_coalesce_player_changes (false);
+               _viewer.set_coalesce_player_changes(false);
 
                _info->triggered_update ();
        }
@@ -794,13 +842,14 @@ private:
                _info->Show (_mode != Config::PLAYER_MODE_FULL);
                _overall_panel->SetBackgroundColour (_mode == Config::PLAYER_MODE_FULL ? wxColour(0, 0, 0) : wxNullColour);
                ShowFullScreen (_mode == Config::PLAYER_MODE_FULL);
-               _viewer->set_pad_black (_mode != Config::PLAYER_MODE_WINDOW);
+               _viewer.set_pad_black(_mode != Config::PLAYER_MODE_WINDOW);
 
                if (_mode == Config::PLAYER_MODE_DUAL) {
                        _dual_screen = new wxFrame (this, wxID_ANY, wxT(""));
                        _dual_screen->SetBackgroundColour (wxColour(0, 0, 0));
                        _dual_screen->ShowFullScreen (true);
-                       _viewer->panel()->Reparent (_dual_screen);
+                       _viewer.panel()->Reparent(_dual_screen);
+                       _viewer.panel()->SetFocus();
                        _dual_screen->Show ();
                        if (wxDisplay::GetCount() > 1) {
                                switch (Config::instance()->image_display()) {
@@ -815,9 +864,10 @@ private:
                                        break;
                                }
                        }
+                       _dual_screen->Bind(wxEVT_CHAR_HOOK, boost::bind(&DOMFrame::dual_screen_key_press, this, _1));
                } else {
                        if (_dual_screen) {
-                               _viewer->panel()->Reparent (_overall_panel);
+                               _viewer.panel()->Reparent(_overall_panel);
                                _dual_screen->Destroy ();
                                _dual_screen = 0;
                        }
@@ -826,9 +876,20 @@ private:
                setup_main_sizer (_mode);
        }
 
+       void dual_screen_key_press(wxKeyEvent& ev)
+       {
+               if (ev.GetKeyCode() == WXK_F11) {
+                       if (ev.ShiftDown()) {
+                               view_dual_screen();
+                       } else if (!ev.HasAnyModifiers()) {
+                               view_full_screen();
+                       }
+               }
+       }
+
        void view_closed_captions ()
        {
-               _viewer->show_closed_captions ();
+               _viewer.show_closed_captions();
        }
 
        void tools_verify ()
@@ -837,16 +898,14 @@ private:
                DCPOMATIC_ASSERT (dcp);
 
                auto job = make_shared<VerifyDCPJob>(dcp->directories());
-               auto progress = new VerifyDCPProgressDialog(this, _("DCP-o-matic Player"));
+               auto progress = make_wx<VerifyDCPProgressDialog>(this, _("DCP-o-matic Player"));
                bool const completed = progress->run (job);
-               progress->Destroy ();
                if (!completed) {
                        return;
                }
 
-               auto d = new VerifyDCPDialog (this, job);
+               auto d = make_wx<VerifyDCPDialog>(this, job);
                d->ShowModal ();
-               d->Destroy ();
        }
 
        void tools_check_for_updates ()
@@ -857,9 +916,8 @@ private:
 
        void tools_timing ()
        {
-               auto d = new TimerDisplay (this, _viewer->state_timer(), _viewer->gets());
+               auto d = make_wx<TimerDisplay>(this, _viewer.state_timer(), _viewer.gets());
                d->ShowModal ();
-               d->Destroy ();
        }
 
        void tools_system_information ()
@@ -873,18 +931,16 @@ private:
 
        void help_about ()
        {
-               auto d = new AboutDialog (this);
+               auto d = make_wx<AboutDialog>(this);
                d->ShowModal ();
-               d->Destroy ();
        }
 
        void help_report_a_problem ()
        {
-               auto d = new ReportProblemDialog (this);
+               auto d = make_wx<ReportProblemDialog>(this);
                if (d->ShowModal () == wxID_OK) {
                        d->report ();
                }
-               d->Destroy ();
        }
 
        void update_checker_state_changed ()
@@ -903,9 +959,8 @@ private:
                }
 
                if (uc->state() == UpdateChecker::State::YES) {
-                       auto dialog = new UpdateDialog (this, uc->stable (), uc->test ());
+                       auto dialog = make_wx<UpdateDialog>(this, uc->stable (), uc->test ());
                        dialog->ShowModal ();
-                       dialog->Destroy ();
                } else if (uc->state() == UpdateChecker::State::FAILED) {
                        error_dialog (this, _("The DCP-o-matic download server could not be contacted."));
                } else {
@@ -954,7 +1009,7 @@ private:
 
                int pos = _history_position;
 
-               /* Clear out non-existant history items before we re-build the menu */
+               /* Clear out non-existent history items before we re-build the menu */
                Config::instance()->clean_player_history ();
                auto history = Config::instance()->player_history ();
 
@@ -990,41 +1045,42 @@ private:
                _tools_verify->Enable (static_cast<bool>(_film));
                _file_add_ov->Enable (static_cast<bool>(_film));
                _file_add_kdm->Enable (static_cast<bool>(_film));
+               _file_save_frame->Enable (static_cast<bool>(_film));
                _view_cpl->Enable (static_cast<bool>(_film));
        }
 
        void start_stop_pressed ()
        {
-               if (_viewer->playing()) {
-                       _viewer->stop();
+               if (_viewer.playing()) {
+                       _viewer.stop();
                } else {
-                       _viewer->start();
+                       _viewer.start();
                }
        }
 
        void go_back_frame ()
        {
-               _viewer->seek_by (-_viewer->one_video_frame(), true);
+               _viewer.seek_by(-_viewer.one_video_frame(), true);
        }
 
        void go_forward_frame ()
        {
-               _viewer->seek_by (_viewer->one_video_frame(), true);
+               _viewer.seek_by(_viewer.one_video_frame(), true);
        }
 
        void go_seconds (int s)
        {
-               _viewer->seek_by (DCPTime::from_seconds(s), true);
+               _viewer.seek_by(DCPTime::from_seconds(s), true);
        }
 
        void go_to_start ()
        {
-               _viewer->seek (DCPTime(), true);
+               _viewer.seek(DCPTime(), true);
        }
 
        void go_to_end ()
        {
-               _viewer->seek (_film->length() - _viewer->one_video_frame(), true);
+               _viewer.seek(_film->length() - _viewer.one_video_frame(), true);
        }
 
        wxFrame* _dual_screen = nullptr;
@@ -1039,7 +1095,7 @@ private:
        int _history_items = 0;
        int _history_position = 0;
        wxMenuItem* _history_separator = nullptr;
-       shared_ptr<FilmViewer> _viewer;
+       FilmViewer _viewer;
        Controls* _controls;
        SystemInformationDialog* _system_information_dialog = nullptr;
        std::shared_ptr<Film> _film;
@@ -1047,6 +1103,7 @@ private:
        boost::signals2::scoped_connection _examine_job_connection;
        wxMenuItem* _file_add_ov = nullptr;
        wxMenuItem* _file_add_kdm = nullptr;
+       wxMenuItem* _file_save_frame = nullptr;
        wxMenuItem* _tools_verify = nullptr;
        wxMenuItem* _view_full_screen = nullptr;
        wxMenuItem* _view_dual_screen = nullptr;
@@ -1069,7 +1126,7 @@ public:
                , _frame (frame)
        {}
 
-       void handle (shared_ptr<Socket> socket)
+       void handle (shared_ptr<Socket> socket) override
        {
                try {
                        int const length = socket->read_uint32 ();
@@ -1103,9 +1160,9 @@ public:
 
 private:
 
-       bool OnInit ()
+       bool OnInit () override
        {
-               wxSplashScreen* splash = nullptr;
+               wx_ptr<wxSplashScreen> splash;
                try {
                        wxInitAllImageHandlers ();
 
@@ -1202,13 +1259,13 @@ private:
                return true;
        }
 
-       void OnInitCmdLine (wxCmdLineParser& parser)
+       void OnInitCmdLine (wxCmdLineParser& parser) override
        {
                parser.SetDesc (command_line_description);
                parser.SetSwitchChars (wxT ("-"));
        }
 
-       bool OnCmdLineParsed (wxCmdLineParser& parser)
+       bool OnCmdLineParsed (wxCmdLineParser& parser) override
        {
                if (parser.GetParamCount() > 0) {
                        _dcp_to_load = wx_to_std (parser.GetParam (0));
@@ -1253,14 +1310,14 @@ private:
        }
 
        /* An unhandled exception has occurred inside the main event loop */
-       bool OnExceptionInMainLoop ()
+       bool OnExceptionInMainLoop () override
        {
                report_exception ();
                /* This will terminate the program */
                return false;
        }
 
-       void OnUnhandledException ()
+       void OnUnhandledException () override
        {
                report_exception ();
        }