Make DCPExaminer::size() optional and deal with the consequences.
[dcpomatic.git] / src / tools / dcpomatic_player.cc
index 7b512d1e31037a3ac5b99c4cf4f6f32bad2db198..e658395211c5b040cce4b191518b641ea477ab9d 100644 (file)
@@ -19,7 +19,9 @@
 */
 
 #include "wx/about_dialog.h"
+#include "wx/file_dialog.h"
 #include "wx/film_viewer.h"
+#include "wx/id.h"
 #include "wx/nag_dialog.h"
 #include "wx/player_config_dialog.h"
 #include "wx/player_information.h"
 #include "wx/update_dialog.h"
 #include "wx/verify_dcp_dialog.h"
 #include "wx/verify_dcp_progress_dialog.h"
+#include "wx/wx_ptr.h"
 #include "wx/wx_signal_manager.h"
 #include "wx/wx_util.h"
 #include "lib/compose.hpp"
 #include "lib/config.h"
+#include "lib/constants.h"
 #include "lib/cross.h"
 #include "lib/dcp_content.h"
 #include "lib/dcp_examiner.h"
@@ -45,6 +49,7 @@
 #include "lib/ffmpeg_content.h"
 #include "lib/file_log.h"
 #include "lib/film.h"
+#include "lib/font_config.h"
 #include "lib/image.h"
 #include "lib/image_jpeg.h"
 #include "lib/image_png.h"
 #include "lib/server.h"
 #include "lib/text_content.h"
 #include "lib/update_checker.h"
-#include "lib/util.h"
 #include "lib/verify_dcp_job.h"
 #include "lib/video_content.h"
 #include <dcp/cpl.h>
 #include <dcp/dcp.h>
 #include <dcp/exceptions.h>
+#include <dcp/filesystem.h>
 #include <dcp/raw_convert.h>
+#include <dcp/scope_guard.h>
 #include <dcp/search.h>
 #include <dcp/warnings.h>
 LIBDCP_DISABLE_WARNINGS
 #include <wx/cmdline.h>
 #include <wx/display.h>
+#include <wx/dnd.h>
 #include <wx/preferences.h>
 #include <wx/progdlg.h>
 #include <wx/splash.h>
@@ -113,16 +120,16 @@ using namespace dcpomatic;
 
 
 enum {
-       ID_file_open = 1,
+       ID_file_open = DCPOMATIC_MAIN_MENU,
        ID_file_add_ov,
        ID_file_add_kdm,
        ID_file_save_frame,
        ID_file_history,
        /* Allow spare IDs after _history for the recent files list */
-       ID_file_close = 100,
+       ID_file_close = DCPOMATIC_MAIN_MENU + 100,
        ID_view_cpl,
        /* Allow spare IDs for CPLs */
-       ID_view_full_screen = 200,
+       ID_view_full_screen = DCPOMATIC_MAIN_MENU + 200,
        ID_view_dual_screen,
        ID_view_closed_captions,
        ID_view_scale_appropriate,
@@ -148,12 +155,56 @@ enum {
        ID_go_to_end
 };
 
+
 class DOMFrame : public wxFrame
 {
 public:
+
+       class DCPDropTarget : public wxFileDropTarget
+       {
+       public:
+               DCPDropTarget(DOMFrame* owner)
+                       : _frame(owner)
+               {}
+
+               bool OnDropFiles(wxCoord, wxCoord, wxArrayString const& filenames) override
+               {
+                       if (filenames.GetCount() == 1) {
+                               /* Try to load a directory */
+                               auto path = boost::filesystem::path(wx_to_std(filenames[0]));
+                               if (dcp::filesystem::is_directory(path)) {
+                                       _frame->load_dcp(wx_to_std(filenames[0]));
+                                       return true;
+                               }
+                       }
+
+                       if (filenames.GetCount() >= 1) {
+                               /* Try to load the parent if we drop some files, one if which is an asset map */
+                               for (size_t i = 0; i < filenames.GetCount(); ++i) {
+                                       auto path = boost::filesystem::path(wx_to_std(filenames[i]));
+                                       if (path.filename() == "ASSETMAP" || path.filename() == "ASSETMAP.xml") {
+                                               _frame->load_dcp(path.parent_path());
+                                               return true;
+                                       }
+                               }
+                       }
+
+                       return false;
+               }
+
+       private:
+               DOMFrame* _frame;
+       };
+
+
        DOMFrame ()
                : wxFrame (nullptr, -1, _("DCP-o-matic Player"))
                , _mode (Config::instance()->player_mode())
+               /* Use a panel as the only child of the Frame so that we avoid
+                  the dark-grey background on Windows.
+               */
+               , _overall_panel(new wxPanel(this, wxID_ANY))
+               , _viewer(_overall_panel)
                , _main_sizer (new wxBoxSizer(wxVERTICAL))
        {
                dcpomatic_log = make_shared<NullLog>();
@@ -197,12 +248,8 @@ public:
                Bind (wxEVT_MENU, boost::bind (&DOMFrame::tools_timing, this), ID_tools_timing);
                Bind (wxEVT_MENU, boost::bind (&DOMFrame::tools_system_information, this), ID_tools_system_information);
 
-               /* Use a panel as the only child of the Frame so that we avoid
-                  the dark-grey background on Windows.
-               */
-               _overall_panel = new wxPanel (this, wxID_ANY);
+               Bind(wxEVT_CLOSE_WINDOW, boost::bind(&DOMFrame::close, this, _1));
 
-               _viewer = make_shared<FilmViewer>(_overall_panel);
                if (Config::instance()->player_mode() == Config::PLAYER_MODE_DUAL) {
                        auto pc = new PlaylistControls (_overall_panel, _viewer);
                        _controls = pc;
@@ -210,10 +257,11 @@ public:
                } else {
                        _controls = new StandardControls (_overall_panel, _viewer, false);
                }
-               _viewer->set_dcp_decode_reduction (Config::instance()->decode_reduction ());
-               _viewer->set_optimise_for_j2k (true);
-               _viewer->PlaybackPermitted.connect (bind(&DOMFrame::playback_permitted, this));
-               _viewer->TooManyDropped.connect (bind(&DOMFrame::too_many_frames_dropped, this));
+               _controls->set_film(_viewer.film());
+               _viewer.set_dcp_decode_reduction(Config::instance()->decode_reduction());
+               _viewer.set_optimise_for_j2k(true);
+               _viewer.PlaybackPermitted.connect(bind(&DOMFrame::playback_permitted, this));
+               _viewer.TooManyDropped.connect(bind(&DOMFrame::too_many_frames_dropped, this));
                _info = new PlayerInformation (_overall_panel, _viewer);
                setup_main_sizer (Config::instance()->player_mode());
 #ifdef __WXOSX__
@@ -260,6 +308,8 @@ public:
                setup_screen ();
 
                _stress.LoadDCP.connect (boost::bind(&DOMFrame::load_dcp, this, _1));
+
+               SetDropTarget(new DCPDropTarget(this));
        }
 
        ~DOMFrame ()
@@ -267,16 +317,22 @@ public:
                /* It's important that this is stopped before our frame starts destroying its children,
                 * otherwise UI elements that it depends on will disappear from under it.
                 */
-               _viewer.reset ();
+               _viewer.stop();
+       }
+
+       void close(wxCloseEvent& ev)
+       {
+               FontConfig::drop();
+               ev.Skip();
        }
 
        void setup_main_sizer (Config::PlayerMode mode)
        {
-               _main_sizer->Detach (_viewer->panel());
+               _main_sizer->Detach(_viewer.panel());
                _main_sizer->Detach (_controls);
                _main_sizer->Detach (_info);
                if (mode != Config::PLAYER_MODE_DUAL) {
-                       _main_sizer->Add (_viewer->panel(), 1, wxEXPAND);
+                       _main_sizer->Add(_viewer.panel(), 1, wxEXPAND);
                }
                _main_sizer->Add (_controls, mode == Config::PLAYER_MODE_DUAL ? 1 : 0, wxEXPAND | wxALL, 6);
                _main_sizer->Add (_info, 0, wxEXPAND | wxALL, 6);
@@ -309,7 +365,7 @@ public:
        void too_many_frames_dropped ()
        {
                if (!Config::instance()->nagged(Config::NAG_TOO_MANY_DROPPED_FRAMES)) {
-                       _viewer->stop ();
+                       _viewer.stop();
                }
 
                NagDialog::maybe_nag (
@@ -326,7 +382,7 @@ public:
 
        void set_decode_reduction (optional<int> reduction)
        {
-               _viewer->set_dcp_decode_reduction (reduction);
+               _viewer.set_dcp_decode_reduction(reduction);
                _info->triggered_update ();
                Config::instance()->set_decode_reduction (reduction);
        }
@@ -338,7 +394,6 @@ public:
                reset_film ();
                try {
                        _stress.set_suspended (true);
-                       // here
                        auto dcp = make_shared<DCPContent>(dir);
                        auto job = make_shared<ExamineContentJob>(_film, dcp);
                        _examine_job_connection = job->Finished.connect(bind(&DOMFrame::add_dcp_to_film, this, weak_ptr<Job>(job), weak_ptr<Content>(dcp)));
@@ -348,6 +403,9 @@ public:
                                return;
                        }
                        Config::instance()->add_to_player_history (dir);
+                       if (dcp->video_frame_rate()) {
+                               _film->set_video_frame_rate(dcp->video_frame_rate().get(), true);
+                       }
                } catch (ProjectFolderError &) {
                        error_dialog (
                                this,
@@ -393,20 +451,20 @@ public:
                _film = film;
                _film->set_tolerant (true);
                _film->set_audio_channels (MAX_DCP_AUDIO_CHANNELS);
-               _viewer->set_film (_film);
+               _viewer.set_film(_film);
                _controls->set_film (_film);
                _film->Change.connect (bind(&DOMFrame::film_changed, this, _1, _2));
                _info->triggered_update ();
        }
 
-       void film_changed (ChangeType type, Film::Property property)
+       void film_changed (ChangeType type, FilmProperty property)
        {
-               if (type != ChangeType::DONE || property != Film::Property::CONTENT) {
+               if (type != ChangeType::DONE || property != FilmProperty::CONTENT) {
                        return;
                }
 
-               if (_viewer->playing ()) {
-                       _viewer->stop ();
+               if (_viewer.playing()) {
+                       _viewer.stop();
                }
 
                /* Start off as Flat */
@@ -419,8 +477,8 @@ public:
                                j->set_use (true);
                        }
 
-                       if (i->video) {
-                               auto const r = Ratio::nearest_from_ratio(i->video->size().ratio());
+                       if (i->video && i->video->size()) {
+                               auto const r = Ratio::nearest_from_ratio(i->video->size()->ratio());
                                if (r->id() == "239") {
                                        /* Any scope content means we use scope */
                                        _film->set_container(r);
@@ -433,7 +491,7 @@ public:
                        }
                }
 
-               _viewer->seek (DCPTime(), true);
+               _viewer.seek(DCPTime(), true);
                _info->triggered_update ();
 
                set_menu_sensitivity ();
@@ -517,7 +575,7 @@ private:
 #endif
 
 #ifdef __WXOSX__
-               auto prefs = _file_menu->Append (wxID_PREFERENCES, _("&Preferences...\tCtrl-P"));
+               auto prefs = _file_menu->Append(wxID_PREFERENCES, _("&Preferences...\tCtrl-,"));
 #else
                auto edit = new wxMenu;
                auto prefs = edit->Append (wxID_PREFERENCES, _("&Preferences...\tCtrl-P"));
@@ -573,7 +631,7 @@ private:
                        d = std_to_wx (Config::instance()->last_player_load_directory()->string());
                }
 
-               auto c = new wxDirDialog (this, _("Select DCP to open"), d, wxDEFAULT_DIALOG_STYLE | wxDD_DIR_MUST_EXIST);
+               auto c = make_wx<wxDirDialog>(this, _("Select DCP to open"), d, wxDEFAULT_DIALOG_STYLE | wxDD_DIR_MUST_EXIST);
 
                int r;
                while (true) {
@@ -590,16 +648,19 @@ private:
                        load_dcp (dcp);
                        Config::instance()->set_last_player_load_directory (dcp.parent_path());
                }
-
-               c->Destroy ();
        }
 
        void file_add_ov ()
        {
-               auto c = new wxDirDialog (
+               auto initial_dir = wxStandardPaths::Get().GetDocumentsDir();
+               if (Config::instance()->last_player_load_directory()) {
+                       initial_dir = std_to_wx(Config::instance()->last_player_load_directory()->string());
+               }
+
+               auto c = make_wx<wxDirDialog>(
                        this,
                        _("Select DCP to open as OV"),
-                       wxStandardPaths::Get().GetDocumentsDir(),
+                       initial_dir,
                        wxDEFAULT_DIALOG_STYLE | wxDD_DIR_MUST_EXIST
                        );
 
@@ -626,47 +687,49 @@ private:
                        for (auto i: dcp->text) {
                                i->set_use (true);
                        }
-                       if (dcp->video) {
-                               auto const r = Ratio::nearest_from_ratio(dcp->video->size().ratio());
+                       if (dcp->video && dcp->video->size()) {
+                               auto const r = Ratio::nearest_from_ratio(dcp->video->size()->ratio());
                                if (r) {
                                        _film->set_container(r);
                                }
                        }
                }
 
-               c->Destroy ();
                _info->triggered_update ();
        }
 
        void file_add_kdm ()
        {
-               auto d = new wxFileDialog (this, _("Select KDM"));
+               FileDialog dialog(this, _("Select KDM"), wxT("XML files|*.xml|All files|*.*"), wxFD_MULTIPLE, "AddKDMPath");
 
-               if (d->ShowModal() == wxID_OK) {
+               if (dialog.show()) {
                        DCPOMATIC_ASSERT (_film);
                        auto dcp = std::dynamic_pointer_cast<DCPContent>(_film->content().front());
                        DCPOMATIC_ASSERT (dcp);
                        try {
                                if (dcp) {
-                                       _viewer->set_coalesce_player_changes (true);
-                                       dcp->add_kdm (dcp::EncryptedKDM(dcp::file_to_string(wx_to_std(d->GetPath()), MAX_KDM_SIZE)));
+                                       dcp::ScopeGuard sg([this]() {
+                                               _viewer.set_coalesce_player_changes(false);
+                                       });
+                                       _viewer.set_coalesce_player_changes(true);
+                                       for (auto path: dialog.paths()) {
+                                               dcp->add_kdm(dcp::EncryptedKDM(dcp::file_to_string(path)));
+                                               _kdms.push_back(path);
+                                       }
                                        examine_content();
-                                       _viewer->set_coalesce_player_changes (false);
                                }
                        } catch (exception& e) {
                                error_dialog (this, wxString::Format (_("Could not load KDM.")), std_to_wx(e.what()));
-                               d->Destroy ();
                                return;
                        }
                }
 
-               d->Destroy ();
                _info->triggered_update ();
        }
 
        void file_save_frame ()
        {
-               wxFileDialog dialog (this, _("Save frame to file"), "", "", "PNG files (*.png)|*.png|JPEG files (*.jpg,*.jpeg)|*.jpg,*.jpeg", wxFD_SAVE | wxFD_OVERWRITE_PROMPT);
+               wxFileDialog dialog (this, _("Save frame to file"), "", "", "PNG files (*.png)|*.png|JPEG files (*.jpg;*.jpeg)|*.jpg;*.jpeg", wxFD_SAVE | wxFD_OVERWRITE_PROMPT);
                if (dialog.ShowModal() == wxID_CANCEL) {
                        return;
                }
@@ -674,7 +737,7 @@ private:
                auto path = boost::filesystem::path (wx_to_std(dialog.GetPath()));
 
                auto player = make_shared<Player>(_film, Image::Alignment::PADDED);
-               player->seek (_viewer->position(), true);
+               player->seek(_viewer.position(), true);
 
                bool done = false;
                player->Video.connect ([path, &done, this](shared_ptr<PlayerVideo> video, DCPTime) {
@@ -751,10 +814,10 @@ private:
                        --id;
                }
 
-               _viewer->set_coalesce_player_changes (true);
+               _viewer.set_coalesce_player_changes(true);
                dcp->set_cpl ((*i)->id());
                examine_content ();
-               _viewer->set_coalesce_player_changes (false);
+               _viewer.set_coalesce_player_changes(false);
 
                _info->triggered_update ();
        }
@@ -797,32 +860,41 @@ private:
                _info->Show (_mode != Config::PLAYER_MODE_FULL);
                _overall_panel->SetBackgroundColour (_mode == Config::PLAYER_MODE_FULL ? wxColour(0, 0, 0) : wxNullColour);
                ShowFullScreen (_mode == Config::PLAYER_MODE_FULL);
-               _viewer->set_pad_black (_mode != Config::PLAYER_MODE_WINDOW);
+               _viewer.set_pad_black(_mode != Config::PLAYER_MODE_WINDOW);
 
                if (_mode == Config::PLAYER_MODE_DUAL) {
                        _dual_screen = new wxFrame (this, wxID_ANY, wxT(""));
                        _dual_screen->SetBackgroundColour (wxColour(0, 0, 0));
                        _dual_screen->ShowFullScreen (true);
-                       _viewer->panel()->Reparent (_dual_screen);
-                       _viewer->panel()->SetFocus();
+                       _viewer.panel()->Reparent(_dual_screen);
+                       _viewer.panel()->SetFocus();
                        _dual_screen->Show ();
+                       LOG_DEBUG_PLAYER("Setting up dual screen mode with %1 displays", wxDisplay::GetCount());
+                       for (auto index = 0U; index < wxDisplay::GetCount(); ++index) {
+                               wxDisplay display(index);
+                               auto client = display.GetClientArea();
+                               auto mode = display.GetCurrentMode();
+                               auto geometry = display.GetGeometry();
+                               LOG_DEBUG_PLAYER("Display %1", index);
+                               LOG_DEBUG_PLAYER("  ClientArea position=(%1, %2) size=(%3, %4)", client.GetX(), client.GetY(), client.GetWidth(), client.GetHeight());
+                               LOG_DEBUG_PLAYER("  Geometry   position=(%1, %2) size=(%3, %4)", geometry.GetX(), geometry.GetY(), geometry.GetWidth(), geometry.GetHeight());
+                               LOG_DEBUG_PLAYER("  Mode       size=(%1, %2)", mode.GetWidth(), mode.GetHeight());
+                               LOG_DEBUG_PLAYER("  Primary?   %1", static_cast<int>(display.IsPrimary()));
+                       }
                        if (wxDisplay::GetCount() > 1) {
-                               switch (Config::instance()->image_display()) {
-                               case 0:
-                                       _dual_screen->Move (0, 0);
-                                       Move (wxDisplay(0U).GetClientArea().GetWidth(), 0);
-                                       break;
-                               case 1:
-                                       _dual_screen->Move (wxDisplay(0U).GetClientArea().GetWidth(), 0);
-                                       // (0, 0) doesn't seem to work for some strange reason
-                                       Move (8, 8);
-                                       break;
-                               }
+                               wxRect geometry[2] = {
+                                       wxDisplay(0U).GetGeometry(),
+                                       wxDisplay(1U).GetGeometry()
+                               };
+                               auto const image_display = Config::instance()->image_display();
+                               _dual_screen->Move(geometry[image_display].GetX(), geometry[image_display].GetY());
+                               _viewer.panel()->SetSize(geometry[image_display].GetWidth(), geometry[image_display].GetHeight());
+                               Move(geometry[1 - image_display].GetX(), geometry[1 - image_display].GetY());
                        }
                        _dual_screen->Bind(wxEVT_CHAR_HOOK, boost::bind(&DOMFrame::dual_screen_key_press, this, _1));
                } else {
                        if (_dual_screen) {
-                               _viewer->panel()->Reparent (_overall_panel);
+                               _viewer.panel()->Reparent(_overall_panel);
                                _dual_screen->Destroy ();
                                _dual_screen = 0;
                        }
@@ -844,7 +916,7 @@ private:
 
        void view_closed_captions ()
        {
-               _viewer->show_closed_captions ();
+               _viewer.show_closed_captions();
        }
 
        void tools_verify ()
@@ -852,17 +924,15 @@ private:
                auto dcp = std::dynamic_pointer_cast<DCPContent>(_film->content().front());
                DCPOMATIC_ASSERT (dcp);
 
-               auto job = make_shared<VerifyDCPJob>(dcp->directories());
-               auto progress = new VerifyDCPProgressDialog(this, _("DCP-o-matic Player"));
-               bool const completed = progress->run (job);
-               progress->Destroy ();
-               if (!completed) {
-                       return;
-               }
+               auto job = make_shared<VerifyDCPJob>(dcp->directories(), _kdms);
+               VerifyDCPProgressDialog progress(this, _("DCP-o-matic Player"));
+               bool const completed = progress.run(job);
+               progress.Close();
 
-               auto d = new VerifyDCPDialog (this, job);
-               d->ShowModal ();
-               d->Destroy ();
+               if (completed) {
+                       VerifyDCPDialog dialog(this, job);
+                       dialog.ShowModal();
+               }
        }
 
        void tools_check_for_updates ()
@@ -873,9 +943,8 @@ private:
 
        void tools_timing ()
        {
-               auto d = new TimerDisplay (this, _viewer->state_timer(), _viewer->gets());
+               auto d = make_wx<TimerDisplay>(this, _viewer.state_timer(), _viewer.gets());
                d->ShowModal ();
-               d->Destroy ();
        }
 
        void tools_system_information ()
@@ -889,18 +958,16 @@ private:
 
        void help_about ()
        {
-               auto d = new AboutDialog (this);
+               auto d = make_wx<AboutDialog>(this);
                d->ShowModal ();
-               d->Destroy ();
        }
 
        void help_report_a_problem ()
        {
-               auto d = new ReportProblemDialog (this);
+               auto d = make_wx<ReportProblemDialog>(this);
                if (d->ShowModal () == wxID_OK) {
                        d->report ();
                }
-               d->Destroy ();
        }
 
        void update_checker_state_changed ()
@@ -919,9 +986,8 @@ private:
                }
 
                if (uc->state() == UpdateChecker::State::YES) {
-                       auto dialog = new UpdateDialog (this, uc->stable (), uc->test ());
+                       auto dialog = make_wx<UpdateDialog>(this, uc->stable (), uc->test ());
                        dialog->ShowModal ();
-                       dialog->Destroy ();
                } else if (uc->state() == UpdateChecker::State::FAILED) {
                        error_dialog (this, _("The DCP-o-matic download server could not be contacted."));
                } else {
@@ -1012,36 +1078,36 @@ private:
 
        void start_stop_pressed ()
        {
-               if (_viewer->playing()) {
-                       _viewer->stop();
+               if (_viewer.playing()) {
+                       _viewer.stop();
                } else {
-                       _viewer->start();
+                       _viewer.start();
                }
        }
 
        void go_back_frame ()
        {
-               _viewer->seek_by (-_viewer->one_video_frame(), true);
+               _viewer.seek_by(-_viewer.one_video_frame(), true);
        }
 
        void go_forward_frame ()
        {
-               _viewer->seek_by (_viewer->one_video_frame(), true);
+               _viewer.seek_by(_viewer.one_video_frame(), true);
        }
 
        void go_seconds (int s)
        {
-               _viewer->seek_by (DCPTime::from_seconds(s), true);
+               _viewer.seek_by(DCPTime::from_seconds(s), true);
        }
 
        void go_to_start ()
        {
-               _viewer->seek (DCPTime(), true);
+               _viewer.seek(DCPTime(), true);
        }
 
        void go_to_end ()
        {
-               _viewer->seek (_film->length() - _viewer->one_video_frame(), true);
+               _viewer.seek(_film->length() - _viewer.one_video_frame(), true);
        }
 
        wxFrame* _dual_screen = nullptr;
@@ -1056,7 +1122,7 @@ private:
        int _history_items = 0;
        int _history_position = 0;
        wxMenuItem* _history_separator = nullptr;
-       shared_ptr<FilmViewer> _viewer;
+       FilmViewer _viewer;
        Controls* _controls;
        SystemInformationDialog* _system_information_dialog = nullptr;
        std::shared_ptr<Film> _film;
@@ -1070,6 +1136,8 @@ private:
        wxMenuItem* _view_dual_screen = nullptr;
        wxSizer* _main_sizer = nullptr;
        PlayerStressTester _stress;
+       /** KDMs that have been loaded, so that we can pass them to the verifier */
+       std::vector<boost::filesystem::path> _kdms;
 };
 
 static const wxCmdLineEntryDesc command_line_description[] = {
@@ -1090,7 +1158,10 @@ public:
        void handle (shared_ptr<Socket> socket) override
        {
                try {
-                       int const length = socket->read_uint32 ();
+                       uint32_t const length = socket->read_uint32 ();
+                       if (length > 65536) {
+                               return;
+                       }
                        scoped_array<char> buffer (new char[length]);
                        socket->read (reinterpret_cast<uint8_t*> (buffer.get()), length);
                        string s (buffer.get());
@@ -1123,7 +1194,7 @@ private:
 
        bool OnInit () override
        {
-               wxSplashScreen* splash = nullptr;
+               wxSplashScreen* splash;
                try {
                        wxInitAllImageHandlers ();
 
@@ -1187,7 +1258,7 @@ private:
                                LOG_DEBUG_PLAYER ("Failed to start play server (%1)", e.what());
                        }
 
-                       if (!_dcp_to_load.empty() && boost::filesystem::is_directory (_dcp_to_load)) {
+                       if (!_dcp_to_load.empty() && dcp::filesystem::is_directory(_dcp_to_load)) {
                                try {
                                        _frame->load_dcp (_dcp_to_load);
                                } catch (exception& e) {