#include "lib/ffmpeg_content.h"
#include "lib/audio_content.h"
#include <dcp/cpl.h>
+#include <dcp/exceptions.h>
#include <wx/wx.h>
#include <wx/dirdlg.h>
#include <boost/foreach.hpp>
using boost::dynamic_pointer_cast;
enum {
- /* Start at 256 so we can have IDs on _cpl_menu from 0 to 255 */
+ /* Start at 256 so we can have IDs on _cpl_menu from 1 to 255 */
ID_repeat = 256,
ID_join,
ID_find_missing,
_menu->AppendSeparator ();
_remove = _menu->Append (ID_remove, _("Remove"));
- _parent->Bind (wxEVT_COMMAND_MENU_SELECTED, boost::bind (&ContentMenu::repeat, this), ID_repeat);
- _parent->Bind (wxEVT_COMMAND_MENU_SELECTED, boost::bind (&ContentMenu::join, this), ID_join);
- _parent->Bind (wxEVT_COMMAND_MENU_SELECTED, boost::bind (&ContentMenu::find_missing, this), ID_find_missing);
- _parent->Bind (wxEVT_COMMAND_MENU_SELECTED, boost::bind (&ContentMenu::properties, this), ID_properties);
- _parent->Bind (wxEVT_COMMAND_MENU_SELECTED, boost::bind (&ContentMenu::re_examine, this), ID_re_examine);
- _parent->Bind (wxEVT_COMMAND_MENU_SELECTED, boost::bind (&ContentMenu::kdm, this), ID_kdm);
- _parent->Bind (wxEVT_COMMAND_MENU_SELECTED, boost::bind (&ContentMenu::ov, this), ID_ov);
- _parent->Bind (wxEVT_COMMAND_MENU_SELECTED, boost::bind (&ContentMenu::remove, this), ID_remove);
+ _parent->Bind (wxEVT_MENU, boost::bind (&ContentMenu::repeat, this), ID_repeat);
+ _parent->Bind (wxEVT_MENU, boost::bind (&ContentMenu::join, this), ID_join);
+ _parent->Bind (wxEVT_MENU, boost::bind (&ContentMenu::find_missing, this), ID_find_missing);
+ _parent->Bind (wxEVT_MENU, boost::bind (&ContentMenu::properties, this), ID_properties);
+ _parent->Bind (wxEVT_MENU, boost::bind (&ContentMenu::re_examine, this), ID_re_examine);
+ _parent->Bind (wxEVT_MENU, boost::bind (&ContentMenu::kdm, this), ID_kdm);
+ _parent->Bind (wxEVT_MENU, boost::bind (&ContentMenu::ov, this), ID_ov);
+ _parent->Bind (wxEVT_MENU, boost::bind (&ContentMenu::remove, this), ID_remove);
- _parent->Bind (wxEVT_MENU, boost::bind (&ContentMenu::cpl_selected, this, _1), 0, ID_repeat - 1);
+ _parent->Bind (wxEVT_MENU, boost::bind (&ContentMenu::cpl_selected, this, _1), 1, ID_repeat - 1);
}
ContentMenu::~ContentMenu ()
_views = v;
int const N = _cpl_menu->GetMenuItemCount();
- for (int i = 0; i < N; ++i) {
+ for (int i = 1; i <= N; ++i) {
_cpl_menu->Delete (i);
}
if (dcp) {
_kdm->Enable (dcp->encrypted ());
_ov->Enable (dcp->needs_assets ());
- DCPExaminer ex (dcp);
- list<shared_ptr<dcp::CPL> > cpls = ex.cpls ();
- _choose_cpl->Enable (cpls.size() > 1);
- int id = 0;
- BOOST_FOREACH (shared_ptr<dcp::CPL> i, cpls) {
- wxMenuItem* item = _cpl_menu->AppendCheckItem (
- id++,
- wxString::Format (
- "%s (%s)",
- std_to_wx(i->annotation_text()).data(),
- std_to_wx(i->id()).data()
- )
- );
- item->Check (dcp->cpl() && dcp->cpl() == i->id());
+ try {
+ DCPExaminer ex (dcp);
+ list<shared_ptr<dcp::CPL> > cpls = ex.cpls ();
+ _choose_cpl->Enable (cpls.size() > 1);
+ /* We can't have 0 as a menu item ID on OS X */
+ int id = 1;
+ BOOST_FOREACH (shared_ptr<dcp::CPL> i, cpls) {
+ wxMenuItem* item = _cpl_menu->AppendCheckItem (
+ id++,
+ wxString::Format (
+ "%s (%s)",
+ std_to_wx(i->annotation_text()).data(),
+ std_to_wx(i->id()).data()
+ )
+ );
+ item->Check (dcp->cpl() && dcp->cpl() == i->id());
+ }
+ } catch (dcp::DCPReadError) {
+ /* The DCP is probably missing */
}
} else {
_kdm->Enable (false);
DCPExaminer ex (dcp);
list<shared_ptr<dcp::CPL> > cpls = ex.cpls ();
- DCPOMATIC_ASSERT (ev.GetId() < int (cpls.size()));
+ DCPOMATIC_ASSERT (ev.GetId() > 0);
+ DCPOMATIC_ASSERT (ev.GetId() <= int (cpls.size()));
list<shared_ptr<dcp::CPL> >::const_iterator i = cpls.begin ();
- for (int j = 0; j < ev.GetId(); ++j) {
+ for (int j = 0; j < ev.GetId() - 1; ++j) {
++i;
}