Fix crash if quick_refresh() fails.
[dcpomatic.git] / src / wx / film_viewer.cc
index 5c218ae44e3b77b1e4c8b7b6006bc334c7e39fec..ade45d766879ab4030f5dfcdc80fc9ea6b462535 100644 (file)
@@ -87,7 +87,8 @@ FilmViewer::FilmViewer (wxWindow* p, bool outline_content, bool jump_to_selected
        , _timecode (new wxStaticText (this, wxID_ANY, wxT("")))
        , _play_button (new wxToggleButton (this, wxID_ANY, _("Play")))
        , _coalesce_player_changes (false)
-       , _pending_player_change (false)
+       , _slider_being_moved (false)
+       , _was_running_before_slider (false)
        , _audio (DCPOMATIC_RTAUDIO_API)
        , _audio_channels (0)
        , _audio_block_size (1024)
@@ -144,12 +145,12 @@ FilmViewer::FilmViewer (wxWindow* p, bool outline_content, bool jump_to_selected
        if (_outline_content) {
                _outline_content->Bind  (wxEVT_CHECKBOX, boost::bind (&FilmViewer::refresh_panel,   this));
        }
-       _left_eye->Bind         (wxEVT_RADIOBUTTON,       boost::bind (&FilmViewer::refresh,         this));
-       _right_eye->Bind        (wxEVT_RADIOBUTTON,       boost::bind (&FilmViewer::refresh,         this));
+       _left_eye->Bind         (wxEVT_RADIOBUTTON,       boost::bind (&FilmViewer::slow_refresh,    this));
+       _right_eye->Bind        (wxEVT_RADIOBUTTON,       boost::bind (&FilmViewer::slow_refresh,    this));
        _slider->Bind           (wxEVT_SCROLL_THUMBTRACK, boost::bind (&FilmViewer::slider_moved,    this, false));
-       _slider->Bind           (wxEVT_SCROLL_PAGEUP,     boost::bind (&FilmViewer::slider_moved,    this, false));
-       _slider->Bind           (wxEVT_SCROLL_PAGEDOWN,   boost::bind (&FilmViewer::slider_moved,    this, false));
-       _slider->Bind           (wxEVT_SCROLL_CHANGED,    boost::bind (&FilmViewer::slider_moved,    this, true));
+       _slider->Bind           (wxEVT_SCROLL_PAGEUP,     boost::bind (&FilmViewer::slider_moved,    this, true));
+       _slider->Bind           (wxEVT_SCROLL_PAGEDOWN,   boost::bind (&FilmViewer::slider_moved,    this, true));
+       _slider->Bind           (wxEVT_SCROLL_THUMBRELEASE, boost::bind (&FilmViewer::slider_released, this));
        _play_button->Bind      (wxEVT_TOGGLEBUTTON,      boost::bind (&FilmViewer::play_clicked,    this));
        _timer.Bind             (wxEVT_TIMER,             boost::bind (&FilmViewer::timer,           this));
        _rewind_button->Bind    (wxEVT_LEFT_DOWN,         boost::bind (&FilmViewer::rewind_clicked,  this, _1));
@@ -220,7 +221,7 @@ FilmViewer::set_film (shared_ptr<Film> film)
        _player->set_play_referenced ();
 
        _film->Changed.connect (boost::bind (&FilmViewer::film_changed, this, _1));
-       _player->Changed.connect (boost::bind (&FilmViewer::player_changed, this, _1));
+       _player->Changed.connect (boost::bind (&FilmViewer::player_changed, this, _1, _2));
 
        /* Keep about 1 second's worth of history samples */
        _latency_history_count = _film->audio_frame_rate() / _audio_block_size;
@@ -228,7 +229,7 @@ FilmViewer::set_film (shared_ptr<Film> film)
        recreate_butler ();
 
        calculate_sizes ();
-       refresh ();
+       slow_refresh ();
 
        setup_sensitivity ();
 }
@@ -281,27 +282,32 @@ FilmViewer::get ()
 {
        DCPOMATIC_ASSERT (_butler);
 
-       pair<shared_ptr<PlayerVideo>, DCPTime> video;
        do {
-               video = _butler->get_video ();
+               _player_video = _butler->get_video ();
        } while (
                _film->three_d() &&
-               ((_left_eye->GetValue() && video.first->eyes() == EYES_RIGHT) || (_right_eye->GetValue() && video.first->eyes() == EYES_LEFT))
+               ((_left_eye->GetValue() && _player_video.first->eyes() == EYES_RIGHT) || (_right_eye->GetValue() && _player_video.first->eyes() == EYES_LEFT))
                );
 
        _butler->rethrow ();
 
-       if (!video.first) {
+       display_player_video ();
+}
+
+void
+FilmViewer::display_player_video ()
+{
+       if (!_player_video.first) {
                _frame.reset ();
                refresh_panel ();
                return;
        }
 
-       if (_playing && (time() - video.second) > one_video_frame()) {
+       if (_playing && (time() - _player_video.second) > one_video_frame()) {
                /* Too late; just drop this frame before we try to get its image (which will be the time-consuming
                   part if this frame is J2K).
                */
-               _video_position = video.second;
+               _video_position = _player_video.second;
                ++_dropped;
                return;
        }
@@ -324,17 +330,17 @@ FilmViewer::get ()
         * image and convert it (from whatever the user has said it is) to RGB.
         */
 
-       _frame = video.first->image (
+       _frame = _player_video.first->image (
                bind (&Log::dcp_log, _film->log().get(), _1, _2),
                bind (&PlayerVideo::always_rgb, _1),
                false, true
                );
 
-       ImageChanged (video.first);
+       ImageChanged (_player_video.first);
 
-       _video_position = video.second;
-       _inter_position = video.first->inter_position ();
-       _inter_size = video.first->inter_size ();
+       _video_position = _player_video.second;
+       _inter_position = _player_video.first->inter_position ();
+       _inter_size = _player_video.first->inter_size ();
 
        refresh_panel ();
 }
@@ -400,13 +406,19 @@ FilmViewer::paint_panel ()
        }
 }
 
+/** @param page true if this was a PAGEUP/PAGEDOWN event for which we won't receive a THUMBRELEASE */
 void
-FilmViewer::slider_moved (bool update_slider)
+FilmViewer::slider_moved (bool page)
 {
        if (!_film) {
                return;
        }
 
+       if (!page && !_slider_being_moved) {
+               /* This is the first event of a drag; stop playback for the duration of the drag */
+               _was_running_before_slider = stop ();
+               _slider_being_moved = true;
+       }
 
        DCPTime t (_slider->GetValue() * _film->length().get() / 4096);
        /* Ensure that we hit the end of the film at the end of the slider */
@@ -415,9 +427,16 @@ FilmViewer::slider_moved (bool update_slider)
        }
        seek (t, false);
        update_position_label ();
-       if (update_slider) {
-               update_position_slider ();
+}
+
+void
+FilmViewer::slider_released ()
+{
+       if (_was_running_before_slider) {
+               /* Restart after a drag */
+               start ();
        }
+       _slider_being_moved = false;
 }
 
 void
@@ -427,7 +446,9 @@ FilmViewer::panel_sized (wxSizeEvent& ev)
        _panel_size.height = ev.GetSize().GetHeight();
 
        calculate_sizes ();
-       refresh ();
+       if (!quick_refresh()) {
+               slow_refresh ();
+       }
        update_position_label ();
        update_position_slider ();
 }
@@ -608,19 +629,34 @@ FilmViewer::forward_clicked (wxMouseEvent& ev)
 }
 
 void
-FilmViewer::player_changed (bool frequent)
+FilmViewer::player_changed (int property, bool frequent)
 {
        if (frequent) {
                return;
        }
 
        if (_coalesce_player_changes) {
-               _pending_player_change = true;
+               _pending_player_changes.push_back (property);
                return;
        }
 
        calculate_sizes ();
-       refresh ();
+       bool refreshed = false;
+       if (
+               property == VideoContentProperty::CROP ||
+               property == VideoContentProperty::SCALE ||
+               property == VideoContentProperty::FADE_IN ||
+               property == VideoContentProperty::FADE_OUT ||
+               property == VideoContentProperty::COLOUR_CONVERSION ||
+               property == PlayerProperty::VIDEO_CONTAINER_SIZE ||
+               property == PlayerProperty::FILM_CONTAINER
+               ) {
+               refreshed = quick_refresh ();
+       }
+
+       if (!refreshed) {
+               slow_refresh ();
+       }
        update_position_label ();
        update_position_slider ();
 }
@@ -653,16 +689,37 @@ FilmViewer::film_changed (Film::Property p)
 {
        if (p == Film::CONTENT || p == Film::THREE_D) {
                setup_sensitivity ();
+       } else if (p == Film::AUDIO_CHANNELS) {
+               recreate_butler ();
        }
 }
 
-/** Re-get the current frame */
+/** Re-get the current frame slowly by seeking */
 void
-FilmViewer::refresh ()
+FilmViewer::slow_refresh ()
 {
        seek (_video_position, true);
 }
 
+/** Try to re-get the current frame quickly by resetting the metadata
+ *  in the PlayerVideo that we used last time.
+ *  @return true if this was possible, false if not.
+ */
+bool
+FilmViewer::quick_refresh ()
+{
+       if (!_player_video.first) {
+               return false;
+       }
+
+       if (!_player_video.first->reset_metadata (_player->video_container_size(), _film->frame_size())) {
+               return false;
+       }
+
+       display_player_video ();
+       return true;
+}
+
 void
 FilmViewer::set_position (DCPTime p)
 {
@@ -677,12 +734,11 @@ FilmViewer::set_coalesce_player_changes (bool c)
 {
        _coalesce_player_changes = c;
 
-       if (c) {
-               _pending_player_change = false;
-       } else {
-               if (_pending_player_change) {
-                       player_changed (false);
+       if (!c) {
+               BOOST_FOREACH (int i, _pending_player_changes) {
+                       player_changed (i, false);
                }
+               _pending_player_changes.clear ();
        }
 }