Emit no audio from DCPs if none is mapped

[dcpomatic.git] / src / wx / kdm_cpl_panel.cc

diff --git a/src/wx/kdm_cpl_panel.cc b/src/wx/kdm_cpl_panel.cc
index 8b4d93129dcd7d7a84e677a64748ea2f722ebb6e..4699582aac538a4302a2472ae7307e336a0410da 100644 (file)
--- a/src/wx/kdm_cpl_panel.cc
+++ b/src/wx/kdm_cpl_panel.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2015-2019 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2015-2021 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -18,32 +18,38 @@
 
 */
 
+
+#include "dcpomatic_button.h"
 #include "kdm_cpl_panel.h"
-#include "wx_util.h"
 #include "static_text.h"
-#include "dcpomatic_button.h"
+#include "wx_util.h"
+#include <dcp/warnings.h>
+LIBDCP_DISABLE_WARNINGS
+#include <libxml++/libxml++.h>
+LIBDCP_ENABLE_WARNINGS
 #include <libcxml/cxml.h>
-#include <boost/foreach.hpp>
+
 
 using std::vector;
 
+
 KDMCPLPanel::KDMCPLPanel (wxWindow* parent, vector<CPLSummary> cpls)
        : wxPanel (parent, wxID_ANY)
        , _cpls (cpls)
 {
-       wxBoxSizer* vertical = new wxBoxSizer (wxVERTICAL);
+       auto vertical = new wxBoxSizer (wxVERTICAL);
 
        /* CPL choice */
-       wxBoxSizer* s = new wxBoxSizer (wxHORIZONTAL);
-       add_label_to_sizer (s, this, _("CPL"), true);
+       auto s = new wxBoxSizer (wxHORIZONTAL);
+       add_label_to_sizer (s, this, _("CPL"), true, 0, wxLEFT | wxRIGHT | wxALIGN_CENTER_VERTICAL);
        _cpl = new wxChoice (this, wxID_ANY);
        s->Add (_cpl, 1, wxEXPAND);
        _cpl_browse = new Button (this, _("Browse..."));
-       s->Add (_cpl_browse, 0, wxALIGN_CENTER_VERTICAL);
+       s->Add (_cpl_browse, 0, wxLEFT | wxALIGN_CENTER_VERTICAL, DCPOMATIC_SIZER_X_GAP);
        vertical->Add (s, 0, wxEXPAND | wxTOP, DCPOMATIC_SIZER_GAP + 2);
 
        /* CPL details */
-       wxFlexGridSizer* table = new wxFlexGridSizer (2, DCPOMATIC_SIZER_X_GAP, DCPOMATIC_SIZER_Y_GAP);
+       auto table = new wxFlexGridSizer(2, DCPOMATIC_SIZER_X_GAP, DCPOMATIC_SIZER_Y_GAP);
        add_label_to_sizer (table, this, _("DCP directory"), true);
        _dcp_directory = new StaticText (this, "");
        table->Add (_dcp_directory);
@@ -57,8 +63,8 @@ KDMCPLPanel::KDMCPLPanel (wxWindow* parent, vector<CPLSummary> cpls)
 
        update_cpl_choice ();
 
-       _cpl->Bind        (wxEVT_CHOICE, boost::bind (&KDMCPLPanel::update_cpl_summary, this));
-       _cpl_browse->Bind (wxEVT_BUTTON,  boost::bind (&KDMCPLPanel::cpl_browse_clicked, this));
+       _cpl->Bind(wxEVT_CHOICE, boost::bind(&KDMCPLPanel::update_cpl_summary, this));
+       _cpl_browse->Bind(wxEVT_BUTTON, boost::bind(&KDMCPLPanel::cpl_browse_clicked, this));
 
        SetSizerAndFit (vertical);
 }
@@ -68,7 +74,7 @@ KDMCPLPanel::update_cpl_choice ()
 {
        _cpl->Clear ();
 
-       BOOST_FOREACH (CPLSummary const & i, _cpls) {
+       for (auto const& i: _cpls) {
                _cpl->Append (std_to_wx(i.cpl_id));
 
                if (_cpls.size() > 0) {
@@ -89,50 +95,49 @@ KDMCPLPanel::update_cpl_summary ()
 
        _dcp_directory->SetLabel (std_to_wx (_cpls[n].dcp_directory));
        _cpl_id->SetLabel (std_to_wx (_cpls[n].cpl_id));
-       _cpl_annotation_text->SetLabel (std_to_wx (_cpls[n].cpl_annotation_text));
+       _cpl_annotation_text->SetLabel (std_to_wx(_cpls[n].cpl_annotation_text.get_value_or("")));
+
+       Changed();
 }
 
 void
 KDMCPLPanel::cpl_browse_clicked ()
 {
-       wxFileDialog* d = new wxFileDialog (this, _("Select CPL XML file"), wxEmptyString, wxEmptyString, "*.xml");
+       auto d = make_wx<wxFileDialog>(this, _("Select CPL XML file"), wxEmptyString, wxEmptyString, "*.xml");
        if (d->ShowModal() == wxID_CANCEL) {
-               d->Destroy ();
                return;
        }
 
        boost::filesystem::path cpl_file (wx_to_std (d->GetPath ()));
        boost::filesystem::path dcp_dir = cpl_file.parent_path ();
 
-       d->Destroy ();
-
-       /* XXX: hack alert */
-       cxml::Document cpl_document ("CompositionPlaylist");
-       cpl_document.read_file (cpl_file);
-
-       bool encrypted = false;
-       BOOST_FOREACH (cxml::ConstNodePtr i, cpl_document.node_children("ReelList")) {
-               BOOST_FOREACH (cxml::ConstNodePtr j, i->node_children("Reel")) {
-                       BOOST_FOREACH (cxml::ConstNodePtr k, j->node_children("AssetList")) {
-                               BOOST_FOREACH (cxml::ConstNodePtr l, k->node_children()) {
-                                       if (!l->node_children("KeyId").empty()) {
-                                               encrypted = true;
+       try {
+               /* XXX: hack alert */
+               cxml::Document cpl_document ("CompositionPlaylist");
+               cpl_document.read_file(dcp::filesystem::fix_long_path(cpl_file));
+
+               bool encrypted = false;
+               for (auto i: cpl_document.node_children("ReelList")) {
+                       for (auto j: i->node_children("Reel")) {
+                               for (auto k: j->node_children("AssetList")) {
+                                       for (auto l: k->node_children()) {
+                                               if (!l->node_children("KeyId").empty()) {
+                                                       encrypted = true;
+                                               }
                                        }
                                }
                        }
                }
-       }
 
-       if (!encrypted) {
-               error_dialog (this, _("This CPL contains no encrypted assets."));
-               return;
-       }
+               if (!encrypted) {
+                       error_dialog (this, _("This CPL contains no encrypted assets."));
+                       return;
+               }
 
-       /* We're ignoring the CPLSummary timestamp stuff here and just putting the new one in at the end
-          of the list, then selecting it.
-       */
+               /* We're ignoring the CPLSummary timestamp stuff here and just putting the new one in at the end
+                  of the list, then selecting it.
+               */
 
-       try {
                _cpls.push_back (
                        CPLSummary (
                                dcp_dir.filename().string(),
@@ -143,8 +148,11 @@ KDMCPLPanel::cpl_browse_clicked ()
                                0
                                )
                        );
-       } catch (cxml::Error &) {
-               error_dialog (this, _("This is not a valid CPL file"));
+       } catch (xmlpp::exception& e) {
+               error_dialog (this, _("This is not a valid CPL file"), std_to_wx(e.what()));
+               return;
+       } catch (cxml::Error& e) {
+               error_dialog (this, _("This is not a valid CPL file"), std_to_wx(e.what()));
                return;
        }