Improve thumbprint dialog; disallow thumbprint editing and make OK only sensitive...
[dcpomatic.git] / src / wx / screen_dialog.cc
index 3e1d7da547a43bfd26e610f0ad74be2eda77fcf3..7578ca4ca9f7d856f6df44b193a31a13db300291 100644 (file)
@@ -54,12 +54,14 @@ public:
                : TableDialog (parent, _("Trusted Device"), 3, 1, true)
        {
                add (_("Thumbprint"), true);
-               _thumbprint = add (new wxTextCtrl(this, wxID_ANY, wxT(""), wxDefaultPosition, wxSize(300, -1)));
+               _thumbprint = add(new wxTextCtrl(this, wxID_ANY, wxT(""), wxDefaultPosition, wxSize(300, -1), wxTE_READONLY));
                _file = add (new Button(this, _("Load certificate...")));
 
                layout ();
 
                _file->Bind (wxEVT_BUTTON, bind(&TrustedDeviceDialog::load_certificate, this));
+
+               setup_sensitivity();
        }
 
        void load_certificate ()
@@ -72,6 +74,7 @@ public:
                try {
                        _certificate = dcp::Certificate(dcp::file_to_string(dialog.paths()[0]));
                        _thumbprint->SetValue (std_to_wx(_certificate->thumbprint()));
+                       setup_sensitivity();
                } catch (dcp::MiscError& e) {
                        error_dialog(this, wxString::Format(_("Could not load certificate (%s)"), std_to_wx(e.what())));
                }
@@ -81,6 +84,7 @@ public:
        {
                _certificate = t.certificate ();
                _thumbprint->SetValue (std_to_wx(t.thumbprint()));
+               setup_sensitivity();
        }
 
        optional<TrustedDevice> get ()
@@ -96,6 +100,13 @@ public:
        }
 
 private:
+       void setup_sensitivity()
+       {
+               auto ok = dynamic_cast<wxButton*>(FindWindowById(wxID_OK, this));
+               DCPOMATIC_ASSERT(ok);
+               ok->Enable(static_cast<bool>(_certificate));
+       }
+
        wxTextCtrl* _thumbprint;
        wxButton* _file;
        boost::optional<dcp::Certificate> _certificate;
@@ -121,61 +132,66 @@ ScreenDialog::ScreenDialog (
        _sizer = new wxGridBagSizer (DCPOMATIC_SIZER_X_GAP, DCPOMATIC_SIZER_Y_GAP);
        int r = 0;
 
-       add_label_to_sizer (_sizer, this, _("Name"), true, wxGBPosition(r, 0));
+       wxFont subheading_font(*wxNORMAL_FONT);
+       subheading_font.SetWeight(wxFONTWEIGHT_BOLD);
+
+       auto subheading = new StaticText(this, _("Details"));
+       subheading->SetFont(subheading_font);
+       _sizer->Add(subheading, wxGBPosition(r, 0), wxGBSpan(1, 2));
+       ++r;
+
+       add_label_to_sizer(_sizer, this, _("Name"), true, wxGBPosition(r, 0), wxDefaultSpan, true);
        _name = new wxTextCtrl (this, wxID_ANY, std_to_wx (name), wxDefaultPosition, wxSize (320, -1));
        _sizer->Add (_name, wxGBPosition (r, 1));
        ++r;
 
-       add_label_to_sizer (_sizer, this, _("Notes"), true, wxGBPosition(r, 0));
+       add_label_to_sizer(_sizer, this, _("Notes"), true, wxGBPosition(r, 0), wxDefaultSpan, true);
        _notes = new wxTextCtrl (this, wxID_ANY, std_to_wx(notes), wxDefaultPosition, wxSize(320, -1));
        _sizer->Add (_notes, wxGBPosition(r, 1));
        ++r;
 
-        wxClientDC dc (this);
-       wxFont font = _name->GetFont ();
-       font.SetFamily (wxFONTFAMILY_TELETYPE);
-       dc.SetFont (font);
-        wxSize size = dc.GetTextExtent (wxT("1234567890123456789012345678"));
-        size.SetHeight (-1);
-
-       add_label_to_sizer (_sizer, this, _("Recipient certificate"), true, wxGBPosition(r, 0));
-       auto s = new wxBoxSizer (wxHORIZONTAL);
-       _recipient_thumbprint = new StaticText (this, wxT (""), wxDefaultPosition, size);
-       _recipient_thumbprint->SetFont (font);
+       subheading = new StaticText(this, _("Recipient"));
+       subheading->SetFont(subheading_font);
+       _sizer->Add(subheading, wxGBPosition(r, 0), wxGBSpan(1, 2), wxTOP, DCPOMATIC_SUBHEADING_TOP_PAD);
+       ++r;
 
        _get_recipient_from_file = new Button (this, _("Get from file..."));
        _download_recipient = new Button (this, _("Download..."));
-       s->Add (_recipient_thumbprint, 1, wxRIGHT | wxALIGN_CENTER_VERTICAL | wxALIGN_LEFT, DCPOMATIC_SIZER_X_GAP);
+       auto s = new wxBoxSizer (wxHORIZONTAL);
        s->Add (_get_recipient_from_file, 0, wxLEFT | wxRIGHT | wxEXPAND, DCPOMATIC_SIZER_X_GAP);
        s->Add (_download_recipient, 0, wxLEFT | wxRIGHT | wxEXPAND, DCPOMATIC_SIZER_X_GAP);
-       _sizer->Add (s, wxGBPosition (r, 1));
+       _sizer->Add(s, wxGBPosition(r, 0), wxGBSpan(1, 2));
        ++r;
 
-       add_label_to_sizer (_sizer, this, _("Filename"), true, wxGBPosition(r, 0));
-       _recipient_file = new wxStaticText(this, wxID_ANY, wxT(""), wxDefaultPosition, wxSize(600, -1), wxST_ELLIPSIZE_MIDDLE | wxST_NO_AUTORESIZE);
-       set_recipient_file(recipient_file.get_value_or(""));
-       _sizer->Add (_recipient_file, wxGBPosition(r, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL, DCPOMATIC_SIZER_Y_GAP);
-       ++r;
+       auto add_certificate_detail = [&r, this](wxString name, wxStaticText** value, wxSize size = wxDefaultSize) {
+               add_label_to_sizer(_sizer, this, name, true, wxGBPosition(r, 0), wxDefaultSpan, true);
+               *value = new StaticText(this, wxT (""), wxDefaultPosition, size);
+               _sizer->Add(*value, wxGBPosition(r, 1));
+               ++r;
+       };
 
-       add_label_to_sizer(_sizer, this, _("Subject common name"), true, wxGBPosition(r, 0));
-       _subject_common_name = new wxStaticText(this, wxID_ANY, wxT(""));
-       _sizer->Add(_subject_common_name, wxGBPosition(r, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL, DCPOMATIC_SIZER_Y_GAP);
-       ++r;
+        wxClientDC dc (this);
+       wxFont teletype_font = _name->GetFont();
+       teletype_font.SetFamily(wxFONTFAMILY_TELETYPE);
+       dc.SetFont(teletype_font);
+        wxSize size = dc.GetTextExtent (wxT("1234567890123456789012345678"));
+        size.SetHeight (-1);
 
-       add_label_to_sizer(_sizer, this, _("Subject organization name"), true, wxGBPosition(r, 0));
-       _subject_organization_name = new wxStaticText(this, wxID_ANY, wxT(""));
-       _sizer->Add(_subject_organization_name, wxGBPosition(r, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL, DCPOMATIC_SIZER_Y_GAP);
-       ++r;
+       add_certificate_detail(_("Thumbprint"), &_recipient_thumbprint, size);
+       _recipient_thumbprint->SetFont(teletype_font);
 
-       add_label_to_sizer(_sizer, this, _("Issuer common name"), true, wxGBPosition(r, 0));
-       _issuer_common_name = new wxStaticText(this, wxID_ANY, wxT(""));
-       _sizer->Add(_issuer_common_name, wxGBPosition(r, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL, DCPOMATIC_SIZER_Y_GAP);
+       add_label_to_sizer(_sizer, this, _("Filename"), true, wxGBPosition(r, 0), wxDefaultSpan, true);
+       _recipient_file = new wxStaticText(this, wxID_ANY, wxT(""), wxDefaultPosition, wxSize(600, -1), wxST_ELLIPSIZE_MIDDLE | wxST_NO_AUTORESIZE);
+       set_recipient_file(recipient_file.get_value_or(""));
+       _sizer->Add (_recipient_file, wxGBPosition(r, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL, DCPOMATIC_SIZER_Y_GAP);
        ++r;
 
-       add_label_to_sizer(_sizer, this, _("Issuer organization name"), true, wxGBPosition(r, 0));
-       _issuer_organization_name = new wxStaticText(this, wxID_ANY, wxT(""));
-       _sizer->Add(_issuer_organization_name, wxGBPosition(r, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL, DCPOMATIC_SIZER_Y_GAP);
-       ++r;
+       add_certificate_detail(_("Subject common name"), &_subject_common_name);
+       add_certificate_detail(_("Subject organization name"), &_subject_organization_name);
+       add_certificate_detail(_("Issuer common name"), &_issuer_common_name);
+       add_certificate_detail(_("Issuer organization name"), &_issuer_organization_name);
+       add_certificate_detail(_("Not valid before"), &_not_valid_before);
+       add_certificate_detail(_("Not valid after"), &_not_valid_after);
 
        set_recipient (recipient);
 
@@ -187,7 +203,8 @@ ScreenDialog::ScreenDialog (
 #else
                auto m = new StaticText (this, _("Other trusted devices"));
 #endif
-               _sizer->Add (m, wxGBPosition(r, 0), wxDefaultSpan, flags, DCPOMATIC_SIZER_Y_GAP);
+               m->SetFont(subheading_font);
+               _sizer->Add(m, wxGBPosition(r, 0), wxDefaultSpan, flags, DCPOMATIC_SUBHEADING_TOP_PAD);
        }
        ++r;
 
@@ -205,7 +222,7 @@ ScreenDialog::ScreenDialog (
                EditableListButton::NEW | EditableListButton::EDIT | EditableListButton::REMOVE
                );
 
-       _sizer->Add (_trusted_device_list, wxGBPosition (r, 0), wxGBSpan (1, 3), wxEXPAND);
+       _sizer->Add(_trusted_device_list, wxGBPosition (r, 0), wxGBSpan (1, 3), wxEXPAND | wxLEFT, DCPOMATIC_SIZER_X_GAP);
        ++r;
 
        _name->Bind (wxEVT_TEXT, boost::bind (&ScreenDialog::setup_sensitivity, this));
@@ -321,6 +338,8 @@ ScreenDialog::set_recipient (optional<dcp::Certificate> r)
                _subject_organization_name->SetLabel(std_to_wx(_recipient->subject_organization_name()));
                _issuer_common_name->SetLabel(std_to_wx(_recipient->issuer_common_name()));
                _issuer_organization_name->SetLabel(std_to_wx(_recipient->issuer_organization_name()));
+               _not_valid_before->SetLabel(std_to_wx(_recipient->not_before().as_string()));
+               _not_valid_after->SetLabel(std_to_wx(_recipient->not_after().as_string()));
                _sizer->Layout ();
        }
 }