Change bitmap_path to take a full name with extension.
[dcpomatic.git] / src / wx / video_panel.cc
index a2aa6f2349fc76b9cb710debd7fe7b189370f778..e866c59a7fcdef5f3968c23058e59f724effc229 100644 (file)
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2012-2020 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2012-2021 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
 
 */
 
-#include "filter_dialog.h"
-#include "video_panel.h"
-#include "wx_util.h"
+
+#include "check_box.h"
 #include "content_colour_conversion_dialog.h"
-#include "content_widget.h"
 #include "content_panel.h"
-#include "static_text.h"
-#include "check_box.h"
+#include "content_widget.h"
 #include "custom_scale_dialog.h"
 #include "dcpomatic_button.h"
-#include "lib/filter.h"
-#include "lib/ffmpeg_content.h"
+#include "filter_dialog.h"
+#include "static_text.h"
+#include "video_panel.h"
+#include "wx_util.h"
 #include "lib/colour_conversion.h"
 #include "lib/config.h"
-#include "lib/util.h"
-#include "lib/ratio.h"
-#include "lib/frame_rate_change.h"
 #include "lib/dcp_content.h"
+#include "lib/ffmpeg_content.h"
+#include "lib/filter.h"
+#include "lib/frame_rate_change.h"
+#include "lib/ratio.h"
+#include "lib/util.h"
 #include "lib/video_content.h"
+#include <dcp/warnings.h>
+LIBDCP_DISABLE_WARNINGS
 #include <wx/spinctrl.h>
 #include <wx/tglbtn.h>
-#include <boost/foreach.hpp>
-#include <boost/unordered_set.hpp>
+LIBDCP_ENABLE_WARNINGS
 #include <boost/functional/hash.hpp>
+#include <boost/unordered_set.hpp>
 #include <set>
 #include <iostream>
 
+
 using std::vector;
 using std::string;
 using std::pair;
 using std::cout;
 using std::list;
 using std::set;
-using boost::shared_ptr;
-using boost::dynamic_pointer_cast;
+using std::shared_ptr;
+using std::dynamic_pointer_cast;
 using boost::bind;
 using boost::optional;
 using namespace dcpomatic;
+#if BOOST_VERSION >= 106100
+using namespace boost::placeholders;
+#endif
 
 
 VideoPanel::VideoPanel (ContentPanel* p)
        : ContentSubPanel (p, _("Video"))
+{
+
+}
+
+
+void
+VideoPanel::create ()
 {
        _reference = new CheckBox (this, _("Use this DCP's video as OV and make VF"));
        _reference_note = new StaticText (this, wxT(""));
        _reference_note->Wrap (200);
-       wxFont font = _reference_note->GetFont();
+       auto font = _reference_note->GetFont();
        font.SetStyle(wxFONTSTYLE_ITALIC);
        font.SetPointSize(font.GetPointSize() - 1);
        _reference_note->SetFont(font);
@@ -83,11 +97,21 @@ VideoPanel::VideoPanel (ContentPanel* p)
 
        _crop_label = create_label (this, _("Crop"), true);
 
-#ifdef __WXGTK3__
+#if defined(__WXGTK3__)
        int const crop_width = 128;
+       int const link_width = 32;
        int const link_height = 64;
+#elif defined(__WXGTK20__)
+       int const crop_width = 56;
+       int const link_width = 24;
+       int const link_height = 32;
+#elif defined(DCPOMATIC_OSX)
+       int const crop_width = 56;
+       int const link_width = 23;
+       int const link_height = 28;
 #else
        int const crop_width = 56;
+       int const link_width = 22;
        int const link_height = 28;
 #endif
 
@@ -97,13 +121,13 @@ VideoPanel::VideoPanel (ContentPanel* p)
                new wxSpinCtrl (this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxSize(crop_width, -1)),
                VideoContentProperty::CROP,
                &Content::video,
-               boost::mem_fn (&VideoContent::left_crop),
+               boost::mem_fn (&VideoContent::requested_left_crop),
                boost::mem_fn (&VideoContent::set_left_crop),
                boost::bind (&VideoPanel::left_crop_changed, this)
                );
 
-       _left_right_link = new wxToggleButton (this, wxID_ANY, wxT(""), wxDefaultPosition, wxSize(22, link_height));
-       _left_right_link->SetBitmap (wxBitmap(bitmap_path("link"), wxBITMAP_TYPE_PNG));
+       _left_right_link = new wxToggleButton (this, wxID_ANY, wxT(""), wxDefaultPosition, wxSize(link_width, link_height));
+       _left_right_link->SetBitmap (wxBitmap(bitmap_path("link.png"), wxBITMAP_TYPE_PNG));
 
        _right_crop_label = create_label (this, _("Right"), true);
        _right_crop = new ContentSpinCtrl<VideoContent> (
@@ -111,7 +135,7 @@ VideoPanel::VideoPanel (ContentPanel* p)
                new wxSpinCtrl (this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxSize(crop_width, -1)),
                VideoContentProperty::CROP,
                &Content::video,
-               boost::mem_fn (&VideoContent::right_crop),
+               boost::mem_fn (&VideoContent::requested_right_crop),
                boost::mem_fn (&VideoContent::set_right_crop),
                boost::bind (&VideoPanel::right_crop_changed, this)
                );
@@ -122,13 +146,13 @@ VideoPanel::VideoPanel (ContentPanel* p)
                new wxSpinCtrl (this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxSize(crop_width, -1)),
                VideoContentProperty::CROP,
                &Content::video,
-               boost::mem_fn (&VideoContent::top_crop),
+               boost::mem_fn (&VideoContent::requested_top_crop),
                boost::mem_fn (&VideoContent::set_top_crop),
                boost::bind (&VideoPanel::top_crop_changed, this)
                );
 
-       _top_bottom_link = new wxToggleButton (this, wxID_ANY, wxT(""), wxDefaultPosition, wxSize(22, link_height));
-       _top_bottom_link->SetBitmap (wxBitmap(bitmap_path("link"), wxBITMAP_TYPE_PNG));
+       _top_bottom_link = new wxToggleButton (this, wxID_ANY, wxT(""), wxDefaultPosition, wxSize(link_width, link_height));
+       _top_bottom_link->SetBitmap (wxBitmap(bitmap_path("link.png"), wxBITMAP_TYPE_PNG));
 
        _bottom_crop_label = create_label (this, _("Bottom"), true);
        _bottom_crop = new ContentSpinCtrl<VideoContent> (
@@ -136,7 +160,7 @@ VideoPanel::VideoPanel (ContentPanel* p)
                new wxSpinCtrl (this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxSize(crop_width, -1)),
                VideoContentProperty::CROP,
                &Content::video,
-               boost::mem_fn (&VideoContent::bottom_crop),
+               boost::mem_fn (&VideoContent::requested_bottom_crop),
                boost::mem_fn (&VideoContent::set_bottom_crop),
                boost::bind (&VideoPanel::bottom_crop_changed, this)
                );
@@ -148,7 +172,7 @@ VideoPanel::VideoPanel (ContentPanel* p)
        _fade_out = new Timecode<ContentTime> (this);
 
        wxClientDC dc (this);
-       wxSize size = dc.GetTextExtent (wxT ("A quite long name"));
+       auto size = dc.GetTextExtent (wxT ("A quite long name"));
 #ifdef __WXGTK3__
        size.SetWidth (size.GetWidth() + 64);
 #endif
@@ -157,18 +181,18 @@ VideoPanel::VideoPanel (ContentPanel* p)
        _scale_label = create_label (this, _("Scale"), true);
        _scale_fit = new wxRadioButton (this, wxID_ANY, _("to fit DCP"));
        _scale_custom = new wxRadioButton (this, wxID_ANY, _("custom"));
-       _scale_custom_edit = new Button (this, _("Edit..."));
+       _scale_custom_edit = new Button (this, _("Edit..."), wxDefaultPosition, small_button_size(this, _("Edit...")));
 
-       _colour_conversion_label = create_label (this, _("Colour conversion"), true);
+       _colour_conversion_label = create_label (this, _("Colour"), true);
        _colour_conversion = new wxChoice (this, wxID_ANY, wxDefaultPosition, size);
        _colour_conversion->Append (_("None"));
-       BOOST_FOREACH (PresetColourConversion const & i, PresetColourConversion::all()) {
+       for (auto const& i: PresetColourConversion::all()) {
                _colour_conversion->Append (std_to_wx (i.name));
        }
 
        /// TRANSLATORS: translate the word "Custom" here; do not include the "Colour|" prefix
        _colour_conversion->Append (S_("Colour|Custom"));
-       _edit_colour_conversion_button = new Button (this, _("Edit..."));
+       _edit_colour_conversion_button = new Button (this, _("Edit..."), wxDefaultPosition, small_button_size(this, _("Edit...")));
 
        _range_label = create_label (this, _("Range"), true);
        _range = new wxChoice (this, wxID_ANY);
@@ -207,71 +231,58 @@ VideoPanel::VideoPanel (ContentPanel* p)
        _top_bottom_link->Bind               (wxEVT_TOGGLEBUTTON, boost::bind(&VideoPanel::top_bottom_link_clicked, this));
 
        add_to_grid ();
+
+       _sizer->Layout ();
 }
 
+
 void
 VideoPanel::add_to_grid ()
 {
-       bool const full = Config::instance()->interface_complexity() == Config::INTERFACE_FULL;
-
        int r = 0;
 
-       _reference->Show (full);
-       _reference_note->Show (full && !_reference_note->GetLabel().IsEmpty());
-
-       if (full) {
-               wxBoxSizer* reference_sizer = new wxBoxSizer (wxVERTICAL);
-               reference_sizer->Add (_reference, 0);
-               reference_sizer->Add (_reference_note, 0);
-               _grid->Add (reference_sizer, wxGBPosition(r, 0), wxGBSpan(1, 3));
-               ++r;
-       }
+       auto reference_sizer = new wxBoxSizer (wxVERTICAL);
+       reference_sizer->Add (_reference, 0);
+       reference_sizer->Add (_reference_note, 0);
+       _grid->Add (reference_sizer, wxGBPosition(r, 0), wxGBSpan(1, 3));
+       ++r;
 
        add_label_to_sizer (_grid, _type_label, true, wxGBPosition(r, 0));
        _frame_type->add (_grid, wxGBPosition(r, 1), wxGBSpan(1, 2));
        ++r;
 
        int cr = 0;
-       wxGridBagSizer* crop = new wxGridBagSizer (DCPOMATIC_SIZER_X_GAP, DCPOMATIC_SIZER_Y_GAP);
+       auto crop = new wxGridBagSizer (DCPOMATIC_SIZER_X_GAP, DCPOMATIC_SIZER_Y_GAP);
+
        add_label_to_sizer (crop, _left_crop_label, true, wxGBPosition (cr, 0));
-       _left_crop->add (crop, wxGBPosition (cr, 1));
+       _left_crop->add (crop, wxGBPosition(cr, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL);
 #ifdef __WXGTK3__
        crop->Add (_left_right_link, wxGBPosition(cr, 2), wxGBSpan(2, 1));
        ++cr;
        add_label_to_sizer (crop, _right_crop_label, true, wxGBPosition(cr, 0));
        _right_crop->add (crop, wxGBPosition(cr, 1));
 #else
-       crop->Add (_left_right_link, wxGBPosition(cr, 2));
+       crop->Add (_left_right_link, wxGBPosition(cr, 2), wxDefaultSpan, wxALIGN_CENTER_VERTICAL);
        add_label_to_sizer (crop, _right_crop_label, true, wxGBPosition (cr, 3));
-       _right_crop->add (crop, wxGBPosition (cr, 4));
+       _right_crop->add (crop, wxGBPosition (cr, 4), wxDefaultSpan, wxALIGN_CENTER_VERTICAL);
 #endif
        ++cr;
        add_label_to_sizer (crop, _top_crop_label, true, wxGBPosition (cr, 0));
-       _top_crop->add (crop, wxGBPosition (cr, 1));
+       _top_crop->add (crop, wxGBPosition (cr, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL);
 #ifdef __WXGTK3__
        crop->Add (_top_bottom_link, wxGBPosition(cr, 2), wxGBSpan(2, 1));
        ++cr;
        add_label_to_sizer (crop, _bottom_crop_label, true, wxGBPosition(cr, 0));
-       _bottom_crop->add (crop, wxGBPosition(cr, 1));
+       _bottom_crop->add (crop, wxGBPosition(cr, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL);
 #else
-       crop->Add (_top_bottom_link, wxGBPosition(cr, 2));
+       crop->Add (_top_bottom_link, wxGBPosition(cr, 2), wxDefaultSpan, wxALIGN_CENTER_VERTICAL);
        add_label_to_sizer (crop, _bottom_crop_label, true, wxGBPosition (cr, 3));
-       _bottom_crop->add (crop, wxGBPosition (cr, 4));
+       _bottom_crop->add (crop, wxGBPosition (cr, 4), wxDefaultSpan, wxALIGN_CENTER_VERTICAL);
 #endif
        add_label_to_sizer (_grid, _crop_label, true, wxGBPosition(r, 0));
        _grid->Add (crop, wxGBPosition(r, 1));
        ++r;
 
-       _scale_label->Show (full);
-       _scale_fit->Show (full);
-       _scale_custom->Show (full);
-       _scale_custom_edit->Show (full);
-       _colour_conversion_label->Show (full);
-       _colour_conversion->Show (full);
-       _edit_colour_conversion_button->Show (full);
-       _range_label->Show (full);
-       _range->Show (full);
-
        add_label_to_sizer (_grid, _fade_in_label, true, wxGBPosition (r, 0));
        _grid->Add (_fade_in, wxGBPosition (r, 1), wxGBSpan (1, 3));
        ++r;
@@ -280,51 +291,50 @@ VideoPanel::add_to_grid ()
        _grid->Add (_fade_out, wxGBPosition (r, 1), wxGBSpan (1, 3));
        ++r;
 
-       if (full) {
-               add_label_to_sizer (_grid, _scale_label, true, wxGBPosition (r, 0));
-               {
-                       wxSizer* v = new wxBoxSizer (wxVERTICAL);
-                       v->Add (_scale_fit, 0, wxBOTTOM, 4);
-                       wxSizer* h = new wxBoxSizer (wxHORIZONTAL);
-                       h->Add (_scale_custom, 1, wxRIGHT | wxALIGN_CENTER_VERTICAL, 6);
-                       h->Add (_scale_custom_edit, 0, wxALIGN_CENTER_VERTICAL);
-                       v->Add (h, 0);
-                       _grid->Add (v, wxGBPosition(r, 1));
-               }
-               ++r;
-
-               add_label_to_sizer (_grid, _colour_conversion_label, true, wxGBPosition(r, 0));
-               {
-                       wxSizer* s = new wxBoxSizer (wxHORIZONTAL);
-                       s->Add (_colour_conversion, 1, wxALIGN_CENTER_VERTICAL | wxTOP | wxBOTTOM | wxRIGHT, 6);
-                       s->Add (_edit_colour_conversion_button, 0, wxALIGN_CENTER_VERTICAL);
-                       _grid->Add (s, wxGBPosition (r, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL);
-               }
-               ++r;
+       add_label_to_sizer (_grid, _scale_label, true, wxGBPosition (r, 0));
+       {
+               auto v = new wxBoxSizer (wxVERTICAL);
+               v->Add (_scale_fit, 0, wxBOTTOM, 4);
+               auto h = new wxBoxSizer (wxHORIZONTAL);
+               h->Add (_scale_custom, 1, wxRIGHT | wxALIGN_CENTER_VERTICAL, 6);
+               h->Add (_scale_custom_edit, 0, wxALIGN_CENTER_VERTICAL);
+               v->Add (h, 0);
+               _grid->Add (v, wxGBPosition(r, 1));
+       }
+       ++r;
 
-               add_label_to_sizer (_grid, _range_label, true, wxGBPosition(r, 0));
-               _grid->Add (_range, wxGBPosition(r, 1), wxGBSpan(1, 2), wxALIGN_CENTER_VERTICAL);
-               ++r;
+       add_label_to_sizer (_grid, _colour_conversion_label, true, wxGBPosition(r, 0));
+       {
+               auto s = new wxBoxSizer (wxHORIZONTAL);
+               s->Add (_colour_conversion, 1, wxALIGN_CENTER_VERTICAL | wxTOP | wxBOTTOM | wxRIGHT, 6);
+               s->Add (_edit_colour_conversion_button, 0, wxALIGN_CENTER_VERTICAL);
+               _grid->Add (s, wxGBPosition (r, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL);
        }
+       ++r;
+
+       add_label_to_sizer (_grid, _range_label, true, wxGBPosition(r, 0));
+       _grid->Add (_range, wxGBPosition(r, 1), wxGBSpan(1, 2), wxALIGN_CENTER_VERTICAL);
+       ++r;
 
        _grid->Add (_description, wxGBPosition (r, 0), wxGBSpan (1, 4), wxEXPAND | wxALIGN_CENTER_VERTICAL, 6);
        ++r;
 }
 
+
 void
 VideoPanel::range_changed ()
 {
-       ContentList vc = _parent->selected_video ();
+       auto vc = _parent->selected_video ();
        if (vc.size() != 1) {
                return;
        }
 
        switch (_range->GetSelection()) {
        case 0:
-               vc.front()->video->set_range (VIDEO_RANGE_FULL);
+               vc.front()->video->set_range (VideoRange::FULL);
                break;
        case 1:
-               vc.front()->video->set_range (VIDEO_RANGE_VIDEO);
+               vc.front()->video->set_range (VideoRange::VIDEO);
                break;
        default:
                DCPOMATIC_ASSERT (false);
@@ -336,14 +346,14 @@ void
 VideoPanel::film_changed (Film::Property property)
 {
        switch (property) {
-       case Film::VIDEO_FRAME_RATE:
-       case Film::CONTAINER:
-       case Film::RESOLUTION:
+       case Film::Property::VIDEO_FRAME_RATE:
+       case Film::Property::CONTAINER:
+       case Film::Property::RESOLUTION:
                setup_description ();
                setup_sensitivity ();
                break;
-       case Film::REEL_TYPE:
-       case Film::INTEROP:
+       case Film::Property::REEL_TYPE:
+       case Film::Property::INTEROP:
                setup_sensitivity ();
                break;
        default:
@@ -351,6 +361,7 @@ VideoPanel::film_changed (Film::Property property)
        }
 }
 
+
 std::size_t
 hash_value (boost::optional<ColourConversion> const & c)
 {
@@ -365,10 +376,10 @@ hash_value (boost::optional<ColourConversion> const & c)
 void
 VideoPanel::film_content_changed (int property)
 {
-       ContentList vc = _parent->selected_video ();
+       auto vc = _parent->selected_video ();
        shared_ptr<Content> vcs;
        shared_ptr<FFmpegContent> fcs;
-       if (!vc.empty ()) {
+       if (!vc.empty()) {
                vcs = vc.front ();
                fcs = dynamic_pointer_cast<FFmpegContent> (vcs);
        }
@@ -376,25 +387,26 @@ VideoPanel::film_content_changed (int property)
        if (property == ContentProperty::VIDEO_FRAME_RATE ||
            property == VideoContentProperty::FRAME_TYPE ||
            property == VideoContentProperty::CROP ||
-           property == VideoContentProperty::SCALE) {
+           property == VideoContentProperty::CUSTOM_RATIO ||
+           property == VideoContentProperty::CUSTOM_SIZE) {
                setup_description ();
        } else if (property == VideoContentProperty::COLOUR_CONVERSION) {
-               boost::unordered_set<optional<ColourConversion> > check;
-               BOOST_FOREACH (shared_ptr<const Content> i, vc) {
+               boost::unordered_set<optional<ColourConversion>> check;
+               for (auto i: vc) {
                        check.insert (i->video->colour_conversion());
                }
 
                /* Remove any "Many" entry that we might have added previously.  There should
                 * be entries for each preset plus one for "None" and one for "Custom".
                 */
-               vector<PresetColourConversion> cc = PresetColourConversion::all ();
+               auto cc = PresetColourConversion::all ();
                if (_colour_conversion->GetCount() > cc.size() + 2) {
                        _colour_conversion->Delete (_colour_conversion->GetCount() - 1);
                }
 
                if (check.size() == 1) {
                        if (vcs && vcs->video->colour_conversion ()) {
-                               optional<size_t> preset = vcs->video->colour_conversion().get().preset ();
+                               auto preset = vcs->video->colour_conversion().get().preset();
                                if (preset) {
                                        checked_set (_colour_conversion, preset.get() + 1);
                                } else {
@@ -417,7 +429,7 @@ VideoPanel::film_content_changed (int property)
                setup_sensitivity ();
        } else if (property == VideoContentProperty::FADE_IN) {
                set<Frame> check;
-               BOOST_FOREACH (shared_ptr<const Content> i, vc) {
+               for (auto i: vc) {
                        check.insert (i->video->fade_in ());
                }
 
@@ -431,7 +443,7 @@ VideoPanel::film_content_changed (int property)
                }
        } else if (property == VideoContentProperty::FADE_OUT) {
                set<Frame> check;
-               BOOST_FOREACH (shared_ptr<const Content> i, vc) {
+               for (auto i: vc) {
                        check.insert (i->video->fade_out ());
                }
 
@@ -454,7 +466,7 @@ VideoPanel::film_content_changed (int property)
                setup_sensitivity ();
        } else if (property == VideoContentProperty::RANGE) {
                if (vcs) {
-                       checked_set (_range, vcs->video->range() == VIDEO_RANGE_FULL ? 0 : 1);
+                       checked_set (_range, vcs->video->range() == VideoRange::FULL ? 0 : 1);
                } else {
                        checked_set (_range, 0);
                }
@@ -462,7 +474,7 @@ VideoPanel::film_content_changed (int property)
                setup_sensitivity ();
        } else if (property == VideoContentProperty::CUSTOM_RATIO || property == VideoContentProperty::CUSTOM_SIZE) {
                set<Frame> check;
-               BOOST_FOREACH (shared_ptr<const Content> i, vc) {
+               for (auto i: vc) {
                        check.insert (i->video->custom_ratio() || i->video->custom_size());
                }
 
@@ -481,7 +493,7 @@ VideoPanel::film_content_changed (int property)
 void
 VideoPanel::setup_description ()
 {
-       ContentList vc = _parent->selected_video ();
+       auto vc = _parent->selected_video ();
        if (vc.empty ()) {
                checked_set (_description, wxT (""));
                return;
@@ -490,7 +502,7 @@ VideoPanel::setup_description ()
                return;
        }
 
-       string d = vc.front()->video->processing_description (_parent->film());
+       auto d = vc.front()->video->processing_description(_parent->film());
        size_t lines = count (d.begin(), d.end(), '\n');
 
        for (int i = lines; i < 6; ++i) {
@@ -498,21 +510,22 @@ VideoPanel::setup_description ()
        }
 
        checked_set (_description, d);
-       _sizer->Layout ();
+       layout ();
 }
 
+
 void
 VideoPanel::colour_conversion_changed ()
 {
-       ContentList vc = _parent->selected_video ();
+       auto vc = _parent->selected_video ();
 
        int const s = _colour_conversion->GetSelection ();
-       vector<PresetColourConversion> all = PresetColourConversion::all ();
+       auto all = PresetColourConversion::all ();
 
        if (s == int(all.size() + 1)) {
                edit_colour_conversion_clicked ();
        } else {
-               BOOST_FOREACH (shared_ptr<Content> i, _parent->selected_video()) {
+               for (auto i: _parent->selected_video()) {
                        if (s == 0) {
                                i->video->unset_colour_conversion ();
                        } else if (s != int(all.size() + 2)) {
@@ -522,15 +535,16 @@ VideoPanel::colour_conversion_changed ()
        }
 }
 
+
 void
 VideoPanel::edit_colour_conversion_clicked ()
 {
-       ContentList vc = _parent->selected_video ();
+       auto vc = _parent->selected_video ();
 
-       ContentColourConversionDialog* d = new ContentColourConversionDialog (this, vc.front()->video->yuv ());
+       auto d = new ContentColourConversionDialog (this, vc.front()->video->yuv ());
        d->set (vc.front()->video->colour_conversion().get_value_or (PresetColourConversion::all().front().conversion));
        if (d->ShowModal() == wxID_OK) {
-               BOOST_FOREACH (shared_ptr<Content> i, vc) {
+               for (auto i: vc) {
                        i->video->set_colour_conversion (d->get ());
                }
        } else {
@@ -540,10 +554,11 @@ VideoPanel::edit_colour_conversion_clicked ()
        d->Destroy ();
 }
 
+
 void
 VideoPanel::content_selection_changed ()
 {
-       ContentList video_sel = _parent->selected_video ();
+       auto video_sel = _parent->selected_video ();
 
        _frame_type->set_content (video_sel);
        _left_crop->set_content (video_sel);
@@ -566,10 +581,11 @@ VideoPanel::content_selection_changed ()
        setup_sensitivity ();
 }
 
+
 void
 VideoPanel::setup_sensitivity ()
 {
-       ContentList sel = _parent->selected ();
+       auto sel = _parent->selected ();
 
        shared_ptr<DCPContent> dcp;
        if (sel.size() == 1) {
@@ -587,7 +603,7 @@ VideoPanel::setup_sensitivity ()
        setup_refer_button (_reference, _reference_note, dcp, can_reference, cannot);
 
        bool any_use = false;
-       BOOST_FOREACH (shared_ptr<Content> i, _parent->selected_video()) {
+       for (auto i: _parent->selected_video()) {
                if (i->video && i->video->use()) {
                        any_use = true;
                }
@@ -610,8 +626,8 @@ VideoPanel::setup_sensitivity ()
                _colour_conversion->Enable (false);
                _range->Enable (false);
        } else {
-               ContentList video_sel = _parent->selected_video ();
-               FFmpegContentList ffmpeg_sel = _parent->selected_ffmpeg ();
+               auto video_sel = _parent->selected_video ();
+               auto ffmpeg_sel = _parent->selected_ffmpeg ();
                bool const single = video_sel.size() == 1;
 
                _frame_type->wrapped()->Enable (true);
@@ -626,10 +642,10 @@ VideoPanel::setup_sensitivity ()
                _scale_custom_edit->Enable (_scale_custom->GetValue());
                _description->Enable (true);
                _colour_conversion->Enable (!video_sel.empty());
-               _range->Enable (single && !video_sel.empty());
+               _range->Enable (single && !video_sel.empty() && !dcp);
        }
 
-       ContentList vc = _parent->selected_video ();
+       auto vc = _parent->selected_video ();
        shared_ptr<Content> vcs;
        if (!vc.empty ()) {
                vcs = vc.front ();
@@ -642,21 +658,25 @@ VideoPanel::setup_sensitivity ()
        }
 }
 
+
 void
 VideoPanel::fade_in_changed ()
 {
-       BOOST_FOREACH (shared_ptr<Content> i, _parent->selected_video ()) {
-               double const vfr = i->active_video_frame_rate (_parent->film());
-               i->video->set_fade_in (_fade_in->get(vfr).frames_round(vfr));
+       auto const hmsf = _fade_in->get();
+       for (auto i: _parent->selected_video()) {
+               auto const vfr = i->active_video_frame_rate(_parent->film());
+               i->video->set_fade_in (dcpomatic::ContentTime(hmsf, vfr).frames_round(vfr));
        }
 }
 
+
 void
 VideoPanel::fade_out_changed ()
 {
-       BOOST_FOREACH (shared_ptr<Content> i, _parent->selected_video ()) {
-               double const vfr = i->active_video_frame_rate (_parent->film());
-               i->video->set_fade_out (_fade_out->get(vfr).frames_round(vfr));
+       auto const hmsf = _fade_out->get();
+       for (auto i: _parent->selected_video()) {
+               auto const vfr = i->active_video_frame_rate (_parent->film());
+               i->video->set_fade_out (dcpomatic::ContentTime(hmsf, vfr).frames_round(vfr));
        }
 }
 
@@ -664,12 +684,12 @@ VideoPanel::fade_out_changed ()
 void
 VideoPanel::reference_clicked ()
 {
-       ContentList c = _parent->selected ();
+       auto c = _parent->selected ();
        if (c.size() != 1) {
                return;
        }
 
-       shared_ptr<DCPContent> d = dynamic_pointer_cast<DCPContent> (c.front ());
+       auto d = dynamic_pointer_cast<DCPContent> (c.front ());
        if (!d) {
                return;
        }
@@ -681,9 +701,12 @@ VideoPanel::reference_clicked ()
 void
 VideoPanel::scale_fit_clicked ()
 {
-       BOOST_FOREACH (shared_ptr<Content> i, _parent->selected_video()) {
+       for (auto i: _parent->selected_video()) {
                i->video->set_custom_ratio (optional<float>());
+               i->video->set_custom_size (optional<dcp::Size>());
        }
+
+       setup_sensitivity ();
 }
 
 
@@ -693,17 +716,19 @@ VideoPanel::scale_custom_clicked ()
        if (!scale_custom_edit_clicked()) {
                _scale_fit->SetValue (true);
        }
+
+       setup_sensitivity ();
 }
 
 
 bool
 VideoPanel::scale_custom_edit_clicked ()
 {
-       shared_ptr<const VideoContent> vc = _parent->selected_video().front()->video;
-       CustomScaleDialog* d = new CustomScaleDialog (this, vc->size(), _parent->film()->frame_size(), vc->custom_ratio(), vc->custom_size());
+       auto vc = _parent->selected_video().front()->video;
+       auto d = new CustomScaleDialog (this, vc->size(), _parent->film()->frame_size(), vc->custom_ratio(), vc->custom_size());
        int const r = d->ShowModal ();
        if (r == wxID_OK) {
-               BOOST_FOREACH (shared_ptr<Content> i, _parent->selected_video()) {
+               for (auto i: _parent->selected_video()) {
                        i->video->set_custom_ratio (d->custom_ratio());
                        i->video->set_custom_size (d->custom_size());
                }
@@ -716,23 +741,32 @@ VideoPanel::scale_custom_edit_clicked ()
 void
 VideoPanel::left_right_link_clicked ()
 {
-       right_crop_changed ();
+       if (_left_changed_last) {
+               left_crop_changed ();
+       } else {
+               right_crop_changed ();
+       }
 }
 
 
 void
 VideoPanel::top_bottom_link_clicked ()
 {
-       bottom_crop_changed ();
+       if (_top_changed_last) {
+               top_crop_changed ();
+       } else {
+               bottom_crop_changed ();
+       }
 }
 
 
 void
 VideoPanel::left_crop_changed ()
 {
+       _left_changed_last = true;
        if (_left_right_link->GetValue()) {
-               BOOST_FOREACH (shared_ptr<Content> i, _parent->selected_video()) {
-                       i->video->set_right_crop (i->video->left_crop());
+               for (auto i: _parent->selected_video()) {
+                       i->video->set_right_crop (i->video->requested_left_crop());
                }
        }
 }
@@ -741,9 +775,10 @@ VideoPanel::left_crop_changed ()
 void
 VideoPanel::right_crop_changed ()
 {
+       _left_changed_last = false;
        if (_left_right_link->GetValue()) {
-               BOOST_FOREACH (shared_ptr<Content> i, _parent->selected_video()) {
-                       i->video->set_left_crop (i->video->right_crop());
+               for (auto i: _parent->selected_video()) {
+                       i->video->set_left_crop (i->video->requested_right_crop());
                }
        }
 }
@@ -752,9 +787,10 @@ VideoPanel::right_crop_changed ()
 void
 VideoPanel::top_crop_changed ()
 {
+       _top_changed_last = true;
        if (_top_bottom_link->GetValue()) {
-               BOOST_FOREACH (shared_ptr<Content> i, _parent->selected_video()) {
-                       i->video->set_bottom_crop (i->video->top_crop());
+               for (auto i: _parent->selected_video()) {
+                       i->video->set_bottom_crop (i->video->requested_top_crop());
                }
        }
 }
@@ -763,12 +799,12 @@ VideoPanel::top_crop_changed ()
 void
 VideoPanel::bottom_crop_changed ()
 {
+       _top_changed_last = false;
        if (_top_bottom_link->GetValue()) {
-               BOOST_FOREACH (shared_ptr<Content> i, _parent->selected_video()) {
-                       i->video->set_top_crop (i->video->bottom_crop());
+               for (auto i: _parent->selected_video()) {
+                       i->video->set_top_crop (i->video->requested_bottom_crop());
                }
        }
 }
 
 
-