/*
- Copyright (C) 2013-2014 Carl Hetherington <cth@carlh.net>
+ Copyright (C) 2013-2021 Carl Hetherington <cth@carlh.net>
- This program is free software; you can redistribute it and/or modify
+ This file is part of DCP-o-matic.
+
+ DCP-o-matic is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
- This program is distributed in the hope that it will be useful,
+ DCP-o-matic is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
- along with this program; if not, write to the Free Software
- Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ along with DCP-o-matic. If not, see <http://www.gnu.org/licenses/>.
*/
+
/** @file test/ffmpeg_audio_test.cc
- * @brief A simple test of reading audio from an FFmpeg file.
+ * @brief Test reading audio from an FFmpeg file.
+ * @ingroup feature
*/
-#include <boost/test/unit_test.hpp>
+
+#include "lib/constants.h"
+#include "lib/content_factory.h"
+#include "lib/dcp_content_type.h"
+#include "lib/ffmpeg_content.h"
+#include "lib/ffmpeg_content.h"
+#include "lib/film.h"
+#include "lib/player.h"
+#include "lib/ratio.h"
+#include "lib/video_content.h"
+#include "test.h"
#include <dcp/cpl.h>
#include <dcp/dcp.h>
-#include <dcp/sound_mxf.h>
+#include <dcp/sound_asset.h>
#include <dcp/sound_frame.h>
#include <dcp/reel_sound_asset.h>
+#include <dcp/sound_asset_reader.h>
#include <dcp/reel.h>
-#include "lib/sndfile_content.h"
-#include "lib/film.h"
-#include "lib/dcp_content_type.h"
-#include "lib/ratio.h"
-#include "lib/ffmpeg_content.h"
-#include "test.h"
+#include <boost/test/unit_test.hpp>
+
+using std::make_shared;
using std::string;
-using boost::lexical_cast;
-using boost::shared_ptr;
+
BOOST_AUTO_TEST_CASE (ffmpeg_audio_test)
{
- shared_ptr<Film> film = new_test_film ("ffmpeg_audio_test");
+ auto film = new_test_film ("ffmpeg_audio_test");
film->set_name ("ffmpeg_audio_test");
- shared_ptr<FFmpegContent> c (new FFmpegContent (film, "test/data/staircase.mov"));
- c->set_scale (VideoContentScale (Ratio::from_id ("185")));
+ auto c = make_shared<FFmpegContent> ("test/data/staircase.mov");
film->examine_and_add_content (c);
- wait_for_jobs ();
+ BOOST_REQUIRE (!wait_for_jobs());
- film->set_container (Ratio::from_id ("185"));
- film->set_audio_channels (6);
- film->set_dcp_content_type (DCPContentType::from_pretty_name ("Test"));
- film->make_dcp ();
- film->write_metadata ();
+ int constexpr audio_channels = 6;
- wait_for_jobs ();
+ film->set_container (Ratio::from_id ("185"));
+ film->set_audio_channels(audio_channels);
+ film->set_dcp_content_type (DCPContentType::from_isdcf_name ("TST"));
+ make_and_verify_dcp (film);
boost::filesystem::path path = "build/test";
path /= "ffmpeg_audio_test";
dcp::DCP check (path.string ());
check.read ();
- shared_ptr<const dcp::ReelSoundAsset> sound_asset = check.cpls().front()->reels().front()->main_sound ();
+ auto sound_asset = check.cpls().front()->reels().front()->main_sound ();
BOOST_CHECK (sound_asset);
- BOOST_CHECK_EQUAL (sound_asset->mxf()->channels (), 6);
+ BOOST_REQUIRE_EQUAL(sound_asset->asset()->channels (), audio_channels);
/* Sample index in the DCP */
int n = 0;
/* DCP sound asset frame */
int frame = 0;
- while (n < sound_asset->mxf()->intrinsic_duration()) {
- shared_ptr<const dcp::SoundFrame> sound_frame = sound_asset->mxf()->get_frame (frame++);
+ while (n < sound_asset->asset()->intrinsic_duration()) {
+ auto sound_frame = sound_asset->asset()->start_read()->get_frame (frame++);
uint8_t const * d = sound_frame->data ();
-
- for (int i = 0; i < sound_frame->size(); i += (3 * sound_asset->mxf()->channels())) {
-
- if (sound_asset->mxf()->channels() > 0) {
- /* L should be silent */
- int const sample = d[i + 0] | (d[i + 1] << 8);
- BOOST_CHECK_EQUAL (sample, 0);
+ for (int offset = 0; offset < sound_frame->size(); offset += (3 * sound_asset->asset()->channels())) {
+ for (auto channel = 0; channel < audio_channels; ++channel) {
+ auto const sample = d[offset + channel * 3 + 1] | (d[offset + channel * 3 + 2] << 8);
+ if (channel == 2) {
+ /* Input should be on centre */
+ BOOST_CHECK_EQUAL(sample, n);
+ } else {
+ /* Everything else should be silent */
+ BOOST_CHECK_EQUAL(sample, 0);
+ }
}
+ ++n;
+ }
+ }
+}
- if (sound_asset->mxf()->channels() > 1) {
- /* R should be silent */
- int const sample = d[i + 2] | (d[i + 3] << 8);
- BOOST_CHECK_EQUAL (sample, 0);
- }
-
- if (sound_asset->mxf()->channels() > 2) {
- /* Mono input so it will appear on centre */
- int const sample = d[i + 7] | (d[i + 8] << 8);
- BOOST_CHECK_EQUAL (sample, n);
- }
- if (sound_asset->mxf()->channels() > 3) {
- /* Lfe should be silent */
- int const sample = d[i + 9] | (d[i + 10] << 8);
- BOOST_CHECK_EQUAL (sample, 0);
- }
+/** Decode a file containing truehd so we can profile it; this is with the player set to normal */
+BOOST_AUTO_TEST_CASE (ffmpeg_audio_test2)
+{
+ auto film = new_test_film2 ("ffmpeg_audio_test2");
+ auto content = content_factory(TestPaths::private_data() / "wayne.mkv")[0];
+ film->examine_and_add_content (content);
+ BOOST_REQUIRE (!wait_for_jobs ());
- if (sound_asset->mxf()->channels() > 4) {
- /* Ls should be silent */
- int const sample = d[i + 11] | (d[i + 12] << 8);
- BOOST_CHECK_EQUAL (sample, 0);
- }
+ auto player = make_shared<Player>(film, Image::Alignment::COMPACT);
+ while (!player->pass ()) {}
+}
- if (sound_asset->mxf()->channels() > 5) {
- /* Rs should be silent */
- int const sample = d[i + 13] | (d[i + 14] << 8);
- BOOST_CHECK_EQUAL (sample, 0);
- }
+/** Decode a file containing truehd so we can profile it; this is with the player set to fast */
+BOOST_AUTO_TEST_CASE (ffmpeg_audio_test3)
+{
+ auto film = new_test_film2 ("ffmpeg_audio_test3");
+ auto content = content_factory(TestPaths::private_data() / "wayne.mkv")[0];
+ film->examine_and_add_content (content);
+ BOOST_REQUIRE (!wait_for_jobs ());
+
+ auto player = make_shared<Player>(film, Image::Alignment::COMPACT);
+ player->set_fast ();
+ while (!player->pass ()) {}
+}
- ++n;
- }
- }
+
+/** Decode a file whose audio previously crashed DCP-o-matic (#1857) */
+BOOST_AUTO_TEST_CASE (ffmpeg_audio_test4)
+{
+ auto film = new_test_film2 ("ffmpeg_audio_test4");
+ auto content = content_factory(TestPaths::private_data() / "Actuellement aout 2020.wmv")[0];
+ film->examine_and_add_content (content);
+ BOOST_REQUIRE (!wait_for_jobs ());
+
+ auto player = make_shared<Player>(film, Image::Alignment::COMPACT);
+ player->set_fast ();
+ BOOST_CHECK_NO_THROW (while (!player->pass()) {});
}
+
projects / dcpomatic.git / blobdiff