Adjust handling of -Wsuggest-override

[dcpomatic.git] / wscript

diff --git a/wscript b/wscript
index 4ccadf6fd3dfdfef13b91d3d6389d2f5e169aae4..994f1b6f3e7aee7c90de95c21dba1272849f3cff 100644 (file)
--- a/wscript
+++ b/wscript
@@ -109,7 +109,6 @@ def configure(conf):
                                        '-Wall',
                                        '-Wextra',
                                        '-Wwrite-strings',
-                                       '-Wsuggest-override',
                                        '-Wno-error=deprecated',
                                        # I tried and failed to ignore these with _Pragma
                                        '-Wno-ignored-qualifiers',
@@ -127,6 +126,10 @@ def configure(conf):
         if int(gcc[0]) >= 8:
             # I tried and failed to ignore these with _Pragma
             conf.env.append_value('CXXFLAGS', ['-Wno-cast-function-type'])
+        if int(gcc[0]) >= 9:
+            # I can't get #pragma GCC diagnostic ignored "-Wsuggest-override" to work on older GCCs,
+            # so only enable this if we're on a newer one
+            conf.env.append_value('CXXFLAGS', '-Wsuggest-override')
         have_c11 = int(gcc[0]) >= 4 and int(gcc[1]) >= 8 and int(gcc[2]) >= 1
         # Most gccs still give these warnings from boost::optional
         conf.env.append_value('CXXFLAGS', ['-Wno-maybe-uninitialized'])