Missing explicit.

diff --git a/src/lib/atmos_metadata.h b/src/lib/atmos_metadata.h
index 65f2cc6c260f5217278f5794c3469992254b2f5f..15d6e3295b28edfeefeddd7ac9c9633d8a4698ef 100644 (file)
--- a/src/lib/atmos_metadata.h
+++ b/src/lib/atmos_metadata.h
@@ -26,7 +26,7 @@
 class AtmosMetadata
 {
 public:
-       AtmosMetadata (std::shared_ptr<const dcp::AtmosAsset> asset);
+       explicit AtmosMetadata (std::shared_ptr<const dcp::AtmosAsset> asset);
        std::shared_ptr<dcp::AtmosAsset> create (dcp::Fraction edit_rate) const;
 
 private:

diff --git a/src/lib/atmos_mxf_content.h b/src/lib/atmos_mxf_content.h
index 57f041774c1b3776926545b7b77c025c2c872c33..42635ab89cdc329c0d65371df8ded26e00518c41 100644 (file)
--- a/src/lib/atmos_mxf_content.h
+++ b/src/lib/atmos_mxf_content.h
@@ -26,7 +26,7 @@
 class AtmosMXFContent : public Content
 {
 public:
-       AtmosMXFContent (boost::filesystem::path path);
+       explicit AtmosMXFContent (boost::filesystem::path path);
        AtmosMXFContent (cxml::ConstNodePtr node, int version);
 
        std::shared_ptr<AtmosMXFContent> shared_from_this () {

diff --git a/src/lib/check_content_change_job.h b/src/lib/check_content_change_job.h
index a374e2a6fb373783e286afd41ff7b29e3092872d..212a49139cd4e8955870383a644e920091e62626 100644 (file)
--- a/src/lib/check_content_change_job.h
+++ b/src/lib/check_content_change_job.h
@@ -27,7 +27,7 @@
 class CheckContentChangeJob : public Job
 {
 public:
-       CheckContentChangeJob (std::shared_ptr<const Film>);
+       explicit CheckContentChangeJob (std::shared_ptr<const Film>);
        ~CheckContentChangeJob ();
 
        std::string name () const override;

diff --git a/src/lib/dcp_content.h b/src/lib/dcp_content.h
index 7fc800b52d91851cb3d62a783bfa3652209ad716..9f5d5c775d9f9f1092f3f9d23f4978335949a38f 100644 (file)
--- a/src/lib/dcp_content.h
+++ b/src/lib/dcp_content.h
@@ -50,7 +50,7 @@ class ContentPart;
 class DCPContent : public Content
 {
 public:
-       DCPContent (boost::filesystem::path p);
+       explicit DCPContent (boost::filesystem::path p);
        DCPContent (cxml::ConstNodePtr, int version);
 
        std::shared_ptr<DCPContent> shared_from_this () {

diff --git a/src/lib/dcp_subtitle_content.h b/src/lib/dcp_subtitle_content.h
index 5949f8b0ba5ef866b68a418379ff98c182b0053f..f346dd661025b360920a4d2b082a34ca04222dfc 100644 (file)
--- a/src/lib/dcp_subtitle_content.h
+++ b/src/lib/dcp_subtitle_content.h
@@ -24,7 +24,7 @@
 class DCPSubtitleContent : public DCPSubtitle, public Content
 {
 public:
-       DCPSubtitleContent (boost::filesystem::path);
+       explicit DCPSubtitleContent (boost::filesystem::path);
        DCPSubtitleContent (cxml::ConstNodePtr, int);
 
        void examine (std::shared_ptr<const Film> film, std::shared_ptr<Job>) override;

diff --git a/src/lib/dcp_text_track.h b/src/lib/dcp_text_track.h
index b29d8c4894f2111e3c3bbfe005b91ef70717c13c..7180e61b513aca9262da3337cc41cb7955f2ba94 100644 (file)
--- a/src/lib/dcp_text_track.h
+++ b/src/lib/dcp_text_track.h
@@ -35,7 +35,7 @@ class DCPTextTrack
 {
 public:
        DCPTextTrack () {}
-       DCPTextTrack (cxml::ConstNodePtr node);
+       explicit DCPTextTrack (cxml::ConstNodePtr node);
        DCPTextTrack (std::string name_, boost::optional<dcp::LanguageTag> language_);
 
        std::string name;

diff --git a/src/lib/dcpomatic_socket.h b/src/lib/dcpomatic_socket.h
index f4520e5cf7c070d3407c2196b1baf8ff98939476..35c94660b960d344ad7ec1ad38c74b227f5702b7 100644 (file)
--- a/src/lib/dcpomatic_socket.h
+++ b/src/lib/dcpomatic_socket.h
@@ -53,7 +53,7 @@ public:
        class ReadDigestScope
        {
        public:
-               ReadDigestScope (std::shared_ptr<Socket> socket);
+               explicit ReadDigestScope (std::shared_ptr<Socket> socket);
                bool check ();
        private:
                std::weak_ptr<Socket> _socket;
@@ -66,7 +66,7 @@ public:
        class WriteDigestScope
        {
        public:
-               WriteDigestScope (std::shared_ptr<Socket> socket);
+               explicit WriteDigestScope (std::shared_ptr<Socket> socket);
                ~WriteDigestScope ();
        private:
                std::weak_ptr<Socket> _socket;

diff --git a/src/lib/exceptions.h b/src/lib/exceptions.h
index 9b7837a46bef89c695f0be7097a254566b8d8939..28dd46814bdb6cf876738796fe715b39334c1b9d 100644 (file)
--- a/src/lib/exceptions.h
+++ b/src/lib/exceptions.h
@@ -155,7 +155,7 @@ public:
 class FileNotFoundError : public std::runtime_error
 {
 public:
-       FileNotFoundError (boost::filesystem::path f);
+       explicit FileNotFoundError (boost::filesystem::path f);
        virtual ~FileNotFoundError () throw () {}
 
        /** @return name of the file that this exception concerns */
@@ -178,7 +178,7 @@ public:
        /** @param f File that we were trying to read from.
         *  @param e errno value, or 0.
         */
-       ReadFileError (boost::filesystem::path f, int e = 0);
+       explicit ReadFileError (boost::filesystem::path f, int e = 0);
 };
 
 
@@ -378,7 +378,7 @@ class GLError : public std::runtime_error
 {
 public:
        GLError (char const* last, int e);
-       GLError (char const* message);
+       explicit GLError (char const* message);
 };
 
 
@@ -388,7 +388,7 @@ public:
 class CopyError : public std::runtime_error
 {
 public:
-       CopyError (std::string s, boost::optional<int> n = boost::optional<int>());
+       explicit CopyError (std::string s, boost::optional<int> n = boost::optional<int>());
        virtual ~CopyError () throw () {}
 
        std::string message () const {

diff --git a/src/lib/ffmpeg_content.h b/src/lib/ffmpeg_content.h
index ce4a8aa6985cdbdc38af33bf5e4c8b479cbc65db..d370335b2b580c49ef93c26326dd67fe3ff629c3 100644 (file)
--- a/src/lib/ffmpeg_content.h
+++ b/src/lib/ffmpeg_content.h
@@ -47,9 +47,9 @@ public:
 class FFmpegContent : public Content
 {
 public:
-       FFmpegContent (boost::filesystem::path);
+       explicit FFmpegContent (boost::filesystem::path);
        FFmpegContent (cxml::ConstNodePtr, int version, std::list<std::string> &);
-       FFmpegContent (std::vector<std::shared_ptr<Content>>);
+       explicit FFmpegContent (std::vector<std::shared_ptr<Content>>);
 
        std::shared_ptr<FFmpegContent> shared_from_this () {
                return std::dynamic_pointer_cast<FFmpegContent> (Content::shared_from_this ());

diff --git a/src/lib/ffmpeg_examiner.h b/src/lib/ffmpeg_examiner.h
index 69347bfd4fd98283714987b962a4d04b6d68c311..5e7399bcef32ebcde8827279fb38d938b55a6f48 100644 (file)
--- a/src/lib/ffmpeg_examiner.h
+++ b/src/lib/ffmpeg_examiner.h
@@ -33,7 +33,7 @@ class Job;
 class FFmpegExaminer : public FFmpeg, public VideoExaminer
 {
 public:
-       FFmpegExaminer (std::shared_ptr<const FFmpegContent>, std::shared_ptr<Job> job = std::shared_ptr<Job>());
+       explicit FFmpegExaminer (std::shared_ptr<const FFmpegContent>, std::shared_ptr<Job> job = std::shared_ptr<Job>());
 
        bool has_video () const override;
 

diff --git a/src/lib/ffmpeg_image_proxy.h b/src/lib/ffmpeg_image_proxy.h
index b2b0260b5437eab63ae99bc66e8d30ad76349ddd..bc970b13aa2bd1a7ff7f03bc2307fa8ca2bdae3f 100644 (file)
--- a/src/lib/ffmpeg_image_proxy.h
+++ b/src/lib/ffmpeg_image_proxy.h
@@ -29,7 +29,7 @@ class FFmpegImageProxy : public ImageProxy
 public:
        explicit FFmpegImageProxy (boost::filesystem::path);
        explicit FFmpegImageProxy (dcp::ArrayData);
-       FFmpegImageProxy (std::shared_ptr<Socket> socket);
+       explicit FFmpegImageProxy (std::shared_ptr<Socket> socket);
 
        Result image (
                Image::Alignment alignment,

diff --git a/src/lib/font_data.h b/src/lib/font_data.h
index 7bd6d46482a55fe9c137c022b257b843657233f2..fff2928fdf6f38aa9abd892a5e21b4dba1e82bbc 100644 (file)
--- a/src/lib/font_data.h
+++ b/src/lib/font_data.h
@@ -38,7 +38,7 @@ class Font;
 class FontData
 {
 public:
-       FontData (std::shared_ptr<const Font> font);
+       explicit FontData (std::shared_ptr<const Font> font);
 
        FontData (std::string id_, dcp::ArrayData data_)
                : id(id_)

diff --git a/src/lib/image_content.h b/src/lib/image_content.h
index d817eeee84e4cc0b6a2685666db207eae79a0025..23b50233c33db5e91045a0c702a41db0ef6446af 100644 (file)
--- a/src/lib/image_content.h
+++ b/src/lib/image_content.h
@@ -26,7 +26,7 @@
 class ImageContent : public Content
 {
 public:
-       ImageContent (boost::filesystem::path);
+       explicit ImageContent (boost::filesystem::path);
        ImageContent (cxml::ConstNodePtr, int);
 
        std::shared_ptr<ImageContent> shared_from_this () {

diff --git a/src/lib/pixel_quanta.h b/src/lib/pixel_quanta.h
index 018ce334638f1819ac56eddb541283303049144d..d91d32843e7c00edf232f92b57af801c6daf9c12 100644 (file)
--- a/src/lib/pixel_quanta.h
+++ b/src/lib/pixel_quanta.h
@@ -49,7 +49,7 @@ public:
                , y(y_)
        {}
 
-       PixelQuanta (cxml::ConstNodePtr node);
+       explicit PixelQuanta (cxml::ConstNodePtr node);
 
        void as_xml (xmlpp::Element* node) const;
 

diff --git a/src/lib/rng.h b/src/lib/rng.h
index e3dc0c50dae50f19d173be612b989456d8678533..1e47fcd02e9685dca8679073e5fc377e22e6cb4d 100644 (file)
--- a/src/lib/rng.h
+++ b/src/lib/rng.h
@@ -31,7 +31,7 @@ namespace dcpomatic {
 class RNG
 {
 public:
-       RNG (int32_t seed);
+       explicit RNG (int32_t seed);
 
        int32_t get ();
 

diff --git a/src/lib/string_text_file_content.h b/src/lib/string_text_file_content.h
index 9c7d4cea0b041b8f94d296518e347a54608b8ce5..0f9408d4d00dadd16fb2402d7dc0c2620a973897 100644 (file)
--- a/src/lib/string_text_file_content.h
+++ b/src/lib/string_text_file_content.h
@@ -31,7 +31,7 @@ class Job;
 class StringTextFileContent : public Content
 {
 public:
-       StringTextFileContent (boost::filesystem::path);
+       explicit StringTextFileContent (boost::filesystem::path);
        StringTextFileContent (cxml::ConstNodePtr, int, std::list<std::string>&);
 
        std::shared_ptr<StringTextFileContent> shared_from_this () {

diff --git a/src/lib/types.h b/src/lib/types.h
index 6fbad21883084da078dcc7ed09d7c78d51921922..624076a8c9a379192e747d17487465299d61297d 100644 (file)
--- a/src/lib/types.h
+++ b/src/lib/types.h
@@ -216,7 +216,7 @@ extern bool operator!= (Crop const & a, Crop const & b);
 
 struct CPLSummary
 {
-       CPLSummary (boost::filesystem::path p);
+       explicit CPLSummary (boost::filesystem::path p);
 
        CPLSummary (std::string d, std::string i, std::string a, boost::filesystem::path f, bool e, time_t t)
                : dcp_directory (d)

diff --git a/src/lib/video_mxf_content.h b/src/lib/video_mxf_content.h
index 5a04c3da9c292405b83f7e3f0c4e20fe73995077..d360ecc492e67c7cda93da8a25be27be520057aa 100644 (file)
--- a/src/lib/video_mxf_content.h
+++ b/src/lib/video_mxf_content.h
@@ -25,7 +25,7 @@
 class VideoMXFContent : public Content
 {
 public:
-       VideoMXFContent (boost::filesystem::path path);
+       explicit VideoMXFContent (boost::filesystem::path path);
        VideoMXFContent (cxml::ConstNodePtr node, int version);
 
        std::shared_ptr<VideoMXFContent> shared_from_this () {

diff --git a/src/lib/zipper.h b/src/lib/zipper.h
index 9f3e867c773c78e6ab8c8f22c2a855c64f7902cc..3a1e958c3843f51cb3bf39ae4ac51f0324ede693 100644 (file)
--- a/src/lib/zipper.h
+++ b/src/lib/zipper.h
@@ -26,7 +26,7 @@
 class Zipper
 {
 public:
-       Zipper (boost::filesystem::path file);
+       explicit Zipper (boost::filesystem::path file);
        ~Zipper ();
 
        Zipper (Zipper const&) = delete;

diff --git a/src/tools/dcpomatic_playlist.cc b/src/tools/dcpomatic_playlist.cc
index 6f06c0624e91109475a6b320c4ca5e8a56ed6fa1..39ac988b3b81d4a503ab0b5382cbca3d4cd578ca 100644 (file)
--- a/src/tools/dcpomatic_playlist.cc
+++ b/src/tools/dcpomatic_playlist.cc
@@ -59,7 +59,7 @@ using namespace boost::placeholders;
 class ContentDialog : public wxDialog, public ContentStore
 {
 public:
-       ContentDialog (wxWindow* parent)
+       explicit ContentDialog (wxWindow* parent)
                : wxDialog (parent, wxID_ANY, _("Add content"), wxDefaultPosition, wxSize(800, 640))
                , _content_view (new ContentView(this))
        {