Fix regression when AVCodecContext's channel layout doesn't get set up by FFmpeg.
authorCarl Hetherington <cth@carlh.net>
Thu, 13 Dec 2012 18:59:46 +0000 (18:59 +0000)
committerCarl Hetherington <cth@carlh.net>
Thu, 13 Dec 2012 18:59:46 +0000 (18:59 +0000)
src/lib/ffmpeg_decoder.cc

index 9b89ffffcbcfbeb5f7573b626bdd2106b9b070d7..46e851e372439a232169b77f1e0a229559dc831a 100644 (file)
@@ -120,11 +120,21 @@ FFmpegDecoder::setup_general ()
                if (s->codec->codec_type == AVMEDIA_TYPE_VIDEO) {
                        _video_stream = i;
                } else if (s->codec->codec_type == AVMEDIA_TYPE_AUDIO) {
+
+                       /* This is a hack; sometimes it seems that _audio_codec_context->channel_layout isn't set up,
+                          so bodge it here.  No idea why we should have to do this.
+                       */
+                       
+                       if (s->codec->channel_layout == 0) {
+                               s->codec->channel_layout = av_get_default_channel_layout (s->codec->channels);
+                       }
+                       
                        _audio_streams.push_back (
                                shared_ptr<AudioStream> (
                                        new FFmpegAudioStream (stream_name (s), i, s->codec->sample_rate, s->codec->channel_layout)
                                        )
                                );
+                       
                } else if (s->codec->codec_type == AVMEDIA_TYPE_SUBTITLE) {
                        _subtitle_streams.push_back (
                                shared_ptr<SubtitleStream> (
@@ -186,14 +196,6 @@ FFmpegDecoder::setup_audio ()
        if (avcodec_open2 (_audio_codec_context, _audio_codec, 0) < 0) {
                throw DecodeError ("could not open audio decoder");
        }
-
-       /* This is a hack; sometimes it seems that _audio_codec_context->channel_layout isn't set up,
-          so bodge it here.  No idea why we should have to do this.
-       */
-
-       if (_audio_codec_context->channel_layout == 0) {
-               _audio_codec_context->channel_layout = av_get_default_channel_layout (ffa->channels());
-       }
 }
 
 void